Overview, OProfile SPU event profiling support for IBM Cell processor
cover Overview, OProfile SPU event profiling support for IBM Cell processor
This is a rework of the previously posted set of patches.
Patch 1 is the user level patch to add the SPU events to the user OProfile tool.
Patch 2 is a kernel patch to do code clean up and restructuring to make it easier to add the new SPU event profiling support. This patch makes no functional changes.
Patch 3 is a kernel patch to add the SPU event profiling support.
Carl Love
Quoted 10 lines · Carl Love
This is a rework of the previously posted set of patches.
Patch 1 is the user level patch to add the SPU events to the user OProfile tool.
Patch 2 is a kernel patch to do code clean up and restructuring to make it easier to add the new SPU event profiling support. This patch makes no functional changes.
Patch 3 is a kernel patch to add the SPU event profiling support.
I applied patch 2 & 3 to:
git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git cell
The patches did not apply cleanly. I had to change the path to arch/powerpc/include/asm/, fix cell/pr_util.h and did some whitespace cleanups. Please run your tests on the cell branch.
Thanks,
-Robert
Signature · 3 lines
Advanced Micro Devices, Inc. Operating System Research Center email: [email protected]
Quoted 16 lines · Robert Richter
Quoted 10 lines · Carl Love
This is a rework of the previously posted set of patches.
Patch 1 is the user level patch to add the SPU events to the user OProfile tool.
Patch 2 is a kernel patch to do code clean up and restructuring to make it easier to add the new SPU event profiling support. This patch makes no functional changes.
Patch 3 is a kernel patch to add the SPU event profiling support.
I applied patch 2 & 3 to:
git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.gitcell
Quoted 8 lines
The patches did not apply cleanly. I had to change the path to
arch/powerpc/include/asm/, fixcell/pr_util.hand did some whitespace cleanups. Please run your tests on the cell branch.Thanks,
-Robert
I pulled down the git tree, compiled and installed it. I tested it against the OProfile testsuite, which includes SPU event profiling tests. Everything passed. The patch I submitted was against a 2.6.26 tree. You are now on a 2.6.28 tree so perhaps that is why the patch did not apply cleanly. The patch has been out there for some time.
Carl Love
Quoted 5 lines · Carl Love
Quoted 5 lines
git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.gitcellThe patches did not apply cleanly. I had to change the path to
arch/powerpc/include/asm/, fixcell/pr_util.hand did some whitespace cleanups. Please run your tests on the cell branch.
Thanks Carl, could you also test the 'next' branch on your architecture, please? This is the latest version of patches to go upstream (containing your patches also).
Thanks,
-Robert
Signature · 3 lines
Advanced Micro Devices, Inc. Operating System Research Center email: [email protected]
Quoted 5 lines · Carl Love
I pulled down the git tree, compiled and installed it. I tested it against the OProfile testsuite, which includes SPU event profiling tests. Everything passed. The patch I submitted was against a 2.6.26 tree. You are now on a 2.6.28 tree so perhaps that is why the patch did not apply cleanly. The patch has been out there for some time.
When you submited it on Dec 2, it should have been against whatever was the latest upstream at the time, not 2.6.26.
Cheers,
Ben.
Quoted 7 lines · Benjamin Herrenschmidt
Quoted 5 lines · Carl Love
I pulled down the git tree, compiled and installed it. I tested it against the OProfile testsuite, which includes SPU event profiling tests. Everything passed. The patch I submitted was against a 2.6.26 tree. You are now on a 2.6.28 tree so perhaps that is why the patch did not apply cleanly. The patch has been out there for some time.
Quoted 5 lines
When you submited it on Dec 2, it should have been against whatever was the latest upstream at the time, not 2.6.26.
Cheers,
Ben.
Ben, Arnd and Robert:
The patch was against the latest Arnd Cell Kernel tree at the time it was posted. The OProfile for cell patches have all been submitted, accepted by Arnd (CELL Kernel maintainer) and pushed up stream by Arnd. Arnd has waited for the OProfile maintainer to review and approve the change before Arnd would push it upstream.
So, at this point, Robert's (OProfile kernel maintainer) and Maynard's (OProfile user space maintainer) approval for the patches.
The question now goes to Arnd and Robert, who is going to push the patches upstream? Looks like Robert is ready to do it, so Arnd do you approve the patches? Would you like to have Robert push the patches upstream or would you prefer to do it? I think we need an answer/agreement on this.
Carl Love
Quoted 15 lines · Carl Love
Quoted 7 lines · Benjamin Herrenschmidt
Quoted 5 lines · Carl Love
I pulled down the git tree, compiled and installed it. I tested it against the OProfile testsuite, which includes SPU event profiling tests. Everything passed. The patch I submitted was against a 2.6.26 tree. You are now on a 2.6.28 tree so perhaps that is why the patch did not apply cleanly. The patch has been out there for some time.
Quoted 5 lines
When you submited it on Dec 2, it should have been against whatever was the latest upstream at the time, not 2.6.26.
Cheers,
Ben.
Quoted 7 lines
Ben, Arnd and Robert:
The patch was against the latest Arnd Cell Kernel tree at the time it was posted. The OProfile for cell patches have all been submitted, accepted by Arnd (CELL Kernel maintainer) and pushed up stream by Arnd. Arnd has waited for the OProfile maintainer to review and approve the change before Arnd would push it upstream.
The patches are already upstream in v2.6.29-rc1. Hope this is ok. I had added them to the oprofile tree and the tree was merged be Linus.
-Robert
Quoted 8 lines
So, at this point, Robert's (OProfile kernel maintainer) and Maynard's (OProfile user space maintainer) approval for the patches.
The question now goes to Arnd and Robert, who is going to push the patches upstream? Looks like Robert is ready to do it, so Arnd do you approve the patches? Would you like to have Robert push the patches upstream or would you prefer to do it? I think we need an answer/agreement on this.
Arnd, I thought the patches were ok for you. If there are still some concerns, we have to make delta patches.
See also here:
git log -4 -p 25006644e6042aab4bb7cdc4bfc5777cd3141df7
-Robert
Signature · 3 lines
Advanced Micro Devices, Inc. Operating System Research Center email: [email protected]
Quoted 2 lines · Robert Richter
Arnd, I thought the patches were ok for you. If there are still some concerns, we have to make delta patches.
Yes, that's fine with me, thanks for taking care of the patches!
Arnd <><
Quoted 7 lines · Arnd Bergmann
Quoted 2 lines · Robert Richter
Arnd, I thought the patches were ok for you. If there are still some concerns, we have to make delta patches.
Yes, that's fine with me, thanks for taking care of the patches!
Arnd <><
Thanks guys for all your help on the patches.
Carl Love