Skip to contentSkip to conversation

linux-next: origin tree build failure

PATCH New Stephen Rothwell 5 participants 26 messages Jan 11, 2009 – Jan 13, 2009

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

Hi Linus,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

arch/powerpc/platforms/pasemi/cpufreq.c: In function 'pas_cpufreq_cpu_init':
arch/powerpc/platforms/pasemi/cpufreq.c:216: error: incompatible types in assignment arch/powerpc/platforms/powermac/cpufreq_64.c: In function 'g5_cpufreq_cpu_init':
arch/powerpc/platforms/powermac/cpufreq_64.c:365: error: incompatible types in assignment arch/powerpc/platforms/cell/cbe_cpufreq.c: In function 'cbe_cpufreq_cpu_init':
arch/powerpc/platforms/cell/cbe_cpufreq.c:121: error: incompatible types in assignment

Caused by commit 835481d9bcd65720b473db6b38746a74a3964218 ("cpumask:
convert struct cpufreq_policy to cpumask_var_t") which missed updating all the powerpc (at least) cpufreq drivers.

Reverting that one commit required fixups, so I reverted merge commit 4e9b1c184cadbece3694603de5f880b6e35bd7a7 ("Merge branch 'cpus4096-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip")
instead.

I am hoping that this will be fixed soon and that revert doesn't propagate more pain through today's linux-next.

This branch was last committed to in the tip tree on Jan 7 (the patch above was committed on Jan 6) but was never propagated to linux-next before being merged into your tree yesterday.

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#1 lore raw
Quoted 11 lines · Stephen Rothwell

Hi Linus,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

arch/powerpc/platforms/pasemi/cpufreq.c: In function 'pas_cpufreq_cpu_init':
arch/powerpc/platforms/pasemi/cpufreq.c:216: error: incompatible types in assignment arch/powerpc/platforms/powermac/cpufreq_64.c: In function 'g5_cpufreq_cpu_init':
arch/powerpc/platforms/powermac/cpufreq_64.c:365: error: incompatible types in assignment arch/powerpc/platforms/cell/cbe_cpufreq.c: In function 'cbe_cpufreq_cpu_init':
arch/powerpc/platforms/cell/cbe_cpufreq.c:121: error: incompatible types in assignment

Quoted 3 lines

Caused by commit 835481d9bcd65720b473db6b38746a74a3964218 ("cpumask:
convert struct cpufreq_policy to cpumask_var_t") which missed updating all the powerpc (at least) cpufreq drivers.

Yeah, it only updates x86 it seems ...

Quoted 7 lines

Reverting that one commit required fixups, so I reverted merge commit 4e9b1c184cadbece3694603de5f880b6e35bd7a7 ("Merge branch 'cpus4096-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip")
instead.

I am hoping that this will be fixed soon and that revert doesn't propagate more pain through today's linux-next.

I've just made a patch, testing it now, will send it in a few minutes

Cheers,
Ben.

#2 lore raw
In reply to Stephen Rothwell
Quoted 11 lines · Stephen Rothwell

Hi Linus,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

arch/powerpc/platforms/pasemi/cpufreq.c: In function 'pas_cpufreq_cpu_init':
arch/powerpc/platforms/pasemi/cpufreq.c:216: error: incompatible types in assignment arch/powerpc/platforms/powermac/cpufreq_64.c: In function 'g5_cpufreq_cpu_init':
arch/powerpc/platforms/powermac/cpufreq_64.c:365: error: incompatible types in assignment arch/powerpc/platforms/cell/cbe_cpufreq.c: In function 'cbe_cpufreq_cpu_init':
arch/powerpc/platforms/cell/cbe_cpufreq.c:121: error: incompatible types in assignment

Quoted 3 lines

Caused by commit 835481d9bcd65720b473db6b38746a74a3964218 ("cpumask:
convert struct cpufreq_policy to cpumask_var_t") which missed updating all the powerpc (at least) cpufreq drivers.

Yeah, it only updates x86 it seems ...

Quoted 7 lines

Reverting that one commit required fixups, so I reverted merge commit 4e9b1c184cadbece3694603de5f880b6e35bd7a7 ("Merge branch 'cpus4096-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip")
instead.

I am hoping that this will be fixed soon and that revert doesn't propagate more pain through today's linux-next.

I've just made a patch, testing it now, will send it in a few minutes

Cheers,
Ben.

#3 lore raw
In reply to Stephen Rothwell
Quoted 11 lines · Stephen Rothwell

Hi Linus,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

arch/powerpc/platforms/pasemi/cpufreq.c: In function 'pas_cpufreq_cpu_init':
arch/powerpc/platforms/pasemi/cpufreq.c:216: error: incompatible types in assignment arch/powerpc/platforms/powermac/cpufreq_64.c: In function 'g5_cpufreq_cpu_init':
arch/powerpc/platforms/powermac/cpufreq_64.c:365: error: incompatible types in assignment arch/powerpc/platforms/cell/cbe_cpufreq.c: In function 'cbe_cpufreq_cpu_init':
arch/powerpc/platforms/cell/cbe_cpufreq.c:121: error: incompatible types in assignment

Quoted 3 lines

Caused by commit 835481d9bcd65720b473db6b38746a74a3964218 ("cpumask:
convert struct cpufreq_policy to cpumask_var_t") which missed updating all the powerpc (at least) cpufreq drivers.

Yeah, it only updates x86 it seems ...

Quoted 7 lines

Reverting that one commit required fixups, so I reverted merge commit 4e9b1c184cadbece3694603de5f880b6e35bd7a7 ("Merge branch 'cpus4096-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip")
instead.

I am hoping that this will be fixed soon and that revert doesn't propagate more pain through today's linux-next.

I've just made a patch, testing it now, will send it in a few minutes

Cheers,
Ben.

#4 lore raw

PATCH 1/1 powerpc: Fix cpufreq drivers after cpufreq core changes

This updates the cpufreq drivers in arch/powerpc so they build again after the core cpufreq changes that broke them in commit in835481d9bcd65720b473db6b38746a74a3964218.

---

Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi drivers still work ?

Linus, you can probably merge this now to fix the build problems.

arch/powerpc/platforms/cell/cbe_cpufreq.c +1 -1
index ec7c8f4..e6506cd 100644
@@ -118,7 +118,7 @@ static int cbe_cpufreq_cpu_init(struct cpufreq_policy *policy)
 	policy->cur = cbe_freqs[cur_pmode].frequency;
 
 #ifdef CONFIG_SMP
-	policy->cpus = per_cpu(cpu_sibling_map, policy->cpu);
+	cpumask_copy(policy->cpus, &per_cpu(cpu_sibling_map, policy->cpu));
 #endif
 
 	cpufreq_frequency_table_get_attr(cbe_freqs, policy->cpu);
arch/powerpc/platforms/cell/cpufreq_spudemand.c +2 -2
index a3c6c01..968c1c0 100644
@@ -110,7 +110,7 @@ static int spu_gov_govern(struct cpufreq_policy *policy, unsigned int event)
 		}
 
 		/* initialize spu_gov_info for all affected cpus */
-		for_each_cpu_mask(i, policy->cpus) {
+		for_each_cpu(i, policy->cpus) {
 			affected_info = &per_cpu(spu_gov_info, i);
 			affected_info->policy = policy;
 		}
@@ -127,7 +127,7 @@ static int spu_gov_govern(struct cpufreq_policy *policy, unsigned int event)
 		spu_gov_cancel_work(info);
 
 		/* clean spu_gov_info for all affected cpus */
-		for_each_cpu_mask (i, policy->cpus) {
+		for_each_cpu (i, policy->cpus) {
 			info = &per_cpu(spu_gov_info, i);
 			info->policy = NULL;
 		}
arch/powerpc/platforms/pasemi/cpufreq.c +1 -1
index 86db47c..be2527a 100644
@@ -213,7 +213,7 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy)
 	pr_debug("current astate is at %d\n",cur_astate);
 
 	policy->cur = pas_freqs[cur_astate].frequency;
-	policy->cpus = cpu_online_map;
+	cpumask_copy(policy->cpus, &cpu_online_map);
 
 	ppc_proc_freq = policy->cur * 1000ul;
 
arch/powerpc/platforms/powermac/cpufreq_64.c +1 -1
index 4dfb4bc..beb3833 100644
@@ -362,7 +362,7 @@ static int g5_cpufreq_cpu_init(struct cpufreq_policy *policy)
 	/* secondary CPUs are tied to the primary one by the
 	 * cpufreq core if in the secondary policy we tell it that
 	 * it actually must be one policy together with all others. */
-	policy->cpus = cpu_online_map;
+	cpumask_copy(policy->cpus, &cpu_online_map);
 	cpufreq_frequency_table_get_attr(g5_cpu_freqs, policy->cpu);
 
 	return cpufreq_frequency_table_cpuinfo(policy,
#5 lore raw

PATCH 1/1 powerpc: Fix cpufreq drivers after cpufreq core changes

In reply to Benjamin Herrenschmidt

This updates the cpufreq drivers in arch/powerpc so they build again after the core cpufreq changes that broke them in commit in835481d9bcd65720b473db6b38746a74a3964218.

---

Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi drivers still work ?

Linus, you can probably merge this now to fix the build problems.

arch/powerpc/platforms/cell/cbe_cpufreq.c +1 -1
index ec7c8f4..e6506cd 100644
@@ -118,7 +118,7 @@ static int cbe_cpufreq_cpu_init(struct cpufreq_policy *policy)
 	policy->cur = cbe_freqs[cur_pmode].frequency;
 
 #ifdef CONFIG_SMP
-	policy->cpus = per_cpu(cpu_sibling_map, policy->cpu);
+	cpumask_copy(policy->cpus, &per_cpu(cpu_sibling_map, policy->cpu));
 #endif
 
 	cpufreq_frequency_table_get_attr(cbe_freqs, policy->cpu);
arch/powerpc/platforms/cell/cpufreq_spudemand.c +2 -2
index a3c6c01..968c1c0 100644
@@ -110,7 +110,7 @@ static int spu_gov_govern(struct cpufreq_policy *policy, unsigned int event)
 		}
 
 		/* initialize spu_gov_info for all affected cpus */
-		for_each_cpu_mask(i, policy->cpus) {
+		for_each_cpu(i, policy->cpus) {
 			affected_info = &per_cpu(spu_gov_info, i);
 			affected_info->policy = policy;
 		}
@@ -127,7 +127,7 @@ static int spu_gov_govern(struct cpufreq_policy *policy, unsigned int event)
 		spu_gov_cancel_work(info);
 
 		/* clean spu_gov_info for all affected cpus */
-		for_each_cpu_mask (i, policy->cpus) {
+		for_each_cpu (i, policy->cpus) {
 			info = &per_cpu(spu_gov_info, i);
 			info->policy = NULL;
 		}
arch/powerpc/platforms/pasemi/cpufreq.c +1 -1
index 86db47c..be2527a 100644
@@ -213,7 +213,7 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy)
 	pr_debug("current astate is at %d\n",cur_astate);
 
 	policy->cur = pas_freqs[cur_astate].frequency;
-	policy->cpus = cpu_online_map;
+	cpumask_copy(policy->cpus, &cpu_online_map);
 
 	ppc_proc_freq = policy->cur * 1000ul;
 
arch/powerpc/platforms/powermac/cpufreq_64.c +1 -1
index 4dfb4bc..beb3833 100644
@@ -362,7 +362,7 @@ static int g5_cpufreq_cpu_init(struct cpufreq_policy *policy)
 	/* secondary CPUs are tied to the primary one by the
 	 * cpufreq core if in the secondary policy we tell it that
 	 * it actually must be one policy together with all others. */
-	policy->cpus = cpu_online_map;
+	cpumask_copy(policy->cpus, &cpu_online_map);
 	cpufreq_frequency_table_get_attr(g5_cpu_freqs, policy->cpu);
 
 	return cpufreq_frequency_table_cpuinfo(policy,
#6 lore raw

PATCH 1/1 powerpc: Fix cpufreq drivers after cpufreq core changes

In reply to Benjamin Herrenschmidt

This updates the cpufreq drivers in arch/powerpc so they build again after the core cpufreq changes that broke them in commit in835481d9bcd65720b473db6b38746a74a3964218.

---

Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi drivers still work ?

Linus, you can probably merge this now to fix the build problems.

arch/powerpc/platforms/cell/cbe_cpufreq.c +1 -1
index ec7c8f4..e6506cd 100644
@@ -118,7 +118,7 @@ static int cbe_cpufreq_cpu_init(struct cpufreq_policy *policy)
 	policy->cur = cbe_freqs[cur_pmode].frequency;
 
 #ifdef CONFIG_SMP
-	policy->cpus = per_cpu(cpu_sibling_map, policy->cpu);
+	cpumask_copy(policy->cpus, &per_cpu(cpu_sibling_map, policy->cpu));
 #endif
 
 	cpufreq_frequency_table_get_attr(cbe_freqs, policy->cpu);
arch/powerpc/platforms/cell/cpufreq_spudemand.c +2 -2
index a3c6c01..968c1c0 100644
@@ -110,7 +110,7 @@ static int spu_gov_govern(struct cpufreq_policy *policy, unsigned int event)
 		}
 
 		/* initialize spu_gov_info for all affected cpus */
-		for_each_cpu_mask(i, policy->cpus) {
+		for_each_cpu(i, policy->cpus) {
 			affected_info = &per_cpu(spu_gov_info, i);
 			affected_info->policy = policy;
 		}
@@ -127,7 +127,7 @@ static int spu_gov_govern(struct cpufreq_policy *policy, unsigned int event)
 		spu_gov_cancel_work(info);
 
 		/* clean spu_gov_info for all affected cpus */
-		for_each_cpu_mask (i, policy->cpus) {
+		for_each_cpu (i, policy->cpus) {
 			info = &per_cpu(spu_gov_info, i);
 			info->policy = NULL;
 		}
arch/powerpc/platforms/pasemi/cpufreq.c +1 -1
index 86db47c..be2527a 100644
@@ -213,7 +213,7 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy)
 	pr_debug("current astate is at %d\n",cur_astate);
 
 	policy->cur = pas_freqs[cur_astate].frequency;
-	policy->cpus = cpu_online_map;
+	cpumask_copy(policy->cpus, &cpu_online_map);
 
 	ppc_proc_freq = policy->cur * 1000ul;
 
arch/powerpc/platforms/powermac/cpufreq_64.c +1 -1
index 4dfb4bc..beb3833 100644
@@ -362,7 +362,7 @@ static int g5_cpufreq_cpu_init(struct cpufreq_policy *policy)
 	/* secondary CPUs are tied to the primary one by the
 	 * cpufreq core if in the secondary policy we tell it that
 	 * it actually must be one policy together with all others. */
-	policy->cpus = cpu_online_map;
+	cpumask_copy(policy->cpus, &cpu_online_map);
 	cpufreq_frequency_table_get_attr(g5_cpu_freqs, policy->cpu);
 
 	return cpufreq_frequency_table_cpuinfo(policy,
#7 lore raw

Re: [PATCH] powerpc: Fix cpufreq drivers after cpufreq core changes

Quoted 11 lines · Benjamin Herrenschmidt

This updates the cpufreq drivers in arch/powerpc so they build again after the core cpufreq changes that broke them in commit in835481d9bcd65720b473db6b38746a74a3964218.

---

Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi drivers still work ?

Linus, you can probably merge this now to fix the build problems.

Thanks Ben!

The powerpc defconfig built fine - you might wan to turn on cpufreq in the powerpc defconfig so that cross-build tests can catch problems like this.

Ingo

#8 lore raw

Re: [PATCH] powerpc: Fix cpufreq drivers after cpufreq core changes

Quoted 12 lines · Ingo Molnar
Quoted 10 lines · Benjamin Herrenschmidt

This updates the cpufreq drivers in arch/powerpc so they build again after the core cpufreq changes that broke them in commit in835481d9bcd65720b473db6b38746a74a3964218.

---

Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi drivers still work ?

Quoted 6 lines
Quoted 1 line

Linus, you can probably merge this now to fix the build problems.

Thanks Ben!

The powerpc defconfig built fine - you might wan to turn on cpufreq in the powerpc defconfig so that cross-build tests can catch problems like this.

Hrm... which config are you using ? ppc64_defconfig has them all on.

Cheers,
Ben.

#9 lore raw

Re: [PATCH] powerpc: Fix cpufreq drivers after cpufreq core changes

In reply to Ingo Molnar
Quoted 12 lines · Ingo Molnar
Quoted 10 lines · Benjamin Herrenschmidt

This updates the cpufreq drivers in arch/powerpc so they build again after the core cpufreq changes that broke them in commit in835481d9bcd65720b473db6b38746a74a3964218.

---

Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi drivers still work ?

Quoted 6 lines
Quoted 1 line

Linus, you can probably merge this now to fix the build problems.

Thanks Ben!

The powerpc defconfig built fine - you might wan to turn on cpufreq in the powerpc defconfig so that cross-build tests can catch problems like this.

Hrm... which config are you using ? ppc64_defconfig has them all on.

Cheers,
Ben.

#10 lore raw

Re: [PATCH] powerpc: Fix cpufreq drivers after cpufreq core changes

In reply to Ingo Molnar
Quoted 12 lines · Ingo Molnar
Quoted 10 lines · Benjamin Herrenschmidt

This updates the cpufreq drivers in arch/powerpc so they build again after the core cpufreq changes that broke them in commit in835481d9bcd65720b473db6b38746a74a3964218.

---

Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi drivers still work ?

Quoted 6 lines
Quoted 1 line

Linus, you can probably merge this now to fix the build problems.

Thanks Ben!

The powerpc defconfig built fine - you might wan to turn on cpufreq in the powerpc defconfig so that cross-build tests can catch problems like this.

Hrm... which config are you using ? ppc64_defconfig has them all on.

Cheers,
Ben.

#11 lore raw

Re: [PATCH] powerpc: Fix cpufreq drivers after cpufreq core changes

In reply to Ingo Molnar
Quoted 12 lines · Ingo Molnar
Quoted 10 lines · Benjamin Herrenschmidt

This updates the cpufreq drivers in arch/powerpc so they build again after the core cpufreq changes that broke them in commit in835481d9bcd65720b473db6b38746a74a3964218.

---

Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi drivers still work ?

Quoted 6 lines
Quoted 1 line

Linus, you can probably merge this now to fix the build problems.

Thanks Ben!

The powerpc defconfig built fine - you might wan to turn on cpufreq in the powerpc defconfig so that cross-build tests can catch problems like this.

Hrm... which config are you using ? ppc64_defconfig has them all on.

Cheers,
Ben.

#12 lore raw

Re: [PATCH] powerpc: Fix cpufreq drivers after cpufreq core changes

In reply to Benjamin Herrenschmidt
Quoted 9 lines · Benjamin Herrenschmidt

This updates the cpufreq drivers in arch/powerpc so they build again after the core cpufreq changes that broke them in commit in835481d9bcd65720b473db6b38746a74a3964218.

---

Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi drivers still work ?

Tested fine on pasemi.

-Olof

#13 lore raw

Re: [PATCH] powerpc: Fix cpufreq drivers after cpufreq core changes

In reply to Benjamin Herrenschmidt
Quoted 9 lines · Benjamin Herrenschmidt

This updates the cpufreq drivers in arch/powerpc so they build again after the core cpufreq changes that broke them in commit in835481d9bcd65720b473db6b38746a74a3964218.

---

Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi drivers still work ?

Tested fine on pasemi.

-Olof

#14 lore raw

Re: [PATCH] powerpc: Fix cpufreq drivers after cpufreq core changes

In reply to Benjamin Herrenschmidt
Quoted 9 lines · Benjamin Herrenschmidt

This updates the cpufreq drivers in arch/powerpc so they build again after the core cpufreq changes that broke them in commit in835481d9bcd65720b473db6b38746a74a3964218.

---

Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi drivers still work ?

Tested fine on pasemi.

-Olof

#15 lore raw

PATCH 1/1 powerpc: Fix cpufreq drivers after cpufreq core changes

In reply to Benjamin Herrenschmidt

This updates the cpufreq drivers in arch/powerpc so they build again after the core cpufreq changes that broke them in commit in835481d9bcd65720b473db6b38746a74a3964218.

---

Tested on a G5. Olof, Arnd, any chance you can test the cell and pasemi drivers still work ?

Linus, you can probably merge this now to fix the build problems.

arch/powerpc/platforms/cell/cbe_cpufreq.c +1 -1
index ec7c8f4..e6506cd 100644
@@ -118,7 +118,7 @@ static int cbe_cpufreq_cpu_init(struct cpufreq_policy *policy)
 	policy->cur = cbe_freqs[cur_pmode].frequency;
 
 #ifdef CONFIG_SMP
-	policy->cpus = per_cpu(cpu_sibling_map, policy->cpu);
+	cpumask_copy(policy->cpus, &per_cpu(cpu_sibling_map, policy->cpu));
 #endif
 
 	cpufreq_frequency_table_get_attr(cbe_freqs, policy->cpu);
arch/powerpc/platforms/cell/cpufreq_spudemand.c +2 -2
index a3c6c01..968c1c0 100644
@@ -110,7 +110,7 @@ static int spu_gov_govern(struct cpufreq_policy *policy, unsigned int event)
 		}
 
 		/* initialize spu_gov_info for all affected cpus */
-		for_each_cpu_mask(i, policy->cpus) {
+		for_each_cpu(i, policy->cpus) {
 			affected_info = &per_cpu(spu_gov_info, i);
 			affected_info->policy = policy;
 		}
@@ -127,7 +127,7 @@ static int spu_gov_govern(struct cpufreq_policy *policy, unsigned int event)
 		spu_gov_cancel_work(info);
 
 		/* clean spu_gov_info for all affected cpus */
-		for_each_cpu_mask (i, policy->cpus) {
+		for_each_cpu (i, policy->cpus) {
 			info = &per_cpu(spu_gov_info, i);
 			info->policy = NULL;
 		}
arch/powerpc/platforms/pasemi/cpufreq.c +1 -1
index 86db47c..be2527a 100644
@@ -213,7 +213,7 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy)
 	pr_debug("current astate is at %d\n",cur_astate);
 
 	policy->cur = pas_freqs[cur_astate].frequency;
-	policy->cpus = cpu_online_map;
+	cpumask_copy(policy->cpus, &cpu_online_map);
 
 	ppc_proc_freq = policy->cur * 1000ul;
 
arch/powerpc/platforms/powermac/cpufreq_64.c +1 -1
index 4dfb4bc..beb3833 100644
@@ -362,7 +362,7 @@ static int g5_cpufreq_cpu_init(struct cpufreq_policy *policy)
 	/* secondary CPUs are tied to the primary one by the
 	 * cpufreq core if in the secondary policy we tell it that
 	 * it actually must be one policy together with all others. */
-	policy->cpus = cpu_online_map;
+	cpumask_copy(policy->cpus, &cpu_online_map);
 	cpufreq_frequency_table_get_attr(g5_cpu_freqs, policy->cpu);
 
 	return cpufreq_frequency_table_cpuinfo(policy,
#16 lore raw
In reply to Benjamin Herrenschmidt
Quoted 12 lines · Benjamin Herrenschmidt
Quoted 11 lines · Stephen Rothwell

Hi Linus,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

arch/powerpc/platforms/pasemi/cpufreq.c: In function 'pas_cpufreq_cpu_init':
arch/powerpc/platforms/pasemi/cpufreq.c:216: error: incompatible types in assignment arch/powerpc/platforms/powermac/cpufreq_64.c: In function 'g5_cpufreq_cpu_init':
arch/powerpc/platforms/powermac/cpufreq_64.c:365: error: incompatible types in assignment arch/powerpc/platforms/cell/cbe_cpufreq.c: In function 'cbe_cpufreq_cpu_init':
arch/powerpc/platforms/cell/cbe_cpufreq.c:121: error: incompatible types in assignment

Quoted 5 lines
Quoted 3 lines

Caused by commit 835481d9bcd65720b473db6b38746a74a3964218 ("cpumask:
convert struct cpufreq_policy to cpumask_var_t") which missed updating all the powerpc (at least) cpufreq drivers.

Yeah, it only updates x86 it seems ...

Yeah - and that build bug was stupid too - when touching a generic file that is called include/linux/cpufreq.h and changing a key data field one should at minimum get the idea that it's generic for a reason and should start grepping the tree ...

It slipped through because it didnt get caught in build tests because cpufreq isnt enabled in the powerpc defconfig.

Ingo

#17 lore raw

Hi Ingo,

Quoted 8 lines · On Mon, 12 Jan 2009 10:05:52 +0100 Ingo Molnar <[email protected]> wrote:

Yeah - and that build bug was stupid too - when touching a generic file that is called include/linux/cpufreq.h and changing a key data field one should at minimum get the idea that it's generic for a reason and should start grepping the tree ...

It slipped through because it didnt get caught in build tests because cpufreq isnt enabled in the powerpc defconfig.

Which is one of the reasons we have linux-next: "integration testing". This way not every developer/maintainer has to have/use cross compilers for every (or even many) non-native (from their point of view) architectures.

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#18 lore raw
Quoted 4 lines · Stephen Rothwell
Quoted 2 lines

It slipped through because it didnt get caught in build tests because cpufreq isnt enabled in the powerpc defconfig.

Which is one of the reasons we have linux-next: "integration testing".

Build bugs slipped through that net too in the past.

And we dont really want developers and maintainers to rely on an external middle man facility to be able to submit patches. So the best method is to make the defconfigs good enough to catch everyday build bugs. Random testing and linux-next can then catch the weird special cases as well.

Ingo

#19 lore raw

Hi Ingo,

Quoted 9 lines · On Mon, 12 Jan 2009 10:32:14 +0100 Ingo Molnar <[email protected]> wrote:
Quoted 4 lines · Stephen Rothwell
Quoted 2 lines

It slipped through because it didnt get caught in build tests because cpufreq isnt enabled in the powerpc defconfig.

Which is one of the reasons we have linux-next: "integration testing".

Build bugs slipped through that net too in the past.

Of course they have.

Quoted 4 lines

And we dont really want developers and maintainers to rely on an external middle man facility to be able to submit patches. So the best method is to make the defconfigs good enough to catch everyday build bugs. Random testing and linux-next can then catch the weird special cases as well.

linux-next is merely a tool - it can't catch anything if you don't use it.

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#20 lore raw
In reply to Ingo Molnar
Quoted 20 lines · Ingo Molnar
Quoted 12 lines · Benjamin Herrenschmidt
Quoted 11 lines · Stephen Rothwell

Hi Linus,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

arch/powerpc/platforms/pasemi/cpufreq.c: In function 'pas_cpufreq_cpu_init':
arch/powerpc/platforms/pasemi/cpufreq.c:216: error: incompatible types in assignment arch/powerpc/platforms/powermac/cpufreq_64.c: In function 'g5_cpufreq_cpu_init':
arch/powerpc/platforms/powermac/cpufreq_64.c:365: error: incompatible types in assignment arch/powerpc/platforms/cell/cbe_cpufreq.c: In function 'cbe_cpufreq_cpu_init':
arch/powerpc/platforms/cell/cbe_cpufreq.c:121: error: incompatible types in assignment

Quoted 5 lines
Quoted 3 lines

Caused by commit 835481d9bcd65720b473db6b38746a74a3964218 ("cpumask:
convert struct cpufreq_policy to cpumask_var_t") which missed updating all the powerpc (at least) cpufreq drivers.

Yeah, it only updates x86 it seems ...

Quoted 7 lines

Yeah - and that build bug was stupid too - when touching a generic file that is called include/linux/cpufreq.h and changing a key data field one should at minimum get the idea that it's generic for a reason and should start grepping the tree ...

It slipped through because it didnt get caught in build tests because cpufreq isnt enabled in the powerpc defconfig.

Which defconfig?

powerpc(master) $ git grep CPU_FREQ=y arch/powerpc/configs/ppc64_defconfig arch/powerpc/configs/ppc64_defconfig:CONFIG_CPU_FREQ=y

cheers

Signature · 8 lines
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
#21 lore raw
Quoted 26 lines · Michael Ellerman
Quoted 25 lines · Ingo Molnar
Quoted 12 lines · Benjamin Herrenschmidt
Quoted 11 lines · Stephen Rothwell

Hi Linus,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

arch/powerpc/platforms/pasemi/cpufreq.c: In function 'pas_cpufreq_cpu_init':
arch/powerpc/platforms/pasemi/cpufreq.c:216: error: incompatible types in assignment arch/powerpc/platforms/powermac/cpufreq_64.c: In function 'g5_cpufreq_cpu_init':
arch/powerpc/platforms/powermac/cpufreq_64.c:365: error: incompatible types in assignment arch/powerpc/platforms/cell/cbe_cpufreq.c: In function 'cbe_cpufreq_cpu_init':
arch/powerpc/platforms/cell/cbe_cpufreq.c:121: error: incompatible types in assignment

Quoted 5 lines
Quoted 3 lines

Caused by commit 835481d9bcd65720b473db6b38746a74a3964218 ("cpumask:
convert struct cpufreq_policy to cpumask_var_t") which missed updating all the powerpc (at least) cpufreq drivers.

Yeah, it only updates x86 it seems ...

Yeah - and that build bug was stupid too - when touching a generic file that is called include/linux/cpufreq.h and changing a key data field one should at minimum get the idea that it's generic for a reason and should start grepping the tree ...

Quoted 7 lines
Quoted 2 lines

It slipped through because it didnt get caught in build tests because cpufreq isnt enabled in the powerpc defconfig.

Which defconfig?

powerpc(master) $ git grep CPU_FREQ=y arch/powerpc/configs/ppc64_defconfig arch/powerpc/configs/ppc64_defconfig:CONFIG_CPU_FREQ=y

ah, indeed - you are right.

Ingo

#22 lore raw
In reply to Michael Ellerman
Quoted 26 lines · Michael Ellerman
Quoted 25 lines · Ingo Molnar
Quoted 12 lines · Benjamin Herrenschmidt
Quoted 11 lines · Stephen Rothwell

Hi Linus,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

arch/powerpc/platforms/pasemi/cpufreq.c: In function 'pas_cpufreq_cpu_init':
arch/powerpc/platforms/pasemi/cpufreq.c:216: error: incompatible types in assignment arch/powerpc/platforms/powermac/cpufreq_64.c: In function 'g5_cpufreq_cpu_init':
arch/powerpc/platforms/powermac/cpufreq_64.c:365: error: incompatible types in assignment arch/powerpc/platforms/cell/cbe_cpufreq.c: In function 'cbe_cpufreq_cpu_init':
arch/powerpc/platforms/cell/cbe_cpufreq.c:121: error: incompatible types in assignment

Quoted 5 lines
Quoted 3 lines

Caused by commit 835481d9bcd65720b473db6b38746a74a3964218 ("cpumask:
convert struct cpufreq_policy to cpumask_var_t") which missed updating all the powerpc (at least) cpufreq drivers.

Yeah, it only updates x86 it seems ...

Yeah - and that build bug was stupid too - when touching a generic file that is called include/linux/cpufreq.h and changing a key data field one should at minimum get the idea that it's generic for a reason and should start grepping the tree ...

Quoted 7 lines
Quoted 2 lines

It slipped through because it didnt get caught in build tests because cpufreq isnt enabled in the powerpc defconfig.

Which defconfig?

powerpc(master) $ git grep CPU_FREQ=y arch/powerpc/configs/ppc64_defconfig arch/powerpc/configs/ppc64_defconfig:CONFIG_CPU_FREQ=y

ah, indeed - you are right.

Ingo

#23 lore raw
In reply to Michael Ellerman
Quoted 26 lines · Michael Ellerman
Quoted 25 lines · Ingo Molnar
Quoted 12 lines · Benjamin Herrenschmidt
Quoted 11 lines · Stephen Rothwell

Hi Linus,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

arch/powerpc/platforms/pasemi/cpufreq.c: In function 'pas_cpufreq_cpu_init':
arch/powerpc/platforms/pasemi/cpufreq.c:216: error: incompatible types in assignment arch/powerpc/platforms/powermac/cpufreq_64.c: In function 'g5_cpufreq_cpu_init':
arch/powerpc/platforms/powermac/cpufreq_64.c:365: error: incompatible types in assignment arch/powerpc/platforms/cell/cbe_cpufreq.c: In function 'cbe_cpufreq_cpu_init':
arch/powerpc/platforms/cell/cbe_cpufreq.c:121: error: incompatible types in assignment

Quoted 5 lines
Quoted 3 lines

Caused by commit 835481d9bcd65720b473db6b38746a74a3964218 ("cpumask:
convert struct cpufreq_policy to cpumask_var_t") which missed updating all the powerpc (at least) cpufreq drivers.

Yeah, it only updates x86 it seems ...

Yeah - and that build bug was stupid too - when touching a generic file that is called include/linux/cpufreq.h and changing a key data field one should at minimum get the idea that it's generic for a reason and should start grepping the tree ...

Quoted 7 lines
Quoted 2 lines

It slipped through because it didnt get caught in build tests because cpufreq isnt enabled in the powerpc defconfig.

Which defconfig?

powerpc(master) $ git grep CPU_FREQ=y arch/powerpc/configs/ppc64_defconfig arch/powerpc/configs/ppc64_defconfig:CONFIG_CPU_FREQ=y

ah, indeed - you are right.

Ingo

#24 lore raw
In reply to Michael Ellerman
Quoted 26 lines · Michael Ellerman
Quoted 25 lines · Ingo Molnar
Quoted 12 lines · Benjamin Herrenschmidt
Quoted 11 lines · Stephen Rothwell

Hi Linus,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

arch/powerpc/platforms/pasemi/cpufreq.c: In function 'pas_cpufreq_cpu_init':
arch/powerpc/platforms/pasemi/cpufreq.c:216: error: incompatible types in assignment arch/powerpc/platforms/powermac/cpufreq_64.c: In function 'g5_cpufreq_cpu_init':
arch/powerpc/platforms/powermac/cpufreq_64.c:365: error: incompatible types in assignment arch/powerpc/platforms/cell/cbe_cpufreq.c: In function 'cbe_cpufreq_cpu_init':
arch/powerpc/platforms/cell/cbe_cpufreq.c:121: error: incompatible types in assignment

Quoted 5 lines
Quoted 3 lines

Caused by commit 835481d9bcd65720b473db6b38746a74a3964218 ("cpumask:
convert struct cpufreq_policy to cpumask_var_t") which missed updating all the powerpc (at least) cpufreq drivers.

Yeah, it only updates x86 it seems ...

Yeah - and that build bug was stupid too - when touching a generic file that is called include/linux/cpufreq.h and changing a key data field one should at minimum get the idea that it's generic for a reason and should start grepping the tree ...

Quoted 7 lines
Quoted 2 lines

It slipped through because it didnt get caught in build tests because cpufreq isnt enabled in the powerpc defconfig.

Which defconfig?

powerpc(master) $ git grep CPU_FREQ=y arch/powerpc/configs/ppc64_defconfig arch/powerpc/configs/ppc64_defconfig:CONFIG_CPU_FREQ=y

ah, indeed - you are right.

Ingo

#25 lore raw
In reply to Stephen Rothwell
Quoted 11 lines · Stephen Rothwell

Hi Linus,

Today's linux-next build (powerpc ppc64_defconfig) failed like this:

arch/powerpc/platforms/pasemi/cpufreq.c: In function 'pas_cpufreq_cpu_init':
arch/powerpc/platforms/pasemi/cpufreq.c:216: error: incompatible types in assignment arch/powerpc/platforms/powermac/cpufreq_64.c: In function 'g5_cpufreq_cpu_init':
arch/powerpc/platforms/powermac/cpufreq_64.c:365: error: incompatible types in assignment arch/powerpc/platforms/cell/cbe_cpufreq.c: In function 'cbe_cpufreq_cpu_init':
arch/powerpc/platforms/cell/cbe_cpufreq.c:121: error: incompatible types in assignment

Quoted 3 lines

Caused by commit 835481d9bcd65720b473db6b38746a74a3964218 ("cpumask:
convert struct cpufreq_policy to cpumask_var_t") which missed updating all the powerpc (at least) cpufreq drivers.

Yeah, it only updates x86 it seems ...

Quoted 7 lines

Reverting that one commit required fixups, so I reverted merge commit 4e9b1c184cadbece3694603de5f880b6e35bd7a7 ("Merge branch 'cpus4096-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip")
instead.

I am hoping that this will be fixed soon and that revert doesn't propagate more pain through today's linux-next.

I've just made a patch, testing it now, will send it in a few minutes

Cheers,
Ben.