Skip to contentSkip to conversation

hwmon: (abituguru3) Partial DMI matching,

PATCH Applied Alistair John Strachan 2 participants 4 messages Jan 13, 2009 – Jan 15, 2009

lore
Share & tools
lore
#0 lore raw

cover hwmon: (abituguru3) Partial DMI matching,

These patches have been compile and runtime tested.

The first patch implements the partial DMI matching we discussed, hopefully this method will prevent any further false negatives (thanks to Jean for his input on the method chosen).

The second patch adds a partial DMI board string for the IN9 32X MAX, enabling DMI board string matching. It depends on the first patch.

Both of these could go upstream; the first can definitely be considered a bugfix, the second is more dubious, but since I've rebased it on the first it could be applied later if required.

(One remaining question would be whether patch 1 should be CCed to -stable,
since there has been a regression introduced into 2.6.27 and present in 2.6.28 for some BIOS revisions of the IP35 Pro.)

--
Cheers,
Alistair.

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#1 lore raw

Re: [lm-sensors] [PATCH 0/2] hwmon: (abituguru3) Partial DMI

Hi Alistair,

Quoted 6 lines · Alistair John Strachan

These patches have been compile and runtime tested.

The first patch implements the partial DMI matching we discussed, hopefully this method will prevent any further false negatives (thanks to Jean for his input on the method chosen).

Quoted 6 lines

The second patch adds a partial DMI board string for the IN9 32X MAX, enabling DMI board string matching. It depends on the first patch.

Both of these could go upstream; the first can definitely be considered a bugfix, the second is more dubious, but since I've rebased it on the first it could be applied later if required.

Yes, I will push these patches upstream later today.

Quoted 3 lines

(One remaining question would be whether patch 1 should be CCed to -stable,
since there has been a regression introduced into 2.6.27 and present in 2.6.28 for some BIOS revisions of the IP35 Pro.)

Is there really a regression? If the DMI matching doesn't work, we fall back to the old detection method, so I can't see how there would be a regression. Care to explain?

(Which doesn't mean we can't push the patches to stable, as stable isn't limited to regressions. Just trying to understand.)

Speaking of DMI matching... If DMI is disabled, we do:

static inline int abituguru3_dmi_detect(void)

{
	return -ENODEV;
}

And this error value causes abituguru3_init() to bail out. Unless I'm missing something, the abituguru3 driver is simply useless without DMI support at the moment. We should either make that official and make the driver depend on DMI at Kconfig level, or change abituguru3_dmi_detect() to return 1, so that we fallback to the old detection method. Opinions?

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#2 lore raw

Re: [lm-sensors] [PATCH 0/2] hwmon: (abituguru3) Partial DMI

In reply to Alistair John Strachan
Quoted 7 lines · On Thursday 15 January 2009 15:22:45 Jean Delvare wrote:
Quoted 3 lines

(One remaining question would be whether patch 1 should be CCed to -stable, since there has been a regression introduced into 2.6.27 and present in 2.6.28 for some BIOS revisions of the IP35 Pro.)

Is there really a regression? If the DMI matching doesn't work, we fall back to the old detection method, so I can't see how there would be a regression. Care to explain?

Having looked at this properly I agree. It's clear that in this bug report what actually happened was the DMI match failed, AND the probe routine failed.

This definitely puts the final nail in the coffin of manual probing, especially on the IP35 Pro (which was where all these changes originated from).

Sorry for the confusion, you are correct, and there is no way this could be considered a regression. I had just extrapolated that from the original poster, but it must be the case that it has never worked, or worked unreliably.

Quoted 7 lines

Speaking of DMI matching... If DMI is disabled, we do:

static inline int abituguru3_dmi_detect(void)

{
	return -ENODEV;
}
Quoted 6 lines

And this error value causes abituguru3_init() to bail out. Unless I'm missing something, the abituguru3 driver is simply useless without DMI support at the moment. We should either make that official and make the driver depend on DMI at Kconfig level, or change abituguru3_dmi_detect() to return 1, so that we fallback to the old detection method. Opinions?

It should return 1. This is simply a blunder. Fortunately CONFIG_DMI is quite difficult to turn off, and no distribution would. I'll follow up to this email with a proper patch.

Apologies for the mistakes..

Signature · 7 lines
Cheers,
Alistair.

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#3 lore raw

Re: [lm-sensors] [PATCH 0/2] hwmon: (abituguru3) Partial DMI

In reply to Alistair John Strachan
Quoted 12 lines · Alistair John Strachan
Quoted 7 lines · On Thursday 15 January 2009 15:22:45 Jean Delvare wrote:
Quoted 3 lines

(One remaining question would be whether patch 1 should be CCed to -stable, since there has been a regression introduced into 2.6.27 and present in 2.6.28 for some BIOS revisions of the IP35 Pro.)

Is there really a regression? If the DMI matching doesn't work, we fall back to the old detection method, so I can't see how there would be a regression. Care to explain?

Having looked at this properly I agree. It's clear that in this bug report what actually happened was the DMI match failed, AND the probe routine failed.

Quoted 8 lines

This definitely puts the final nail in the coffin of manual probing, especially on the IP35 Pro (which was where all these changes originated from).

Sorry for the confusion, you are correct, and there is no way this could be considered a regression. I had just extrapolated that from the original poster, but it must be the case that it has never worked, or worked unreliably.

Or the regression was cause by a BUIS update. In which case we are not responsible for it.

Quoted 14 lines
Quoted 7 lines

Speaking of DMI matching... If DMI is disabled, we do:

static inline int abituguru3_dmi_detect(void)

{
	return -ENODEV;
}
Quoted 6 lines

And this error value causes abituguru3_init() to bail out. Unless I'm missing something, the abituguru3 driver is simply useless without DMI support at the moment. We should either make that official and make the driver depend on DMI at Kconfig level, or change abituguru3_dmi_detect() to return 1, so that we fallback to the old detection method. Opinions?

Quoted 3 lines

It should return 1. This is simply a blunder. Fortunately CONFIG_DMI is quite difficult to turn off, and no distribution would. I'll follow up to this email with a proper patch.

Great, thanks.

Quoted 1 line

Apologies for the mistakes..

Heh, no problem.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors