Skip to contentSkip to conversation

wireless-regdb: fix Makefile to prevent unintended rebuilds

PATCH New Pavel Roskin 1 participant 1 message Jan 14, 2009 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 wireless-regdb: fix Makefile to prevent unintended rebuilds

Rules depending on key.priv.pem should only be available if that file is already present. They should not trigger automatic generation of key.priv.pem.

"make clean" should not remove files that can only be generated by the maintainer. Use "make maintainer-clean" for that.

"make clean" should remove *.pyc files.

---
This revision of the patch contains a minor simplification. Unlike the first version, it will be sent to the right address (hopefully).

 Makefile |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
Makefile +6 -1
index 1d8ff2a..85d50bd 100644
@@ -1,15 +1,20 @@
-.PHONY: all clean
+.PHONY: all clean maintainer-clean
 
 all: regulatory.bin key.pub.pem
 
 clean:
+	rm -f *.pyc
+
+maintainer-clean: clean
 	rm -f regulatory.bin key.pub.pem
 
+ifneq ($(wildcard key.priv.pem),)
 regulatory.bin: db.txt key.priv.pem
 	./db2bin.py regulatory.bin db.txt key.priv.pem
 
 key.pub.pem: key.priv.pem
 	openssl rsa -in key.priv.pem -out key.pub.pem -pubout -outform PEM
+endif
 
 key.priv.pem:
 	openssl genrsa -out key.priv.pem 2048
Signature · 2 lines
Regards,
Pavel Roskin