mfd: Mark WM835x USB_SLV_500MA bit as accessible
Subsystems (2)
PATCH 1/1 mfd: Mark WM835x USB_SLV_500MA bit as accessible
Signed-off-by Mark Brown <[email protected]>
--- drivers/mfd/wm8350-regmap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/wm8350-regmap.c +1 -1
@@ -3188,7 +3188,7 @@ const struct wm8350_reg_access wm8350_reg_io_map[] = { { 0x7CFF, 0x0C00, 0x7FFF }, /* R1 - ID */ { 0x0000, 0x0000, 0x0000 }, /* R2 */ { 0xBE3B, 0xBE3B, 0x8000 }, /* R3 - System Control 1 */ - { 0xFCF7, 0xFCF7, 0xF800 }, /* R4 - System Control 2 */ + { 0xFEF7, 0xFEF7, 0xF800 }, /* R4 - System Control 2 */ { 0x80FF, 0x80FF, 0x8000 }, /* R5 - System Hibernate */ { 0xFB0E, 0xFB0E, 0x0000 }, /* R6 - Interface Control */ { 0x0000, 0x0000, 0x0000 }, /* R7 */
Signature · 1 line
1.5.6.5
Quoted 10 lines · On Wed, 14 Jan 2009 14:55:01 +0000 Mark Brown…
Signed-off-by Mark Brown <[email protected]>--- drivers/mfd/wm8350-regmap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/mfd/wm8350-regmap.c +0
-0
drivers/mfd/wm8350-regmap.c const struct wm8350_reg_access wm8350_reg_io_map[] = { · line 3194
Quoted 8 lines
drivers/mfd/wm8350-regmap.c +1
-1@@ -3188,7 +3188,7 @@ const struct wm8350_reg_access wm8350_reg_io_map[] = { { 0x7CFF, 0x0C00, 0x7FFF }, /* R1 - ID */ { 0x0000, 0x0000, 0x0000 }, /* R2 */ { 0xBE3B, 0xBE3B, 0x8000 }, /* R3 - System Control 1 */ - { 0xFCF7, 0xFCF7, 0xF800 }, /* R4 - System Control 2 */ + { 0xFEF7, 0xFEF7, 0xF800 }, /* R4 - System Control 2 */ { 0x80FF, 0x80FF, 0x8000 }, /* R5 - System Hibernate */ { 0xFB0E, 0xFB0E, 0x0000 }, /* R6 - Interface Control */ { 0x0000, 0x0000, 0x0000 }, /* R7 */
Why?
Quoted 6 lines · Andrew Morton
drivers/mfd/wm8350-regmap.c const struct wm8350_reg_access wm8350_reg_io_map[] = { · line 3191
Quoted 2 lines · Mark Brown
drivers/mfd/wm8350-regmap.c +1
-1- { 0xFCF7, 0xFCF7, 0xF800 }, /* R4 - System Control 2 */ + { 0xFEF7, 0xFEF7, 0xF800 }, /* R4 - System Control 2 */Why?
The code is out of sync with the silicon - this table provides the driver with a map of what access is provided in hardware, the fact that this was masked off is a bug in the driver.
Samuel Ortiz
AppliedQuoted 4 lines · Mark Brown
Signed-off-by Mark Brown <[email protected]>--- drivers/mfd/wm8350-regmap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
Quoted 16 lines
drivers/mfd/wm8350-regmap.c +1
-1@@ -3188,7 +3188,7 @@ const struct wm8350_reg_access wm8350_reg_io_map[] = { { 0x7CFF, 0x0C00, 0x7FFF }, /* R1 - ID */ { 0x0000, 0x0000, 0x0000 }, /* R2 */ { 0xBE3B, 0xBE3B, 0x8000 }, /* R3 - System Control 1 */ - { 0xFCF7, 0xFCF7, 0xF800 }, /* R4 - System Control 2 */ + { 0xFEF7, 0xFEF7, 0xF800 }, /* R4 - System Control 2 */ { 0x80FF, 0x80FF, 0x8000 }, /* R5 - System Hibernate */ { 0xFB0E, 0xFB0E, 0x0000 }, /* R6 - Interface Control */ { 0x0000, 0x0000, 0x0000 }, /* R7 */Signature · 1 line
1.5.6.5
Signature · 2 lines
Intel Open Source Technology Centre http://oss.intel.com/