Skip to contentSkip to conversation

Btrfs Snapshot Removal And General Project Status

DISCUSSION Tarkan Erimer 2 participants 3 messages Jan 14, 2009 – Jan 16, 2009

lore
Share & tools
lore
#0 lore raw

Hi Chris,

For the last few days, I was playing with btrfs. It looks really very promising and fantastic! :-)
Thanks for everybody who involved with this amazing file system project! ;-) Now, I play with snapshots. Creating snapshot is a breeze. Recovering from snapshots work very well without any problems as far as I tried. But; when I tried to remove the snapshot directories, I got an error message that says : "cannot remove directory `snap1': Directory not empty". But actually, it is empty. After that, I googled a bit and found at "http://btrfs.wiki.kernel.org/index.php/Project_ideas" at "Removal Snapshots" section, it states that it needs to be implement. But, it's unclear which state this feature is now.

It could be perfect to prepare a document that shows the current status (completed, blah-blah % completed etc.) of the features,general status of the project and maybe deadlines of feature implementions. Like : "next release will have blah-blah features" etc.

BTW, is there any temporary way to remove these snapshot directories before this "Remove Snapshot" feature implemented ? ;-)

Tarkan ERIMER

#1 lore raw
Quoted 2 lines · Tarkan Erimer

Hi Chris,

Sorry for the delay, I missed this one somehow.

Quoted 2 lines

For the last few days, I was playing with btrfs. It looks really very promising and fantastic! :-)

Glad to hear it worked.

Quoted 10 lines

Thanks for everybody who involved with this amazing file system project! ;-) Now, I play with snapshots. Creating snapshot is a breeze. Recovering from snapshots work very well without any problems as far as I tried. But; when I tried to remove the snapshot directories, I got an error message that says : "cannot remove directory `snap1': Directory not empty". But actually, it is empty. After that, I googled a bit and found at "http://btrfs.wiki.kernel.org/index.php/Project_ideas" at "Removal Snapshots" section, it states that it needs to be implement. But, it's unclear which state this feature is now.

That's right. You did rm -rf dir, which is actually the slowest possible way to remove the snapshot ;) A much more optimized version is possible, and already implemented as part of transaction commit.

But, the fast version is basically the same as unlinking a directory that may or may not be in use. We need to implement code to do that properly wrt the VFS.

Quoted 5 lines

It could be perfect to prepare a document that shows the current status (completed, blah-blah % completed etc.) of the features,general status of the project and maybe deadlines of feature implementions. Like :
"next release will have blah-blah features" etc.

A very good point, I'm in the process of documenting this better.

Quoted 4 lines

BTW, is there any temporary way to remove these snapshot directories before this "Remove Snapshot" feature implemented ? ;-)

Unfortunately not, sorry.

-chris

#2 lore raw
Quoted 1 line · Chris Mason

Sorry for the delay, I missed this one somehow.

Oh,it's really no problem. ;-) All we know that you're too busy nowadays, cause of btrfs' mainline inclusion. :-)

Quoted 5 lines

That's right. You did rm -rf dir, which is actually the slowest possible way to remove the snapshot ;) A much more optimized version is possible, and already implemented as part of transaction commit.

Thanks for pointing ;-)

Quoted 3 lines

A very good point, I'm in the process of documenting this better.

Good luck! :-)

Tarkan ERIMER