Skip to contentSkip to conversation

install man-pages as non-executables

PATCH Applied Andre Przywara 2 participants 2 messages Jan 19, 2009 – Jan 22, 2009 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 install man-pages as non-executables

make install-doc omits an explicit permission mask for the man-pages. This defaults to have the executable bits set. Adding "-m 644" (for rw-r--r--) fixes that.

---
 Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Makefile +2 -2
index 8cbdcda..fc7809d 100644
@@ -233,9 +233,9 @@ install-doc: $(DOCS)
 	$(INSTALL) -m 644 qemu-doc.html  qemu-tech.html "$(DESTDIR)$(docdir)"
 ifndef CONFIG_WIN32
 	mkdir -p "$(DESTDIR)$(mandir)/man1"
-	$(INSTALL) qemu.1 qemu-img.1 "$(DESTDIR)$(mandir)/man1"
+	$(INSTALL) -m 644 qemu.1 qemu-img.1 "$(DESTDIR)$(mandir)/man1"
 	mkdir -p "$(DESTDIR)$(mandir)/man8"
-	$(INSTALL) qemu-nbd.8 "$(DESTDIR)$(mandir)/man8"
+	$(INSTALL) -m 644 qemu-nbd.8 "$(DESTDIR)$(mandir)/man8"
 endif
 
 install: all $(if $(BUILD_DOCS),install-doc)
Signature · 1 line
1.5.2.2
#1 lore raw
Quoted 6 lines · Andre Przywara

make install-doc omits an explicit permission mask for the man-pages. This defaults to have the executable bits set. Adding "-m 644" (for rw-r--r--) fixes that.

Applied. Thanks.

Regards,

Anthony Liguori

Quoted 21 lines
---
 Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Makefile +2 -2
index 8cbdcda..fc7809d 100644
@@ -233,9 +233,9 @@ install-doc: $(DOCS)
 	$(INSTALL) -m 644 qemu-doc.html  qemu-tech.html "$(DESTDIR)$(docdir)"
 ifndef CONFIG_WIN32
 	mkdir -p "$(DESTDIR)$(mandir)/man1"
-	$(INSTALL) qemu.1 qemu-img.1 "$(DESTDIR)$(mandir)/man1"
+	$(INSTALL) -m 644 qemu.1 qemu-img.1 "$(DESTDIR)$(mandir)/man1"
 	mkdir -p "$(DESTDIR)$(mandir)/man8"
-	$(INSTALL) qemu-nbd.8 "$(DESTDIR)$(mandir)/man8"
+	$(INSTALL) -m 644 qemu-nbd.8 "$(DESTDIR)$(mandir)/man8"
 endif
 
 install: all $(if $(BUILD_DOCS),install-doc)