PCI PCIe portdrv: Fix allocation of interrupts (rev. 3)
PATCH 1/1 PCI PCIe portdrv: Fix allocation of interrupts (rev. 3)
Hi,
The patch below fixes the problem with MSI-X vectors allocation by the PCIe port driver. It applies on top of the series of PCIe port driver cleanups and bug fixes I've just sent.
Please review.
Thanks,
Rafael
---
Subject: PCI PCIe portdrv: Fix allocation of interrupts (rev. 3)
From: Rafael J. Wysocki <[email protected]>
If MSI-X interrupt mode is used by the PCI Express port driver, too many vectors are allocated and it is not ensured that the right vectors will be used for the right services. Namely, the PCI Express specification states that both PCI Express native PME and PCI Express hotplug will always use the same MSI or MSI-X message for signalling interrupts, which implies that the same vector will be used by both of them. Also, the VC service does not use interrupts at all. Moreover, is not clear which of the vectors allocated by pci_enable_msix() will be used for PME and hotplug and which of them will be used for AER if all of these services are configured.
For these reasons, rework the allocation of interrupts for PCI Express ports so that at most two vectors are allocated and ensure that the right vector will be used for the right purpose.
--- drivers/pci/pcie/portdrv.h | 2 drivers/pci/pcie/portdrv_core.c | 142 +++++++++++++++++++++++++++++----------- include/linux/pcieport_if.h | 12 ++- 3 files changed, 114 insertions(+), 42 deletions(-)
drivers/pci/pcie/portdrv_core.c +104 -38
@@ -31,6 +31,72 @@ static void release_pcie_device(struct d }/** +* pcie_port_enable_msix - try to set up MSI-X as interrupt mode for given port +* @dev: PCI Express port to handle +* @vectors: Array of interrupt vectors to populate +* @nvec: Number of interrupt vectors to allocate +* +* Return value: 0 on success, error code on failure +*/ +static int pcie_port_enable_msix (struct pci_dev *dev,int *vectors,int nvec) +{ +struct msix_entry msix_entries[PCIE_PORT_DEVICE_MAXINTERRUPTS ] = { + {0 , }, + }; +int status, pos, i; +u16 reg16; +u32 reg32; + +for (i =0 ; i < nvec; i++) + msix_entries[i].entry = i; + + status =pci_enable_msix (dev, msix_entries, nvec); +if (status) +return status; + +/* +* The code below follows the PCI Express Base Specification 2.0 clearly +* stating in Section 6.1.6 that "PME and Hot-Plug Event interrupts +* (when both are implemented) always share the same MSI or MSI-X +* vector, as indicated by the Interrupt Message Number field in the PCI +* Express Capabilities register", where according to Section 7.8.2 of +* the Specification "For MSI-X, the value in this field indicates which +* MSI-X Table entry is used to generate the interrupt message." +*/ + pos =pci_find_capability (dev,PCI_CAP_ID_EXP ); +pci_read_config_word (dev, pos +PCIE_CAPABILITIES_REG , ®16); + i = (reg16 >>9 ) &PCIE_PORT_MSI_VECTOR_MASK ; +if (i >= nvec) { + goto Error; + }else { + vectors[PCIE_PORT_SERVICE_PME_SHIFT ] = msix_entries[i].vector; + vectors[PCIE_PORT_SERVICE_HP_SHIFT ] = msix_entries[i].vector; + } + +/* +* The code below follows Section 7.10.10 of the PCI Express Base +* Specification 2.0 stating that bits 31-27 of the Root Error Status +* Register contain a value indicating which of the MSI/MSI-X vectors +* assigned to the port is going to be used for AER, where "For MSI-X, +* the value in this register indicates which MSI-X Table entry is used +* to generate the interrupt message." +*/ + pos =pci_find_ext_capability (dev,PCI_EXT_CAP_ID_ERR ); +pci_read_config_dword (dev, pos +PCI_ERR_ROOT_STATUS , ®32); + i = (reg32 >>27 ) &PCIE_PORT_MSI_VECTOR_MASK ; +if (i >= nvec) + goto Error; +else + vectors[PCIE_PORT_SERVICE_AER_SHIFT ] = msix_entries[i].vector; + +return 0 ; + + Error: +pci_disable_msix (dev); +return -EIO ; +} + +/** * assign_interrupt_mode - choose interrupt mode for PCI Express port services * (INTx, MSI-X, MSI) and set up vectors * @dev: PCI Express port to handle
@@ -42,49 +108,49 @@ static void release_pcie_device(struct dstatic int assign_interrupt_mode (struct pci_dev *dev,int *vectors,int mask) {struct pcie_port_data *port_data =pci_get_drvdata (dev); -int i, pos, nvec, status = -EINVAL ; -int interrupt_mode =PCIE_PORT_NO_IRQ ; +int nvec, irq, interrupt_mode =PCIE_PORT_NO_IRQ ; +int i; -/* Set INTx as default */ -for (i =0 , nvec =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) { -if (mask & (1 << i)) - nvec++; - vectors[i] = dev->irq; - } -if (dev->pin) - interrupt_mode = PCIE_PORT_INTx_MODE; +/* +* Determine the number of vectors to allocate. +* +* According to the PCI Express specification both PME and PCI Express +* hotplug always use the same interrupt vector, while AER can use +* a different one. +*/ + nvec =0 ; +if (mask & (PCIE_PORT_SERVICE_PME |PCIE_PORT_SERVICE_HP )) + nvec++; +if (mask &PCIE_PORT_SERVICE_AER ) + nvec++; +if (!nvec) +return PCIE_PORT_NO_IRQ ;/* Check MSI quirk */ if (port_data->port_type ==PCIE_RC_PORT && pcie_mch_quirk) -return interrupt_mode; + goto Fallback; + +/* For nvec > 1 use MSI-X if supported */ +if (nvec >1 && !pcie_port_enable_msix (dev, vectors, nvec)) { + interrupt_mode =PCIE_PORT_MSIX_MODE ; + goto Exit; + } + +/* We're not going to use MSI-X, so try MSI and fall back to INTx */ +if (!pci_enable_msi (dev)) + interrupt_mode =PCIE_PORT_MSI_MODE ; + + Fallback: +if (interrupt_mode ==PCIE_PORT_NO_IRQ && dev->pin) + interrupt_mode = PCIE_PORT_INTx_MODE; + + irq = interrupt_mode !=PCIE_PORT_NO_IRQ ? dev->irq :-1 ; +for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) + vectors[i] = irq; + + Exit: + vectors[PCIE_PORT_SERVICE_VC_SHIFT ] =-1 ; -/* Select MSI-X over MSI if supported */ - pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); -if (pos) { -struct msix_entry msix_entries[PCIE_PORT_DEVICE_MAXSERVICES ] = - {{0 ,0 }, {0 ,1 }, {0 ,2 }, {0 ,3 }}; - status =pci_enable_msix (dev, msix_entries, nvec); -if (!status) { -int j =0 ; - - interrupt_mode =PCIE_PORT_MSIX_MODE ; -for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) { -if (mask & (1 << i)) - vectors[i] = msix_entries[j++].vector; - } - } - } -if (status) { - pos =pci_find_capability (dev,PCI_CAP_ID_MSI ); -if (pos) { - status =pci_enable_msi (dev); -if (!status) { - interrupt_mode =PCIE_PORT_MSI_MODE ; -for (i =0 ;i <PCIE_PORT_DEVICE_MAXSERVICES ;i++) - vectors[i] = dev->irq; - } - } - }return interrupt_mode; }
include/linux/pcieport_if.h +8 -4
@@ -16,10 +16,14 @@#define PCIE_ANY_PORT 7/* Service Type */ -#define PCIE_PORT_SERVICE_PME 1/* Power Management Event */ -#define PCIE_PORT_SERVICE_AER 2/* Advanced Error Reporting */ -#define PCIE_PORT_SERVICE_HP 4/* Native Hotplug */ -#define PCIE_PORT_SERVICE_VC 8/* Virtual Channel */ +#define PCIE_PORT_SERVICE_PME_SHIFT 0/* Power Management Event */ +#define PCIE_PORT_SERVICE_PME (1 << PCIE_PORT_SERVICE_PME_SHIFT) +#define PCIE_PORT_SERVICE_AER_SHIFT 1/* Advanced Error Reporting */ +#define PCIE_PORT_SERVICE_AER (1 << PCIE_PORT_SERVICE_AER_SHIFT) +#define PCIE_PORT_SERVICE_HP_SHIFT 2/* Native Hotplug */ +#define PCIE_PORT_SERVICE_HP (1 << PCIE_PORT_SERVICE_HP_SHIFT) +#define PCIE_PORT_SERVICE_VC_SHIFT 3/* Virtual Channel */ +#define PCIE_PORT_SERVICE_VC (1 << PCIE_PORT_SERVICE_VC_SHIFT)/* Root/Upstream/Downstream Port's Interrupt Mode */ #define PCIE_PORT_NO_IRQ (-1)
drivers/pci/pcie/portdrv.h +2 -0
@@ -25,6 +25,8 @@#define PCIE_CAPABILITIES_REG 0x2#define PCIE_SLOT_CAPABILITIES_REG 0x14#define PCIE_PORT_DEVICE_MAXSERVICES 4 +#define PCIE_PORT_DEVICE_MAXINTERRUPTS 2 +#define PCIE_PORT_MSI_VECTOR_MASK 0x1f#define get_descriptor_id (type, service) (((type - 4) << 4) | service)
Quoted 8 lines · Rafael J. Wysocki
Hi,
The patch below fixes the problem with MSI-X vectors allocation by the PCIe port driver. It applies on top of the series of PCIe port driver cleanups and bug fixes I've just sent.
Please review.
The patch seems to still have the following assumptions.
- The number of MSI-X table entries is less than or equal to two.
- MSI-X table entries are mapped only to PME/HP and/or AER.
Thanks,
Kenji Kaneshige
Quoted 237 lines
Thanks,
Rafael---
Subject: PCI PCIe portdrv: Fix allocation of interrupts (rev. 3)
From: Rafael J. Wysocki <[email protected]>If MSI-X interrupt mode is used by the PCI Express port driver, too many vectors are allocated and it is not ensured that the right vectors will be used for the right services. Namely, the PCI Express specification states that both PCI Express native PME and PCI Express hotplug will always use the same MSI or MSI-X message for signalling interrupts, which implies that the same vector will be used by both of them. Also, the VC service does not use interrupts at all. Moreover, is not clear which of the vectors allocated by
pci_enable_msix()will be used for PME and hotplug and which of them will be used for AER if all of these services are configured.For these reasons, rework the allocation of interrupts for PCI Express ports so that at most two vectors are allocated and ensure that the right vector will be used for the right purpose.
Signed-off-by Rafael J. Wysocki <[email protected]>--- drivers/pci/pcie/portdrv.h | 2 drivers/pci/pcie/portdrv_core.c | 142 +++++++++++++++++++++++++++++----------- include/linux/pcieport_if.h | 12 ++- 3 files changed, 114 insertions(+), 42 deletions(-)Index:
linux-2.6/drivers/pci/pcie/portdrv_core.c
===================================================================drivers/pci/pcie/portdrv_core.c +104
-38@@ -31,6 +31,72 @@ static void release_pcie_device(struct d }/** +* pcie_port_enable_msix - try to set up MSI-X as interrupt mode for given port +* @dev: PCI Express port to handle +* @vectors: Array of interrupt vectors to populate +* @nvec: Number of interrupt vectors to allocate +* +* Return value: 0 on success, error code on failure +*/ +static int pcie_port_enable_msix (struct pci_dev *dev,int *vectors,int nvec) +{ +struct msix_entry msix_entries[PCIE_PORT_DEVICE_MAXINTERRUPTS ] = { + {0 , }, + }; +int status, pos, i; +u16 reg16; +u32 reg32; + +for (i =0 ; i < nvec; i++) + msix_entries[i].entry = i; + + status =pci_enable_msix (dev, msix_entries, nvec); +if (status) +return status; + +/* +* The code below follows the PCI Express Base Specification 2.0 clearly +* stating in Section 6.1.6 that "PME and Hot-Plug Event interrupts +* (when both are implemented) always share the same MSI or MSI-X +* vector, as indicated by the Interrupt Message Number field in the PCI +* Express Capabilities register", where according to Section 7.8.2 of +* the Specification "For MSI-X, the value in this field indicates which +* MSI-X Table entry is used to generate the interrupt message." +*/ + pos =pci_find_capability (dev,PCI_CAP_ID_EXP ); +pci_read_config_word (dev, pos +PCIE_CAPABILITIES_REG , ®16); + i = (reg16 >>9 ) &PCIE_PORT_MSI_VECTOR_MASK ; +if (i >= nvec) { + goto Error; + }else { + vectors[PCIE_PORT_SERVICE_PME_SHIFT ] = msix_entries[i].vector; + vectors[PCIE_PORT_SERVICE_HP_SHIFT ] = msix_entries[i].vector; + } + +/* +* The code below follows Section 7.10.10 of the PCI Express Base +* Specification 2.0 stating that bits 31-27 of the Root Error Status +* Register contain a value indicating which of the MSI/MSI-X vectors +* assigned to the port is going to be used for AER, where "For MSI-X, +* the value in this register indicates which MSI-X Table entry is used +* to generate the interrupt message." +*/ + pos =pci_find_ext_capability (dev,PCI_EXT_CAP_ID_ERR ); +pci_read_config_dword (dev, pos +PCI_ERR_ROOT_STATUS , ®32); + i = (reg32 >>27 ) &PCIE_PORT_MSI_VECTOR_MASK ; +if (i >= nvec) + goto Error; +else + vectors[PCIE_PORT_SERVICE_AER_SHIFT ] = msix_entries[i].vector; + +return 0 ; + + Error: +pci_disable_msix (dev); +return -EIO ; +} + +/** * assign_interrupt_mode - choose interrupt mode for PCI Express port services * (INTx, MSI-X, MSI) and set up vectors * @dev: PCI Express port to handle @@ -42,49 +108,49 @@ static void release_pcie_device(struct dstatic int assign_interrupt_mode (struct pci_dev *dev,int *vectors,int mask) {struct pcie_port_data *port_data =pci_get_drvdata (dev); -int i, pos, nvec, status = -EINVAL ; -int interrupt_mode =PCIE_PORT_NO_IRQ ; +int nvec, irq, interrupt_mode =PCIE_PORT_NO_IRQ ; +int i; -/* Set INTx as default */ -for (i =0 , nvec =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) { -if (mask & (1 << i)) - nvec++; - vectors[i] = dev->irq; - } -if (dev->pin) - interrupt_mode = PCIE_PORT_INTx_MODE; +/* +* Determine the number of vectors to allocate. +* +* According to the PCI Express specification both PME and PCI Express +* hotplug always use the same interrupt vector, while AER can use +* a different one. +*/ + nvec =0 ; +if (mask & (PCIE_PORT_SERVICE_PME |PCIE_PORT_SERVICE_HP )) + nvec++; +if (mask &PCIE_PORT_SERVICE_AER ) + nvec++; +if (!nvec) +return PCIE_PORT_NO_IRQ ;/* Check MSI quirk */ if (port_data->port_type ==PCIE_RC_PORT && pcie_mch_quirk) -return interrupt_mode; + goto Fallback; + +/* For nvec > 1 use MSI-X if supported */ +if (nvec >1 && !pcie_port_enable_msix (dev, vectors, nvec)) { + interrupt_mode =PCIE_PORT_MSIX_MODE ; + goto Exit; + } + +/* We're not going to use MSI-X, so try MSI and fall back to INTx */ +if (!pci_enable_msi (dev)) + interrupt_mode =PCIE_PORT_MSI_MODE ; + + Fallback: +if (interrupt_mode ==PCIE_PORT_NO_IRQ && dev->pin) + interrupt_mode = PCIE_PORT_INTx_MODE; + + irq = interrupt_mode !=PCIE_PORT_NO_IRQ ? dev->irq :-1 ; +for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) + vectors[i] = irq; + + Exit: + vectors[PCIE_PORT_SERVICE_VC_SHIFT ] =-1 ; -/* Select MSI-X over MSI if supported */ - pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); -if (pos) { -struct msix_entry msix_entries[PCIE_PORT_DEVICE_MAXSERVICES ] = - {{0 ,0 }, {0 ,1 }, {0 ,2 }, {0 ,3 }}; - status =pci_enable_msix (dev, msix_entries, nvec); -if (!status) { -int j =0 ; - - interrupt_mode =PCIE_PORT_MSIX_MODE ; -for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) { -if (mask & (1 << i)) - vectors[i] = msix_entries[j++].vector; - } - } - } -if (status) { - pos =pci_find_capability (dev,PCI_CAP_ID_MSI ); -if (pos) { - status =pci_enable_msi (dev); -if (!status) { - interrupt_mode =PCIE_PORT_MSI_MODE ; -for (i =0 ;i <PCIE_PORT_DEVICE_MAXSERVICES ;i++) - vectors[i] = dev->irq; - } - } - }return interrupt_mode; }Index:
linux-2.6/include/linux/pcieport_if.h
===================================================================include/linux/pcieport_if.h +8
-4@@ -16,10 +16,14 @@#define PCIE_ANY_PORT 7/* Service Type */ -#define PCIE_PORT_SERVICE_PME 1/* Power Management Event */ -#define PCIE_PORT_SERVICE_AER 2/* Advanced Error Reporting */ -#define PCIE_PORT_SERVICE_HP 4/* Native Hotplug */ -#define PCIE_PORT_SERVICE_VC 8/* Virtual Channel */ +#define PCIE_PORT_SERVICE_PME_SHIFT 0/* Power Management Event */ +#define PCIE_PORT_SERVICE_PME (1 << PCIE_PORT_SERVICE_PME_SHIFT) +#define PCIE_PORT_SERVICE_AER_SHIFT 1/* Advanced Error Reporting */ +#define PCIE_PORT_SERVICE_AER (1 << PCIE_PORT_SERVICE_AER_SHIFT) +#define PCIE_PORT_SERVICE_HP_SHIFT 2/* Native Hotplug */ +#define PCIE_PORT_SERVICE_HP (1 << PCIE_PORT_SERVICE_HP_SHIFT) +#define PCIE_PORT_SERVICE_VC_SHIFT 3/* Virtual Channel */ +#define PCIE_PORT_SERVICE_VC (1 << PCIE_PORT_SERVICE_VC_SHIFT)/* Root/Upstream/Downstream Port's Interrupt Mode */ #define PCIE_PORT_NO_IRQ (-1)Index:
linux-2.6/drivers/pci/pcie/portdrv.h
===================================================================drivers/pci/pcie/portdrv.h +2
-1@@ -25,6 +25,8 @@#define PCIE_CAPABILITIES_REG 0x2#define PCIE_SLOT_CAPABILITIES_REG 0x14#define PCIE_PORT_DEVICE_MAXSERVICES 4 +#define PCIE_PORT_DEVICE_MAXINTERRUPTS 2 +#define PCIE_PORT_MSI_VECTOR_MASK 0x1f#define get_descriptor_id (type, service) (((type - 4) << 4) | service) --To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 7 lines · Kenji Kaneshige
Quoted 6 lines · Rafael J. Wysocki
Hi,
The patch below fixes the problem with MSI-X vectors allocation by the PCIe port driver. It applies on top of the series of PCIe port driver cleanups and bug fixes I've just sent.
Quoted 7 lines
Quoted 2 lines
Please review.
The patch seems to still have the following assumptions.
- The number of MSI-X table entries is less than or equal to two.
- MSI-X table entries are mapped only to PME/HP and/or AER.
It is not true.
If any of PME/HP and AER requires entry other than first two ([0],[1]), this code will give up MSI-X and fall back to MSI (or INTx).
In other words, the portdrv will use MSI-X only if entries for PME/PM and AER is in the first two entries of the MSI-X table.
Thanks,
H.Seto
Quoted 245 lines
Quoted 232 lines
Thanks,
Rafael---
Subject: PCI PCIe portdrv: Fix allocation of interrupts (rev. 3)
From: Rafael J. Wysocki <[email protected]>If MSI-X interrupt mode is used by the PCI Express port driver, too many vectors are allocated and it is not ensured that the right vectors will be used for the right services. Namely, the PCI Express specification states that both PCI Express native PME and PCI Express hotplug will always use the same MSI or MSI-X message for signalling interrupts, which implies that the same vector will be used by both of them. Also, the VC service does not use interrupts at all. Moreover, is not clear which of the vectors allocated by
pci_enable_msix()will be used for PME and hotplug and which of them will be used for AER if all of these services are configured.For these reasons, rework the allocation of interrupts for PCI Express ports so that at most two vectors are allocated and ensure that the right vector will be used for the right purpose.
Signed-off-by Rafael J. Wysocki <[email protected]>--- drivers/pci/pcie/portdrv.h | 2 drivers/pci/pcie/portdrv_core.c | 142 +++++++++++++++++++++++++++++----------- include/linux/pcieport_if.h | 12 ++- 3 files changed, 114 insertions(+), 42 deletions(-)Index:
linux-2.6/drivers/pci/pcie/portdrv_core.c
===================================================================drivers/pci/pcie/portdrv_core.c +104
-38@@ -31,6 +31,72 @@ static void release_pcie_device(struct d }/** +* pcie_port_enable_msix - try to set up MSI-X as interrupt mode for given port +* @dev: PCI Express port to handle +* @vectors: Array of interrupt vectors to populate +* @nvec: Number of interrupt vectors to allocate +* +* Return value: 0 on success, error code on failure +*/ +static int pcie_port_enable_msix (struct pci_dev *dev,int *vectors,int nvec) +{ +struct msix_entry msix_entries[PCIE_PORT_DEVICE_MAXINTERRUPTS ] = { + {0 , }, + }; +int status, pos, i; +u16 reg16; +u32 reg32; + +for (i =0 ; i < nvec; i++) + msix_entries[i].entry = i; + + status =pci_enable_msix (dev, msix_entries, nvec); +if (status) +return status; + +/* +* The code below follows the PCI Express Base Specification 2.0 clearly +* stating in Section 6.1.6 that "PME and Hot-Plug Event interrupts +* (when both are implemented) always share the same MSI or MSI-X +* vector, as indicated by the Interrupt Message Number field in the PCI +* Express Capabilities register", where according to Section 7.8.2 of +* the Specification "For MSI-X, the value in this field indicates which +* MSI-X Table entry is used to generate the interrupt message." +*/ + pos =pci_find_capability (dev,PCI_CAP_ID_EXP ); +pci_read_config_word (dev, pos +PCIE_CAPABILITIES_REG , ®16); + i = (reg16 >>9 ) &PCIE_PORT_MSI_VECTOR_MASK ; +if (i >= nvec) { + goto Error; + }else { + vectors[PCIE_PORT_SERVICE_PME_SHIFT ] = msix_entries[i].vector; + vectors[PCIE_PORT_SERVICE_HP_SHIFT ] = msix_entries[i].vector; + } + +/* +* The code below follows Section 7.10.10 of the PCI Express Base +* Specification 2.0 stating that bits 31-27 of the Root Error Status +* Register contain a value indicating which of the MSI/MSI-X vectors +* assigned to the port is going to be used for AER, where "For MSI-X, +* the value in this register indicates which MSI-X Table entry is used +* to generate the interrupt message." +*/ + pos =pci_find_ext_capability (dev,PCI_EXT_CAP_ID_ERR ); +pci_read_config_dword (dev, pos +PCI_ERR_ROOT_STATUS , ®32); + i = (reg32 >>27 ) &PCIE_PORT_MSI_VECTOR_MASK ; +if (i >= nvec) + goto Error; +else + vectors[PCIE_PORT_SERVICE_AER_SHIFT ] = msix_entries[i].vector; + +return 0 ; + + Error: +pci_disable_msix (dev); +return -EIO ; +} + +/** * assign_interrupt_mode - choose interrupt mode for PCI Express port services * (INTx, MSI-X, MSI) and set up vectors * @dev: PCI Express port to handle @@ -42,49 +108,49 @@ static void release_pcie_device(struct dstatic int assign_interrupt_mode (struct pci_dev *dev,int *vectors,int mask) {struct pcie_port_data *port_data =pci_get_drvdata (dev); -int i, pos, nvec, status = -EINVAL ; -int interrupt_mode =PCIE_PORT_NO_IRQ ; +int nvec, irq, interrupt_mode =PCIE_PORT_NO_IRQ ; +int i; -/* Set INTx as default */ -for (i =0 , nvec =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) { -if (mask & (1 << i)) - nvec++; - vectors[i] = dev->irq; - } -if (dev->pin) - interrupt_mode = PCIE_PORT_INTx_MODE; +/* +* Determine the number of vectors to allocate. +* +* According to the PCI Express specification both PME and PCI Express +* hotplug always use the same interrupt vector, while AER can use +* a different one. +*/ + nvec =0 ; +if (mask & (PCIE_PORT_SERVICE_PME |PCIE_PORT_SERVICE_HP )) + nvec++; +if (mask &PCIE_PORT_SERVICE_AER ) + nvec++; +if (!nvec) +return PCIE_PORT_NO_IRQ ;/* Check MSI quirk */ if (port_data->port_type ==PCIE_RC_PORT && pcie_mch_quirk) -return interrupt_mode; + goto Fallback; + +/* For nvec > 1 use MSI-X if supported */ +if (nvec >1 && !pcie_port_enable_msix (dev, vectors, nvec)) { + interrupt_mode =PCIE_PORT_MSIX_MODE ; + goto Exit; + } + +/* We're not going to use MSI-X, so try MSI and fall back to INTx */ +if (!pci_enable_msi (dev)) + interrupt_mode =PCIE_PORT_MSI_MODE ; + + Fallback: +if (interrupt_mode ==PCIE_PORT_NO_IRQ && dev->pin) + interrupt_mode = PCIE_PORT_INTx_MODE; + + irq = interrupt_mode !=PCIE_PORT_NO_IRQ ? dev->irq :-1 ; +for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) + vectors[i] = irq; + + Exit: + vectors[PCIE_PORT_SERVICE_VC_SHIFT ] =-1 ; -/* Select MSI-X over MSI if supported */ - pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); -if (pos) { -struct msix_entry msix_entries[PCIE_PORT_DEVICE_MAXSERVICES ] = - {{0 ,0 }, {0 ,1 }, {0 ,2 }, {0 ,3 }}; - status =pci_enable_msix (dev, msix_entries, nvec); -if (!status) { -int j =0 ; - - interrupt_mode =PCIE_PORT_MSIX_MODE ; -for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) { -if (mask & (1 << i)) - vectors[i] = msix_entries[j++].vector; - } - } - } -if (status) { - pos =pci_find_capability (dev,PCI_CAP_ID_MSI ); -if (pos) { - status =pci_enable_msi (dev); -if (!status) { - interrupt_mode =PCIE_PORT_MSI_MODE ; -for (i =0 ;i <PCIE_PORT_DEVICE_MAXSERVICES ;i++) - vectors[i] = dev->irq; - } - } - }return interrupt_mode; }Index:
linux-2.6/include/linux/pcieport_if.h
===================================================================include/linux/pcieport_if.h +8
-4@@ -16,10 +16,14 @@#define PCIE_ANY_PORT 7/* Service Type */ -#define PCIE_PORT_SERVICE_PME 1/* Power Management Event */ -#define PCIE_PORT_SERVICE_AER 2/* Advanced Error Reporting */ -#define PCIE_PORT_SERVICE_HP 4/* Native Hotplug */ -#define PCIE_PORT_SERVICE_VC 8/* Virtual Channel */ +#define PCIE_PORT_SERVICE_PME_SHIFT 0/* Power Management Event */ +#define PCIE_PORT_SERVICE_PME (1 << PCIE_PORT_SERVICE_PME_SHIFT) +#define PCIE_PORT_SERVICE_AER_SHIFT 1/* Advanced Error Reporting */ +#define PCIE_PORT_SERVICE_AER (1 << PCIE_PORT_SERVICE_AER_SHIFT) +#define PCIE_PORT_SERVICE_HP_SHIFT 2/* Native Hotplug */ +#define PCIE_PORT_SERVICE_HP (1 << PCIE_PORT_SERVICE_HP_SHIFT) +#define PCIE_PORT_SERVICE_VC_SHIFT 3/* Virtual Channel */ +#define PCIE_PORT_SERVICE_VC (1 << PCIE_PORT_SERVICE_VC_SHIFT)/* Root/Upstream/Downstream Port's Interrupt Mode */ #define PCIE_PORT_NO_IRQ (-1)Index:
linux-2.6/drivers/pci/pcie/portdrv.h
===================================================================drivers/pci/pcie/portdrv.h +2
-1@@ -25,6 +25,8 @@#define PCIE_CAPABILITIES_REG 0x2#define PCIE_SLOT_CAPABILITIES_REG 0x14#define PCIE_PORT_DEVICE_MAXSERVICES 4 +#define PCIE_PORT_DEVICE_MAXINTERRUPTS 2 +#define PCIE_PORT_MSI_VECTOR_MASK 0x1f#define get_descriptor_id (type, service) (((type - 4) << 4) | service) --Quoted 5 lines
To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 8 lines · Hidetoshi Seto
Quoted 7 lines · Kenji Kaneshige
Quoted 6 lines · Rafael J. Wysocki
Hi,
The patch below fixes the problem with MSI-X vectors allocation by the PCIe port driver. It applies on top of the series of PCIe port driver cleanups and bug fixes I've just sent.
Quoted 9 lines
Quoted 6 lines
Quoted 2 lines
Please review.
The patch seems to still have the following assumptions.
- The number of MSI-X table entries is less than or equal to two.
- MSI-X table entries are mapped only to PME/HP and/or AER.It is not true.
Maybe I should have said:
The patch will not work if any of PME/HP or AER requires entry other than first two.
Quoted 3 lines
If any of PME/HP and AER requires entry other than first two ([0],[1]), this code will give up MSI-X and fall back to MSI (or INTx).
Yes. My opinion is MSI-X should work even if PME/HP or AER requires entry other than first two.
Quoted 3 lines
In other words, the portdrv will use MSI-X only if entries for PME/PM and AER is in the first two entries of the MSI-X table.
This is exactly my worry, and it's why I want to eliminate the assumptions above.
Thanks,
Kenji Kaneshige
Quoted 250 lines
Thanks,
H.SetoQuoted 244 lines
Quoted 232 lines
Thanks,
Rafael---
Subject: PCI PCIe portdrv: Fix allocation of interrupts (rev. 3)
From: Rafael J. Wysocki <[email protected]>If MSI-X interrupt mode is used by the PCI Express port driver, too many vectors are allocated and it is not ensured that the right vectors will be used for the right services. Namely, the PCI Express specification states that both PCI Express native PME and PCI Express hotplug will always use the same MSI or MSI-X message for signalling interrupts, which implies that the same vector will be used by both of them. Also, the VC service does not use interrupts at all. Moreover, is not clear which of the vectors allocated by
pci_enable_msix()will be used for PME and hotplug and which of them will be used for AER if all of these services are configured.For these reasons, rework the allocation of interrupts for PCI Express ports so that at most two vectors are allocated and ensure that the right vector will be used for the right purpose.
Signed-off-by Rafael J. Wysocki <[email protected]>--- drivers/pci/pcie/portdrv.h | 2 drivers/pci/pcie/portdrv_core.c | 142 +++++++++++++++++++++++++++++----------- include/linux/pcieport_if.h | 12 ++- 3 files changed, 114 insertions(+), 42 deletions(-)Index:
linux-2.6/drivers/pci/pcie/portdrv_core.c
===================================================================drivers/pci/pcie/portdrv_core.c +104
-38@@ -31,6 +31,72 @@ static void release_pcie_device(struct d }/** +* pcie_port_enable_msix - try to set up MSI-X as interrupt mode for given port +* @dev: PCI Express port to handle +* @vectors: Array of interrupt vectors to populate +* @nvec: Number of interrupt vectors to allocate +* +* Return value: 0 on success, error code on failure +*/ +static int pcie_port_enable_msix (struct pci_dev *dev,int *vectors,int nvec) +{ +struct msix_entry msix_entries[PCIE_PORT_DEVICE_MAXINTERRUPTS ] = { + {0 , }, + }; +int status, pos, i; +u16 reg16; +u32 reg32; + +for (i =0 ; i < nvec; i++) + msix_entries[i].entry = i; + + status =pci_enable_msix (dev, msix_entries, nvec); +if (status) +return status; + +/* +* The code below follows the PCI Express Base Specification 2.0 clearly +* stating in Section 6.1.6 that "PME and Hot-Plug Event interrupts +* (when both are implemented) always share the same MSI or MSI-X +* vector, as indicated by the Interrupt Message Number field in the PCI +* Express Capabilities register", where according to Section 7.8.2 of +* the Specification "For MSI-X, the value in this field indicates which +* MSI-X Table entry is used to generate the interrupt message." +*/ + pos =pci_find_capability (dev,PCI_CAP_ID_EXP ); +pci_read_config_word (dev, pos +PCIE_CAPABILITIES_REG , ®16); + i = (reg16 >>9 ) &PCIE_PORT_MSI_VECTOR_MASK ; +if (i >= nvec) { + goto Error; + }else { + vectors[PCIE_PORT_SERVICE_PME_SHIFT ] = msix_entries[i].vector; + vectors[PCIE_PORT_SERVICE_HP_SHIFT ] = msix_entries[i].vector; + } + +/* +* The code below follows Section 7.10.10 of the PCI Express Base +* Specification 2.0 stating that bits 31-27 of the Root Error Status +* Register contain a value indicating which of the MSI/MSI-X vectors +* assigned to the port is going to be used for AER, where "For MSI-X, +* the value in this register indicates which MSI-X Table entry is used +* to generate the interrupt message." +*/ + pos =pci_find_ext_capability (dev,PCI_EXT_CAP_ID_ERR ); +pci_read_config_dword (dev, pos +PCI_ERR_ROOT_STATUS , ®32); + i = (reg32 >>27 ) &PCIE_PORT_MSI_VECTOR_MASK ; +if (i >= nvec) + goto Error; +else + vectors[PCIE_PORT_SERVICE_AER_SHIFT ] = msix_entries[i].vector; + +return 0 ; + + Error: +pci_disable_msix (dev); +return -EIO ; +} + +/** * assign_interrupt_mode - choose interrupt mode for PCI Express port services * (INTx, MSI-X, MSI) and set up vectors * @dev: PCI Express port to handle @@ -42,49 +108,49 @@ static void release_pcie_device(struct dstatic int assign_interrupt_mode (struct pci_dev *dev,int *vectors,int mask) {struct pcie_port_data *port_data =pci_get_drvdata (dev); -int i, pos, nvec, status = -EINVAL ; -int interrupt_mode =PCIE_PORT_NO_IRQ ; +int nvec, irq, interrupt_mode =PCIE_PORT_NO_IRQ ; +int i; -/* Set INTx as default */ -for (i =0 , nvec =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) { -if (mask & (1 << i)) - nvec++; - vectors[i] = dev->irq; - } -if (dev->pin) - interrupt_mode = PCIE_PORT_INTx_MODE; +/* +* Determine the number of vectors to allocate. +* +* According to the PCI Express specification both PME and PCI Express +* hotplug always use the same interrupt vector, while AER can use +* a different one. +*/ + nvec =0 ; +if (mask & (PCIE_PORT_SERVICE_PME |PCIE_PORT_SERVICE_HP )) + nvec++; +if (mask &PCIE_PORT_SERVICE_AER ) + nvec++; +if (!nvec) +return PCIE_PORT_NO_IRQ ;/* Check MSI quirk */ if (port_data->port_type ==PCIE_RC_PORT && pcie_mch_quirk) -return interrupt_mode; + goto Fallback; + +/* For nvec > 1 use MSI-X if supported */ +if (nvec >1 && !pcie_port_enable_msix (dev, vectors, nvec)) { + interrupt_mode =PCIE_PORT_MSIX_MODE ; + goto Exit; + } + +/* We're not going to use MSI-X, so try MSI and fall back to INTx */ +if (!pci_enable_msi (dev)) + interrupt_mode =PCIE_PORT_MSI_MODE ; + + Fallback: +if (interrupt_mode ==PCIE_PORT_NO_IRQ && dev->pin) + interrupt_mode = PCIE_PORT_INTx_MODE; + + irq = interrupt_mode !=PCIE_PORT_NO_IRQ ? dev->irq :-1 ; +for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) + vectors[i] = irq; + + Exit: + vectors[PCIE_PORT_SERVICE_VC_SHIFT ] =-1 ; -/* Select MSI-X over MSI if supported */ - pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); -if (pos) { -struct msix_entry msix_entries[PCIE_PORT_DEVICE_MAXSERVICES ] = - {{0 ,0 }, {0 ,1 }, {0 ,2 }, {0 ,3 }}; - status =pci_enable_msix (dev, msix_entries, nvec); -if (!status) { -int j =0 ; - - interrupt_mode =PCIE_PORT_MSIX_MODE ; -for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) { -if (mask & (1 << i)) - vectors[i] = msix_entries[j++].vector; - } - } - } -if (status) { - pos =pci_find_capability (dev,PCI_CAP_ID_MSI ); -if (pos) { - status =pci_enable_msi (dev); -if (!status) { - interrupt_mode =PCIE_PORT_MSI_MODE ; -for (i =0 ;i <PCIE_PORT_DEVICE_MAXSERVICES ;i++) - vectors[i] = dev->irq; - } - } - }return interrupt_mode; }Index:
linux-2.6/include/linux/pcieport_if.h
===================================================================include/linux/pcieport_if.h +8
-4@@ -16,10 +16,14 @@#define PCIE_ANY_PORT 7/* Service Type */ -#define PCIE_PORT_SERVICE_PME 1/* Power Management Event */ -#define PCIE_PORT_SERVICE_AER 2/* Advanced Error Reporting */ -#define PCIE_PORT_SERVICE_HP 4/* Native Hotplug */ -#define PCIE_PORT_SERVICE_VC 8/* Virtual Channel */ +#define PCIE_PORT_SERVICE_PME_SHIFT 0/* Power Management Event */ +#define PCIE_PORT_SERVICE_PME (1 << PCIE_PORT_SERVICE_PME_SHIFT) +#define PCIE_PORT_SERVICE_AER_SHIFT 1/* Advanced Error Reporting */ +#define PCIE_PORT_SERVICE_AER (1 << PCIE_PORT_SERVICE_AER_SHIFT) +#define PCIE_PORT_SERVICE_HP_SHIFT 2/* Native Hotplug */ +#define PCIE_PORT_SERVICE_HP (1 << PCIE_PORT_SERVICE_HP_SHIFT) +#define PCIE_PORT_SERVICE_VC_SHIFT 3/* Virtual Channel */ +#define PCIE_PORT_SERVICE_VC (1 << PCIE_PORT_SERVICE_VC_SHIFT)/* Root/Upstream/Downstream Port's Interrupt Mode */ #define PCIE_PORT_NO_IRQ (-1)Index:
linux-2.6/drivers/pci/pcie/portdrv.h
===================================================================drivers/pci/pcie/portdrv.h +2
-1@@ -25,6 +25,8 @@#define PCIE_CAPABILITIES_REG 0x2#define PCIE_SLOT_CAPABILITIES_REG 0x14#define PCIE_PORT_DEVICE_MAXSERVICES 4 +#define PCIE_PORT_DEVICE_MAXINTERRUPTS 2 +#define PCIE_PORT_MSI_VECTOR_MASK 0x1f#define get_descriptor_id (type, service) (((type - 4) << 4) | service) --Quoted 5 lines
To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 31 lines · Kenji Kaneshige
Quoted 8 lines · Hidetoshi Seto
Quoted 7 lines · Kenji Kaneshige
Quoted 6 lines · Rafael J. Wysocki
Hi,
The patch below fixes the problem with MSI-X vectors allocation by the PCIe port driver. It applies on top of the series of PCIe port driver cleanups and bug fixes I've just sent.
Quoted 9 lines
Quoted 6 lines
Quoted 2 lines
Please review.
The patch seems to still have the following assumptions.
- The number of MSI-X table entries is less than or equal to two.
- MSI-X table entries are mapped only to PME/HP and/or AER.It is not true.
Maybe I should have said:
The patch will not work if any of PME/HP or AER requires entry other than first two.
Quoted 3 lines
If any of PME/HP and AER requires entry other than first two ([0],[1]), this code will give up MSI-X and fall back to MSI (or INTx).
Yes. My opinion is MSI-X should work even if PME/HP or AER requires entry other than first two.
Quoted 6 lines
Quoted 3 lines
In other words, the portdrv will use MSI-X only if entries for PME/PM and AER is in the first two entries of the MSI-X table.
This is exactly my worry, and it's why I want to eliminate the assumptions above.
OK, appended is yet another version of the patch.
If MSI-X are supported, it allocates as many vectors as there are entries in the port's MSI-X table, but no more than 32, and figures out which of them will be used for the port services.
Thanks,
Rafael
---
Subject: PCI PCIe portdrv: Fix allocation of interrupts (rev. 4)
From: Rafael J. Wysocki <[email protected]>
If MSI-X interrupt mode is used by the PCI Express port driver, too many vectors are allocated and it is not ensured that the right vectors will be used for the right services. Namely, the PCI Express specification states that both PCI Express native PME and PCI Express hotplug will always use the same MSI or MSI-X message for signalling interrupts, which implies that the same vector will be used by both of them. Also, the VC service does not use interrupts at all. Moreover, is not clear which of the vectors allocated by pci_enable_msix() in the current code will be used for PME and hotplug and which of them will be used for AER if all of these services are configured.
For these reasons, rework the allocation of interrupts for PCI Express ports so that if MSI-X are enabled, the right vectors will be used for the right purposes.
--- drivers/pci/msi.c | 24 +++++- drivers/pci/pcie/portdrv.h | 1 drivers/pci/pcie/portdrv_core.c | 151 +++++++++++++++++++++++++++++----------- include/linux/pci.h | 5 + include/linux/pcieport_if.h | 12 ++- 5 files changed, 146 insertions(+), 47 deletions(-)
drivers/pci/pcie/portdrv_core.c +113 -38
@@ -31,6 +31,96 @@ static void release_pcie_device(struct d }/** +* pcie_port_enable_msix - try to set up MSI-X as interrupt mode for given port +* @dev: PCI Express port to handle +* @vectors: Array of interrupt vectors to populate +* +* Return value: 0 on success, error code on failure +*/ +static int pcie_port_enable_msix (struct pci_dev *dev,int *vectors) +{ +struct msix_entry *msix_entries; +int status, pos, nr_entries, i; +u16 reg16; +u32 reg32; + + nr_entries =pci_msix_table_size (dev); +if (!nr_entries) +return -EINVAL ; +/* +* According to the PCI Express Base Specification 2.0, the indices of +* the MSI-X table entires used by port services must not exceed 31 +*/ +if (nr_entries >32 ) + nr_entries =32 ; + + msix_entries =kzalloc (sizeof (struct msix_entry ) * nr_entries, +GFP_KERNEL ); +if (!msix_entries) +return -ENOMEM ; +for (i =0 ; i < nr_entries; i++) + msix_entries[i].entry = i; + +/* +* Allocate the MSI-X vectors. Initially, they are all masked and only +* request_irq() will unmask them. Since we're only going to request +* the ones that actually will be used, we don't need to worry about the +* other ones. +*/ + status =pci_enable_msix (dev, msix_entries, nr_entries); +if (status) + goto Exit; + +/* +* The code below follows the PCI Express Base Specification 2.0 clearly +* stating in Section 6.1.6 that "PME and Hot-Plug Event interrupts +* (when both are implemented) always share the same MSI or MSI-X +* vector, as indicated by the Interrupt Message Number field in the PCI +* Express Capabilities register", where according to Section 7.8.2 of +* the Specification "For MSI-X, the value in this field indicates which +* MSI-X Table entry is used to generate the interrupt message." +*/ + pos =pci_find_capability (dev,PCI_CAP_ID_EXP ); +pci_read_config_word (dev, pos +PCIE_CAPABILITIES_REG , ®16); + i = (reg16 >>9 ) &PCIE_PORT_MSI_VECTOR_MASK ; +if (i >= nr_entries) { + status = -EIO ; + goto Error; + }else { +int irq = msix_entries[i].vector; + + vectors[PCIE_PORT_SERVICE_PME_SHIFT ] = irq; + vectors[PCIE_PORT_SERVICE_HP_SHIFT ] = irq; + } + +/* +* The code below follows Section 7.10.10 of the PCI Express Base +* Specification 2.0 stating that bits 31-27 of the Root Error Status +* Register contain a value indicating which of the MSI/MSI-X vectors +* assigned to the port is going to be used for AER, where "For MSI-X, +* the value in this register indicates which MSI-X Table entry is used +* to generate the interrupt message." +*/ + pos =pci_find_ext_capability (dev,PCI_EXT_CAP_ID_ERR ); +pci_read_config_dword (dev, pos +PCI_ERR_ROOT_STATUS , ®32); + i = reg32 >>27 ; +if (i >= nr_entries) { + status = -EIO ; + goto Error; + }else { + vectors[PCIE_PORT_SERVICE_AER_SHIFT ] = msix_entries[i].vector; + } + + Exit: +kfree (msix_entries); +return status; + + Error: +pci_disable_msix (dev); + goto Exit; +} + +/** * assign_interrupt_mode - choose interrupt mode for PCI Express port services * (INTx, MSI-X, MSI) and set up vectors * @dev: PCI Express port to handle
@@ -42,49 +132,34 @@ static void release_pcie_device(struct dstatic int assign_interrupt_mode (struct pci_dev *dev,int *vectors,int mask) {struct pcie_port_data *port_data =pci_get_drvdata (dev); -int i, pos, nvec, status = -EINVAL ; -int interrupt_mode =PCIE_PORT_NO_IRQ ; +int irq, interrupt_mode =PCIE_PORT_NO_IRQ ; +int i; + +/* Check MSI quirk */ +if (port_data->port_type ==PCIE_RC_PORT && pcie_mch_quirk) + goto Fallback; -/* Set INTx as default */ -for (i =0 , nvec =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) { -if (mask & (1 << i)) - nvec++; - vectors[i] = dev->irq; +/* Try to use MSI-X if supported */ +if (!pcie_port_enable_msix (dev, vectors)) { + interrupt_mode =PCIE_PORT_MSIX_MODE ; + goto Exit; } -if (dev->pin) + +/* We're not going to use MSI-X, so try MSI and fall back to INTx */ +if (!pci_enable_msi (dev)) + interrupt_mode =PCIE_PORT_MSI_MODE ; + + Fallback: +if (interrupt_mode ==PCIE_PORT_NO_IRQ && dev->pin) interrupt_mode = PCIE_PORT_INTx_MODE; -/* Check MSI quirk */ -if (port_data->port_type ==PCIE_RC_PORT && pcie_mch_quirk) -return interrupt_mode; + irq = interrupt_mode !=PCIE_PORT_NO_IRQ ? dev->irq :-1 ; +for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) + vectors[i] = irq; + + Exit: + vectors[PCIE_PORT_SERVICE_VC_SHIFT ] =-1 ; -/* Select MSI-X over MSI if supported */ - pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); -if (pos) { -struct msix_entry msix_entries[PCIE_PORT_DEVICE_MAXSERVICES ] = - {{0 ,0 }, {0 ,1 }, {0 ,2 }, {0 ,3 }}; - status =pci_enable_msix (dev, msix_entries, nvec); -if (!status) { -int j =0 ; - - interrupt_mode =PCIE_PORT_MSIX_MODE ; -for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) { -if (mask & (1 << i)) - vectors[i] = msix_entries[j++].vector; - } - } - } -if (status) { - pos =pci_find_capability (dev,PCI_CAP_ID_MSI ); -if (pos) { - status =pci_enable_msi (dev); -if (!status) { - interrupt_mode =PCIE_PORT_MSI_MODE ; -for (i =0 ;i <PCIE_PORT_DEVICE_MAXSERVICES ;i++) - vectors[i] = dev->irq; - } - } - }return interrupt_mode; }
include/linux/pcieport_if.h +8 -4
@@ -16,10 +16,14 @@#define PCIE_ANY_PORT 7/* Service Type */ -#define PCIE_PORT_SERVICE_PME 1/* Power Management Event */ -#define PCIE_PORT_SERVICE_AER 2/* Advanced Error Reporting */ -#define PCIE_PORT_SERVICE_HP 4/* Native Hotplug */ -#define PCIE_PORT_SERVICE_VC 8/* Virtual Channel */ +#define PCIE_PORT_SERVICE_PME_SHIFT 0/* Power Management Event */ +#define PCIE_PORT_SERVICE_PME (1 << PCIE_PORT_SERVICE_PME_SHIFT) +#define PCIE_PORT_SERVICE_AER_SHIFT 1/* Advanced Error Reporting */ +#define PCIE_PORT_SERVICE_AER (1 << PCIE_PORT_SERVICE_AER_SHIFT) +#define PCIE_PORT_SERVICE_HP_SHIFT 2/* Native Hotplug */ +#define PCIE_PORT_SERVICE_HP (1 << PCIE_PORT_SERVICE_HP_SHIFT) +#define PCIE_PORT_SERVICE_VC_SHIFT 3/* Virtual Channel */ +#define PCIE_PORT_SERVICE_VC (1 << PCIE_PORT_SERVICE_VC_SHIFT)/* Root/Upstream/Downstream Port's Interrupt Mode */ #define PCIE_PORT_NO_IRQ (-1)
drivers/pci/pcie/portdrv.h +1 -0
@@ -25,6 +25,7 @@#define PCIE_CAPABILITIES_REG 0x2#define PCIE_SLOT_CAPABILITIES_REG 0x14#define PCIE_PORT_DEVICE_MAXSERVICES 4 +#define PCIE_PORT_MSI_VECTOR_MASK 0x1f#define get_descriptor_id (type, service) (((type - 4) << 4) | service)
drivers/pci/msi.c +19 -5
@@ -670,6 +670,23 @@ static int msi_free_irqs(struct pci_dev* }/** +* pci_msix_table_size - return the number of device's MSI-X table entries +* @dev: pointer to the pci_dev data structure of MSI-X device function +*/ +int pci_msix_table_size (struct pci_dev *dev) +{ +int pos; +u16 control; + + pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); +if (!pos) +return 0 ; + +pci_read_config_word (dev,msi_control_reg (pos), &control); +return multi_msix_capable (control); +} + +/** * pci_enable_msix - configure device's MSI-X capability structure * @dev: pointer to the pci_dev data structure of MSI-X device function * @entries: pointer to an array of MSI-X entries
@@ -686,9 +703,8 @@ static int msi_free_irqs(struct pci_dev***/ int pci_enable_msix (struct pci_dev * dev,struct msix_entry *entries,int nvec) { -int status, pos, nr_entries; +int status, nr_entries;int i, j; -u16 control;if (!entries)return -EINVAL ;
@@ -697,9 +713,7 @@ int pci_enable_msix(struct pci_dev* dev,if (status)return status; - pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); -pci_read_config_word (dev,msi_control_reg (pos), &control); - nr_entries =multi_msix_capable (control); + nr_entries =pci_msix_table_size (dev);if (nvec > nr_entries)return -EINVAL ;
include/linux/pci.h +5 -0
@@ -799,6 +799,10 @@ static inline void pci_msi_shutdown(strustatic inline void pci_disable_msi (struct pci_dev *dev) { } +static inline int pci_msix_table_size (struct pci_dev *dev) +{ +return 0 ; +}static inline int pci_enable_msix (struct pci_dev *dev,struct msix_entry *entries,int nvec) {
@@ -823,6 +827,7 @@ static inline int pci_msi_enabled(void)extern int pci_enable_msi (struct pci_dev *dev);extern void pci_msi_shutdown (struct pci_dev *dev);extern void pci_disable_msi (struct pci_dev *dev); +extern int pci_msix_table_size (struct pci_dev *dev);extern int pci_enable_msix (struct pci_dev *dev,struct msix_entry *entries,int nvec);extern void pci_msix_shutdown (struct pci_dev *dev);
PATCH 1/1 PCI PCIe portdrv: Fix allocation ...)
Quoted 36 lines · Rafael J. Wysocki
Quoted 35 lines · Kenji Kaneshige
Quoted 8 lines · Hidetoshi Seto
Quoted 7 lines · Kenji Kaneshige
Quoted 6 lines · Rafael J. Wysocki
Hi,
The patch below fixes the problem with MSI-X vectors allocation by the PCIe port driver. It applies on top of the series of PCIe port driver cleanups and bug fixes I've just sent.
Quoted 9 lines
Quoted 6 lines
Quoted 2 lines
Please review.
The patch seems to still have the following assumptions.
- The number of MSI-X table entries is less than or equal to two.
- MSI-X table entries are mapped only to PME/HP and/or AER.It is not true.
Maybe I should have said:
The patch will not work if any of PME/HP or AER requires entry other than first two.
Quoted 3 lines
If any of PME/HP and AER requires entry other than first two ([0],[1]), this code will give up MSI-X and fall back to MSI (or INTx).
Yes. My opinion is MSI-X should work even if PME/HP or AER requires entry other than first two.
Quoted 3 lines
In other words, the portdrv will use MSI-X only if entries for PME/PM and AER is in the first two entries of the MSI-X table.
Quoted 8 lines
Quoted 2 lines
This is exactly my worry, and it's why I want to eliminate the assumptions above.
OK, appended is yet another version of the patch.
If MSI-X are supported, it allocates as many vectors as there are entries in the port's MSI-X table, but no more than 32, and figures out which of them will be used for the port services.
The patch didn't check which services are available during the MSI-X set up which was wrong.
Also, in the meantime, i thought it might be a good idea to free the interrupt routing table entries that aren't going to be used after all.
The patch below adds this to the previous version and checks for the availability of port services in the MSI-X setup resume. I hope it will be acceptable to everyone.
Thanks,
Rafael
---
Subject: PCI PCIe portdrv: Fix allocation of interrupts (rev. 5)
From: Rafael J. Wysocki <[email protected]>
If MSI-X interrupt mode is used by the PCI Express port driver, too many vectors are allocated and it is not ensured that the right vectors will be used for the right services. Namely, the PCI Express specification states that both PCI Express native PME and PCI Express hotplug will always use the same MSI or MSI-X message for signalling interrupts, which implies that the same vector will be used by both of them. Also, the VC service does not use interrupts at all. Moreover, is not clear which of the vectors allocated by pci_enable_msix() in the current code will be used for PME and hotplug and which of them will be used for AER if all of these services are configured.
For these reasons, rework the allocation of interrupts for PCI Express ports so that if MSI-X are enabled, the right vectors will be used for the right purposes.
--- drivers/pci/msi.c | 24 +++- drivers/pci/pcie/portdrv.h | 6 + drivers/pci/pcie/portdrv_core.c | 195 ++++++++++++++++++++++++++++++++-------- include/linux/pci.h | 5 + include/linux/pcieport_if.h | 12 +- 5 files changed, 194 insertions(+), 48 deletions(-)
drivers/pci/pcie/portdrv_core.c +156 -39
@@ -31,6 +31,141 @@ static void release_pcie_device(struct d }/** +* pcie_port_msix_add_entry - add entry to given array of MSI-X entries +* @entries: Array of MSI-X entries +* @new_entry: Index of the entry to add to the array +* @nr_entries: Number of entries aleady in the array +* +* Return value: Position of the added entry in the array +*/ +static int pcie_port_msix_add_entry ( +struct msix_entry *entries,int new_entry,int nr_entries) +{ +int j; + +for (j =0 ; j < nr_entries; j++) +if (entries[j].entry == new_entry) +return j; + + entries[j].entry = new_entry; +return j; +} + +/** +* pcie_port_enable_msix - try to set up MSI-X as interrupt mode for given port +* @dev: PCI Express port to handle +* @vectors: Array of interrupt vectors to populate +* @mask: Bitmask of port capabilities returned by get_port_device_capability() +* +* Return value: 0 on success, error code on failure +*/ +static int pcie_port_enable_msix (struct pci_dev *dev,int *vectors,int mask) +{ +struct msix_entry *msix_entries; +int idx[PCIE_PORT_DEVICE_MAXSERVICES ]; +int nr_entries, status, pos, i, nvec; +u16 reg16; +u32 reg32; + + nr_entries =pci_msix_table_size (dev); +if (!nr_entries) +return -EINVAL ; +if (nr_entries >PCIE_PORT_MAX_MSIX_ENTRIES ) + nr_entries =PCIE_PORT_MAX_MSIX_ENTRIES ; + + msix_entries =kzalloc (sizeof (*msix_entries) * nr_entries,GFP_KERNEL ); +if (!msix_entries) +return -ENOMEM ; + +/* +* Allocate as many entries as the device wants temporarily, so that we +* can check which of them will be useful. +*/ +for (i =0 ; i < nr_entries; i++) + msix_entries[i].entry = i; + + status =pci_enable_msix (dev, msix_entries, nr_entries); +if (status) + goto Exit; + +for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) + idx[i] =-1 ; + status = -EIO ; + nvec =0 ; + +if (mask & (PCIE_PORT_SERVICE_PME |PCIE_PORT_SERVICE_HP )) { +int entry; + +/* +* The code below follows the PCI Express Base Specification 2.0 +* stating in Section 6.1.6 that "PME and Hot-Plug Event +* interrupts (when both are implemented) always share the same +* MSI or MSI-X vector, as indicated by the Interrupt Message +* Number field in the PCI Express Capabilities register", where +* according to Section 7.8.2 of the specification "For MSI-X, +* the value in this field indicates which MSI-X Table entry is +* used to generate the interrupt message." +*/ + pos =pci_find_capability (dev,PCI_CAP_ID_EXP ); +pci_read_config_word (dev, pos +PCIE_CAPABILITIES_REG , ®16); + entry = (reg16 >>9 ) &PCIE_PORT_MSI_VECTOR_MASK ; +if (entry >= nr_entries) + goto Error; + + i =pcie_port_msix_add_entry (msix_entries, entry, nvec); +if (i == nvec) + nvec++; + + idx[PCIE_PORT_SERVICE_PME_SHIFT ] = i; + idx[PCIE_PORT_SERVICE_HP_SHIFT ] = i; + } + +if (mask &PCIE_PORT_SERVICE_AER ) { +int entry; + +/* +* The code below follows Section 7.10.10 of the PCI Express +* Base Specification 2.0 stating that bits 31-27 of the Root +* Error Status Register contain a value indicating which of the +* MSI/MSI-X vectors assigned to the port is going to be used +* for AER, where "For MSI-X, the value in this register +* indicates which MSI-X Table entry is used to generate the +* interrupt message." +*/ + pos =pci_find_ext_capability (dev,PCI_EXT_CAP_ID_ERR ); +pci_read_config_dword (dev, pos +PCI_ERR_ROOT_STATUS , ®32); + entry = reg32 >>27 ; +if (entry >= nr_entries) + goto Error; + + i =pcie_port_msix_add_entry (msix_entries, entry, nvec); +if (i == nvec) + nvec++; + + idx[PCIE_PORT_SERVICE_AER_SHIFT ] = i; + } + +/* Drop the temporary MSI-X setup */ +pci_disable_msix (dev); + +/* Now allocate the MSI-X vectors for real */ + status =pci_enable_msix (dev, msix_entries, nvec); +if (status) + goto Error; + +for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) + vectors[i] = idx[i] >=0 ? msix_entries[idx[i]].vector :-1 ; + + Exit: +kfree (msix_entries); +return status; + + Error: +pci_disable_msix (dev); + goto Exit; +} + +/** * assign_interrupt_mode - choose interrupt mode for PCI Express port services * (INTx, MSI-X, MSI) and set up vectors * @dev: PCI Express port to handle
@@ -42,49 +177,31 @@ static void release_pcie_device(struct dstatic int assign_interrupt_mode (struct pci_dev *dev,int *vectors,int mask) {struct pcie_port_data *port_data =pci_get_drvdata (dev); -int i, pos, nvec, status = -EINVAL ; -int interrupt_mode =PCIE_PORT_NO_IRQ ; - -/* Set INTx as default */ -for (i =0 , nvec =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) { -if (mask & (1 << i)) - nvec++; - vectors[i] = dev->irq; - } -if (dev->pin) - interrupt_mode = PCIE_PORT_INTx_MODE; +int irq, interrupt_mode =PCIE_PORT_NO_IRQ ; +int i;/* Check MSI quirk */ if (port_data->port_type ==PCIE_RC_PORT && pcie_mch_quirk) -return interrupt_mode; + goto Fallback; + +/* Try to use MSI-X if supported */ +if (!pcie_port_enable_msix (dev, vectors, mask)) +return PCIE_PORT_MSIX_MODE ; + +/* We're not going to use MSI-X, so try MSI and fall back to INTx */ +if (!pci_enable_msi (dev)) + interrupt_mode =PCIE_PORT_MSI_MODE ; + + Fallback: +if (interrupt_mode ==PCIE_PORT_NO_IRQ && dev->pin) + interrupt_mode = PCIE_PORT_INTx_MODE; + + irq = interrupt_mode !=PCIE_PORT_NO_IRQ ? dev->irq :-1 ; +for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) + vectors[i] = irq; + + vectors[PCIE_PORT_SERVICE_VC_SHIFT ] =-1 ; -/* Select MSI-X over MSI if supported */ - pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); -if (pos) { -struct msix_entry msix_entries[PCIE_PORT_DEVICE_MAXSERVICES ] = - {{0 ,0 }, {0 ,1 }, {0 ,2 }, {0 ,3 }}; - status =pci_enable_msix (dev, msix_entries, nvec); -if (!status) { -int j =0 ; - - interrupt_mode =PCIE_PORT_MSIX_MODE ; -for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) { -if (mask & (1 << i)) - vectors[i] = msix_entries[j++].vector; - } - } - } -if (status) { - pos =pci_find_capability (dev,PCI_CAP_ID_MSI ); -if (pos) { - status =pci_enable_msi (dev); -if (!status) { - interrupt_mode =PCIE_PORT_MSI_MODE ; -for (i =0 ;i <PCIE_PORT_DEVICE_MAXSERVICES ;i++) - vectors[i] = dev->irq; - } - } - }return interrupt_mode; }
include/linux/pcieport_if.h +8 -4
@@ -16,10 +16,14 @@#define PCIE_ANY_PORT 7/* Service Type */ -#define PCIE_PORT_SERVICE_PME 1/* Power Management Event */ -#define PCIE_PORT_SERVICE_AER 2/* Advanced Error Reporting */ -#define PCIE_PORT_SERVICE_HP 4/* Native Hotplug */ -#define PCIE_PORT_SERVICE_VC 8/* Virtual Channel */ +#define PCIE_PORT_SERVICE_PME_SHIFT 0/* Power Management Event */ +#define PCIE_PORT_SERVICE_PME (1 << PCIE_PORT_SERVICE_PME_SHIFT) +#define PCIE_PORT_SERVICE_AER_SHIFT 1/* Advanced Error Reporting */ +#define PCIE_PORT_SERVICE_AER (1 << PCIE_PORT_SERVICE_AER_SHIFT) +#define PCIE_PORT_SERVICE_HP_SHIFT 2/* Native Hotplug */ +#define PCIE_PORT_SERVICE_HP (1 << PCIE_PORT_SERVICE_HP_SHIFT) +#define PCIE_PORT_SERVICE_VC_SHIFT 3/* Virtual Channel */ +#define PCIE_PORT_SERVICE_VC (1 << PCIE_PORT_SERVICE_VC_SHIFT)/* Root/Upstream/Downstream Port's Interrupt Mode */ #define PCIE_PORT_NO_IRQ (-1)
drivers/pci/pcie/portdrv.h +6 -0
@@ -25,6 +25,12 @@#define PCIE_CAPABILITIES_REG 0x2#define PCIE_SLOT_CAPABILITIES_REG 0x14#define PCIE_PORT_DEVICE_MAXSERVICES 4 +#define PCIE_PORT_MSI_VECTOR_MASK 0x1f +/* +* According to the PCI Express Base Specification 2.0, the indices of the MSI-X +* table entires used by port services must not exceed 31 +*/ +#define PCIE_PORT_MAX_MSIX_ENTRIES 32#define get_descriptor_id (type, service) (((type - 4) << 4) | service)
drivers/pci/msi.c +19 -5
@@ -670,6 +670,23 @@ static int msi_free_irqs(struct pci_dev* }/** +* pci_msix_table_size - return the number of device's MSI-X table entries +* @dev: pointer to the pci_dev data structure of MSI-X device function +*/ +int pci_msix_table_size (struct pci_dev *dev) +{ +int pos; +u16 control; + + pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); +if (!pos) +return 0 ; + +pci_read_config_word (dev,msi_control_reg (pos), &control); +return multi_msix_capable (control); +} + +/** * pci_enable_msix - configure device's MSI-X capability structure * @dev: pointer to the pci_dev data structure of MSI-X device function * @entries: pointer to an array of MSI-X entries
@@ -686,9 +703,8 @@ static int msi_free_irqs(struct pci_dev***/ int pci_enable_msix (struct pci_dev * dev,struct msix_entry *entries,int nvec) { -int status, pos, nr_entries; +int status, nr_entries;int i, j; -u16 control;if (!entries)return -EINVAL ;
@@ -697,9 +713,7 @@ int pci_enable_msix(struct pci_dev* dev,if (status)return status; - pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); -pci_read_config_word (dev,msi_control_reg (pos), &control); - nr_entries =multi_msix_capable (control); + nr_entries =pci_msix_table_size (dev);if (nvec > nr_entries)return -EINVAL ;
include/linux/pci.h +5 -0
@@ -799,6 +799,10 @@ static inline void pci_msi_shutdown(strustatic inline void pci_disable_msi (struct pci_dev *dev) { } +static inline int pci_msix_table_size (struct pci_dev *dev) +{ +return 0 ; +}static inline int pci_enable_msix (struct pci_dev *dev,struct msix_entry *entries,int nvec) {
@@ -823,6 +827,7 @@ static inline int pci_msi_enabled(void)extern int pci_enable_msi (struct pci_dev *dev);extern void pci_msi_shutdown (struct pci_dev *dev);extern void pci_disable_msi (struct pci_dev *dev); +extern int pci_msix_table_size (struct pci_dev *dev);extern int pci_enable_msix (struct pci_dev *dev,struct msix_entry *entries,int nvec);extern void pci_msix_shutdown (struct pci_dev *dev);
Re: [PATCH PCI PCIe portdrv: Fix allocation of interrupts (rev. 5)
Quoted 1 line · Rafael J. Wysocki
On Saturday 17 January 2009, Rafael J. Wysocki wrote:
(snip)
Quoted 96 lines
Quoted 3 lines
If MSI-X are supported, it allocates as many vectors as there are entries in the port's MSI-X table, but no more than 32, and figures out which of them will be used for the port services.
The patch didn't check which services are available during the MSI-X set up which was wrong.
Also, in the meantime, i thought it might be a good idea to free the interrupt routing table entries that aren't going to be used after all.
The patch below adds this to the previous version and checks for the availability of port services in the MSI-X setup resume. I hope it will be acceptable to everyone.
Thanks,
Rafael---
Subject: PCI PCIe portdrv: Fix allocation of interrupts (rev. 5)
From: Rafael J. Wysocki <[email protected]>If MSI-X interrupt mode is used by the PCI Express port driver, too many vectors are allocated and it is not ensured that the right vectors will be used for the right services. Namely, the PCI Express specification states that both PCI Express native PME and PCI Express hotplug will always use the same MSI or MSI-X message for signalling interrupts, which implies that the same vector will be used by both of them. Also, the VC service does not use interrupts at all. Moreover, is not clear which of the vectors allocated by
pci_enable_msix()in the current code will be used for PME and hotplug and which of them will be used for AER if all of these services are configured.For these reasons, rework the allocation of interrupts for PCI Express ports so that if MSI-X are enabled, the right vectors will be used for the right purposes.
Signed-off-by Rafael J. Wysocki <[email protected]>--- drivers/pci/msi.c | 24 +++- drivers/pci/pcie/portdrv.h | 6 + drivers/pci/pcie/portdrv_core.c | 195 ++++++++++++++++++++++++++++++++-------- include/linux/pci.h | 5 + include/linux/pcieport_if.h | 12 +- 5 files changed, 194 insertions(+), 48 deletions(-)Index:
linux-2.6/drivers/pci/pcie/portdrv_core.c
===================================================================drivers/pci/pcie/portdrv_core.c +42
-0@@ -31,6 +31,141 @@ static void release_pcie_device(struct d }/** +* pcie_port_msix_add_entry - add entry to given array of MSI-X entries +* @entries: Array of MSI-X entries +* @new_entry: Index of the entry to add to the array +* @nr_entries: Number of entries aleady in the array +* +* Return value: Position of the added entry in the array +*/ +static int pcie_port_msix_add_entry ( +struct msix_entry *entries,int new_entry,int nr_entries) +{ +int j; + +for (j =0 ; j < nr_entries; j++) +if (entries[j].entry == new_entry) +return j; + + entries[j].entry = new_entry; +return j; +} + +/** +* pcie_port_enable_msix - try to set up MSI-X as interrupt mode for given port +* @dev: PCI Express port to handle +* @vectors: Array of interrupt vectors to populate +* @mask: Bitmask of port capabilities returned by get_port_device_capability() +* +* Return value: 0 on success, error code on failure +*/ +static int pcie_port_enable_msix (struct pci_dev *dev,int *vectors,int mask) +{ +struct msix_entry *msix_entries; +int idx[PCIE_PORT_DEVICE_MAXSERVICES ]; +int nr_entries, status, pos, i, nvec; +u16 reg16; +u32 reg32; + + nr_entries =pci_msix_table_size (dev); +if (!nr_entries) +return -EINVAL ; +if (nr_entries >PCIE_PORT_MAX_MSIX_ENTRIES ) + nr_entries =PCIE_PORT_MAX_MSIX_ENTRIES ; +
drivers/pci/pcie/portdrv_core.c static void release_pcie_device(struct d · line 85
Quoted 10 lines
drivers/pci/pcie/portdrv_core.c +10
-0+ msix_entries =kzalloc (sizeof (*msix_entries) * nr_entries,GFP_KERNEL ); +if (!msix_entries) +return -ENOMEM ; + +/* +* Allocate as many entries as the device wants temporarily, so that we +* can check which of them will be useful. +*/ +for (i =0 ; i < nr_entries; i++) + msix_entries[i].entry = i;
/* * So, if msix_entries is correctly equal to the number of entries this * port actually uses, we'll happily go through without using trick. */
Quoted 52 lines
drivers/pci/pcie/portdrv_core.c +52
-0+ + status =pci_enable_msix (dev, msix_entries, nr_entries); +if (status) + goto Exit; + +for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) + idx[i] =-1 ; + status = -EIO ; + nvec =0 ; + +if (mask & (PCIE_PORT_SERVICE_PME |PCIE_PORT_SERVICE_HP )) { +int entry; + +/* +* The code below follows the PCI Express Base Specification 2.0 +* stating in Section 6.1.6 that "PME and Hot-Plug Event +* interrupts (when both are implemented) always share the same +* MSI or MSI-X vector, as indicated by the Interrupt Message +* Number field in the PCI Express Capabilities register", where +* according to Section 7.8.2 of the specification "For MSI-X, +* the value in this field indicates which MSI-X Table entry is +* used to generate the interrupt message." +*/ + pos =pci_find_capability (dev,PCI_CAP_ID_EXP ); +pci_read_config_word (dev, pos +PCIE_CAPABILITIES_REG , ®16); + entry = (reg16 >>9 ) &PCIE_PORT_MSI_VECTOR_MASK ; +if (entry >= nr_entries) + goto Error; + + i =pcie_port_msix_add_entry (msix_entries, entry, nvec); +if (i == nvec) + nvec++; + + idx[PCIE_PORT_SERVICE_PME_SHIFT ] = i; + idx[PCIE_PORT_SERVICE_HP_SHIFT ] = i; + } + +if (mask &PCIE_PORT_SERVICE_AER ) { +int entry; + +/* +* The code below follows Section 7.10.10 of the PCI Express +* Base Specification 2.0 stating that bits 31-27 of the Root +* Error Status Register contain a value indicating which of the +* MSI/MSI-X vectors assigned to the port is going to be used +* for AER, where "For MSI-X, the value in this register +* indicates which MSI-X Table entry is used to generate the +* interrupt message." +*/ + pos =pci_find_ext_capability (dev,PCI_EXT_CAP_ID_ERR ); +pci_read_config_dword (dev, pos +PCI_ERR_ROOT_STATUS , ®32); + entry = reg32 >>27 ;
drivers/pci/pcie/portdrv_core.c static void release_pcie_device(struct d · line 147
Quoted 10 lines
drivers/pci/pcie/portdrv_core.c +10
-0+if (entry >= nr_entries) + goto Error; + + i =pcie_port_msix_add_entry (msix_entries, entry, nvec); +if (i == nvec) + nvec++; + + idx[PCIE_PORT_SERVICE_AER_SHIFT ] = i; + } +
/* Are there any unused entries? */
if (nr_allocated > nvec) {
/* this port have extra entries not for services we know... */drivers/pci/pcie/portdrv_core.c static void release_pcie_device(struct d · line 154
Quoted 7 lines
drivers/pci/pcie/portdrv_core.c +7
-0+/* Drop the temporary MSI-X setup */ +pci_disable_msix (dev); + +/* Now allocate the MSI-X vectors for real */ + status =pci_enable_msix (dev, msix_entries, nvec); +if (status) + goto Error;
/*
* World have broken hardwares, so even spec says numbers are constant,
* it would be better to re-check registers after 2nd pci_enable_msix.
* Or we just skip this. (However this was what your concern, Rafael?) */
if (func_foo_do_paranoia_check(dev, msix_entries, nvec))
goto Error;
}
Quoted 143 lines
drivers/pci/pcie/portdrv_core.c +35
-39+ +for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) + vectors[i] = idx[i] >=0 ? msix_entries[idx[i]].vector :-1 ; + + Exit: +kfree (msix_entries); +return status; + + Error: +pci_disable_msix (dev); + goto Exit; +} + +/** * assign_interrupt_mode - choose interrupt mode for PCI Express port services * (INTx, MSI-X, MSI) and set up vectors * @dev: PCI Express port to handle @@ -42,49 +177,31 @@ static void release_pcie_device(struct dstatic int assign_interrupt_mode (struct pci_dev *dev,int *vectors,int mask) {struct pcie_port_data *port_data =pci_get_drvdata (dev); -int i, pos, nvec, status = -EINVAL ; -int interrupt_mode =PCIE_PORT_NO_IRQ ; - -/* Set INTx as default */ -for (i =0 , nvec =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) { -if (mask & (1 << i)) - nvec++; - vectors[i] = dev->irq; - } -if (dev->pin) - interrupt_mode = PCIE_PORT_INTx_MODE; +int irq, interrupt_mode =PCIE_PORT_NO_IRQ ; +int i;/* Check MSI quirk */ if (port_data->port_type ==PCIE_RC_PORT && pcie_mch_quirk) -return interrupt_mode; + goto Fallback; + +/* Try to use MSI-X if supported */ +if (!pcie_port_enable_msix (dev, vectors, mask)) +return PCIE_PORT_MSIX_MODE ; + +/* We're not going to use MSI-X, so try MSI and fall back to INTx */ +if (!pci_enable_msi (dev)) + interrupt_mode =PCIE_PORT_MSI_MODE ; + + Fallback: +if (interrupt_mode ==PCIE_PORT_NO_IRQ && dev->pin) + interrupt_mode = PCIE_PORT_INTx_MODE; + + irq = interrupt_mode !=PCIE_PORT_NO_IRQ ? dev->irq :-1 ; +for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) + vectors[i] = irq; + + vectors[PCIE_PORT_SERVICE_VC_SHIFT ] =-1 ; -/* Select MSI-X over MSI if supported */ - pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); -if (pos) { -struct msix_entry msix_entries[PCIE_PORT_DEVICE_MAXSERVICES ] = - {{0 ,0 }, {0 ,1 }, {0 ,2 }, {0 ,3 }}; - status =pci_enable_msix (dev, msix_entries, nvec); -if (!status) { -int j =0 ; - - interrupt_mode =PCIE_PORT_MSIX_MODE ; -for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) { -if (mask & (1 << i)) - vectors[i] = msix_entries[j++].vector; - } - } - } -if (status) { - pos =pci_find_capability (dev,PCI_CAP_ID_MSI ); -if (pos) { - status =pci_enable_msi (dev); -if (!status) { - interrupt_mode =PCIE_PORT_MSI_MODE ; -for (i =0 ;i <PCIE_PORT_DEVICE_MAXSERVICES ;i++) - vectors[i] = dev->irq; - } - } - }return interrupt_mode; }Index:
linux-2.6/include/linux/pcieport_if.h
===================================================================include/linux/pcieport_if.h +8
-4@@ -16,10 +16,14 @@#define PCIE_ANY_PORT 7/* Service Type */ -#define PCIE_PORT_SERVICE_PME 1/* Power Management Event */ -#define PCIE_PORT_SERVICE_AER 2/* Advanced Error Reporting */ -#define PCIE_PORT_SERVICE_HP 4/* Native Hotplug */ -#define PCIE_PORT_SERVICE_VC 8/* Virtual Channel */ +#define PCIE_PORT_SERVICE_PME_SHIFT 0/* Power Management Event */ +#define PCIE_PORT_SERVICE_PME (1 << PCIE_PORT_SERVICE_PME_SHIFT) +#define PCIE_PORT_SERVICE_AER_SHIFT 1/* Advanced Error Reporting */ +#define PCIE_PORT_SERVICE_AER (1 << PCIE_PORT_SERVICE_AER_SHIFT) +#define PCIE_PORT_SERVICE_HP_SHIFT 2/* Native Hotplug */ +#define PCIE_PORT_SERVICE_HP (1 << PCIE_PORT_SERVICE_HP_SHIFT) +#define PCIE_PORT_SERVICE_VC_SHIFT 3/* Virtual Channel */ +#define PCIE_PORT_SERVICE_VC (1 << PCIE_PORT_SERVICE_VC_SHIFT)/* Root/Upstream/Downstream Port's Interrupt Mode */ #define PCIE_PORT_NO_IRQ (-1)Index:
linux-2.6/drivers/pci/pcie/portdrv.h
===================================================================drivers/pci/pcie/portdrv.h +6
-0@@ -25,6 +25,12 @@#define PCIE_CAPABILITIES_REG 0x2#define PCIE_SLOT_CAPABILITIES_REG 0x14#define PCIE_PORT_DEVICE_MAXSERVICES 4 +#define PCIE_PORT_MSI_VECTOR_MASK 0x1f +/* +* According to the PCI Express Base Specification 2.0, the indices of the MSI-X +* table entires used by port services must not exceed 31 +*/ +#define PCIE_PORT_MAX_MSIX_ENTRIES 32#define get_descriptor_id (type, service) (((type - 4) << 4) | service)Index:
linux-2.6/drivers/pci/msi.c
===================================================================drivers/pci/msi.c +7
-0@@ -670,6 +670,23 @@ static int msi_free_irqs(struct pci_dev* }/** +* pci_msix_table_size - return the number of device's MSI-X table entries +* @dev: pointer to the pci_dev data structure of MSI-X device function +*/ +int pci_msix_table_size (struct pci_dev *dev) +{ +int pos; +u16 control;
drivers/pci/msi.c static int msi_free_irqs(struct pci_dev* · line 689
Quoted 10 lines
drivers/pci/msi.c +10
-0+ + pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); +if (!pos) +return 0 ; + +pci_read_config_word (dev,msi_control_reg (pos), &control); +return multi_msix_capable (control); +} + +/**
I think this pci_msix_table_size() is useful alone. It would be nice if we can have separated patches.
i.e.:
[PATCH] PCI/MSI: introduce pci_msix_table_size() [PATCH] PCI PCIe portdrv: Fix allocation of interrupts (rev. 6)
Thanks,
H.Seto
Quoted 55 lines
drivers/pci/msi.c +2
-5* pci_enable_msix - configure device's MSI-X capability structure * @dev: pointer to the pci_dev data structure of MSI-X device function * @entries: pointer to an array of MSI-X entries @@ -686,9 +703,8 @@ static int msi_free_irqs(struct pci_dev***/ int pci_enable_msix (struct pci_dev * dev,struct msix_entry *entries,int nvec) { -int status, pos, nr_entries; +int status, nr_entries;int i, j; -u16 control;if (!entries)return -EINVAL ;@@ -697,9 +713,7 @@ int pci_enable_msix(struct pci_dev* dev,if (status)return status; - pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); -pci_read_config_word (dev,msi_control_reg (pos), &control); - nr_entries =multi_msix_capable (control); + nr_entries =pci_msix_table_size (dev);if (nvec > nr_entries)return -EINVAL ;Index:
linux-2.6/include/linux/pci.h
===================================================================include/linux/pci.h +5
-1@@ -799,6 +799,10 @@ static inline void pci_msi_shutdown(strustatic inline void pci_disable_msi (struct pci_dev *dev) { } +static inline int pci_msix_table_size (struct pci_dev *dev) +{ +return 0 ; +}static inline int pci_enable_msix (struct pci_dev *dev,struct msix_entry *entries,int nvec) {@@ -823,6 +827,7 @@ static inline int pci_msi_enabled(void)extern int pci_enable_msi (struct pci_dev *dev);extern void pci_msi_shutdown (struct pci_dev *dev);extern void pci_disable_msi (struct pci_dev *dev); +extern int pci_msix_table_size (struct pci_dev *dev);extern int pci_enable_msix (struct pci_dev *dev,struct msix_entry *entries,int nvec);extern void pci_msix_shutdown (struct pci_dev *dev); --To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH PCI PCIe portdrv: Fix allocation of interrupts (rev. 5)
Quoted 177 lines · Hidetoshi Seto
Quoted 1 line · Rafael J. Wysocki
On Saturday 17 January 2009, Rafael J. Wysocki wrote:
(snip)
Quoted 95 lines
Quoted 3 lines
If MSI-X are supported, it allocates as many vectors as there are entries in the port's MSI-X table, but no more than 32, and figures out which of them will be used for the port services.
The patch didn't check which services are available during the MSI-X set up which was wrong.
Also, in the meantime, i thought it might be a good idea to free the interrupt routing table entries that aren't going to be used after all.
The patch below adds this to the previous version and checks for the availability of port services in the MSI-X setup resume. I hope it will be acceptable to everyone.
Thanks,
Rafael---
Subject: PCI PCIe portdrv: Fix allocation of interrupts (rev. 5)
From: Rafael J. Wysocki <[email protected]>If MSI-X interrupt mode is used by the PCI Express port driver, too many vectors are allocated and it is not ensured that the right vectors will be used for the right services. Namely, the PCI Express specification states that both PCI Express native PME and PCI Express hotplug will always use the same MSI or MSI-X message for signalling interrupts, which implies that the same vector will be used by both of them. Also, the VC service does not use interrupts at all. Moreover, is not clear which of the vectors allocated by
pci_enable_msix()in the current code will be used for PME and hotplug and which of them will be used for AER if all of these services are configured.For these reasons, rework the allocation of interrupts for PCI Express ports so that if MSI-X are enabled, the right vectors will be used for the right purposes.
Signed-off-by Rafael J. Wysocki <[email protected]>--- drivers/pci/msi.c | 24 +++- drivers/pci/pcie/portdrv.h | 6 + drivers/pci/pcie/portdrv_core.c | 195 ++++++++++++++++++++++++++++++++-------- include/linux/pci.h | 5 + include/linux/pcieport_if.h | 12 +- 5 files changed, 194 insertions(+), 48 deletions(-)Index:
linux-2.6/drivers/pci/pcie/portdrv_core.c
===================================================================drivers/pci/pcie/portdrv_core.c +42
-0@@ -31,6 +31,141 @@ static void release_pcie_device(struct d }/** +* pcie_port_msix_add_entry - add entry to given array of MSI-X entries +* @entries: Array of MSI-X entries +* @new_entry: Index of the entry to add to the array +* @nr_entries: Number of entries aleady in the array +* +* Return value: Position of the added entry in the array +*/ +static int pcie_port_msix_add_entry ( +struct msix_entry *entries,int new_entry,int nr_entries) +{ +int j; + +for (j =0 ; j < nr_entries; j++) +if (entries[j].entry == new_entry) +return j; + + entries[j].entry = new_entry; +return j; +} + +/** +* pcie_port_enable_msix - try to set up MSI-X as interrupt mode for given port +* @dev: PCI Express port to handle +* @vectors: Array of interrupt vectors to populate +* @mask: Bitmask of port capabilities returned by get_port_device_capability() +* +* Return value: 0 on success, error code on failure +*/ +static int pcie_port_enable_msix (struct pci_dev *dev,int *vectors,int mask) +{ +struct msix_entry *msix_entries; +int idx[PCIE_PORT_DEVICE_MAXSERVICES ]; +int nr_entries, status, pos, i, nvec; +u16 reg16; +u32 reg32; + + nr_entries =pci_msix_table_size (dev); +if (!nr_entries) +return -EINVAL ; +if (nr_entries >PCIE_PORT_MAX_MSIX_ENTRIES ) + nr_entries =PCIE_PORT_MAX_MSIX_ENTRIES ; +drivers/pci/pcie/portdrv_core.c static void release_pcie_device(struct d · line 85
Quoted 10 lines
drivers/pci/pcie/portdrv_core.c +10
-0+ msix_entries =kzalloc (sizeof (*msix_entries) * nr_entries,GFP_KERNEL ); +if (!msix_entries) +return -ENOMEM ; + +/* +* Allocate as many entries as the device wants temporarily, so that we +* can check which of them will be useful. +*/ +for (i =0 ; i < nr_entries; i++) + msix_entries[i].entry = i;/* * So, if msix_entries is correctly equal to the number of entries this * port actually uses, we'll happily go through without using trick. */Quoted 52 lines
drivers/pci/pcie/portdrv_core.c +52
-0+ + status =pci_enable_msix (dev, msix_entries, nr_entries); +if (status) + goto Exit; + +for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) + idx[i] =-1 ; + status = -EIO ; + nvec =0 ; + +if (mask & (PCIE_PORT_SERVICE_PME |PCIE_PORT_SERVICE_HP )) { +int entry; + +/* +* The code below follows the PCI Express Base Specification 2.0 +* stating in Section 6.1.6 that "PME and Hot-Plug Event +* interrupts (when both are implemented) always share the same +* MSI or MSI-X vector, as indicated by the Interrupt Message +* Number field in the PCI Express Capabilities register", where +* according to Section 7.8.2 of the specification "For MSI-X, +* the value in this field indicates which MSI-X Table entry is +* used to generate the interrupt message." +*/ + pos =pci_find_capability (dev,PCI_CAP_ID_EXP ); +pci_read_config_word (dev, pos +PCIE_CAPABILITIES_REG , ®16); + entry = (reg16 >>9 ) &PCIE_PORT_MSI_VECTOR_MASK ; +if (entry >= nr_entries) + goto Error; + + i =pcie_port_msix_add_entry (msix_entries, entry, nvec); +if (i == nvec) + nvec++; + + idx[PCIE_PORT_SERVICE_PME_SHIFT ] = i; + idx[PCIE_PORT_SERVICE_HP_SHIFT ] = i; + } + +if (mask &PCIE_PORT_SERVICE_AER ) { +int entry; + +/* +* The code below follows Section 7.10.10 of the PCI Express +* Base Specification 2.0 stating that bits 31-27 of the Root +* Error Status Register contain a value indicating which of the +* MSI/MSI-X vectors assigned to the port is going to be used +* for AER, where "For MSI-X, the value in this register +* indicates which MSI-X Table entry is used to generate the +* interrupt message." +*/ + pos =pci_find_ext_capability (dev,PCI_EXT_CAP_ID_ERR ); +pci_read_config_dword (dev, pos +PCI_ERR_ROOT_STATUS , ®32); + entry = reg32 >>27 ;drivers/pci/pcie/portdrv_core.c static void release_pcie_device(struct d · line 147
Quoted 10 lines
drivers/pci/pcie/portdrv_core.c +10
-0+if (entry >= nr_entries) + goto Error; + + i =pcie_port_msix_add_entry (msix_entries, entry, nvec); +if (i == nvec) + nvec++; + + idx[PCIE_PORT_SERVICE_AER_SHIFT ] = i; + } +/* Are there any unused entries? */
Quoted 3 lines
if (nr_allocated > nvec) {
/* this port have extra entries not for services we know... */Sounds good. That is,
If the number of entries we required equals to nr_entries (from Table size field in Message Control register), we don't need to drop the first MSI-X setup.
Thanks,
Kenji Kaneshige
Quoted 244 lines
drivers/pci/pcie/portdrv_core.c static void release_pcie_device(struct d · line 154
Quoted 7 lines
drivers/pci/pcie/portdrv_core.c +7
-0+/* Drop the temporary MSI-X setup */ +pci_disable_msix (dev); + +/* Now allocate the MSI-X vectors for real */ + status =pci_enable_msix (dev, msix_entries, nvec); +if (status) + goto Error;/*
* World have broken hardwares, so even spec says numbers are constant,
* it would be better to re-check registers after 2ndpci_enable_msix.
* Or we just skip this. (However this was what your concern, Rafael?) */
if (func_foo_do_paranoia_check(dev, msix_entries, nvec))
goto Error;
}Quoted 143 lines
drivers/pci/pcie/portdrv_core.c +35
-39+ +for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) + vectors[i] = idx[i] >=0 ? msix_entries[idx[i]].vector :-1 ; + + Exit: +kfree (msix_entries); +return status; + + Error: +pci_disable_msix (dev); + goto Exit; +} + +/** * assign_interrupt_mode - choose interrupt mode for PCI Express port services * (INTx, MSI-X, MSI) and set up vectors * @dev: PCI Express port to handle @@ -42,49 +177,31 @@ static void release_pcie_device(struct dstatic int assign_interrupt_mode (struct pci_dev *dev,int *vectors,int mask) {struct pcie_port_data *port_data =pci_get_drvdata (dev); -int i, pos, nvec, status = -EINVAL ; -int interrupt_mode =PCIE_PORT_NO_IRQ ; - -/* Set INTx as default */ -for (i =0 , nvec =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) { -if (mask & (1 << i)) - nvec++; - vectors[i] = dev->irq; - } -if (dev->pin) - interrupt_mode = PCIE_PORT_INTx_MODE; +int irq, interrupt_mode =PCIE_PORT_NO_IRQ ; +int i;/* Check MSI quirk */ if (port_data->port_type ==PCIE_RC_PORT && pcie_mch_quirk) -return interrupt_mode; + goto Fallback; + +/* Try to use MSI-X if supported */ +if (!pcie_port_enable_msix (dev, vectors, mask)) +return PCIE_PORT_MSIX_MODE ; + +/* We're not going to use MSI-X, so try MSI and fall back to INTx */ +if (!pci_enable_msi (dev)) + interrupt_mode =PCIE_PORT_MSI_MODE ; + + Fallback: +if (interrupt_mode ==PCIE_PORT_NO_IRQ && dev->pin) + interrupt_mode = PCIE_PORT_INTx_MODE; + + irq = interrupt_mode !=PCIE_PORT_NO_IRQ ? dev->irq :-1 ; +for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) + vectors[i] = irq; + + vectors[PCIE_PORT_SERVICE_VC_SHIFT ] =-1 ; -/* Select MSI-X over MSI if supported */ - pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); -if (pos) { -struct msix_entry msix_entries[PCIE_PORT_DEVICE_MAXSERVICES ] = - {{0 ,0 }, {0 ,1 }, {0 ,2 }, {0 ,3 }}; - status =pci_enable_msix (dev, msix_entries, nvec); -if (!status) { -int j =0 ; - - interrupt_mode =PCIE_PORT_MSIX_MODE ; -for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) { -if (mask & (1 << i)) - vectors[i] = msix_entries[j++].vector; - } - } - } -if (status) { - pos =pci_find_capability (dev,PCI_CAP_ID_MSI ); -if (pos) { - status =pci_enable_msi (dev); -if (!status) { - interrupt_mode =PCIE_PORT_MSI_MODE ; -for (i =0 ;i <PCIE_PORT_DEVICE_MAXSERVICES ;i++) - vectors[i] = dev->irq; - } - } - }return interrupt_mode; }Index:
linux-2.6/include/linux/pcieport_if.h
===================================================================include/linux/pcieport_if.h +8
-4@@ -16,10 +16,14 @@#define PCIE_ANY_PORT 7/* Service Type */ -#define PCIE_PORT_SERVICE_PME 1/* Power Management Event */ -#define PCIE_PORT_SERVICE_AER 2/* Advanced Error Reporting */ -#define PCIE_PORT_SERVICE_HP 4/* Native Hotplug */ -#define PCIE_PORT_SERVICE_VC 8/* Virtual Channel */ +#define PCIE_PORT_SERVICE_PME_SHIFT 0/* Power Management Event */ +#define PCIE_PORT_SERVICE_PME (1 << PCIE_PORT_SERVICE_PME_SHIFT) +#define PCIE_PORT_SERVICE_AER_SHIFT 1/* Advanced Error Reporting */ +#define PCIE_PORT_SERVICE_AER (1 << PCIE_PORT_SERVICE_AER_SHIFT) +#define PCIE_PORT_SERVICE_HP_SHIFT 2/* Native Hotplug */ +#define PCIE_PORT_SERVICE_HP (1 << PCIE_PORT_SERVICE_HP_SHIFT) +#define PCIE_PORT_SERVICE_VC_SHIFT 3/* Virtual Channel */ +#define PCIE_PORT_SERVICE_VC (1 << PCIE_PORT_SERVICE_VC_SHIFT)/* Root/Upstream/Downstream Port's Interrupt Mode */ #define PCIE_PORT_NO_IRQ (-1)Index:
linux-2.6/drivers/pci/pcie/portdrv.h
===================================================================drivers/pci/pcie/portdrv.h +6
-0@@ -25,6 +25,12 @@#define PCIE_CAPABILITIES_REG 0x2#define PCIE_SLOT_CAPABILITIES_REG 0x14#define PCIE_PORT_DEVICE_MAXSERVICES 4 +#define PCIE_PORT_MSI_VECTOR_MASK 0x1f +/* +* According to the PCI Express Base Specification 2.0, the indices of the MSI-X +* table entires used by port services must not exceed 31 +*/ +#define PCIE_PORT_MAX_MSIX_ENTRIES 32#define get_descriptor_id (type, service) (((type - 4) << 4) | service)Index:
linux-2.6/drivers/pci/msi.c
===================================================================drivers/pci/msi.c +7
-0@@ -670,6 +670,23 @@ static int msi_free_irqs(struct pci_dev* }/** +* pci_msix_table_size - return the number of device's MSI-X table entries +* @dev: pointer to the pci_dev data structure of MSI-X device function +*/ +int pci_msix_table_size (struct pci_dev *dev) +{ +int pos; +u16 control;drivers/pci/msi.c static int msi_free_irqs(struct pci_dev* · line 689
Quoted 10 lines
drivers/pci/msi.c +10
-0+ + pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); +if (!pos) +return 0 ; + +pci_read_config_word (dev,msi_control_reg (pos), &control); +return multi_msix_capable (control); +} + +/** I think this
pci_msix_table_size()is useful alone. It would be nice if we can have separated patches.i.e.:
[PATCH] PCI/MSI: introducepci_msix_table_size()[PATCH] PCI PCIe portdrv: Fix allocation of interrupts (rev. 6)Thanks,
H.SetoQuoted 50 lines
drivers/pci/msi.c +2
-5* pci_enable_msix - configure device's MSI-X capability structure * @dev: pointer to the pci_dev data structure of MSI-X device function * @entries: pointer to an array of MSI-X entries @@ -686,9 +703,8 @@ static int msi_free_irqs(struct pci_dev***/ int pci_enable_msix (struct pci_dev * dev,struct msix_entry *entries,int nvec) { -int status, pos, nr_entries; +int status, nr_entries;int i, j; -u16 control;if (!entries)return -EINVAL ;@@ -697,9 +713,7 @@ int pci_enable_msix(struct pci_dev* dev,if (status)return status; - pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); -pci_read_config_word (dev,msi_control_reg (pos), &control); - nr_entries =multi_msix_capable (control); + nr_entries =pci_msix_table_size (dev);if (nvec > nr_entries)return -EINVAL ;Index:
linux-2.6/include/linux/pci.h
===================================================================include/linux/pci.h +5
-1@@ -799,6 +799,10 @@ static inline void pci_msi_shutdown(strustatic inline void pci_disable_msi (struct pci_dev *dev) { } +static inline int pci_msix_table_size (struct pci_dev *dev) +{ +return 0 ; +}static inline int pci_enable_msix (struct pci_dev *dev,struct msix_entry *entries,int nvec) {@@ -823,6 +827,7 @@ static inline int pci_msi_enabled(void)extern int pci_enable_msi (struct pci_dev *dev);extern void pci_msi_shutdown (struct pci_dev *dev);extern void pci_disable_msi (struct pci_dev *dev); +extern int pci_msix_table_size (struct pci_dev *dev);extern int pci_enable_msix (struct pci_dev *dev,struct msix_entry *entries,int nvec);extern void pci_msix_shutdown (struct pci_dev *dev); --Quoted 5 lines
To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH PCI PCIe portdrv: Fix allocation of interrupts (rev. 5)
Quoted 10 lines · Kenji Kaneshige
Quoted 9 lines · Hidetoshi Seto
Quoted 1 line · Rafael J. Wysocki
On Saturday 17 January 2009, Rafael J. Wysocki wrote:
(snip)
Quoted 6 lines
Quoted 3 lines
If MSI-X are supported, it allocates as many vectors as there are entries in the port's MSI-X table, but no more than 32, and figures out which of them will be used for the port services.
The patch didn't check which services are available during the MSI-X set up which was wrong.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Also, in the meantime, i thought it might be a good idea to free the interrupt routing table entries that aren't going to be used after all.
The patch below adds this to the previous version and checks for the availability of port services in the MSI-X setup resume. I hope it will be acceptable to everyone.
[--snip--]
Quoted 11 lines
Quoted 5 lines
/* Are there any unused entries? */
if (nr_allocated > nvec) { /* this port have extra entries not for services we know... */Sounds good. That is,
If the number of entries we required equals to
nr_entries(from Table size field in Message Control register), we don't need to drop the first MSI-X setup.
I've split the patch into two parts, one adding pci_msix_table_size() and the other containing the rest of changes. Also, I've modified the second patch to follow the above observation.
The patches will follow as replies to this message.
Thanks,
Rafael
PATCH 1/2 PCI/MSI: Introduce pci_msix_table_size()
From: Rafael J. Wysocki <[email protected]>
Introduce new function pci_msix_table_size() returning the size of the MSI-X table of given PCI device or 0 if the device doesn't support MSI-X.
--- drivers/pci/msi.c | 24 +++++++++++++++++++----- include/linux/pci.h | 5 +++++ 2 files changed, 24 insertions(+), 5 deletions(-)
drivers/pci/msi.c +19 -5
@@ -670,6 +670,23 @@ static int msi_free_irqs(struct pci_dev* }/** +* pci_msix_table_size - return the number of device's MSI-X table entries +* @dev: pointer to the pci_dev data structure of MSI-X device function +*/ +int pci_msix_table_size (struct pci_dev *dev) +{ +int pos; +u16 control; + + pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); +if (!pos) +return 0 ; + +pci_read_config_word (dev,msi_control_reg (pos), &control); +return multi_msix_capable (control); +} + +/** * pci_enable_msix - configure device's MSI-X capability structure * @dev: pointer to the pci_dev data structure of MSI-X device function * @entries: pointer to an array of MSI-X entries
@@ -686,9 +703,8 @@ static int msi_free_irqs(struct pci_dev***/ int pci_enable_msix (struct pci_dev * dev,struct msix_entry *entries,int nvec) { -int status, pos, nr_entries; +int status, nr_entries;int i, j; -u16 control;if (!entries)return -EINVAL ;
@@ -697,9 +713,7 @@ int pci_enable_msix(struct pci_dev* dev,if (status)return status; - pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); -pci_read_config_word (dev,msi_control_reg (pos), &control); - nr_entries =multi_msix_capable (control); + nr_entries =pci_msix_table_size (dev);if (nvec > nr_entries)return -EINVAL ;
include/linux/pci.h +5 -0
@@ -799,6 +799,10 @@ static inline void pci_msi_shutdown(strustatic inline void pci_disable_msi (struct pci_dev *dev) { } +static inline int pci_msix_table_size (struct pci_dev *dev) +{ +return 0 ; +}static inline int pci_enable_msix (struct pci_dev *dev,struct msix_entry *entries,int nvec) {
@@ -823,6 +827,7 @@ static inline int pci_msi_enabled(void)extern int pci_enable_msi (struct pci_dev *dev);extern void pci_msi_shutdown (struct pci_dev *dev);extern void pci_disable_msi (struct pci_dev *dev); +extern int pci_msix_table_size (struct pci_dev *dev);extern int pci_enable_msix (struct pci_dev *dev,struct msix_entry *entries,int nvec);extern void pci_msix_shutdown (struct pci_dev *dev);
PATCH 2/2 PCI PCIe portdrv: Fix allocation of interrupts (rev. 6)
From: Rafael J. Wysocki <[email protected]>
If MSI-X interrupt mode is used by the PCI Express port driver, too many vectors are allocated and it is not ensured that the right vectors will be used for the right services. Namely, the PCI Express specification states that both PCI Express native PME and PCI Express hotplug will always use the same MSI or MSI-X message for signalling interrupts, which implies that the same vector will be used by both of them. Also, the VC service does not use interrupts at all. Moreover, is not clear which of the vectors allocated by pci_enable_msix() in the current code will be used for PME and hotplug and which of them will be used for AER if all of these services are configured.
For these reasons, rework the allocation of interrupts for PCI Express ports so that if MSI-X are enabled, the right vectors will be used for the right purposes.
--- drivers/pci/pcie/portdrv.h | 6 + drivers/pci/pcie/portdrv_core.c | 204 ++++++++++++++++++++++++++++++++-------- include/linux/pcieport_if.h | 12 +- 3 files changed, 180 insertions(+), 42 deletions(-)
drivers/pci/pcie/portdrv_core.c +166 -38
@@ -31,6 +31,152 @@ static void release_pcie_device(struct d }/** +* pcie_port_msix_add_entry - add entry to given array of MSI-X entries +* @entries: Array of MSI-X entries +* @new_entry: Index of the entry to add to the array +* @nr_entries: Number of entries aleady in the array +* +* Return value: Position of the added entry in the array +*/ +static int pcie_port_msix_add_entry ( +struct msix_entry *entries,int new_entry,int nr_entries) +{ +int j; + +for (j =0 ; j < nr_entries; j++) +if (entries[j].entry == new_entry) +return j; + + entries[j].entry = new_entry; +return j; +} + +/** +* pcie_port_enable_msix - try to set up MSI-X as interrupt mode for given port +* @dev: PCI Express port to handle +* @vectors: Array of interrupt vectors to populate +* @mask: Bitmask of port capabilities returned by get_port_device_capability() +* +* Return value: 0 on success, error code on failure +*/ +static int pcie_port_enable_msix (struct pci_dev *dev,int *vectors,int mask) +{ +struct msix_entry *msix_entries; +int idx[PCIE_PORT_DEVICE_MAXSERVICES ]; +int nr_entries, status, pos, i, nvec; +u16 reg16; +u32 reg32; + + nr_entries =pci_msix_table_size (dev); +if (!nr_entries) +return -EINVAL ; +if (nr_entries >PCIE_PORT_MAX_MSIX_ENTRIES ) + nr_entries =PCIE_PORT_MAX_MSIX_ENTRIES ; + + msix_entries =kzalloc (sizeof (*msix_entries) * nr_entries,GFP_KERNEL ); +if (!msix_entries) +return -ENOMEM ; + +/* +* Allocate as many entries as the port wants, so that we can check +* which of them will be useful. Moreover, if nr_entries is correctly +* equal to the number of entries this port actually uses, we'll happily +* go through without any tricks. +*/ +for (i =0 ; i < nr_entries; i++) + msix_entries[i].entry = i; + + status =pci_enable_msix (dev, msix_entries, nr_entries); +if (status) + goto Exit; + +for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) + idx[i] =-1 ; + status = -EIO ; + nvec =0 ; + +if (mask & (PCIE_PORT_SERVICE_PME |PCIE_PORT_SERVICE_HP )) { +int entry; + +/* +* The code below follows the PCI Express Base Specification 2.0 +* stating in Section 6.1.6 that "PME and Hot-Plug Event +* interrupts (when both are implemented) always share the same +* MSI or MSI-X vector, as indicated by the Interrupt Message +* Number field in the PCI Express Capabilities register", where +* according to Section 7.8.2 of the specification "For MSI-X, +* the value in this field indicates which MSI-X Table entry is +* used to generate the interrupt message." +*/ + pos =pci_find_capability (dev,PCI_CAP_ID_EXP ); +pci_read_config_word (dev, pos +PCIE_CAPABILITIES_REG , ®16); + entry = (reg16 >>9 ) &PCIE_PORT_MSI_VECTOR_MASK ; +if (entry >= nr_entries) + goto Error; + + i =pcie_port_msix_add_entry (msix_entries, entry, nvec); +if (i == nvec) + nvec++; + + idx[PCIE_PORT_SERVICE_PME_SHIFT ] = i; + idx[PCIE_PORT_SERVICE_HP_SHIFT ] = i; + } + +if (mask &PCIE_PORT_SERVICE_AER ) { +int entry; + +/* +* The code below follows Section 7.10.10 of the PCI Express +* Base Specification 2.0 stating that bits 31-27 of the Root +* Error Status Register contain a value indicating which of the +* MSI/MSI-X vectors assigned to the port is going to be used +* for AER, where "For MSI-X, the value in this register +* indicates which MSI-X Table entry is used to generate the +* interrupt message." +*/ + pos =pci_find_ext_capability (dev,PCI_EXT_CAP_ID_ERR ); +pci_read_config_dword (dev, pos +PCI_ERR_ROOT_STATUS , ®32); + entry = reg32 >>27 ; +if (entry >= nr_entries) + goto Error; + + i =pcie_port_msix_add_entry (msix_entries, entry, nvec); +if (i == nvec) + nvec++; + + idx[PCIE_PORT_SERVICE_AER_SHIFT ] = i; + } + +/* +* If nvec is equal to the allocated number of entries, we can just use +* what we have. Otherwise, the port has some extra entries not for the +* services we know and we need to work around that. +*/ +if (nvec == nr_entries) { + status =0 ; + }else { +/* Drop the temporary MSI-X setup */ +pci_disable_msix (dev); + +/* Now allocate the MSI-X vectors for real */ + status =pci_enable_msix (dev, msix_entries, nvec); +if (status) + goto Exit; + } + +for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) + vectors[i] = idx[i] >=0 ? msix_entries[idx[i]].vector :-1 ; + + Exit: +kfree (msix_entries); +return status; + + Error: +pci_disable_msix (dev); + goto Exit; +} + +/** * assign_interrupt_mode - choose interrupt mode for PCI Express port services * (INTx, MSI-X, MSI) and set up vectors * @dev: PCI Express port to handle
@@ -42,49 +188,31 @@ static void release_pcie_device(struct dstatic int assign_interrupt_mode (struct pci_dev *dev,int *vectors,int mask) {struct pcie_port_data *port_data =pci_get_drvdata (dev); -int i, pos, nvec, status = -EINVAL ; -int interrupt_mode =PCIE_PORT_NO_IRQ ; - -/* Set INTx as default */ -for (i =0 , nvec =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) { -if (mask & (1 << i)) - nvec++; - vectors[i] = dev->irq; - } -if (dev->pin) - interrupt_mode = PCIE_PORT_INTx_MODE; +int irq, interrupt_mode =PCIE_PORT_NO_IRQ ; +int i;/* Check MSI quirk */ if (port_data->port_type ==PCIE_RC_PORT && pcie_mch_quirk) -return interrupt_mode; + goto Fallback; -/* Select MSI-X over MSI if supported */ - pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); -if (pos) { -struct msix_entry msix_entries[PCIE_PORT_DEVICE_MAXSERVICES ] = - {{0 ,0 }, {0 ,1 }, {0 ,2 }, {0 ,3 }}; - status =pci_enable_msix (dev, msix_entries, nvec); -if (!status) { -int j =0 ; +/* Try to use MSI-X if supported */ +if (!pcie_port_enable_msix (dev, vectors, mask)) +return PCIE_PORT_MSIX_MODE ; + +/* We're not going to use MSI-X, so try MSI and fall back to INTx */ +if (!pci_enable_msi (dev)) + interrupt_mode =PCIE_PORT_MSI_MODE ; + + Fallback: +if (interrupt_mode ==PCIE_PORT_NO_IRQ && dev->pin) + interrupt_mode = PCIE_PORT_INTx_MODE; + + irq = interrupt_mode !=PCIE_PORT_NO_IRQ ? dev->irq :-1 ; +for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) + vectors[i] = irq; + + vectors[PCIE_PORT_SERVICE_VC_SHIFT ] =-1 ; - interrupt_mode =PCIE_PORT_MSIX_MODE ; -for (i =0 ; i <PCIE_PORT_DEVICE_MAXSERVICES ; i++) { -if (mask & (1 << i)) - vectors[i] = msix_entries[j++].vector; - } - } - } -if (status) { - pos =pci_find_capability (dev,PCI_CAP_ID_MSI ); -if (pos) { - status =pci_enable_msi (dev); -if (!status) { - interrupt_mode =PCIE_PORT_MSI_MODE ; -for (i =0 ;i <PCIE_PORT_DEVICE_MAXSERVICES ;i++) - vectors[i] = dev->irq; - } - } - }return interrupt_mode; }
include/linux/pcieport_if.h +8 -4
@@ -16,10 +16,14 @@#define PCIE_ANY_PORT 7/* Service Type */ -#define PCIE_PORT_SERVICE_PME 1/* Power Management Event */ -#define PCIE_PORT_SERVICE_AER 2/* Advanced Error Reporting */ -#define PCIE_PORT_SERVICE_HP 4/* Native Hotplug */ -#define PCIE_PORT_SERVICE_VC 8/* Virtual Channel */ +#define PCIE_PORT_SERVICE_PME_SHIFT 0/* Power Management Event */ +#define PCIE_PORT_SERVICE_PME (1 << PCIE_PORT_SERVICE_PME_SHIFT) +#define PCIE_PORT_SERVICE_AER_SHIFT 1/* Advanced Error Reporting */ +#define PCIE_PORT_SERVICE_AER (1 << PCIE_PORT_SERVICE_AER_SHIFT) +#define PCIE_PORT_SERVICE_HP_SHIFT 2/* Native Hotplug */ +#define PCIE_PORT_SERVICE_HP (1 << PCIE_PORT_SERVICE_HP_SHIFT) +#define PCIE_PORT_SERVICE_VC_SHIFT 3/* Virtual Channel */ +#define PCIE_PORT_SERVICE_VC (1 << PCIE_PORT_SERVICE_VC_SHIFT)/* Root/Upstream/Downstream Port's Interrupt Mode */ #define PCIE_PORT_NO_IRQ (-1)
drivers/pci/pcie/portdrv.h +6 -0
@@ -25,6 +25,12 @@#define PCIE_CAPABILITIES_REG 0x2#define PCIE_SLOT_CAPABILITIES_REG 0x14#define PCIE_PORT_DEVICE_MAXSERVICES 4 +#define PCIE_PORT_MSI_VECTOR_MASK 0x1f +/* +* According to the PCI Express Base Specification 2.0, the indices of the MSI-X +* table entires used by port services must not exceed 31 +*/ +#define PCIE_PORT_MAX_MSIX_ENTRIES 32#define get_descriptor_id (type, service) (((type - 4) << 4) | service)
Re: [PATCH 2/2] PCI PCIe portdrv: Fix allocation of interrupts (rev. 6)
Nice work, Rafael!
Thanks,
H.Seto
Quoted 20 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
If MSI-X interrupt mode is used by the PCI Express port driver, too many vectors are allocated and it is not ensured that the right vectors will be used for the right services. Namely, the PCI Express specification states that both PCI Express native PME and PCI Express hotplug will always use the same MSI or MSI-X message for signalling interrupts, which implies that the same vector will be used by both of them. Also, the VC service does not use interrupts at all. Moreover, is not clear which of the vectors allocated by
pci_enable_msix()in the current code will be used for PME and hotplug and which of them will be used for AER if all of these services are configured.For these reasons, rework the allocation of interrupts for PCI Express ports so that if MSI-X are enabled, the right vectors will be used for the right purposes.
Signed-off-by Rafael J. Wysocki <[email protected]>---
Re: [PATCH 2/2] PCI PCIe portdrv: Fix allocation of interrupts (rev. 6)
Quoted 3 lines · Hidetoshi Seto
Reviewed-by Hidetoshi Seto <[email protected]>Nice work, Rafael!
Thanks for the review!
Best,
Rafael
Quoted 21 lines
Quoted 20 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
If MSI-X interrupt mode is used by the PCI Express port driver, too many vectors are allocated and it is not ensured that the right vectors will be used for the right services. Namely, the PCI Express specification states that both PCI Express native PME and PCI Express hotplug will always use the same MSI or MSI-X message for signalling interrupts, which implies that the same vector will be used by both of them. Also, the VC service does not use interrupts at all. Moreover, is not clear which of the vectors allocated by
pci_enable_msix()in the current code will be used for PME and hotplug and which of them will be used for AER if all of these services are configured.For these reasons, rework the allocation of interrupts for PCI Express ports so that if MSI-X are enabled, the right vectors will be used for the right purposes.
Signed-off-by Rafael J. Wysocki <[email protected]>---
Re: [PATCH 1/2] PCI/MSI: Introduce pci_msix_table_size()
In reply to Rafael J. WysockiThanks,
H.Seto
Quoted 8 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
Introduce new function
pci_msix_table_size()returning the size of the MSI-X table of given PCI device or 0 if the device doesn't support MSI-X.Signed-off-by Rafael J. Wysocki <[email protected]>---
Re: [PATCH 1/2] PCI/MSI: Introduce pci_msix_table_size()
In reply to Rafael J. WysockiQuoted 52 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
Introduce new function
pci_msix_table_size()returning the size of the MSI-X table of given PCI device or 0 if the device doesn't support MSI-X.Signed-off-by Rafael J. Wysocki <[email protected]>--- drivers/pci/msi.c | 24 +++++++++++++++++++----- include/linux/pci.h | 5 +++++ 2 files changed, 24 insertions(+), 5 deletions(-)Index:
linux-2.6/drivers/pci/msi.c
===================================================================drivers/pci/msi.c +18
-2@@ -670,6 +670,23 @@ static int msi_free_irqs(struct pci_dev* }/** +* pci_msix_table_size - return the number of device's MSI-X table entries +* @dev: pointer to the pci_dev data structure of MSI-X device function +*/ +int pci_msix_table_size (struct pci_dev *dev) +{ +int pos; +u16 control; + + pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); +if (!pos) +return 0 ; + +pci_read_config_word (dev,msi_control_reg (pos), &control); +return multi_msix_capable (control); +} + +/** * pci_enable_msix - configure device's MSI-X capability structure * @dev: pointer to the pci_dev data structure of MSI-X device function * @entries: pointer to an array of MSI-X entries @@ -686,9 +703,8 @@ static int msi_free_irqs(struct pci_dev***/ int pci_enable_msix (struct pci_dev * dev,struct msix_entry *entries,int nvec) { -int status, pos, nr_entries; +int status, nr_entries;int i, j; -u16 control;if (!entries)return -EINVAL ;
drivers/pci/msi.c int pci_enable_msix(struct pci_dev* dev, · line 718
Quoted 9 lines
drivers/pci/msi.c +1
-3@@ -697,9 +713,7 @@ int pci_enable_msix(struct pci_dev* dev,if (status)return status; - pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); -pci_read_config_word (dev,msi_control_reg (pos), &control); - nr_entries =multi_msix_capable (control); + nr_entries =pci_msix_table_size (dev);if (nvec > nr_entries)return -EINVAL ;
I see similar code in msix_capability_init(), although it still needs pos. Did you deliberately not replace that, or just miss it?
cheers
Signature · 8 lines
Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
Re: [PATCH 1/2] PCI/MSI: Introduce pci_msix_table_size()
Quoted 56 lines · Michael Ellerman
Quoted 55 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
Introduce new function
pci_msix_table_size()returning the size of the MSI-X table of given PCI device or 0 if the device doesn't support MSI-X.Signed-off-by Rafael J. Wysocki <[email protected]>--- drivers/pci/msi.c | 24 +++++++++++++++++++----- include/linux/pci.h | 5 +++++ 2 files changed, 24 insertions(+), 5 deletions(-)Index:
linux-2.6/drivers/pci/msi.c
===================================================================drivers/pci/msi.c +18
-2@@ -670,6 +670,23 @@ static int msi_free_irqs(struct pci_dev* }/** +* pci_msix_table_size - return the number of device's MSI-X table entries +* @dev: pointer to the pci_dev data structure of MSI-X device function +*/ +int pci_msix_table_size (struct pci_dev *dev) +{ +int pos; +u16 control; + + pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); +if (!pos) +return 0 ; + +pci_read_config_word (dev,msi_control_reg (pos), &control); +return multi_msix_capable (control); +} + +/** * pci_enable_msix - configure device's MSI-X capability structure * @dev: pointer to the pci_dev data structure of MSI-X device function * @entries: pointer to an array of MSI-X entries @@ -686,9 +703,8 @@ static int msi_free_irqs(struct pci_dev***/ int pci_enable_msix (struct pci_dev * dev,struct msix_entry *entries,int nvec) { -int status, pos, nr_entries; +int status, nr_entries;int i, j; -u16 control;if (!entries)return -EINVAL ;@@ -697,9 +713,7 @@ int pci_enable_msix(struct pci_dev* dev,if (status)return status;
Quoted 9 lines
drivers/pci/msi.c int pci_enable_msix(struct pci_dev* dev, · line 718
Quoted 6 lines
drivers/pci/msi.c +1
-3- pos =pci_find_capability (dev,PCI_CAP_ID_MSIX ); -pci_read_config_word (dev,msi_control_reg (pos), &control); - nr_entries =multi_msix_capable (control); + nr_entries =pci_msix_table_size (dev);if (nvec > nr_entries)return -EINVAL ;I see similar code in
msix_capability_init(), although it still needs pos. Did you deliberately not replace that, or just miss it?
I didn't replace it exactly because it required the pos anyway.
Thanks,
Rafael
Re: [PATCH PCI PCIe portdrv: Fix allocation of interrupts (rev. 5)
In reply to Hidetoshi SetoQuoted 10 lines · Hidetoshi Seto
Quoted 1 line · Rafael J. Wysocki
On Saturday 17 January 2009, Rafael J. Wysocki wrote:
(snip)
Quoted 7 lines
Quoted 3 lines
If MSI-X are supported, it allocates as many vectors as there are entries in the port's MSI-X table, but no more than 32, and figures out which of them will be used for the port services.
The patch didn't check which services are available during the MSI-X set up which was wrong.
Quoted 7 lines
Quoted 7 lines
Also, in the meantime, i thought it might be a good idea to free the interrupt routing table entries that aren't going to be used after all.
The patch below adds this to the previous version and checks for the availability of port services in the MSI-X setup resume. I hope it will be acceptable to everyone.
[--snip--]
Quoted 11 lines
drivers/pci/pcie/portdrv_core.c static void release_pcie_device(struct d · line 85
Quoted 6 lines
drivers/pci/pcie/portdrv_core.c +6
-0+/* +* Allocate as many entries as the device wants temporarily, so that we +* can check which of them will be useful. +*/ +for (i =0 ; i < nr_entries; i++) + msix_entries[i].entry = i;/* * So, if msix_entries is correctly equal to the number of entries this * port actually uses, we'll happily go through without using trick. */
Good point!
Quoted 4 lines
drivers/pci/pcie/portdrv_core.c static void release_pcie_device(struct d · line 89
Quoted 4 lines
drivers/pci/pcie/portdrv_core.c +4
-0+ + status =pci_enable_msix (dev, msix_entries, nr_entries); +if (status) + goto Exit;
[--snip--]
Quoted 8 lines
Quoted 1 line
+
/* Are there any unused entries? */
if (nr_allocated > nvec) { /* this port have extra entries not for services we know... */Review
Quoted 2 lines
(quoted diff) +2
-0+ /* Drop the temporary MSI-X setup */ + pci_disable_msix(dev);
Yes, I'm going to do that.
Quoted 5 lines
drivers/pci/pcie/portdrv_core.c static void release_pcie_device(struct d · line 154
Quoted 4 lines
drivers/pci/pcie/portdrv_core.c +4
-0+/* Now allocate the MSI-X vectors for real */ + status =pci_enable_msix (dev, msix_entries, nvec); +if (status) + goto Error;
Quoted 7 lines
/*
* World have broken hardwares, so even spec says numbers are constant,
* it would be better to re-check registers after 2ndpci_enable_msix.
* Or we just skip this. (However this was what your concern, Rafael?) */
if (func_foo_do_paranoia_check(dev, msix_entries, nvec))
goto Error;
Well, I think let's not do it for now. If there's a system that actually breaks here, then we can introduce the extra checking.
Thanks,
Rafael
Re: [PATCH PCI PCIe portdrv: Fix allocation of interrupts (rev. 5)
Rafael J. Wysocki wrote:
[snip]
Quoted 11 lines
Quoted 7 lines
/*
* World have broken hardwares, so even spec says numbers are constant,
* it would be better to re-check registers after 2ndpci_enable_msix.
* Or we just skip this. (However this was what your concern, Rafael?) */
if (func_foo_do_paranoia_check(dev, msix_entries, nvec))
goto Error;Well, I think let's not do it for now. If there's a system that actually breaks here, then we can introduce the extra checking.
Agreed.
Thanks,
Kenji Kaneshige