Btrfs: check return value for kthread_run() correctly
PATCH 1/1 Btrfs: check return value for kthread_run() correctly
kthread_run() returns the kthread or ERR_PTR(-ENOMEM), not NULL.
Signed-off-by Qinghuang Feng <[email protected]>
---
fs/btrfs/disk-io.c +2 -2
@@ -1740,13 +1740,13 @@ struct btrfs_root *open_ctree(struct super_block *sb, fs_info->system_alloc_profile = fs_info->metadata_alloc_profile; fs_info->cleaner_kthread =kthread_run (cleaner_kthread, tree_root,"btrfs-cleaner" ); -if (!fs_info->cleaner_kthread) +if (IS_ERR (fs_info->cleaner_kthread)) goto fail_csum_root; fs_info->transaction_kthread =kthread_run (transaction_kthread, tree_root,"btrfs-transaction" ); -if (!fs_info->transaction_kthread) +if (IS_ERR (fs_info->transaction_kthread)) goto fail_cleaner;if (btrfs_super_log_root (disk_super) !=0 ) {
Quoted 2 lines · Qinghuang Feng
kthread_run()returns the kthread orERR_PTR(-ENOMEM), not NULL.
Thanks, got it.
-chris