ath9k: Fix typo in chip version check
PATCH 1/1 ath9k: Fix typo in chip version check
Signed-off-by Vasanthakumar Thiagarajan <[email protected]>
--- drivers/net/wireless/ath9k/hw.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/ath9k/hw.c +1 -1
@@ -2255,7 +2255,7 @@ int ath9k_hw_reset(struct ath_hal *ah, struct ath9k_channel *chan,return -EINVAL ; } -if (AR_SREV_9280 (ah)) { +if (AR_SREV_9280_10_OR_LATER (ah)) {REG_SET_BIT (ah,AR_GPIO_INPUT_EN_VAL ,AR_GPIO_JTAG_DISABLE );
Signature · 1 line
1.5.5.1
PATCH 1/1 ath9k: Fix typo in chip version check
Hello, Vasanthakumar!
Quoted 4 lines · Vasanthakumar Thiagarajan
Signed-off-by Vasanthakumar Thiagarajan <[email protected]>--- drivers/net/wireless/ath9k/hw.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
I'm not a developer of ath9k, and I don't know much about the hardware. However, I think your patch should be better explained.
drivers/net/wireless/ath9k/hw.c int ath9k_hw_reset(struct ath_hal *ah, struct ath9k_channel *chan, · line 2258
Quoted 2 lines
drivers/net/wireless/ath9k/hw.c +1
-1-if (AR_SREV_9280 (ah)) { +if (AR_SREV_9280_10_OR_LATER (ah)) {
It's not a typo. A typo would be something like AR_SREV_9380, that is never defined. Or maybe a message like "foudn AR9280". AR_SREV_9280 is defined and has valid uses. If you think it needs to be changed in this particular case, an explanation is needed. It would be nice if you mentioned that it fixes something for some hardware.
Signature · 2 lines
Regards, Pavel Roskin