Skip to contentSkip to conversation

do_pipe cleanup: drop its last user in arch/alpha/

PATCH In review Cheng Renquan 2 participants 3 messages Jan 24, 2009 – Feb 2, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 do_pipe cleanup: drop its last user in arch/alpha/

The last user of do_pipe is in arch/alpha/, after replacing it with do_pipe_flags, the do_pipe can be eventually dropped.

---
 arch/alpha/kernel/entry.S   |    3 ++-
 arch/alpha/kernel/osf_sys.c |    2 +-
 fs/pipe.c                   |    5 -----
 include/linux/fs.h          |    1 -
 4 files changed, 3 insertions(+), 8 deletions(-)
arch/alpha/kernel/entry.S +2 -1
index aa2e50c..9031eb5 100644
@@ -903,8 +903,9 @@ sys_alpha_pipe:
 	stq	$26, 0($sp)
 	.prologue 0
 
+	mov	$31, $17
 	lda	$16, 8($sp)
-	jsr	$26, do_pipe
+	jsr	$26, do_pipe_flags
 
 	ldq	$26, 0($sp)
 	bne	$0, 1f
arch/alpha/kernel/osf_sys.c +1 -1
index 18a3ea1..5c1678e 100644
@@ -46,7 +46,7 @@
 #include <asm/hwrpb.h>
 #include <asm/processor.h>
 
-extern int do_pipe(int *);
+extern int do_pipe_flags(int *, int);
 
 /*
  * Brk needs to return an error.  Still support Linux's brk(0) query idiom,
fs/pipe.c +0 -5
index 3a48ba5..365120c 100644
@@ -1034,11 +1034,6 @@ int do_pipe_flags(int *fd, int flags)
 	return error;
 }
 
-int do_pipe(int *fd)
-{
-	return do_pipe_flags(fd, 0);
-}
-
 /*
  * sys_pipe() is the normal C calling standard for creating
  * a pipe. It's not the way Unix traditionally does this, though.
include/linux/fs.h +0 -1
index 6022f44..9c0494c 100644
@@ -1875,7 +1875,6 @@ static inline void allow_write_access(struct file *file)
 	if (file)
 		atomic_inc(&file->f_path.dentry->d_inode->i_writecount);
 }
-extern int do_pipe(int *);
 extern int do_pipe_flags(int *, int);
 extern struct file *create_read_pipe(struct file *f, int flags);
 extern struct file *create_write_pipe(int flags);
Signature · 1 line
1.6.0.6
#1 lore raw

PATCH 1/1 add the missing linux alpha port mailling list

---
 MAINTAINERS |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
MAINTAINERS +1 -0
index 3fe4dc2..38e8d09 100644
@@ -357,6 +357,7 @@ S:	Odd Fixes for 2.4; Maintained for 2.6.
 P:	Ivan Kokshaysky
 M:	[email protected]
 S:	Maintained for 2.4; PCI support for 2.6.
+L:	[email protected]
 
 AMD GEODE CS5536 USB DEVICE CONTROLLER DRIVER
 P:	Thomas Dahlmann
Signature · 1 line
1.6.0.6
#2 lore raw
In reply to Cheng Renquan

arch/alpha/kernel/osf_sys.c line 49

Quoted 8 lines · On Sat, 24 Jan 2009 12:43:50 +0800 Cheng Renquan <[email protected]> wrote:
arch/alpha/kernel/osf_sys.c +1 -1
@@ -46,7 +46,7 @@
 #include <asm/hwrpb.h>
 #include <asm/processor.h>
 
-extern int do_pipe(int *);
+extern int do_pipe_flags(int *, int);

From: Andrew Morton <[email protected]>

WARNING: externs should be avoided in .c files #42: FILE: arch/alpha/kernel/osf_sys.c:49:
+extern int do_pipe_flags(int *, int);

total: 0 errors, 1 warnings, 36 lines checked

./patches/do_pipe-drop-its-last-user-in-arch-alpha.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc Al Viro <[email protected]>
Cc Cheng Renquan <[email protected]>
Cc Ivan Kokshaysky <[email protected]>
Cc Jens Axboe <[email protected]>
Cc Richard Henderson <[email protected]>

---

 arch/alpha/kernel/osf_sys.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/alpha/kernel/osf_sys.c renamed from arch/alpha/kernel/osf_sys.c~do_pipe-drop-its-last-user-in-arch-alpha-checkpatch-fixes +1 -2
diff -puN arch/alpha/kernel/osf_sys.c~do_pipe-drop-its-last-user-in-arch-alpha-checkpatch-fixes arch/alpha/kernel/osf_sys.c
@@ -14,6 +14,7 @@
 #include <linux/sched.h>
 #include <linux/kernel.h>
 #include <linux/mm.h>
+#include <linux/fs.h>
 #include <linux/smp.h>
 #include <linux/smp_lock.h>
 #include <linux/stddef.h>
@@ -46,8 +47,6 @@
 #include <asm/hwrpb.h>
 #include <asm/processor.h>
 
-extern int do_pipe_flags(int *, int);
-
 /*
  * Brk needs to return an error.  Still support Linux's brk(0) query idiom,
  * which OSF programs just shouldn't be doing.  We're still not quite

_

OK?