Skip to contentSkip to conversation

Fix cpu_arm_handle_mmu_fault warning

PATCH Applied Nathan Froyd 2 participants 2 messages Jan 27, 2009 – Feb 7, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix cpu_arm_handle_mmu_fault warning

This patch fixes:

/scratch/froydnj/qemu.git/target-arm/helper.c:451: warning: no previous prototype for 'cpu_arm_handle_mmu_fault'

by moving the declaration of the function to cpu.h from exec.h. cpu.h seems to be the place most other ports declare the corresponding function.

---
 target-arm/cpu.h  |    2 ++
 target-arm/exec.h |    3 ---
 2 files changed, 2 insertions(+), 3 deletions(-)
target-arm/cpu.h +2 -0
index 54c2c2e..cab80cd 100644
@@ -217,6 +217,8 @@ uint32_t do_arm_semihosting(CPUARMState *env);
    is returned if the signal was handled by the virtual CPU.  */
 int cpu_arm_signal_handler(int host_signum, void *pinfo,
                            void *puc);
+int cpu_arm_handle_mmu_fault (CPUARMState *env, target_ulong address, int rw,
+                              int mmu_idx, int is_softmuu);
 
 void cpu_lock(void);
 void cpu_unlock(void);
target-arm/exec.h +0 -3
index b70e0cb..3e4083a 100644
@@ -37,9 +37,6 @@ static inline void regs_to_env(void)
 {
 }
 
-int cpu_arm_handle_mmu_fault (CPUState *env, target_ulong address, int rw,
-                              int mmu_idx, int is_softmmu);
-
 static inline int cpu_halted(CPUState *env) {
     if (!env->halted)
         return 0;
Signature · 1 line
1.6.0.5
#1 lore raw
Quoted 4 lines · Nathan Froyd

This patch fixes:

/scratch/froydnj/qemu.git/target-arm/helper.c:451: warning: no previous prototype for 'cpu_arm_handle_mmu_fault'

Quoted 8 lines

by moving the declaration of the function to cpu.h from exec.h. cpu.h seems to be the place most other ports declare the corresponding function.

---
 target-arm/cpu.h  |    2 ++
 target-arm/exec.h |    3 ---
 2 files changed, 2 insertions(+), 3 deletions(-)

Thanks, applied.

Quoted 33 lines
target-arm/cpu.h +2 -0
index 54c2c2e..cab80cd 100644
@@ -217,6 +217,8 @@ uint32_t do_arm_semihosting(CPUARMState *env);
    is returned if the signal was handled by the virtual CPU.  */
 int cpu_arm_signal_handler(int host_signum, void *pinfo,
                            void *puc);
+int cpu_arm_handle_mmu_fault (CPUARMState *env, target_ulong address, int rw,
+                              int mmu_idx, int is_softmuu);
 
 void cpu_lock(void);
 void cpu_unlock(void);
target-arm/exec.h +0 -3
index b70e0cb..3e4083a 100644
@@ -37,9 +37,6 @@ static inline void regs_to_env(void)
 {
 }
 
-int cpu_arm_handle_mmu_fault (CPUState *env, target_ulong address, int rw,
-                              int mmu_idx, int is_softmmu);
-
 static inline int cpu_halted(CPUState *env) {
     if (!env->halted)
         return 0;
Signature · 1 line
1.6.0.5
Signature · 2 lines
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
[email protected]                 http://www.aurel32.net