Skip to contentSkip to conversation

fix verification of memory area

STAGING Applied Roel Kluin 2 participants 2 messages Jan 28, 2009 Staging

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

fix verification of memory area

---

drivers/staging/poch/poch.c +1 -1
index ec343ef..0d111dd 100644
@@ -1026,7 +1026,7 @@ static int poch_ioctl(struct inode *inode, struct file *filp,
 		}
 		break;
 	case POCH_IOC_GET_COUNTERS:
-		if (access_ok(VERIFY_WRITE, argp, sizeof(struct poch_counters)))
+		if (!access_ok(VERIFY_WRITE, argp, sizeof(struct poch_counters)))
 			return -EFAULT;
 
 		spin_lock_irq(&channel->counters_lock);
#1 lore raw

patch staging-poch-fix-verification-of-memory-area.patch added to gregkh-2.6 tree

This is a note to let you know that I've just added the patch titled

Subject: Staging: poch: fix verification of memory area

to my gregkh-2.6 tree. Its filename is

staging-poch-fix-verification-of-memory-area.patch

This tree can be found at
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/

Quoted 1 line

From [email protected] Wed Jan 28 14:00:58 2009

From: Roel Kluin <[email protected]>
Date: Wed, 28 Jan 2009 22:14:17 +0100
Subject: Staging: poch: fix verification of memory area
To: Greg KH <[email protected]>
Cc: lkml <[email protected]>
Message-ID: <[email protected]>

fix verification of memory area

---
 drivers/staging/poch/poch.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/poch/poch.c +1 -1
@@ -1026,7 +1026,7 @@ static int poch_ioctl(struct inode *inod
 		}
 		break;
 	case POCH_IOC_GET_COUNTERS:
-		if (access_ok(VERIFY_WRITE, argp, sizeof(struct poch_counters)))
+		if (!access_ok(VERIFY_WRITE, argp, sizeof(struct poch_counters)))
 			return -EFAULT;
 
 		spin_lock_irq(&channel->counters_lock);

Patches currently in gregkh-2.6 which might be from [email protected] are

usb.current/usb-gadget-fix-x-y.patch staging/staging-meilhaus-unsigned-won-t-get-negative-after-subtraction.patch staging/staging-otus-logical-bit-and-confusion.patch staging/staging-usbip-usbip_start_threads-handle-kernel_thread-failure.patch staging/staging-poch-fix-verification-of-memory-area.patch