Skip to contentSkip to conversation

blacklist Powercom USB UPS in hid

PATCH Applied Michael Tokarev 2 participants 2 messages Jan 31, 2009 – Feb 1, 2009 HID

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 blacklist Powercom USB UPS in hid

This is my second attempt to fix the thing. Now completely tested and appears to work as expected, finally (I hope anyway).

For quite some time users with various UPSes from Powercom were forced to play magic with bind/unbind in /sys in order to be able to see the UPSes. The beasts does not work as HID devices, even if claims to do so. cypress_m8 driver works with the devices instead, creating a normal serial port with which normal UPS controlling software works.

The manufacturer confirmed the upcoming models with proper HID support will have different device IDs. In any way, it's wrong to have two completely different modules for one device in kernel.

Blacklist the device in HID (add it to hid_ignore_list) to stop this mess, finally.

drivers/hid/hid-ids.h +4 -0
index acc1abc..8beb9bd 100644
@@ -348,6 +348,10 @@
 #define USB_VENDOR_ID_PLAYDOTCOM	0x0b43
 #define USB_DEVICE_ID_PLAYDOTCOM_EMS_USBII	0x0003
 
+/* Powercom UPS which is not HID but Serial<=>USB converter (cypress_m8 module) */
+#define USB_VENDOR_ID_POWERCOM		0x0d9f
+#define USB_DEVICE_ID_POWERCOM_UPS	0x0002
+
 #define USB_VENDOR_ID_SAITEK		0x06a3
 #define USB_DEVICE_ID_SAITEK_RUMBLEPAD	0xff17
 
drivers/hid/hid-core.c +1 -0
index 5d7640e..db03ca5 100644
@@ -1605,2 +1605,3 @@ static const struct hid_device_id hid_ignore_list[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_PANJIT, 0x0004) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_POWERCOM, USB_DEVICE_ID_POWERCOM_UPS) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_SOUNDGRAPH, USB_DEVICE_ID_SOUNDGRAPH_IMON_LCD) },
Applied
#1 lore raw
Quoted 2 lines · Michael Tokarev

This is my second attempt to fix the thing. Now completely tested and appears to work as expected, finally (I hope anyway).

General remark -- when submitting patches for certain kernel subsystem, it's always good idead to CC the corresponding maitainer, to avoid having the patches lost.

drivers/hid/hid-ids.h line 354

Quoted 4 lines
drivers/hid/hid-ids.h +4 -0
+/* Powercom UPS which is not HID but Serial<=>USB converter (cypress_m8 module) */
+#define USB_VENDOR_ID_POWERCOM		0x0d9f
+#define USB_DEVICE_ID_POWERCOM_UPS	0x0002
+

I have removed this comment, as we don't have it for any other entries in that file either. The changelog should be always enought to provide the information for those curious.

Applied, thanks Michael.

Signature · 2 lines
Jiri Kosina
SUSE Labs