Skip to contentSkip to conversation

mfd/htc-egpio: fix iomem resource handling using resource_size

PATCH Applied Philipp Zabel 2 participants 2 messages Jan 31, 2009 – Feb 6, 2009 Multifunction devices (MFD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd/htc-egpio: fix iomem resource handling using resource_size

Fixes an off-by-one error in the iomem resource mapping.

---
 drivers/mfd/htc-egpio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/htc-egpio.c +1 -1
index 1a4d046..e9b0745 100644
@@ -286,7 +286,7 @@ static int __init egpio_probe(struct platform_device *pdev)
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (!res)
 		goto fail;
-	ei->base_addr = ioremap_nocache(res->start, res->end - res->start);
+	ei->base_addr = ioremap_nocache(res->start, resource_size(res));
 	if (!ei->base_addr)
 		goto fail;
 	pr_debug("EGPIO phys=%08x virt=%p\n", (u32)res->start, ei->base_addr);
Signature · 1 line
1.5.6.5
Applied
#1 lore raw
Quoted 1 line · Philipp Zabel

Fixes an off-by-one error in the iomem resource mapping.

Applied to my for-linus branch. Will Send a pull request to Linus soon. Thanks a lot.

Cheers,
Samuel.

Quoted 21 lines
---
 drivers/mfd/htc-egpio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/htc-egpio.c +1 -1
index 1a4d046..e9b0745 100644
@@ -286,7 +286,7 @@ static int __init egpio_probe(struct platform_device *pdev)
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (!res)
 		goto fail;
-	ei->base_addr = ioremap_nocache(res->start, res->end - res->start);
+	ei->base_addr = ioremap_nocache(res->start, resource_size(res));
 	if (!ei->base_addr)
 		goto fail;
 	pr_debug("EGPIO phys=%08x virt=%p\n", (u32)res->start, ei->base_addr);
Signature · 1 line
1.5.6.5
Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/