Skip to contentSkip to conversation

xfstests: Fix *FLAGS passing and dependencies.

PATCH In review Arkadiusz Miśkiewicz 2 participants 2 messages Feb 2, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: Fix *FLAGS passing and dependencies.

Pass *FLAGS in some targets.

Drop LIBHANDLE, LIBATTR and LIBACL from deps since there are in form "-llibrary".

---
 src/Makefile |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
src/Makefile +6 -6
index ad4c204..634e1b3 100644
@@ -58,10 +58,10 @@ genhashnames: genhashnames.o
 nametest: nametest.o $(LIBTEST)
 	$(LINKTEST) $(LIBTEST) $(LDLIBS)
 
-bstat: bstat.o $(LIBHANDLE)
+bstat: bstat.o
 	$(LINKTEST) $(LIBHANDLE) $(LDLIBS)
 
-t_immutable: t_immutable.o $(LIBHANDLE) $(LIBACL)
+t_immutable: t_immutable.o
 	$(LINKTEST) $(LIBACL) $(LIBHANDLE) $(LDLIBS)
 
 loggen:	loggen.o
@@ -82,17 +82,17 @@ multi_open_unlink: multi_open_unlink.o
 #scaleread: scaleread.o $(LDLIBS)
 #	$(LINKTEST)
 
-acl_get: acl_get.o $(LIBACL) $(LIBATTR)
+acl_get: acl_get.o
 	$(LINKTEST) $(LIBACL) $(LIBATTR) $(LDLIBS)
 
-dmiperf: dmiperf.o $(LIBATTR)
+dmiperf: dmiperf.o
 	$(LINKTEST) $(LIBATTR) $(LDLIBS)
 
 preallo_rw_pattern_reader:
-	$(CC) -DREAD iopat.c -o preallo_rw_pattern_reader
+	$(CC) $(GCFLAGS) $(LDFLAGS) -DREAD iopat.c -o preallo_rw_pattern_reader
 
 preallo_rw_pattern_writer:
-	$(CC) -DWRITE iopat.c -o preallo_rw_pattern_writer
+	$(CC) $(GCFLAGS) $(LDFLAGS) -DWRITE iopat.c -o preallo_rw_pattern_writer
 
 ftrunc: ftrunc.o
 	$(LINKTEST)
Signature · 1 line
1.6.1.1

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw
Quoted 4 lines · Arkadiusz Miśkiewicz

Pass *FLAGS in some targets.

Drop LIBHANDLE, LIBATTR and LIBACL from deps since there are in form "-llibrary".

ugh, weird.

Quoted 2 lines

Looks fine to me. I'll merge it to the kernel.org repo.

-Eric

Quoted 47 lines
---
 src/Makefile |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
src/Makefile +6 -7
index ad4c204..634e1b3 100644
@@ -58,10 +58,10 @@ genhashnames: genhashnames.o
 nametest: nametest.o $(LIBTEST)
 	$(LINKTEST) $(LIBTEST) $(LDLIBS)
 
-bstat: bstat.o $(LIBHANDLE)
+bstat: bstat.o
 	$(LINKTEST) $(LIBHANDLE) $(LDLIBS)
 
-t_immutable: t_immutable.o $(LIBHANDLE) $(LIBACL)
+t_immutable: t_immutable.o
 	$(LINKTEST) $(LIBACL) $(LIBHANDLE) $(LDLIBS)
 
 loggen:	loggen.o
@@ -82,17 +82,17 @@ multi_open_unlink: multi_open_unlink.o
 #scaleread: scaleread.o $(LDLIBS)
 #	$(LINKTEST)
 
-acl_get: acl_get.o $(LIBACL) $(LIBATTR)
+acl_get: acl_get.o
 	$(LINKTEST) $(LIBACL) $(LIBATTR) $(LDLIBS)
 
-dmiperf: dmiperf.o $(LIBATTR)
+dmiperf: dmiperf.o
 	$(LINKTEST) $(LIBATTR) $(LDLIBS)
 
 preallo_rw_pattern_reader:
-	$(CC) -DREAD iopat.c -o preallo_rw_pattern_reader
+	$(CC) $(GCFLAGS) $(LDFLAGS) -DREAD iopat.c -o preallo_rw_pattern_reader
 
 preallo_rw_pattern_writer:
-	$(CC) -DWRITE iopat.c -o preallo_rw_pattern_writer
+	$(CC) $(GCFLAGS) $(LDFLAGS) -DWRITE iopat.c -o preallo_rw_pattern_writer
 
 ftrunc: ftrunc.o
 	$(LINKTEST)
 
 
------------------------------------------------------------------------
Quoted 4 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs