Skip to contentSkip to conversation

Perf test 7 fails on s390 since 6.12.0

DISCUSSION Thomas Richter 3 participants 4 messages Dec 2, 2024 – Dec 4, 2024

lore
Share & tools
lore

Thomas Richter

author Acked-by Namhyung Kim
#0 lore raw

I just downloaded the latest kernel tree 6.13.0rc1 and observed several failures of the perf test suite.

This test case is the first one:

# ./perf test -F 7
Unrecognized literal '#system_tsc_freq'  7: Simple expression parser  : FAILED!
# 
# ./perf test -Fvv 7
--- start ---
Using CPUID IBM,9175,705,ME1,3.8,002f
parsing metric: 1+1
parsing metric: FOO+BAR
lookup(FOO): val 1.000000
lookup(BAR): val 2.000000
...

parsing metric: #num_cpus
literal: #num_cpus = 8.000000
parsing metric: #num_cores
literal: #num_cores = 4.000000
parsing metric: #num_dies
literal: #num_dies = 0.000000
parsing metric: #num_packages
literal: #num_packages = 1.000000
parsing metric: #system_tsc_freq
Unrecognized literal '#system_tsc_freq'literal: #system_tsc_freq = nan FAILED tests/expr.c:252 #system_tsc_freq == 0
---- end ----
7: Simple expression parser : FAILED!
[root@b83lp65 perf]#

I bisectred this to

# git bisect good
609aa2667f67c1588d4e741110265f74b7713177 is the first bad commit
commit 609aa2667f67c1588d4e741110265f74b7713177
Author: Ian Rogers <[email protected]>
Date:   Tue Oct 1 20:20:12 2024 -0700

perf tool_pmu: Switch to standard pmu functions and json descriptions

Use the regular PMU approaches with tool json events to reduce the amount of special tool_pmu code - tool_pmu__config_terms and tool_pmu__for_each_event_cb are removed. Some functions remain, like tool_pmu__str_to_event, as conveniences to metricgroups. Add tool_pmu__skip_event/tool_pmu__num_skip_events to handle the case that tool json events shouldn't appear on certain architectures. This isn't done in jevents.py due to complexity in the empty-pmu-events.c and when all vendor json is built into the tool.

Note this test used to work before on s390.
It now also fails on the 6.13.0-rc1.

Any hints on how to fix this? Thanks.

Signature · 9 lines
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
IBM Deutschland Research & Development GmbH

Vorsitzender des Aufsichtsrats: Wolfgang Wendt

Geschäftsführung: David Faller

Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294
#1 lore raw
Quoted 7 lines · Thomas Richter

I just downloaded the latest kernel tree 6.13.0rc1 and observed several failures of the perf test suite.

This test case is the first one:

# ./perf test -F 7
Unrecognized literal '#system_tsc_freq'  7: Simple expression parser  : FAILED!
#

Hi Thomas,

Did you see this thread: https://lore.kernel.org/linux-perf-users/[email protected]/

Is that related to your issue? I looked but I couldn't find a V2 from Athira.

The same test was also mentioned on "[GIT PULL] perf-tools changes for v6.13", but I can't tell if it's the same type of failure or not.

James

Quoted 55 lines
# ./perf test -Fvv 7
--- start ---
Using CPUID IBM,9175,705,ME1,3.8,002f
parsing metric: 1+1
parsing metric: FOO+BAR
lookup(FOO): val 1.000000
lookup(BAR): val 2.000000
...

parsing metric: #num_cpus
literal: #num_cpus = 8.000000
parsing metric: #num_cores
literal: #num_cores = 4.000000
parsing metric: #num_dies
literal: #num_dies = 0.000000
parsing metric: #num_packages
literal: #num_packages = 1.000000
parsing metric: #system_tsc_freq
Unrecognized literal '#system_tsc_freq'literal: #system_tsc_freq = nan FAILED tests/expr.c:252 #system_tsc_freq == 0
---- end ----
7: Simple expression parser : FAILED!
[root@b83lp65 perf]#

I bisectred this to

# git bisect good
609aa2667f67c1588d4e741110265f74b7713177 is the first bad commit
commit 609aa2667f67c1588d4e741110265f74b7713177
Author: Ian Rogers <[email protected]>
Date:   Tue Oct 1 20:20:12 2024 -0700

perf tool_pmu: Switch to standard pmu functions and json descriptions

Use the regular PMU approaches with tool json events to reduce the amount of special tool_pmu code - tool_pmu__config_terms and tool_pmu__for_each_event_cb are removed. Some functions remain, like tool_pmu__str_to_event, as conveniences to metricgroups. Add tool_pmu__skip_event/tool_pmu__num_skip_events to handle the case that tool json events shouldn't appear on certain architectures. This isn't done in jevents.py due to complexity in the empty-pmu-events.c and when all vendor json is built into the tool.

Note this test used to work before on s390.
It now also fails on the 6.13.0-rc1.

Any hints on how to fix this? Thanks.

#2 lore raw

Hello,

Quoted 11 lines · James Clark
Quoted 7 lines · Thomas Richter

I just downloaded the latest kernel tree 6.13.0rc1 and observed several failures of the perf test suite.

This test case is the first one:

# ./perf test -F 7
Unrecognized literal '#system_tsc_freq'  7: Simple expression parser  : FAILED!
#
Quoted 6 lines

Hi Thomas,

Did you see this thread: https://lore.kernel.org/linux-perf-users/[email protected]/

Is that related to your issue? I looked but I couldn't find a V2 from Athira.

Oh, I missed this one. I'll take a look again and let Athira proceed.

Quoted 3 lines

The same test was also mentioned on "[GIT PULL] perf-tools changes for v6.13", but I can't tell if it's the same type of failure or not.

I suspect it's the same issue.

Thanks,
Namhyung

author Tested-by
#3 lore raw
In reply to James Clark
Quoted 13 lines · James Clark
Quoted 7 lines · Thomas Richter

I just downloaded the latest kernel tree 6.13.0rc1 and observed several failures of the perf test suite.

This test case is the first one:

# ./perf test -F 7
Unrecognized literal '#system_tsc_freq'  7: Simple expression parser  : FAILED!
#

Hi Thomas,

Quoted 9 lines

Did you see this thread: https://lore.kernel.org/linux-perf-users/[email protected]/

Is that related to your issue? I looked but I couldn't find a V2 from Athira.

The same test was also mentioned on "[GIT PULL] perf-tools changes for v6.13", but I can't tell if it's the same type of failure or not.

James

Thanks James,

yes it is the same issue. I applied above mentioned fix and it works again:

# ./perf test -Fvv 7# ./perf test -Fv 7
--- start ---
Using CPUID IBM,3931,704,A01,3.7,002f
division by zero
syntax error
---- end ----
  7: Simple expression parser                                        : Ok
#

For s390 you have my

Signature · 9 lines
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
IBM Deutschland Research & Development GmbH

Vorsitzender des Aufsichtsrats: Wolfgang Wendt

Geschäftsführung: David Faller

Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294