Skip to contentSkip to conversation

include qemu-kvm.h at all cases.

PATCH Applied Glauber Costa 3 participants 3 messages Feb 12, 2009 – Feb 17, 2009 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 include qemu-kvm.h at all cases.

We don't have any kind of kvm support for linux-user targets, but conditionalizing the inclusion of kvm header make linux-user compilation break. And we don't have a reason to prevent that, do we?

---
 qemu/gdbstub.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
qemu/gdbstub.c +1 -1
index c4d4361..a23e916 100644
@@ -33,8 +33,8 @@
 #include "qemu-char.h"
 #include "sysemu.h"
 #include "gdbstub.h"
-#include "qemu-kvm.h"
 #endif
+#include "qemu-kvm.h"
 
 #define MAX_PACKET_LENGTH 4096
 
Signature · 1 line
1.5.6.5
#1 lore raw
Quoted 4 lines · Glauber Costa

We don't have any kind of kvm support for linux-user targets,
but conditionalizing the inclusion of kvm header make linux-user compilation break. And we don't have a reason to prevent that, do we?

Ack, again, same problem here. The lack of inclusion of this header breaks the build of kvm-84 for the Ubuntu package.

:-Dustin

Applied
#2 lore raw
In reply to Glauber Costa
Quoted 5 lines · Glauber Costa

We don't have any kind of kvm support for linux-user targets, but conditionalizing the inclusion of kvm header make linux-user compilation break. And we don't have a reason to prevent that, do we?

Applied, thanks.

Signature · 2 lines
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.