smsc9420: fix another postfixed timeout
Subsystems (2)
PATCH 1/1 smsc9420: fix another postfixed timeout
Roel Kluin recently fixed several instances where variables reach -1, but 0 is tested afterwards. This patch fixes another, so the timeout will be correctly detected and a warning printed.
Signed-off-by Steve Glendinning <[email protected]>
--- drivers/net/smsc9420.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/smsc9420.c +1 -1
@@ -341,7 +341,7 @@ static int smsc9420_eeprom_send_cmd(struct smsc9420_pdata *pd, u32 op)do {msleep (1 ); e2cmd =smsc9420_reg_read (pd,E2P_CMD ); - }while ((e2cmd &E2P_CMD_EPC_BUSY_ ) && (timeout--)); + }while ((e2cmd &E2P_CMD_EPC_BUSY_ ) && (--timeout));if (!timeout) {smsc_info (HW ,"TIMED OUT" );
Signature · 1 line
1.6.0.6
From: Steve Glendinning <[email protected]>
Date: Mon, 16 Feb 2009 07:46:06 +0000
Quoted 5 lines
Roel Kluin recently fixed several instances where variables reach -1, but 0 is tested afterwards. This patch fixes another, so the timeout will be correctly detected and a warning printed.
Signed-off-by Steve Glendinning <[email protected]>
Applied.