Skip to contentSkip to conversation

kernel: add -D__CHECK_ENDIAN__ by default

RFC PATCH In review Harvey Harrison 2 participants 2 messages Feb 18, 2009 – Feb 19, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 kernel: add -D__CHECK_ENDIAN__ by default

The noise level with endian checking is getting to the point where having this enabled by default wouldn't be too bad. If this were to go in for the 2.6.30 devel cycle it may motivate the last sections that are still particularly noisy (sound/, drivers/scsi/ come to mind)

---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Makefile +1 -1
index 96628d0..4d4e400 100644
@@ -326,7 +326,7 @@ PERL		= perl
 CHECK		= sparse
 
 CHECKFLAGS     := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ \
-		  -Wbitwise -Wno-return-void $(CF)
+		  -D__CHECK_ENDIAN__ -Wbitwise -Wno-return-void $(CF)
 MODFLAGS	= -DMODULE
 CFLAGS_MODULE   = $(MODFLAGS)
 AFLAGS_MODULE   = $(MODFLAGS)
Signature · 1 line
1.6.2.rc1.175.g96b8a
#1 lore raw
Quoted 4 lines · Harvey Harrison

The noise level with endian checking is getting to the point where having this enabled by default wouldn't be too bad. If this were to go in for the 2.6.30 devel cycle it may motivate the last sections that are still particularly noisy (sound/, drivers/scsi/ come to mind)

In which case you should juse kill the CHECK_ENDIAN ifdef and make the checking versions the default. Also Documentation/sparse.txt needs some updates for this change.