Skip to contentSkip to conversation

mmc: add MODALIAS linkage for MMC/SD devices

PATCH Applied Andy Whitcroft 2 participants 3 messages Feb 23, 2009 – Mar 2, 2009 1 message not in the archive MMC, SD and SDIO

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 mmc: add MODALIAS linkage for MMC/SD devices

[Pierre, here is the updated version. Got lost somewhere after testing and before sending out.]

Currently we are using an explicit udev rule to trigger loading of the mmc-block module when an MMC or SD card is detected:

    SUBSYSTEM=="mmc", RUN+="/sbin/modprobe -Qba mmc-block"

It makes much more sense for the mmc bus driver and the mmc-block module to share MODALIAS information so that they are linked automatically.

There is no real information of use in the MMC system at the current time. All devices inserted require us to load the mmc-block device. Until such time as useful parameters exist simply reflect the module linkage via the module alias below:

mmc:block

---
 drivers/mmc/card/block.c |    2 ++
 drivers/mmc/core/bus.c   |    8 ++++++++
 2 files changed, 10 insertions(+), 0 deletions(-)
drivers/mmc/card/block.c +2 -0
index 513eb09..fe8041e 100644
@@ -41,6 +41,8 @@
 
 #include "queue.h"
 
+MODULE_ALIAS("mmc:block");
+
 /*
  * max 8 partitions per card
  */
drivers/mmc/core/bus.c +8 -0
index f210a8e..bdb165f 100644
@@ -84,6 +84,14 @@ mmc_bus_uevent(struct device *dev, struct kobj_uevent_env *env)
 	}
 
 	retval = add_uevent_var(env, "MMC_NAME=%s", mmc_card_name(card));
+	if (retval)
+		return retval;
+
+	/*
+	 * Request the mmc_block device.  Note: that this is a direct request
+	 * for the module it carries no information as to what is inserted.
+	 */
+	retval = add_uevent_var(env, "MODALIAS=mmc:block");
 
 	return retval;
 }
Signature · 1 line
1.6.1.2.419.g0d87e
#2 lore raw
Quoted 16 lines · On Mon, 23 Feb 2009 12:38:41 +0000 Andy Whitcroft <[email protected]> wrote:

[Pierre, here is the updated version. Got lost somewhere after testing and before sending out.]

Currently we are using an explicit udev rule to trigger loading of the mmc-block module when an MMC or SD card is detected:

    SUBSYSTEM=="mmc", RUN+="/sbin/modprobe -Qba mmc-block"

It makes much more sense for the mmc bus driver and the mmc-block module to share MODALIAS information so that they are linked automatically.

There is no real information of use in the MMC system at the current time. All devices inserted require us to load the mmc-block device. Until such time as useful parameters exist simply reflect the module linkage via the module alias below:

Quoted 4 lines

mmc:block

---

Queued, thanks.

Rgds

Signature · 9 lines
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.
#3 lore raw

cover mmc-modalias-v2r1

In reply to a message not in the archive

*** BLURB HERE ***

Andy Whitcroft (1):
mmc: add MODALIAS linkage for MMC/SD devices

 drivers/mmc/card/block.c |    2 ++
 drivers/mmc/core/bus.c   |    8 ++++++++
 2 files changed, 10 insertions(+), 0 deletions(-)