Skip to contentSkip to conversation

spidev: do not reference spidev_remove using __devexit_p

PATCH New Wolfgang Ocker 1 participant 1 message Feb 24, 2009 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spidev: do not reference spidev_remove using __devexit_p

This patch removes the usage of __devexit_p() for spidev_remove() in the definition of struct spi_driver spidev_spi.

This causes a kernel oops if the master driver is removed and reinserted in case spidev is builtin.

---
linux-2.6.28.6/drivers/spi/spidev.c.fix_spidev_remove 2009-02-17 18:29:27.000000000 +0100
+++ linux-2.6.28.6/drivers/spi/spidev.c 2009-02-24 13:30:07.000000000 +0100
@@ -633,7 +633,7 @@ static struct spi_driver spidev_spi = {
.owner = THIS_MODULE,
},
.probe = spidev_probe,
- .remove = __devexit_p(spidev_remove),
+ .remove = spidev_remove,

/* NOTE: suspend/resume methods are not necessary here.
* We don't do anything except pass the requests to/from

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H