Skip to contentSkip to conversation

add the openmoko git kernel stable branch to fso/milestone5

PATCH In review Angus Ainslie 4 participants 8 messages Feb 24, 2009 – Feb 26, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add the openmoko git kernel stable branch to fso/milestone5

Add a recipe for the openmoko git stable kernel branch

---
 conf/distro/include/sane-srcrevs.inc        |    1 +
 packages/linux/linux-openmoko-stable_git.bb |   33 +++++++++++++++++++++++++++
 2 files changed, 34 insertions(+), 0 deletions(-)                             
 create mode 100644 packages/linux/linux-openmoko-stable_git.bb                
conf/distro/include/sane-srcrevs.inc +1 -0
index 4f87639..4c056a8 100644                                                           
@@ -103,6 +103,7 @@ SRCREV_pn-linux-ixp4xx ?= "1085"                                    
 SRCREV_pn-linux-openmoko-2.6.24 ?= "fb42ce6724576fc173faf8abfb04aa2c36d213b7"          
 SRCREV_pn-linux-openmoko-2.6.28 ?= "34240a1c06ae36180dee695aa25bbae869b2aa26"          
 SRCREV_pn-linux-openmoko-devel ?= "498d0953423a504cd24d11a0307e0ec01b81b68d"           
+SRCREV_pn-linux-openmoko-stable ?= "0e5fe639e234cdeb11d8441f19c5b3109a8b6a17"          
 SRCREV_pn-linux-eten ?= "ab2d414f4f13816af0ec0401b608133ca946624a"                     
 SRCREV_pn-llvm-gcc4 ?= "374"                                                           
 SRCREV_pn-llvm-gcc4-cross ?= "374"                                                     
packages/linux/linux-openmoko-stable_git.bb new file +33 -0
new file mode 100644                                                                                  
index 0000000..e5fb71f                                                                                
@@ -0,0 +1,33 @@
+require linux.inc
+require linux-openmoko.inc
+
+DESCRIPTION_${PN} = "Linux ${KERNEL_RELEASE} kernel for the Openmoko Neo GSM Smartphones"
+
+DEFAULT_PREFERENCE = "-1"
+
+KERNEL_RELEASE = "2.6.29-rc3"
+KERNEL_VERSION = "${KERNEL_RELEASE}"
+
+OMV = "stable"
+PV = "${KERNEL_RELEASE}-${OMV}+gitr${SRCREV}"
+PR = "r2"
+
+SRC_URI = "\
+  git://git.openmoko.org/git/kernel.git;protocol=git;branch=stable \
+#  file://defconfig-oe.patch \
+"
+S = "${WORKDIR}/git"
+
+do_configure_prepend() {
+       if [ ${MACHINE} = "om-gta01" ] ; then
+               install -m 644 ./arch/arm/configs/gta01_moredrivers_defconfig ${WORKDIR}/defconfig-oe
+       fi
+       if [ ${MACHINE} = "om-gta02" ] ; then
+               install -m 644 ./arch/arm/configs/gta02_packaging_defconfig ${WORKDIR}/defconfig-oe
+       fi
+       if [ ${MACHINE} = "om-gta03" ] ; then
+               install -m 644 ./arch/arm/configs/gta03_defconfig ${WORKDIR}/defconfig-oe
+       fi
+#      cat ${WORKDIR}/defconfig-oe.patch | patch -p0 -d ${WORKDIR}
+}
+

--
1.5.6.5

#1 lore raw

packages/linux/linux-openmoko-stable_git.bb line 12

Quoted 5 lines · Angus Ainslie
packages/linux/linux-openmoko-stable_git.bb new file +5 -0
+KERNEL_RELEASE = "2.6.29-rc3"
+KERNEL_VERSION = "${KERNEL_RELEASE}"
+
+OMV = "stable"
+PV = "${KERNEL_RELEASE}-${OMV}+gitr${SRCREV}"

NACK. This violates OEs versioning policy since 2.6.29-rc3 will sort higher than 2.6.29 final.

regards,

Koen

#2 lore raw

Am Dienstag, den 24.02.2009, 20:56 +0100 schrieb Koen Kooi:

Quoted 10 lines · Angus Ainslie

packages/linux/linux-openmoko-stable_git.bb line 12

Quoted 6 lines
packages/linux/linux-openmoko-stable_git.bb new file +5 -0
+KERNEL_RELEASE = "2.6.29-rc3"
+KERNEL_VERSION = "${KERNEL_RELEASE}"
+
+OMV = "stable"
+PV = "${KERNEL_RELEASE}-${OMV}+gitr${SRCREV}"

NACK. This violates OEs versioning policy since 2.6.29-rc3 will sort higher than 2.6.29 final.

Right.

Angus, I'd just keep 2.6.28+whatever. I don't think it's that relevant which rc is the baseline of this version.

If you disagree, just go with 2.6.28+2.6.29rc3.

In general, the format is <stable>+<devel> until <devel> has become final. This (and all the other policies) should be in the Wiki. If not, please alert us and we'll add them.

Cheers,

Signature · 1 line
:M:
#3 lore raw
Quoted 7 lines · Michael 'Mickey' Lauer

In general, the format is <stable>+<devel> until <devel> has become final. This (and all the other policies) should be in the Wiki. If not, please alert us and we'll add them.

Cheers,

I found the policy section and am reading it now. The commit policy still has references to monotone.

http://wiki.openembedded.net/index.php/Commit_Policy

Angus

#5 lore raw
In reply to Koen Kooi
Quoted 7 lines · Koen Kooi

NACK. This violates OEs versioning policy since 2.6.29-rc3 will sort higher than 2.6.29 final.

regards,

Koen

Is this better ?

Thanks
Angus

---
 conf/distro/include/sane-srcrevs.inc        |    1 +
 packages/linux/linux-openmoko-stable_git.bb |   33 +++++++++++++++++++++++++++
 2 files changed, 35 insertions(+), 1 deletions(-)                             
 create mode 100644 packages/linux/linux-openmoko-stable_git.bb                
conf/distro/include/sane-srcrevs.inc +1 -0
index 2f4e913..328e612 100644                                                           
@@ -97,6 +97,7 @@ SRCREV_pn-linux-ixp4xx ?= "1085"                                      
 SRCREV_pn-linux-openmoko-2.6.24 ?= "fb42ce6724576fc173faf8abfb04aa2c36d213b7"          
 SRCREV_pn-linux-openmoko-2.6.28 ?= "34240a1c06ae36180dee695aa25bbae869b2aa26"          
 SRCREV_pn-linux-openmoko-devel ?= "34240a1c06ae36180dee695aa25bbae869b2aa26"           
+SRCREV_pn-linux-openmoko-stable ?= "0e5fe639e234cdeb11d8441f19c5b3109a8b6a17"          
 SRCREV_pn-linux-eten ?= "ab2d414f4f13816af0ec0401b608133ca946624a"                     
 SRCREV_pn-llvm-gcc4 ?= "374"                                                           
 SRCREV_pn-llvm-gcc4-cross ?= "374"                                                     
packages/linux/linux-openmoko-stable_git.bb new file +33 -0
new file mode 100644                                                                                  
index 0000000..a7b74b8                                                                                
@@ -0,0 +1,33 @@
+require linux.inc
+require linux-openmoko.inc
+
+DESCRIPTION_${PN} = "Linux ${KERNEL_RELEASE} kernel for the Openmoko Neo GSM Smartphones"
+
+DEFAULT_PREFERENCE = "-1"
+
+KERNEL_RELEASE = "2.6.29"
+KERNEL_VERSION = "${KERNEL_RELEASE}"
+
+OMV = "stable"
+PV = "${KERNEL_RELEASE}-${OMV}+gitr${SRCREV}"
+PR = "r2"
+
+SRC_URI = "\
+  git://git.openmoko.org/git/kernel.git;protocol=git;branch=stable \
+#  file://defconfig-oe.patch \
+"
+S = "${WORKDIR}/git"
+
+do_configure_prepend() {
+       if [ ${MACHINE} = "om-gta01" ] ; then
+               install -m 644 ./arch/arm/configs/gta01_moredrivers_defconfig ${WORKDIR}/defconfig-oe
+       fi
+       if [ ${MACHINE} = "om-gta02" ] ; then
+               install -m 644 ./arch/arm/configs/gta02_packaging_defconfig ${WORKDIR}/defconfig-oe
+       fi
+       if [ ${MACHINE} = "om-gta03" ] ; then
+               install -m 644 ./arch/arm/configs/gta03_defconfig ${WORKDIR}/defconfig-oe
+       fi
+#      cat ${WORKDIR}/defconfig-oe.patch | patch -p0 -d ${WORKDIR}
+}
+

--
1.5.6.5

#6 lore raw

Round 3 per Mickey's and Koen's sugestions

Angus

---
 conf/distro/include/sane-srcrevs.inc        |    1 +
 packages/linux/linux-openmoko-stable_git.bb |   33 +++++++++++++++++++++++++++
 2 files changed, 35 insertions(+), 1 deletions(-)                             
 create mode 100644 packages/linux/linux-openmoko-stable_git.bb                
conf/distro/include/sane-srcrevs.inc +1 -0
index 2f4e913..328e612 100644                                                           
@@ -97,6 +97,7 @@ SRCREV_pn-linux-ixp4xx ?= "1085"                                      
 SRCREV_pn-linux-openmoko-2.6.24 ?= "fb42ce6724576fc173faf8abfb04aa2c36d213b7"          
 SRCREV_pn-linux-openmoko-2.6.28 ?= "34240a1c06ae36180dee695aa25bbae869b2aa26"          
 SRCREV_pn-linux-openmoko-devel ?= "34240a1c06ae36180dee695aa25bbae869b2aa26"           
+SRCREV_pn-linux-openmoko-stable ?= "0e5fe639e234cdeb11d8441f19c5b3109a8b6a17"          
 SRCREV_pn-linux-eten ?= "ab2d414f4f13816af0ec0401b608133ca946624a"                     
 SRCREV_pn-llvm-gcc4 ?= "374"                                                           
 SRCREV_pn-llvm-gcc4-cross ?= "374"                                                     
packages/linux/linux-openmoko-stable_git.bb new file +33 -0
new file mode 100644                                                                                  
index 0000000..a7b74b8                                                                                
@@ -0,0 +1,33 @@
+require linux.inc
+require linux-openmoko.inc
+
+DESCRIPTION_${PN} = "Linux ${KERNEL_RELEASE} kernel for the Openmoko Neo GSM Smartphones"
+
+DEFAULT_PREFERENCE = "-1"
+
+KERNEL_RELEASE = "2.6.28"
+KERNEL_VERSION = "${KERNEL_RELEASE}"
+
+OMV = "stable"
+PV = "${KERNEL_RELEASE}-${OMV}+gitr${SRCREV}"
+PR = "r2"
+
+SRC_URI = "\
+  git://git.openmoko.org/git/kernel.git;protocol=git;branch=stable \
+#  file://defconfig-oe.patch \
+"
+S = "${WORKDIR}/git"
+
+do_configure_prepend() {
+       if [ ${MACHINE} = "om-gta01" ] ; then
+               install -m 644 ./arch/arm/configs/gta01_moredrivers_defconfig ${WORKDIR}/defconfig-oe
+       fi
+       if [ ${MACHINE} = "om-gta02" ] ; then
+               install -m 644 ./arch/arm/configs/gta02_packaging_defconfig ${WORKDIR}/defconfig-oe
+       fi
+       if [ ${MACHINE} = "om-gta03" ] ; then
+               install -m 644 ./arch/arm/configs/gta03_defconfig ${WORKDIR}/defconfig-oe
+       fi
+#      cat ${WORKDIR}/defconfig-oe.patch | patch -p0 -d ${WORKDIR}
+}
+

--
1.5.6.5

#7 lore raw
Quoted 5 lines · Angus Ainslie

Round 3 per Mickey's and Koen's sugestions

Angus

How long should I wait before I assume that patches have been silently reviewed ?

Thanks
Angus