Skip to contentSkip to conversation

mflash: Initial mflash support

PATCH New unsik Kim 2 participants 2 messages Feb 25, 2009 – Apr 3, 2009

Subsystems (2)
lore
Share & tools
lore

unsik Kim

author
#0 lore raw

PATCH 1/1 mflash: Initial mflash support

Mflash is fusion memory device mainly targeted consumer eletronic and mobile phone.
Internally, it have nand flash and other hardware logics and supports some different operation (ATA, IO, XIP) modes.

IO mode is custom mode for the host that doesn't have IDE interface. (Many mobile targeted SoC doesn't have IDE bus)

This driver support mflash IO mode.

Followings are brief descriptions about IO mode.

1. IO mode based on ATA protocol and uses some custom command. (read confirm, write confirm)
2. IO mode uses SRAM bus interface.

---
This is all-in-one mflash patch. (Whole series of patches were squashed and rebased.) Please, use this if you forgot <[email protected]>.

---
 common/Makefile             |    2 +
 common/cmd_mgdisk.c         |   76 ++++++
 common/cmd_nvedit.c         |    8 +-
 common/env_mgdisk.c         |   92 +++++++
 disk/part.c                 |    8 +-
 disk/part_amiga.c           |    5 +-
 disk/part_dos.c             |    1 +
 disk/part_efi.c             |    1 +
 disk/part_iso.c             |    1 +
 disk/part_mac.c             |    1 +
 doc/README.mflash           |   94 +++++++
 drivers/block/Makefile      |    5 +-
 drivers/block/mg_disk.c     |  582 +++++++++++++++++++++++++++++++++++++++++++
 drivers/block/mg_disk_prv.h |  145 +++++++++++
 fs/fat/fat.c                |    2 +
 include/config_cmd_all.h    |    1 +
 include/environment.h       |   12 +
 include/mg_disk.h           |   51 ++++
 include/part.h              |    1 +
 19 files changed, 1080 insertions(+), 8 deletions(-)
 create mode 100644 common/cmd_mgdisk.c
 create mode 100644 common/env_mgdisk.c
 create mode 100644 doc/README.mflash
 create mode 100644 drivers/block/mg_disk.c
 create mode 100644 drivers/block/mg_disk_prv.h
 create mode 100644 include/mg_disk.h
common/Makefile +2 -0
index f13cd11..72e8b7d 100644
@@ -53,6 +53,7 @@ COBJS-$(CONFIG_ENV_IS_IN_DATAFLASH) += env_dataflash.o
 COBJS-$(CONFIG_ENV_IS_IN_EEPROM) += env_eeprom.o
 COBJS-y += env_embedded.o
 COBJS-$(CONFIG_ENV_IS_IN_FLASH) += env_flash.o
+COBJS-$(CONFIG_ENV_IS_IN_MG_DISK) += env_mgdisk.o
 COBJS-$(CONFIG_ENV_IS_IN_NAND) += env_nand.o
 COBJS-$(CONFIG_ENV_IS_IN_NVRAM) += env_nvram.o
 COBJS-$(CONFIG_ENV_IS_IN_ONENAND) += env_onenand.o
@@ -104,6 +105,7 @@ COBJS-$(CONFIG_LOGBUFFER) += cmd_log.o
 COBJS-$(CONFIG_ID_EEPROM) += cmd_mac.o
 COBJS-$(CONFIG_CMD_MEMORY) += cmd_mem.o
 COBJS-$(CONFIG_CMD_MFSL) += cmd_mfsl.o
+COBJS-$(CONFIG_CMD_MG_DISK) += cmd_mgdisk.o
 COBJS-$(CONFIG_MII) += miiphyutil.o
 COBJS-$(CONFIG_CMD_MII) += miiphyutil.o
 COBJS-$(CONFIG_CMD_MII) += cmd_mii.o
common/cmd_mgdisk.c new file +76 -0

76 lines not on this page · raw message

common/cmd_nvedit.c +5 -3
index 68c673e..8198688 100644
@@ -52,15 +52,17 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
-#if !defined(CONFIG_ENV_IS_IN_NVRAM)	&& \
-    !defined(CONFIG_ENV_IS_IN_EEPROM)	&& \
+#if !defined(CONFIG_ENV_IS_IN_EEPROM)	&& \
     !defined(CONFIG_ENV_IS_IN_FLASH)	&& \
     !defined(CONFIG_ENV_IS_IN_DATAFLASH)	&& \
+    !defined(CONFIG_ENV_IS_IN_MG_DISK)	&& \
     !defined(CONFIG_ENV_IS_IN_NAND)	&& \
+    !defined(CONFIG_ENV_IS_IN_NVRAM)	&& \
     !defined(CONFIG_ENV_IS_IN_ONENAND)	&& \
     !defined(CONFIG_ENV_IS_IN_SPI_FLASH)	&& \
     !defined(CONFIG_ENV_IS_NOWHERE)
-# error Define one of CONFIG_ENV_IS_IN_{NVRAM|EEPROM|FLASH|DATAFLASH|ONENAND|SPI_FLASH|NOWHERE}
+# error Define one of CONFIG_ENV_IS_IN_{EEPROM|FLASH|DATAFLASH|ONENAND|\
+SPI_FLASH|MG_DISK|NVRAM|NOWHERE}
 #endif
 
 #define XMK_STR(x)	#x
common/env_mgdisk.c new file +92 -0

92 lines not on this page · raw message

disk/part.c +7 -1
index e353cee..fe299c7 100644
@@ -35,6 +35,7 @@
 #endif
 
 #if (defined(CONFIG_CMD_IDE) || \
+     defined(CONFIG_CMD_MG_DISK) || \
      defined(CONFIG_CMD_SATA) || \
      defined(CONFIG_CMD_SCSI) || \
      defined(CONFIG_CMD_USB) || \
@@ -65,6 +66,9 @@ static const struct block_drvr block_drvr[] = {
 #if defined(CONFIG_SYSTEMACE)
 	{ .name = "ace", .get_dev = systemace_get_dev, },
 #endif
+#if defined(CONFIG_CMD_MG_DISK)
+	{ .name = "mgd", .get_dev = mg_disk_get_dev, },
+#endif
 	{ },
 };
 
@@ -91,6 +95,7 @@ block_dev_desc_t *get_dev(char* ifname, int dev)
 #endif
 
 #if (defined(CONFIG_CMD_IDE) || \
+     defined(CONFIG_CMD_MG_DISK) || \
      defined(CONFIG_CMD_SATA) || \
      defined(CONFIG_CMD_SCSI) || \
      defined(CONFIG_CMD_USB) || \
@@ -203,11 +208,12 @@ void dev_print (block_dev_desc_t *dev_desc)
 #endif
 
 #if (defined(CONFIG_CMD_IDE) || \
+     defined(CONFIG_CMD_MG_DISK) || \
      defined(CONFIG_CMD_SATA) || \
      defined(CONFIG_CMD_SCSI) || \
      defined(CONFIG_CMD_USB) || \
      defined(CONFIG_MMC)		|| \
-     defined(CONFIG_SYSTEMACE)          )
+     defined(CONFIG_SYSTEMACE) )
 
 #if defined(CONFIG_MAC_PARTITION) || \
     defined(CONFIG_DOS_PARTITION) || \
disk/part_amiga.c +3 -2
index c2daf6a..50efe39 100644
@@ -27,6 +27,7 @@
 #include "part_amiga.h"
 
 #if defined(CONFIG_CMD_IDE) || \
+    defined(CONFIG_CMD_MG_DISK) || \
     defined(CONFIG_CMD_SCSI) || \
     defined(CONFIG_CMD_USB) || \
     defined(CONFIG_MMC) || \
@@ -154,7 +155,7 @@ struct rigid_disk_block *get_rdisk(block_dev_desc_t *dev_desc)
 
     s = getenv("amiga_scanlimit");
     if (s)
-	limit = atoi(s);
+	limit = simple_strtoul(s, NULL, 10);
     else
 	limit = AMIGA_BLOCK_LIMIT;
 
@@ -195,7 +196,7 @@ struct bootcode_block *get_bootcode(block_dev_desc_t *dev_desc)
 
     s = getenv("amiga_scanlimit");
     if (s)
-	limit = atoi(s);
+	limit = simple_strtoul(s, NULL, 10);
     else
 	limit = AMIGA_BLOCK_LIMIT;
 
disk/part_dos.c +1 -0
index 4ab0b40..93bf3dd 100644
@@ -36,6 +36,7 @@
 #include "part_dos.h"
 
 #if defined(CONFIG_CMD_IDE) || \
+    defined(CONFIG_CMD_MG_DISK) || \
     defined(CONFIG_CMD_SATA) || \
     defined(CONFIG_CMD_SCSI) || \
     defined(CONFIG_CMD_USB) || \
disk/part_efi.c +1 -0
index 70f62cc..626f022 100644
@@ -37,6 +37,7 @@
 #include "part_efi.h"
 
 #if defined(CONFIG_CMD_IDE) || \
+    defined(CONFIG_CMD_MG_DISK) || \
     defined(CONFIG_CMD_SATA) || \
     defined(CONFIG_CMD_SCSI) || \
     defined(CONFIG_CMD_USB) || \
disk/part_iso.c +1 -0
index 719b949..8fe6148 100644
@@ -26,6 +26,7 @@
 #include "part_iso.h"
 
 #if defined(CONFIG_CMD_IDE) || \
+    defined(CONFIG_CMD_MG_DISK) || \
     defined(CONFIG_CMD_SCSI) || \
     defined(CONFIG_CMD_SATA) || \
     defined(CONFIG_CMD_USB) || \
disk/part_mac.c +1 -0
index c1afc8c..bebe415 100644
@@ -35,6 +35,7 @@
 #include "part_mac.h"
 
 #if defined(CONFIG_CMD_IDE) || \
+    defined(CONFIG_CMD_MG_DISK) || \
     defined(CONFIG_CMD_SCSI) || \
     defined(CONFIG_CMD_SATA) || \
     defined(CONFIG_CMD_USB) || \
doc/README.mflash new file +94 -0

94 lines not on this page · raw message

drivers/block/Makefile +3 -2
index 59388d9..eccefc1 100644
@@ -25,13 +25,14 @@ include $(TOPDIR)/config.mk
 
 LIB	:= $(obj)libblock.a
 
-COBJS-$(CONFIG_SCSI_AHCI) += ahci.o
 COBJS-$(CONFIG_ATA_PIIX) += ata_piix.o
+COBJS-$(CONFIG_CMD_MG_DISK) += mg_disk.o
 COBJS-$(CONFIG_FSL_SATA) += fsl_sata.o
+COBJS-$(CONFIG_IDE_SIL680) += sil680.o
 COBJS-$(CONFIG_LIBATA) += libata.o
 COBJS-$(CONFIG_PATA_BFIN) += pata_bfin.o
 COBJS-$(CONFIG_SATA_SIL3114) += sata_sil3114.o
-COBJS-$(CONFIG_IDE_SIL680) += sil680.o
+COBJS-$(CONFIG_SCSI_AHCI) += ahci.o
 COBJS-$(CONFIG_SCSI_SYM53C8XX) += sym53c8xx.o
 COBJS-$(CONFIG_SYSTEMACE) += systemace.o
 
drivers/block/mg_disk.c new file +582 -0

582 lines not on this page · raw message

drivers/block/mg_disk_prv.h new file +145 -0

145 lines not on this page · raw message

fs/fat/fat.c +2 -0
index 8081ee7..602edae 100644
@@ -84,6 +84,7 @@ fat_register_device(block_dev_desc_t *dev_desc, int part_no)
 		return -1;
 	}
 #if (defined(CONFIG_CMD_IDE) || \
+     defined(CONFIG_CMD_MG_DISK) || \
      defined(CONFIG_CMD_SATA) || \
      defined(CONFIG_CMD_SCSI) || \
      defined(CONFIG_CMD_USB) || \
@@ -987,6 +988,7 @@ file_fat_detectfs(void)
 		return 1;
 	}
 #if defined(CONFIG_CMD_IDE) || \
+    defined(CONFIG_CMD_MG_DISK) || \
     defined(CONFIG_CMD_SATA) || \
     defined(CONFIG_CMD_SCSI) || \
     defined(CONFIG_CMD_USB) || \
include/config_cmd_all.h +1 -0
index 205dd1f..76cb968 100644
@@ -83,5 +83,6 @@
 #define CONFIG_CMD_VFD		/* VFD support (TRAB)		*/
 #define CONFIG_CMD_XIMG		/* Load part of Multi Image	*/
 #define CONFIG_CMD_AT91_SPIMUX	/* AT91 MMC/SPI Mux Support     */
+#define CONFIG_CMD_MG_DISK	/* mGine m(g)flash IO node support */
 
 #endif	/* _CONFIG_CMD_ALL_H */
include/environment.h +12 -0
index ea6b4d1..507e832 100644
@@ -84,6 +84,18 @@
 # endif
 #endif /* CONFIG_ENV_IS_IN_NAND */
 
+#if defined(CONFIG_ENV_IS_IN_MG_DISK)
+# ifndef CONFIG_ENV_ADDR
+#  error "Need to define CONFIG_ENV_ADDR when using CONFIG_ENV_IS_IN_MG_DISK"
+# endif
+# ifndef CONFIG_ENV_SIZE
+#  error "Need to define CONFIG_ENV_SIZE when using CONFIG_ENV_IS_IN_MG_DISK"
+# endif
+# ifdef CONFIG_ENV_IS_EMBEDDED
+#  error "CONFIG_ENV_IS_EMBEDDED not supported when using CONFIG_ENV_IS_IN_MG_DISK"
+# endif
+#endif /* CONFIG_ENV_IS_IN_MG_DISK */
+
 #ifdef USE_HOSTCC
 # include <stdint.h>
 #else
include/mg_disk.h new file +51 -0

51 lines not on this page · raw message

include/part.h +1 -0
index 980fd04..3cdae02 100644
@@ -100,6 +100,7 @@ block_dev_desc_t* scsi_get_dev(int dev);
 block_dev_desc_t* usb_stor_get_dev(int dev);
 block_dev_desc_t* mmc_get_dev(int dev);
 block_dev_desc_t* systemace_get_dev(int dev);
+block_dev_desc_t* mg_disk_get_dev(int dev);
 
 /* disk/part.c */
 int get_partition_info (block_dev_desc_t * dev_desc, int part, disk_partition_t *info);
Signature · 4 lines
1.5.6.6

Regards,
unsik Kim
#1 lore raw

PATCH 1/1 mflash: Initial mflash support

Dear unsik Kim,

Quoted 39 lines · In message <[email protected]> you wrote:

Mflash is fusion memory device mainly targeted consumer eletronic and mobile phone.
Internally, it have nand flash and other hardware logics and supports some different operation (ATA, IO, XIP) modes.

IO mode is custom mode for the host that doesn't have IDE interface. (Many mobile targeted SoC doesn't have IDE bus)

This driver support mflash IO mode.

Followings are brief descriptions about IO mode.

1. IO mode based on ATA protocol and uses some custom command. (read confirm, write confirm)
2. IO mode uses SRAM bus interface.

---
This is all-in-one mflash patch. (Whole series of patches were squashed and rebased.) Please, use this if you forgot <[email protected]>.

---
 common/Makefile             |    2 +
 common/cmd_mgdisk.c         |   76 ++++++
 common/cmd_nvedit.c         |    8 +-
 common/env_mgdisk.c         |   92 +++++++
 disk/part.c                 |    8 +-
 disk/part_amiga.c           |    5 +-
 disk/part_dos.c             |    1 +
 disk/part_efi.c             |    1 +
 disk/part_iso.c             |    1 +
 disk/part_mac.c             |    1 +
 doc/README.mflash           |   94 +++++++
 drivers/block/Makefile      |    5 +-
 drivers/block/mg_disk.c     |  582 +++++++++++++++++++++++++++++++++++++++++++
 drivers/block/mg_disk_prv.h |  145 +++++++++++
 fs/fat/fat.c                |    2 +
 include/config_cmd_all.h    |    1 +
 include/environment.h       |   12 +
 include/mg_disk.h           |   51 ++++
Quoted 8 lines
 include/part.h              |    1 +
 19 files changed, 1080 insertions(+), 8 deletions(-)
 create mode 100644 common/cmd_mgdisk.c
 create mode 100644 common/env_mgdisk.c
 create mode 100644 doc/README.mflash
 create mode 100644 drivers/block/mg_disk.c
 create mode 100644 drivers/block/mg_disk_prv.h
 create mode 100644 include/mg_disk.h

Oops. Forget my previous message, please.

Applied this one. Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The human race has one really effective weapon, and that is laughter.
                                                         - Mark Twain