mflash: reflect akpm's review
Subsystems (2)
PATCH 1/1 mflash: reflect akpm's review
* refine and reduce mg_wait's timeout value
* reduce probing time:
add dev_attr field to mg_drv_data and reset-out
GPIO resource
* remove uneffective reset when error occured
* remove pointless "?"
* use correct jiffy wrap
* replace local mg_ide_fixstring to libata_core's
* avoid divide-by-zero
* change host->dev_base type to 'void __iomem *'
* add missing GPIOLIB and ATA dependency
Signed-off-by unsik Kim <[email protected]>
---
When using interrupt mode, most of the busy wait eliminated. The worst case of busy wait is under 10msec. (This is extremely rare case) Typically wait <500nsec at mg_out's mg_wait.
--- Documentation/blockdev/mflash.txt | 13 ++- drivers/block/Kconfig | 2 +- drivers/block/mg_disk.c | 352 ++++++++++++++++++++----------------- include/linux/mg_disk.h | 57 +++++-- 4 files changed, 246 insertions(+), 178 deletions(-)
Documentation/blockdev/mflash.txt +12 -1
@@ -36,6 +36,8 @@ configuration file is all. Here is some pseudo example. static struct mg_drv_data mflash_drv_data = { /* If you want to polling driver set to 1 */ .use_polling = 0, + /* device attribution */ + .dev_attr = MG_BOOT_DEV }; static struct resource mg_mflash_rsc[] = {
@@ -55,9 +57,18 @@ static struct resource mg_mflash_rsc[] = { [2] = { .start = 43, .end = 43, - .name = "mg_rst", + .name = MG_RST_PIN, .flags = IORESOURCE_IO }, + /* mflash reset-out pin + * If you use mflash as storage device (i.e. other than MG_BOOT_DEV), + * should assign this */ + [3] = { + .start = 51, + .end = 51, + .name = MG_RSTOUT_PIN, + .flags = IORESOURCE_IO + } }; static struct platform_device mflash_dev = {
drivers/block/Kconfig +1 -1
@@ -405,7 +405,7 @@ config ATA_OVER_ETH config MG_DISK tristate "mGine mflash, gflash support" - depends on ARM + depends on ARM && ATA && GPIOLIB help mGine mFlash(gFlash) block device driver
drivers/block/mg_disk.c +188 -164
687 lines not on this page · raw message
include/linux/mg_disk.h +45 -12
93 lines not on this page · raw message
Signature · 3 lines
1.5.6.6 Regards, unsik Kim