Skip to contentSkip to conversation

Input: bf54x-keys: Fix typo

PATCH Applied Bryan Wu 3 participants 5 messages Mar 6, 2009 – Apr 14, 2009

Subsystems (4)
lore
Share & tools
lore

Bryan Wu

author
#0 lore raw

PATCH 1/1 Input: bf54x-keys: Fix typo

From: Michael Hennerich <[email protected]>

---
 drivers/input/keyboard/bf54x-keys.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/input/keyboard/bf54x-keys.c +1 -1
index ee855c5..c6f4e16 100644
@@ -212,7 +212,7 @@ static int __devinit bfin_kpad_probe(struct platform_device *pdev)
 	if (!pdata->debounce_time || pdata->debounce_time > MAX_MULT ||
 	    !pdata->coldrive_time || pdata->coldrive_time > MAX_MULT) {
 		printk(KERN_ERR DRV_NAME
-			": Invalid Debounce/Columdrive Time from pdata\n");
+			": Invalid Debounce/Columndrive Time from platform data\n");
 		bfin_write_KPAD_MSEL(0xFF0);	/* Default MSEL	*/
 	} else {
 		bfin_write_KPAD_MSEL(
Signature · 1 line
1.5.6.3
maintainer Applied
#1 lore raw

Hi Bryan,

Quoted 13 lines · Bryan Wu

From: Michael Hennerich <[email protected]>

---
 drivers/input/keyboard/bf54x-keys.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/input/keyboard/bf54x-keys.c +0 -0
index ee855c5..c6f4e16 100644

drivers/input/keyboard/bf54x-keys.c static int __devinit bfin_kpad_probe(struct platform_device *pdev) · line 215

Quoted 5 lines
drivers/input/keyboard/bf54x-keys.c +1 -1
@@ -212,7 +212,7 @@ static int __devinit bfin_kpad_probe(struct platform_device *pdev)
 	if (!pdata->debounce_time || pdata->debounce_time > MAX_MULT ||
 	    !pdata->coldrive_time || pdata->coldrive_time > MAX_MULT) {
 		printk(KERN_ERR DRV_NAME
-			": Invalid Debounce/Columdrive Time from pdata\n");
+			": Invalid Debounce/Columndrive Time from platform data\n");

Applied, but lowered severity form error to warning since the driver is still functional even with bad timing values in platform data.

Signature · 1 line
Dmitry
#2 lore raw

PATCH 1/1 Input: bf54x-keys: Remove depreciated IRQF_SAMPLE_RANDOM flag

In reply to Bryan Wu

From: Michael Hennerich <[email protected]>

(quoted diff) +0 -0

b/drivers/input/keyboard/bf54x-keys.c
index c6f4e16..73c4481 100644

drivers/input/keyboard/bf54x-keys.c +0 -0
@@ -252,7 +252,7 @@ static int __devinit bfin_kpad_probe(struct

platform_device *pdev)

        }

        error = request_irq(bf54x_kpad->irq, bfin_kpad_isr,

- IRQF_SAMPLE_RANDOM, DRV_NAME, pdev);
+ 0 , DRV_NAME, pdev);
if (error) {
printk(KERN_ERR DRV_NAME
": unable to claim irq %d; error %d\n",

#3 lore raw

PATCH 1/1 Input: ad7877.c and ad7879.c: Remove depreciated IRQF_SAMPLE_RANDOM flag

From: Michael Hennerich <[email protected]>

This patch removes depreciated IRQF_SAMPLE_RANDOM flags from drivers currently queued in Dmitry's input subsystem tree.

---
 drivers/input/touchscreen/ad7877.c |    4 ++--                       
 drivers/input/touchscreen/ad7879.c |    3 +--                        
 2 files changed, 3 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/drivers/input/joystick/bfin_rotary.c
index c318849..7e91bff 100644

--- a/drivers/input/joystick/bfin_rotary.c

+++ b/drivers/input/joystick/bfin_rotary.c

@@ -138,7 +138,7 @@ static int __devinit bfin_rotary_probe(struct platform_device *pdev)

                goto out2;

 

        ret = request_irq(rotary->irq, bfin_rotary_isr,

- IRQF_SAMPLE_RANDOM,
dev_name(&pdev->dev), pdev);
+ 0 , dev_name(&pdev->dev), pdev);

        if (ret) {

                dev_err(&pdev->dev,

                        "unable to claim irq %d; error %d\n",
(quoted diff) +0 -0

b/drivers/input/keyboard/adp5588_keys.c
index b424ce4..1da7000 100644

--- a/drivers/input/keyboard/adp5588_keys.c

+++ b/drivers/input/keyboard/adp5588_keys.c

@@ -308,7 +308,7 @@ static int __devinit adp5588_probe(struct i2c_client *client,

        }

 

        ret = request_irq(client->irq, adp5588_irq, IRQF_TRIGGER_FALLING

|
- IRQF_SAMPLE_RANDOM | IRQF_DISABLED,

+ IRQF_DISABLED,

                client->dev.driver->name, kpad);

        if (ret) {

                dev_err(&client->dev, "irq %d busy?\n", client->irq);
#4 lore raw

RE: [PATCH] Input: ad7877.c and ad7879.c: Remove depreciated IRQF_SAMPLE_RANDOM flag

In reply to Hennerich, Michael

From: Michael Hennerich <[email protected]>

Dmitry,

Please ignore my last email.

This patch removes depreciated IRQF_SAMPLE_RANDOM flags from drivers currently queued in Dmitry's input subsystem tree.

---
 drivers/input/touchscreen/ad7877.c |    4 ++--                       
 drivers/input/touchscreen/ad7879.c |    3 +--                        
 2 files changed, 3 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/drivers/input/touchscreen/ad7877.c
index 047bb57..dae7357 100644

drivers/input/touchscreen/ad7877.c +0 -0
@@ -739,8 +739,8 @@ static int __devinit ad7877_probe(struct spi_device

*spi)

/* Request AD7877 /DAV GPIO interrupt */

- err = request_irq(spi->irq, ad7877_irq, IRQF_TRIGGER_FALLING |
- IRQF_SAMPLE_RANDOM, spi->dev.driver->name, ts);
+ err = request_irq(spi->irq, ad7877_irq, IRQF_TRIGGER_FALLING,
+ spi->dev.driver->name, ts);
if (err) {
dev_dbg(&spi->dev, "irq %d busy?\n", spi->irq); goto err_free_mem;

(quoted diff) +0 -0

b/drivers/input/touchscreen/ad7879.c
index 59fad2f..2eb40ee 100644

drivers/input/touchscreen/ad7879.c +0 -0
@@ -448,8 +448,7 @@ static int __devinit ad7879_construct(bus_device

*bus, struct ad7879 *ts)
ad7879_setup(ts);

err = request_irq(bus->irq, ad7879_irq,

-			  IRQF_TRIGGER_FALLING | IRQF_SAMPLE_RANDOM,
-			  bus->dev.driver->name, ts);
+			  IRQF_TRIGGER_FALLING, bus->dev.driver->name,

ts);

if (err) {
dev_err(&bus->dev, "irq %d busy?\n", bus->irq);

Quoted 5 lines

-----Original Message-----
From: Hennerich, Michael
Sent: Tuesday, April 14, 2009 12:45 PM
To: '[email protected]'
Cc: '[email protected]'; '[email protected]';

'Robin Getz'; Hennerich, Michael

Quoted 1 line

Subject: [PATCH] Input: ad7877.c and ad7879.c: Remove depreciated

IRQF_SAMPLE_RANDOM flag

Quoted 6 lines

From: Michael Hennerich <[email protected]>

This patch removes depreciated IRQF_SAMPLE_RANDOM flags from drivers currently queued in Dmitry's input subsystem tree.

Review

Quoted 8 lines

---

drivers/input/touchscreen/ad7877.c |    4 ++--
drivers/input/touchscreen/ad7879.c |    3 +--
2 files changed, 3 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/drivers/input/joystick/bfin_rotary.c

drivers/input/joystick/bfin_rotary.c static int __devinit bfin_rotary_probe(struct

Quoted 4 lines

index c318849..7e91bff 100644

drivers/input/joystick/bfin_rotary.c +0 -0
@@ -138,7 +138,7 @@ static int __devinit bfin_rotary_probe(struct

platform_device *pdev)

drivers/input/joystick/bfin_rotary.c static int __devinit bfin_rotary_probe(struct · line 141

Quoted 4 lines
drivers/input/joystick/bfin_rotary.c +0 -1
               goto out2;
 
       ret = request_irq(rotary->irq, bfin_rotary_isr,
-                                IRQF_SAMPLE_RANDOM,

dev_name(&pdev->dev), pdev);

Review

Quoted 5 lines
drivers/input/joystick/bfin_rotary.c +1 -0
+                                0 , dev_name(&pdev->dev), pdev);
       if (ret) {
               dev_err(&pdev->dev,
                       "unable to claim irq %d; error %d\n",
(quoted diff) +0 -0

b/drivers/input/keyboard/adp5588_keys.c

drivers/input/keyboard/adp5588_keys.c static int __devinit adp5588_probe(struct

Quoted 4 lines

index b424ce4..1da7000 100644

drivers/input/keyboard/adp5588_keys.c +0 -0
@@ -308,7 +308,7 @@ static int __devinit adp5588_probe(struct

i2c_client *client,

drivers/input/keyboard/adp5588_keys.c static int __devinit adp5588_probe(struct · line 310

Quoted 3 lines
drivers/input/keyboard/adp5588_keys.c +0 -0
       }
 
       ret = request_irq(client->irq, adp5588_irq,

IRQF_TRIGGER_FALLING |

Quoted 5 lines
drivers/input/keyboard/adp5588_keys.c +1 -1
-               IRQF_SAMPLE_RANDOM | IRQF_DISABLED,
+               IRQF_DISABLED,
               client->dev.driver->name, kpad);
       if (ret) {
               dev_err(&client->dev, "irq %d busy?\n", client->irq);