x86: cpu architecture debug code
The following changes since commit cb553adb4e83bc5314b5a0c397e546a215b19307:
Ingo Molnar (1):
Merge branch 'tracing/printk'
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-tip-cpu.git master
Jaswinder Singh Rajput (1):
x86: cpu architecture debug code
arch/x86/include/asm/cpu_debug.h | 191 +++++++++++ arch/x86/kernel/cpu/Makefile | 2 +- arch/x86/kernel/cpu/cpu_debug.c | 668 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 860 insertions(+), 1 deletions(-) create mode 100755 arch/x86/include/asm/cpu_debug.h create mode 100755 arch/x86/kernel/cpu/cpu_debug.c
Complete diff:
arch/x86/include/asm/cpu_debug.h new file +191 -0
@@ -0,0 +1,191 @@ +#ifndef _ASM_X86_CPU_DEBUG_H +#define _ASM_X86_CPU_DEBUG_H + +/* +* CPU x86 architecture debug +* +* Copyright(C) 2009 Jaswinder Singh Rajput +*/ + +/* Register flags */ +enum cpu_debug_bit { +/* Model Specific Registers (MSRs) */ +CPU_MC_BIT ,/* Machine Check */ +CPU_MONITOR_BIT ,/* Monitor */ +CPU_TIME_BIT ,/* Time */ +CPU_PMC_BIT ,/* Performance Monitor */ +CPU_PLATFORM_BIT ,/* Platform */ +CPU_APIC_BIT ,/* APIC */ +CPU_POWERON_BIT ,/* Power-on */ +CPU_CONTROL_BIT ,/* Control */ +CPU_FEATURES_BIT ,/* Features control */ +CPU_LBRANCH_BIT ,/* Last Branch */ +CPU_BIOS_BIT ,/* BIOS */ +CPU_FREQ_BIT ,/* Frequency */ +CPU_MTTR_BIT ,/* MTRR */ +CPU_PERF_BIT ,/* Performance */ +CPU_CACHE_BIT ,/* Cache */ +CPU_SYSENTER_BIT ,/* Sysenter */ +CPU_THERM_BIT ,/* Thermal */ +CPU_MISC_BIT ,/* Miscellaneous */ +CPU_DEBUG_BIT ,/* Debug */ +CPU_PAT_BIT ,/* PAT */ +CPU_VMX_BIT ,/* VMX */ +CPU_CALL_BIT ,/* System Call */ +CPU_BASE_BIT ,/* BASE Address */ +CPU_SMM_BIT ,/* System mgmt mode */ +CPU_SVM_BIT ,/*Secure Virtual Machine*/ +CPU_OSVM_BIT ,/* OS-Visible Workaround*/ +/* Standard Registers */ +CPU_TSS_BIT ,/* Task Stack Segment */ +CPU_CR_BIT ,/* Control Registers */ +/* End of Registers flags */ +CPU_REG_ALL_BIT ,/* Select all Registers */ +}; + +#define CPU_REG_ALL (~0)/* Select all Registers */ + +#define CPU_MC (1 << CPU_MC_BIT) +#define CPU_MONITOR (1 << CPU_MONITOR_BIT) +#define CPU_TIME (1 << CPU_TIME_BIT) +#define CPU_PMC (1 << CPU_PMC_BIT) +#define CPU_PLATFORM (1 << CPU_PLATFORM_BIT) +#define CPU_APIC (1 << CPU_APIC_BIT) +#define CPU_POWERON (1 << CPU_POWERON_BIT) +#define CPU_CONTROL (1 << CPU_CONTROL_BIT) +#define CPU_FEATURES (1 << CPU_FEATURES_BIT) +#define CPU_LBRANCH (1 << CPU_LBRANCH_BIT) +#define CPU_BIOS (1 << CPU_BIOS_BIT) +#define CPU_FREQ (1 << CPU_FREQ_BIT) +#define CPU_MTRR (1 << CPU_MTTR_BIT) +#define CPU_PERF (1 << CPU_PERF_BIT) +#define CPU_CACHE (1 << CPU_CACHE_BIT) +#define CPU_SYSENTER (1 << CPU_SYSENTER_BIT) +#define CPU_THERM (1 << CPU_THERM_BIT) +#define CPU_MISC (1 << CPU_MISC_BIT) +#define CPU_DEBUG (1 << CPU_DEBUG_BIT) +#define CPU_PAT (1 << CPU_PAT_BIT) +#define CPU_VMX (1 << CPU_VMX_BIT) +#define CPU_CALL (1 << CPU_CALL_BIT) +#define CPU_BASE (1 << CPU_BASE_BIT) +#define CPU_SMM (1 << CPU_SMM_BIT) +#define CPU_SVM (1 << CPU_SVM_BIT) +#define CPU_OSVM (1 << CPU_OSVM_BIT) +#define CPU_TSS (1 << CPU_TSS_BIT) +#define CPU_CR (1 << CPU_CR_BIT) + +/* Register file flags */ +enum cpu_file_bit { +CPU_INDEX_BIT ,/* index */ +CPU_VALUE_BIT ,/* value */ +}; + +#define CPU_FILE_VALUE (1 << CPU_VALUE_BIT) + +/* +* DisplayFamily_DisplayModel Processor Families/Processor Number Series +* -------------------------- ------------------------------------------ +* 05_01, 05_02, 05_04 Pentium, Pentium with MMX +* +* 06_01 Pentium Pro +* 06_03, 06_05 Pentium II Xeon, Pentium II +* 06_07, 06_08, 06_0A, 06_0B Pentium III Xeon, Pentum III +* +* 06_09, 060D Pentium M +* +* 06_0E Core Duo, Core Solo +* +* 06_0F Xeon 3000, 3200, 5100, 5300, 7300 series, +* Core 2 Quad, Core 2 Extreme, Core 2 Duo, +* Pentium dual-core +* 06_17 Xeon 5200, 5400 series, Core 2 Quad Q9650 +* +* 06_1C Atom +* +* 0F_00, 0F_01, 0F_02 Xeon, Xeon MP, Pentium 4 +* 0F_03, 0F_04 Xeon, Xeon MP, Pentium 4, Pentium D +* +* 0F_06 Xeon 7100, 5000 Series, Xeon MP, +* Pentium 4, Pentium D +*/ + +/* Register processors bits */ +enum cpu_processor_bit { +CPU_NONE , +/* Intel */ +CPU_INTEL_PENTIUM_BIT , +CPU_INTEL_P6_BIT , +CPU_INTEL_PENTIUM_M_BIT , +CPU_INTEL_CORE_BIT , +CPU_INTEL_CORE2_BIT , +CPU_INTEL_ATOM_BIT , +CPU_INTEL_XEON_P4_BIT , +CPU_INTEL_XEON_MP_BIT , +}; + +#define CPU_ALL (~0)/* Select all CPUs */ + +#define CPU_INTEL_PENTIUM (1 << CPU_INTEL_PENTIUM_BIT) +#define CPU_INTEL_P6 (1 << CPU_INTEL_P6_BIT) +#define CPU_INTEL_PENTIUM_M (1 << CPU_INTEL_PENTIUM_M_BIT) +#define CPU_INTEL_CORE (1 << CPU_INTEL_CORE_BIT) +#define CPU_INTEL_CORE2 (1 << CPU_INTEL_CORE2_BIT) +#define CPU_INTEL_ATOM (1 << CPU_INTEL_ATOM_BIT) +#define CPU_INTEL_XEON_P4 (1 << CPU_INTEL_XEON_P4_BIT) +#define CPU_INTEL_XEON_MP (1 << CPU_INTEL_XEON_MP_BIT) + +#define CPU_INTEL_PX (CPU_INTEL_P6 | CPU_INTEL_PENTIUM_M) +#define CPU_INTEL_COREX (CPU_INTEL_CORE | CPU_INTEL_CORE2) +#define CPU_INTEL_XEON (CPU_INTEL_XEON_P4 | CPU_INTEL_XEON_MP) +#define CPU_CO_AT (CPU_INTEL_CORE | CPU_INTEL_ATOM) +#define CPU_C2_AT (CPU_INTEL_CORE2 | CPU_INTEL_ATOM) +#define CPU_CX_AT (CPU_INTEL_COREX | CPU_INTEL_ATOM) +#define CPU_CX_XE (CPU_INTEL_COREX | CPU_INTEL_XEON) +#define CPU_P6_XE (CPU_INTEL_P6 | CPU_INTEL_XEON) +#define CPU_PM_CO_AT (CPU_INTEL_PENTIUM_M | CPU_CO_AT) +#define CPU_C2_AT_XE (CPU_C2_AT | CPU_INTEL_XEON) +#define CPU_CX_AT_XE (CPU_CX_AT | CPU_INTEL_XEON) +#define CPU_P6_CX_AT (CPU_INTEL_P6 | CPU_CX_AT) +#define CPU_P6_CX_XE (CPU_P6_XE | CPU_INTEL_COREX) +#define CPU_P6_CX_AT_XE (CPU_INTEL_P6 | CPU_CX_AT_XE) +#define CPU_PM_CX_AT_XE (CPU_INTEL_PENTIUM_M | CPU_CX_AT_XE) +#define CPU_PM_CX_AT (CPU_INTEL_PENTIUM_M | CPU_CX_AT) +#define CPU_PM_CX_XE (CPU_INTEL_PENTIUM_M | CPU_CX_XE) +#define CPU_PX_CX_AT (CPU_INTEL_PX | CPU_CX_AT) +#define CPU_PX_CX_AT_XE (CPU_INTEL_PX | CPU_CX_AT_XE) + +/* Select all Intel CPUs*/ +#define CPU_INTEL_ALL (CPU_INTEL_PENTIUM | CPU_PX_CX_AT_XE) + +#define MAX_CPU_FILES 512 + +struct cpu_private { +unsigned cpu; +unsigned type; +unsigned reg; +unsigned file; +}; + +struct cpu_debug_base { +char *name;/* Register name */ +unsigned flag;/* Register flag */ +}; + +struct cpu_cpuX_base { +struct dentry *dentry;/* Register dentry */ +int init;/* Register index file */ +}; + +struct cpu_file_base { +char *name;/* Register file name */ +unsigned flag;/* Register file flag */ +}; + +struct cpu_debug_range { +unsigned min;/* Register range min */ +unsigned max;/* Register range max */ +unsigned flag;/* Supported flags */ +unsigned model;/* Supported models */ +}; + +#endif /* _ASM_X86_CPU_DEBUG_H */
arch/x86/kernel/cpu/Makefile +1 -1
@@ -9,7 +9,7 @@ endif obj-y := intel_cacheinfo.o addon_cpuid_features.o obj-y += proc.o capflags.o powerflags.o common.o -obj-y += vmware.o hypervisor.o +obj-y += vmware.o hypervisor.o cpu_debug.o obj-$(CONFIG_X86_32) += bugs.o cmpxchg.o obj-$(CONFIG_X86_64) += bugs_64.o
arch/x86/kernel/cpu/cpu_debug.c new file +668 -0
668 lines not on this page · raw message
Quoted 11 lines · Jaswinder Singh Rajput
The following changes since commit
cb553adb4e83bc5314b5a0c397e546a215b19307:
Ingo Molnar (1):
Merge branch 'tracing/printk'are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-tip-cpu.gitmasterJaswinder Singh Rajput (1):
x86: cpu architecture debug code
After adding descriptor tables and with minor changes. Here is new pull request:
Log file is available at:
http://git.kernel.org/?p=linux/kernel/git/jaswinder/linux-2.6-tip-cpu.git;a=commitdiff;h=70cd60ec1ff658166814633770c102d10f465d23
The following changes since commit cb553adb4e83bc5314b5a0c397e546a215b19307:
Ingo Molnar (1):
Merge branch 'tracing/printk'
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-tip-cpu.git master
Jaswinder Singh Rajput (1):
x86: cpu architecture debug code
arch/x86/include/asm/cpu_debug.h | 193 +++++++++++ arch/x86/kernel/cpu/Makefile | 2 +- arch/x86/kernel/cpu/cpu_debug.c | 692 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 886 insertions(+), 1 deletions(-) create mode 100755 arch/x86/include/asm/cpu_debug.h create mode 100755 arch/x86/kernel/cpu/cpu_debug.c
Complete diff:
arch/x86/include/asm/cpu_debug.h new file +193 -0
@@ -0,0 +1,193 @@ +#ifndef _ASM_X86_CPU_DEBUG_H +#define _ASM_X86_CPU_DEBUG_H + +/* +* CPU x86 architecture debug +* +* Copyright(C) 2009 Jaswinder Singh Rajput +*/ + +/* Register flags */ +enum cpu_debug_bit { +/* Model Specific Registers (MSRs) */ +CPU_MC_BIT ,/* Machine Check */ +CPU_MONITOR_BIT ,/* Monitor */ +CPU_TIME_BIT ,/* Time */ +CPU_PMC_BIT ,/* Performance Monitor */ +CPU_PLATFORM_BIT ,/* Platform */ +CPU_APIC_BIT ,/* APIC */ +CPU_POWERON_BIT ,/* Power-on */ +CPU_CONTROL_BIT ,/* Control */ +CPU_FEATURES_BIT ,/* Features control */ +CPU_LBRANCH_BIT ,/* Last Branch */ +CPU_BIOS_BIT ,/* BIOS */ +CPU_FREQ_BIT ,/* Frequency */ +CPU_MTTR_BIT ,/* MTRR */ +CPU_PERF_BIT ,/* Performance */ +CPU_CACHE_BIT ,/* Cache */ +CPU_SYSENTER_BIT ,/* Sysenter */ +CPU_THERM_BIT ,/* Thermal */ +CPU_MISC_BIT ,/* Miscellaneous */ +CPU_DEBUG_BIT ,/* Debug */ +CPU_PAT_BIT ,/* PAT */ +CPU_VMX_BIT ,/* VMX */ +CPU_CALL_BIT ,/* System Call */ +CPU_BASE_BIT ,/* BASE Address */ +CPU_SMM_BIT ,/* System mgmt mode */ +CPU_SVM_BIT ,/*Secure Virtual Machine*/ +CPU_OSVM_BIT ,/* OS-Visible Workaround*/ +/* Standard Registers */ +CPU_TSS_BIT ,/* Task Stack Segment */ +CPU_CR_BIT ,/* Control Registers */ +CPU_DT_BIT ,/* Descriptor Table */ +/* End of Registers flags */ +CPU_REG_ALL_BIT ,/* Select all Registers */ +}; + +#define CPU_REG_ALL (~0)/* Select all Registers */ + +#define CPU_MC (1 << CPU_MC_BIT) +#define CPU_MONITOR (1 << CPU_MONITOR_BIT) +#define CPU_TIME (1 << CPU_TIME_BIT) +#define CPU_PMC (1 << CPU_PMC_BIT) +#define CPU_PLATFORM (1 << CPU_PLATFORM_BIT) +#define CPU_APIC (1 << CPU_APIC_BIT) +#define CPU_POWERON (1 << CPU_POWERON_BIT) +#define CPU_CONTROL (1 << CPU_CONTROL_BIT) +#define CPU_FEATURES (1 << CPU_FEATURES_BIT) +#define CPU_LBRANCH (1 << CPU_LBRANCH_BIT) +#define CPU_BIOS (1 << CPU_BIOS_BIT) +#define CPU_FREQ (1 << CPU_FREQ_BIT) +#define CPU_MTRR (1 << CPU_MTTR_BIT) +#define CPU_PERF (1 << CPU_PERF_BIT) +#define CPU_CACHE (1 << CPU_CACHE_BIT) +#define CPU_SYSENTER (1 << CPU_SYSENTER_BIT) +#define CPU_THERM (1 << CPU_THERM_BIT) +#define CPU_MISC (1 << CPU_MISC_BIT) +#define CPU_DEBUG (1 << CPU_DEBUG_BIT) +#define CPU_PAT (1 << CPU_PAT_BIT) +#define CPU_VMX (1 << CPU_VMX_BIT) +#define CPU_CALL (1 << CPU_CALL_BIT) +#define CPU_BASE (1 << CPU_BASE_BIT) +#define CPU_SMM (1 << CPU_SMM_BIT) +#define CPU_SVM (1 << CPU_SVM_BIT) +#define CPU_OSVM (1 << CPU_OSVM_BIT) +#define CPU_TSS (1 << CPU_TSS_BIT) +#define CPU_CR (1 << CPU_CR_BIT) +#define CPU_DT (1 << CPU_DT_BIT) + +/* Register file flags */ +enum cpu_file_bit { +CPU_INDEX_BIT ,/* index */ +CPU_VALUE_BIT ,/* value */ +}; + +#define CPU_FILE_VALUE (1 << CPU_VALUE_BIT) + +/* +* DisplayFamily_DisplayModel Processor Families/Processor Number Series +* -------------------------- ------------------------------------------ +* 05_01, 05_02, 05_04 Pentium, Pentium with MMX +* +* 06_01 Pentium Pro +* 06_03, 06_05 Pentium II Xeon, Pentium II +* 06_07, 06_08, 06_0A, 06_0B Pentium III Xeon, Pentum III +* +* 06_09, 060D Pentium M +* +* 06_0E Core Duo, Core Solo +* +* 06_0F Xeon 3000, 3200, 5100, 5300, 7300 series, +* Core 2 Quad, Core 2 Extreme, Core 2 Duo, +* Pentium dual-core +* 06_17 Xeon 5200, 5400 series, Core 2 Quad Q9650 +* +* 06_1C Atom +* +* 0F_00, 0F_01, 0F_02 Xeon, Xeon MP, Pentium 4 +* 0F_03, 0F_04 Xeon, Xeon MP, Pentium 4, Pentium D +* +* 0F_06 Xeon 7100, 5000 Series, Xeon MP, +* Pentium 4, Pentium D +*/ + +/* Register processors bits */ +enum cpu_processor_bit { +CPU_NONE , +/* Intel */ +CPU_INTEL_PENTIUM_BIT , +CPU_INTEL_P6_BIT , +CPU_INTEL_PENTIUM_M_BIT , +CPU_INTEL_CORE_BIT , +CPU_INTEL_CORE2_BIT , +CPU_INTEL_ATOM_BIT , +CPU_INTEL_XEON_P4_BIT , +CPU_INTEL_XEON_MP_BIT , +}; + +#define CPU_ALL (~0)/* Select all CPUs */ + +#define CPU_INTEL_PENTIUM (1 << CPU_INTEL_PENTIUM_BIT) +#define CPU_INTEL_P6 (1 << CPU_INTEL_P6_BIT) +#define CPU_INTEL_PENTIUM_M (1 << CPU_INTEL_PENTIUM_M_BIT) +#define CPU_INTEL_CORE (1 << CPU_INTEL_CORE_BIT) +#define CPU_INTEL_CORE2 (1 << CPU_INTEL_CORE2_BIT) +#define CPU_INTEL_ATOM (1 << CPU_INTEL_ATOM_BIT) +#define CPU_INTEL_XEON_P4 (1 << CPU_INTEL_XEON_P4_BIT) +#define CPU_INTEL_XEON_MP (1 << CPU_INTEL_XEON_MP_BIT) + +#define CPU_INTEL_PX (CPU_INTEL_P6 | CPU_INTEL_PENTIUM_M) +#define CPU_INTEL_COREX (CPU_INTEL_CORE | CPU_INTEL_CORE2) +#define CPU_INTEL_XEON (CPU_INTEL_XEON_P4 | CPU_INTEL_XEON_MP) +#define CPU_CO_AT (CPU_INTEL_CORE | CPU_INTEL_ATOM) +#define CPU_C2_AT (CPU_INTEL_CORE2 | CPU_INTEL_ATOM) +#define CPU_CX_AT (CPU_INTEL_COREX | CPU_INTEL_ATOM) +#define CPU_CX_XE (CPU_INTEL_COREX | CPU_INTEL_XEON) +#define CPU_P6_XE (CPU_INTEL_P6 | CPU_INTEL_XEON) +#define CPU_PM_CO_AT (CPU_INTEL_PENTIUM_M | CPU_CO_AT) +#define CPU_C2_AT_XE (CPU_C2_AT | CPU_INTEL_XEON) +#define CPU_CX_AT_XE (CPU_CX_AT | CPU_INTEL_XEON) +#define CPU_P6_CX_AT (CPU_INTEL_P6 | CPU_CX_AT) +#define CPU_P6_CX_XE (CPU_P6_XE | CPU_INTEL_COREX) +#define CPU_P6_CX_AT_XE (CPU_INTEL_P6 | CPU_CX_AT_XE) +#define CPU_PM_CX_AT_XE (CPU_INTEL_PENTIUM_M | CPU_CX_AT_XE) +#define CPU_PM_CX_AT (CPU_INTEL_PENTIUM_M | CPU_CX_AT) +#define CPU_PM_CX_XE (CPU_INTEL_PENTIUM_M | CPU_CX_XE) +#define CPU_PX_CX_AT (CPU_INTEL_PX | CPU_CX_AT) +#define CPU_PX_CX_AT_XE (CPU_INTEL_PX | CPU_CX_AT_XE) + +/* Select all Intel CPUs*/ +#define CPU_INTEL_ALL (CPU_INTEL_PENTIUM | CPU_PX_CX_AT_XE) + +#define MAX_CPU_FILES 512 + +struct cpu_private { +unsigned cpu; +unsigned type; +unsigned reg; +unsigned file; +}; + +struct cpu_debug_base { +char *name;/* Register name */ +unsigned flag;/* Register flag */ +}; + +struct cpu_cpuX_base { +struct dentry *dentry;/* Register dentry */ +int init;/* Register index file */ +}; + +struct cpu_file_base { +char *name;/* Register file name */ +unsigned flag;/* Register file flag */ +}; + +struct cpu_debug_range { +unsigned min;/* Register range min */ +unsigned max;/* Register range max */ +unsigned flag;/* Supported flags */ +unsigned model;/* Supported models */ +}; + +#endif /* _ASM_X86_CPU_DEBUG_H */
arch/x86/kernel/cpu/Makefile +1 -1
@@ -9,7 +9,7 @@ endif obj-y := intel_cacheinfo.o addon_cpuid_features.o obj-y += proc.o capflags.o powerflags.o common.o -obj-y += vmware.o hypervisor.o +obj-y += vmware.o hypervisor.o cpu_debug.o obj-$(CONFIG_X86_32) += bugs.o cmpxchg.o obj-$(CONFIG_X86_64) += bugs_64.o
arch/x86/kernel/cpu/cpu_debug.c new file +692 -0
692 lines not on this page · raw message
Quoted 5 lines · Jaswinder Singh Rajput
Quoted 4 lines · Jaswinder Singh Rajput
The following changes since commit
cb553adb4e83bc5314b5a0c397e546a215b19307:
Ingo Molnar (1):
Merge branch 'tracing/printk'
Quoted 7 lines
Quoted 7 lines
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-tip-cpu.gitmasterJaswinder Singh Rajput (1):
x86: cpu architecture debug code
I still doubt that this is going to be useful (I don't see use cases for it). Nevertheless I have some comments.
arch/x86/kernel/cpu/Makefile endif · line 15
Quoted 13 lines
arch/x86/kernel/cpu/Makefile +1
-1@@ -9,7 +9,7 @@ endif obj-y := intel_cacheinfo.o addon_cpuid_features.o obj-y += proc.o capflags.o powerflags.o common.o -obj-y += vmware.o hypervisor.o +obj-y += vmware.o hypervisor.o cpu_debug.o obj-$(CONFIG_X86_32) += bugs.o cmpxchg.o obj-$(CONFIG_X86_64) += bugs_64.o
There is no kernel config option and this code will always be compiled in. Why?
Quoted 6 lines
arch/x86/kernel/cpu/cpu_debug.c new file +0
-0@@ -0,0 +1,692 @@
...
Quoted 12 lines
arch/x86/kernel/cpu/cpu_debug.c new file +12
-0+static int cpu_seq_show (struct seq_file *seq,void *v) +{ +struct cpu_private *priv = seq->private; + +if (priv ==NULL ) +return -EINVAL ; + +switch (cpu_base[priv->type].flag) { +case CPU_TSS : +smp_call_function_single (priv->cpu, print_stdreg, seq,1 ); +break ; +case CPU_CR :
arch/x86/kernel/cpu/cpu_debug.c line 470
Quoted 10 lines
arch/x86/kernel/cpu/cpu_debug.c new file +10
-0+smp_call_function_single (priv->cpu, print_cr, seq,1 ); +break ; +case CPU_DT : +smp_call_function_single (priv->cpu, print_dt, seq,1 ); +break ; +default : +print_msr (seq, priv->cpu, cpu_base[priv->type].flag); +break ; + } +seq_printf (seq,"\n" );
(As one example.) Please don't print empty lines.
General thoughts/questions:
Your code is not cpu-hotpluggable. The complete debugfs subtree shows up for all CPUs - including CPUs that are offline. Was this your intention?
How does this (especially dumping of register state) fit into other kernel debugging facilities, ie.
- kgdb
- sysrq
Regards,
Andreas
Signature · 5 lines
Operating | Advanced Micro Devices GmbH System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany Research | Geschäftsführer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München (OSRC) | Registergericht München, HRB Nr. 43632