Skip to contentSkip to conversation

ioemu: msi/msix clean up on hotplug remove

PATCH New Qing He 1 participant 1 message Mar 11, 2009

lore
Share & tools
lore

Qing He

author
#0 lore raw

PATCH 1/1 ioemu: msi/msix clean up on hotplug remove

The passthrough MSI/MSI-X should be unbound and unmapped when unregister_real_device is called, this patch fix this.

hw/pass-through.c +4 -10
index 4a86309..308bcc3 100644
@@ -3753,20 +3753,14 @@ int unregister_real_device(int php_slot)
                                        e_device, e_intx, 0);
         if ( rc < 0 )
         {
-            /* TBD: unregister device in case of an error */
             PT_LOG("Error: Unbinding of interrupt failed! rc=%d\n", rc);
         }
     }
-    else if (assigned_device->msi_trans_en)
-    {
-        rc = xc_domain_unbind_pt_irq(xc_handle, domid, assigned_device->msi->pirq,
-                                     PT_IRQ_TYPE_MSI_TRANSLATE, 0,
-                                     e_device, e_intx, 0);
-        if (rc < 0)
-            PT_LOG("Error: Unbinding pt irq for MSI-INTx failed! rc=%d\n", rc);
-    }
 
-    /* TODO: unmap passthrough MSI and MSI-X irqs */
+    if (assigned_device->msi)
+        pt_msi_disable(assigned_device);
+    if (assigned_device->msix)
+        pt_msix_disable(assigned_device);
 
     /* delete all emulated config registers */
     pt_config_delete(assigned_device);