PM: Start C-state definitions from base 0
Subsystems (3)
PATCH v3 1/1 PM: Start C-state definitions from base 0
The current definition of C-states starts from base 1. Whereas, the cpuidle driver uses base 0. This patch eliminates need for explicit mapping (add/ sbutract) due to different base values.
Signed-off-by Sanjeev Premi <[email protected]>
--- arch/arm/mach-omap2/cpuidle34xx.c | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-)
arch/arm/mach-omap2/cpuidle34xx.c +8 -8
@@ -33,13 +33,13 @@ #ifdef CONFIG_CPU_IDLE -#define OMAP3_MAX_STATES 7 -#define OMAP3_STATE_C1 1 /* C1 - MPU WFI + Core active */ -#define OMAP3_STATE_C2 2 /* C2 - MPU CSWR + Core active */ -#define OMAP3_STATE_C3 3 /* C3 - MPU OFF + Core active */ -#define OMAP3_STATE_C4 4 /* C4 - MPU RET + Core RET */ -#define OMAP3_STATE_C5 5 /* C5 - MPU OFF + Core RET */ -#define OMAP3_STATE_C6 6 /* C6 - MPU OFF + Core OFF */ +#define OMAP3_MAX_STATES 6 +#define OMAP3_STATE_C1 0 /* C1 - MPU WFI + Core active */ +#define OMAP3_STATE_C2 1 /* C2 - MPU CSWR + Core active */ +#define OMAP3_STATE_C3 2 /* C3 - MPU OFF + Core active */ +#define OMAP3_STATE_C4 3 /* C4 - MPU RET + Core RET */ +#define OMAP3_STATE_C5 4 /* C5 - MPU OFF + Core RET */ +#define OMAP3_STATE_C6 5 /* C6 - MPU OFF + Core OFF */ struct omap3_processor_cx { u8 valid;
@@ -244,7 +244,7 @@ int omap3_idle_init(void) dev = &per_cpu (omap3_idle_dev,smp_processor_id ()); -for (i =1 ; i <OMAP3_MAX_STATES ; i++) { +for (i =OMAP3_STATE_C1 ; i <OMAP3_MAX_STATES ; i++) { cx = &omap3_power_states[i]; state = &dev->states[count];
Signature · 1 line
1.5.6
Quoted 36 lines · Sanjeev Premi
The current definition of C-states starts from base 1. Whereas, the cpuidle driver uses base 0. This patch eliminates need for explicit mapping (add/ sbutract) due to different base values.
Signed-off-by Sanjeev Premi <[email protected]>--- arch/arm/mach-omap2/cpuidle34xx.c | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-)arch/arm/mach-omap2/cpuidle34xx.c +7
-7@@ -33,13 +33,13 @@ #ifdef CONFIG_CPU_IDLE -#define OMAP3_MAX_STATES 7 -#define OMAP3_STATE_C1 1 /* C1 - MPU WFI + Core active */ -#define OMAP3_STATE_C2 2 /* C2 - MPU CSWR + Core active */ -#define OMAP3_STATE_C3 3 /* C3 - MPU OFF + Core active */ -#define OMAP3_STATE_C4 4 /* C4 - MPU RET + Core RET */ -#define OMAP3_STATE_C5 5 /* C5 - MPU OFF + Core RET */ -#define OMAP3_STATE_C6 6 /* C6 - MPU OFF + Core OFF */ +#define OMAP3_MAX_STATES 6 +#define OMAP3_STATE_C1 0 /* C1 - MPU WFI + Core active */ +#define OMAP3_STATE_C2 1 /* C2 - MPU CSWR + Core active */ +#define OMAP3_STATE_C3 2 /* C3 - MPU OFF + Core active */ +#define OMAP3_STATE_C4 3 /* C4 - MPU RET + Core RET */ +#define OMAP3_STATE_C5 4 /* C5 - MPU OFF + Core RET */ +#define OMAP3_STATE_C6 5 /* C6 - MPU OFF + Core OFF */ struct omap3_processor_cx { u8 valid;
arch/arm/mach-omap2/cpuidle34xx.c int omap3_idle_init(void) · line 250
Quoted 8 lines
arch/arm/mach-omap2/cpuidle34xx.c +1
-1@@ -244,7 +244,7 @@ int omap3_idle_init(void) dev = &per_cpu (omap3_idle_dev,smp_processor_id ()); -for (i =1 ; i <OMAP3_MAX_STATES ; i++) { +for (i =OMAP3_STATE_C1 ; i <OMAP3_MAX_STATES ; i++) { cx = &omap3_power_states[i]; state = &dev->states[count];
Thanks, pushing to PM branch after slight fixup in order to apply after Peter's new C-state patch.
Kevin