RFC: Wacom Bluetooth HID driver, first pass
Subsystems (2)
Heya,
This is a first pass at a driver for the Wacom Graphire Bluetooth tablet, based on work by Andrew Zabolotny[1]. It's mildly tested (eg. it works in my very few tests).
I was looking for guidance for the code itself, possibly making it easier to merge in the input/tablet/wacom* drivers into it in the future, as well as some explanations as to how I'm supposed to reset tools, etc. so the user-space drivers (the X.org linuxwacom driver) doesn't need special-casing for the device.
Note that it requires a user-space activation to switch to Mode 2, using bluetoothd (as the Bluetooth HID doesn't support hid_output_raw_event). Patch at:
http://cvs.fedoraproject.org/viewvc/rpms/bluez/devel/bluez-activate-wacom-mode2.patch?view=markup
Cheers
[1]: http://cs.ozerki.net/zap/wacom-bt/
drivers/hid/Kconfig +7 -0
@@ -261,6 +261,13 @@ config THRUSTMASTER_FF Say Y here if you have a THRUSTMASTER FireStore Dual Power 2 or a THRUSTMASTER Ferrari GT Rumble Force or Force Feedback Wheel. +config HID_WACOM + tristate "Wacom Bluetooth devices support" if EMBEDDED + depends on BT_HIDP + default !EMBEDDED + ---help--- + Support for Wacom Graphire Bluetooth tablet. + config ZEROPLUS_FF tristate "Zeroplus based game controller support" depends on USB_HID
drivers/hid/Makefile +1 -0
@@ -41,6 +41,7 @@ obj-$(CONFIG_GREENASIA_FF) += hid-gaff.o obj-$(CONFIG_THRUSTMASTER_FF) += hid-tmff.o obj-$(CONFIG_HID_TOPSEED) += hid-topseed.o obj-$(CONFIG_ZEROPLUS_FF) += hid-zpff.o +obj-$(CONFIG_HID_WACOM) += hid-wacom.o obj-$(CONFIG_USB_HID) += usbhid/ obj-$(CONFIG_USB_MOUSE) += usbhid/
drivers/hid/hid-core.c +1 -0
@@ -1305,6 +1305,7 @@ static const struct hid_device_id hid_blacklist[] = { { HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb651) }, { HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb654) }, { HID_USB_DEVICE(USB_VENDOR_ID_TOPSEED, USB_DEVICE_ID_TOPSEED_CYBERLINK) }, + { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
drivers/hid/hid-ids.h +1 -0
@@ -400,6 +400,7 @@#define USB_DEVICE_ID_VERNIER_LCSPEC 0x0006#define USB_VENDOR_ID_WACOM 0x056a +#define USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH 0x81#define USB_VENDOR_ID_WISEGROUP 0x0925#define USB_DEVICE_ID_1_PHIDGETSERVO_20 0x8101
drivers/hid/hid-wacom.c new file +268 -0
268 lines not on this page · raw message
Quoted 12 lines · Bastien Nocera
Heya,
This is a first pass at a driver for the Wacom Graphire Bluetooth tablet, based on work by Andrew Zabolotny[1]. It's mildly tested (eg. it works in my very few tests).
I was looking for guidance for the code itself, possibly making it easier to merge in the input/tablet/wacom* drivers into it in the future, as well as some explanations as to how I'm supposed to reset tools, etc. so the user-space drivers (the X.org linuxwacom driver) doesn't need special-casing for the device.
Quoted 4 lines
Note that it requires a user-space activation to switch to Mode 2, using bluetoothd (as the Bluetooth HID doesn't support
hid_output_raw_event). Patch at:
http://cvs.fedoraproject.org/viewvc/rpms/bluez/devel/bluez-activate-wacom-mode2.patch?view=markup
A couple of notes:
- the wheel action is reversed, it's a simple fix, done locally
- hidp and the Bluetooth sub-system says it can't probe the device with error "-14" when hid-wacom.ko isn't already loaded
- I'm getting oopses in hci_conn_del() when the device goes away (eg. I turn it off).
I'd appreciate any help making this just a tad more stable.
Any comments about the code itself?
Cheers
PS: Original mail at
http://thread.gmane.org/gmane.linux.kernel.input/7078 for the Bluetooth hackers
Marcel Holtmann
maintainerHi Bastien,
Quoted 15 lines
Quoted 10 lines
This is a first pass at a driver for the Wacom Graphire Bluetooth tablet, based on work by Andrew Zabolotny[1]. It's mildly tested (eg. it works in my very few tests).
I was looking for guidance for the code itself, possibly making it easier to merge in the input/tablet/wacom* drivers into it in the future, as well as some explanations as to how I'm supposed to reset tools, etc. so the user-space drivers (the X.org linuxwacom driver) doesn't need special-casing for the device.
Quoted 4 lines
Note that it requires a user-space activation to switch to Mode 2, using bluetoothd (as the Bluetooth HID doesn't support
hid_output_raw_event). Patch at:
http://cvs.fedoraproject.org/viewvc/rpms/bluez/devel/bluez-activate-wacom-mode2.patch?view=markup
Quoted 5 lines
A couple of notes:
- the wheel action is reversed, it's a simple fix, done locally
- hidp and the Bluetooth sub-system says it can't probe the device with
error "-14" when hid-wacom.ko isn't already loaded
what was the reason for not forcing HID to load the generic driver? I lost track on how HID is suppose to handle these. You could also introduce a phony export like we do with L2CAP to ensure it is loaded even if userspace isn't ready to handle this dependency.
Quoted 3 lines
- I'm getting oopses in
hci_conn_del()when the device goes away (eg. I
turn it off).
Try to run a net-next-2.6 or bluetooth-next-2.6 kernel. Kyle should have merged these patches into the latest rawhide kernel.
Quoted 3 lines
I'd appreciate any help making this just a tad more stable.
Any comments about the code itself?
The main parsing function looks highly complicated and could either use more comments or break into two.
if ((wdata->tool = tool)) {
input_report_key(input, tool, 1);
need_sync = 1;
}Don't do the assignment in the if clause test. Did you run checkpatch.pl on it?
Regards
Marcel
Quoted 20 lines · Marcel Holtmann
Hi Bastien,
Quoted 18 lines
Quoted 17 lines
This is a first pass at a driver for the Wacom Graphire Bluetooth tablet, based on work by Andrew Zabolotny[1]. It's mildly tested (eg. it
works in my very few tests).I was looking for guidance for the code itself, possibly making it easier to merge in the input/tablet/wacom* drivers into it in the future, as well as some explanations as to how I'm supposed to reset tools, etc. so the user-space drivers (the X.org linuxwacom driver) doesn't need special-casing for the device.
Note that it requires a user-space activation to switch to Mode 2, using
bluetoothd (as the Bluetooth HID doesn't supporthid_output_raw_event).
Patch at:
http://cvs.fedoraproject.org/viewvc/rpms/bluez/devel/bluez-activate-wacom-mode2.patch?view=markup
Quoted 7 lines
Quoted 5 lines
A couple of notes:
- the wheel action is reversed, it's a simple fix, done locally
- hidp and the Bluetooth sub-system says it can't probe the device with
error "-14" when hid-wacom.ko isn't already loadedwhat was the reason for not forcing HID to load the generic driver?
What generic driver? If you're talking about the default Wacom driver, it isn't an HID driver, and requires a USB device.
Quoted 4 lines
I
lost track on how HID is suppose to handle these. You could also introduce a phony export like we do with L2CAP to ensure it is loaded even if userspace isn't ready to handle this dependency.
Well, the problem is that the driver _does_ load, but I'm not certain about the sequence of events between the Bluetooth sub-system, the user-space enabling (see the linked patch to bluetoothd), and the HID sub-system.
Quoted 6 lines
Quoted 3 lines
- I'm getting oopses in
hci_conn_del()when the device goes away (eg. I
turn it off).Try to run a net-next-2.6 or bluetooth-next-2.6 kernel. Kyle should have merged these patches into the latest rawhide kernel.
I was hoping this would be fixed in the latest linus-2.6 tree, guess not.
Quoted 6 lines
Quoted 3 lines
I'd appreciate any help making this just a tad more stable.
Any comments about the code itself?
The main parsing function looks highly complicated and could either use more comments or break into two.
The parsing is adapted from the code Andrew wrote, so I don't have any great insights into it. Right it's in "it works well enough to do things" mode, clean-ups and bug fixes will probably follow when my machine stops crashing when using that driver :)
Quoted 6 lines
if ((wdata->tool = tool)) { input_report_key(input, tool, 1); need_sync = 1; }Don't do the assignment in the if clause test.
As I mentioned, copy/paste code this is.
Quoted 2 lines
Did you run
checkpatch.pl on it?
Nope, I didn't, but will do.
Cheers
Quoted 1 line · Bastien Nocera
On Mon, 2009-03-16 at 15:00 +0100, Marcel Holtmann wrote:
<snip>
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
A couple of notes:
- the wheel action is reversed, it's a simple fix, done locally
- hidp and the Bluetooth sub-system says it can't probe the device with
error "-14" when hid-wacom.ko isn't already loaded
Bluetooth: HIDP (Human Interface Emulation) ver 1.2 wacom 0005:056A:0081.0001: parse failed
wacom: probe of 0005:056A:0081.0001 failed with error -14 wacom driver registered
Quoted 10 lines
Quoted 1 line
what was the reason for not forcing HID to load the generic driver?
What generic driver? If you're talking about the default Wacom driver, it isn't an HID driver, and requires a USB device.
Quoted 4 lines
I
lost track on how HID is suppose to handle these. You could also introduce a phony export like we do with L2CAP to ensure it is loaded even if userspace isn't ready to handle this dependency.
Quoted 4 lines
Well, the problem is that the driver _does_ load, but I'm not certain about the sequence of events between the Bluetooth sub-system, the user-space enabling (see the linked patch to bluetoothd), and the HID sub-system.
Turning the device off and on again works though. No idea what's happening.
Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
- I'm getting oopses in
hci_conn_del()when the device goes away (eg. I
turn it off).Try to run a net-next-2.6 or bluetooth-next-2.6 kernel. Kyle should have merged these patches into the latest rawhide kernel.
I was hoping this would be fixed in the latest linus-2.6 tree, guess not.
No more crashes. Great stuff.
I sent a fixed up patch to the list earlier.
Cheers
PATCH 1/1 Wacom Graphire Bluetooth driver
In reply to Bastien NoceraQuoted 1 line
Quoted 1 line
From
3495e3be72d1df6132d5f5d978d2def3e4d57fc3Mon Sep 17 00:00:00 2001
From: Bastien Nocera <[email protected]>
Date: Mon, 16 Mar 2009 23:36:54 +0000
Subject: [PATCH] Wacom Graphire Bluetooth driver
Based on the work by Andrew Zabolotny, an HID driver for the Bluetooth Wacom tablet. This is required as it uses a slightly different protocols from what's currently support by the drivers/input/wacom* driver, and those only support USB.
A user-space patch is required to activate mode 2 of the Wacom tablet, as hidp does not support hid_output_raw_report.
--- drivers/hid/Kconfig | 7 ++ drivers/hid/Makefile | 1 + drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h | 1 + drivers/hid/hid-wacom.c | 272 +++++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 282 insertions(+), 0 deletions(-) create mode 100644 drivers/hid/hid-wacom.c
drivers/hid/Kconfig +7 -0
@@ -261,6 +261,13 @@ config THRUSTMASTER_FF Say Y here if you have a THRUSTMASTER FireStore Dual Power 2 or a THRUSTMASTER Ferrari GT Rumble Force or Force Feedback Wheel. +config HID_WACOM + tristate "Wacom Bluetooth devices support" if EMBEDDED + depends on BT_HIDP + default !EMBEDDED + ---help--- + Support for Wacom Graphire Bluetooth tablet. + config ZEROPLUS_FF tristate "Zeroplus based game controller support" depends on USB_HID
drivers/hid/Makefile +1 -0
@@ -41,6 +41,7 @@ obj-$(CONFIG_GREENASIA_FF) += hid-gaff.o obj-$(CONFIG_THRUSTMASTER_FF) += hid-tmff.o obj-$(CONFIG_HID_TOPSEED) += hid-topseed.o obj-$(CONFIG_ZEROPLUS_FF) += hid-zpff.o +obj-$(CONFIG_HID_WACOM) += hid-wacom.o obj-$(CONFIG_USB_HID) += usbhid/ obj-$(CONFIG_USB_MOUSE) += usbhid/
drivers/hid/hid-core.c +1 -0
@@ -1305,6 +1305,7 @@ static const struct hid_device_id hid_blacklist[] = { { HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb651) }, { HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb654) }, { HID_USB_DEVICE(USB_VENDOR_ID_TOPSEED, USB_DEVICE_ID_TOPSEED_CYBERLINK) }, + { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
drivers/hid/hid-ids.h +1 -0
@@ -400,6 +400,7 @@#define USB_DEVICE_ID_VERNIER_LCSPEC 0x0006#define USB_VENDOR_ID_WACOM 0x056a +#define USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH 0x81#define USB_VENDOR_ID_WISEGROUP 0x0925#define USB_DEVICE_ID_1_PHIDGETSERVO_20 0x8101
drivers/hid/hid-wacom.c new file +272 -0
272 lines not on this page · raw message
Signature · 1 line
1.6.2
Re: [PATCH] Wacom Graphire Bluetooth driver (updated with a few fixes)
Quoted 1 line
Quoted 1 line
From
99074a7cf9622837af84d330e07bdb46307c254fMon Sep 17 00:00:00 2001
From: Bastien Nocera <[email protected]>
Date: Mon, 16 Mar 2009 23:36:54 +0000
Subject: [PATCH] Wacom Graphire Bluetooth driver
Based on the work by Andrew Zabolotny, an HID driver for the Bluetooth Wacom tablet. This is required as it uses a slightly different protocols from what's currently support by the drivers/input/wacom* driver, and those only support USB.
A user-space patch is required to activate mode 2 of the Wacom tablet, as hidp does not support hid_output_raw_report.
--- drivers/hid/Kconfig | 7 ++ drivers/hid/Makefile | 1 + drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h | 1 + drivers/hid/hid-wacom.c | 260 +++++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 270 insertions(+), 0 deletions(-) create mode 100644 drivers/hid/hid-wacom.c
drivers/hid/Kconfig +7 -0
@@ -261,6 +261,13 @@ config THRUSTMASTER_FF Say Y here if you have a THRUSTMASTER FireStore Dual Power 2 or a THRUSTMASTER Ferrari GT Rumble Force or Force Feedback Wheel. +config HID_WACOM + tristate "Wacom Bluetooth devices support" if EMBEDDED + depends on BT_HIDP + default !EMBEDDED + ---help--- + Support for Wacom Graphire Bluetooth tablet. + config ZEROPLUS_FF tristate "Zeroplus based game controller support" depends on USB_HID
drivers/hid/Makefile +1 -0
@@ -41,6 +41,7 @@ obj-$(CONFIG_GREENASIA_FF) += hid-gaff.o obj-$(CONFIG_THRUSTMASTER_FF) += hid-tmff.o obj-$(CONFIG_HID_TOPSEED) += hid-topseed.o obj-$(CONFIG_ZEROPLUS_FF) += hid-zpff.o +obj-$(CONFIG_HID_WACOM) += hid-wacom.o obj-$(CONFIG_USB_HID) += usbhid/ obj-$(CONFIG_USB_MOUSE) += usbhid/
drivers/hid/hid-core.c +1 -0
@@ -1305,6 +1305,7 @@ static const struct hid_device_id hid_blacklist[] = { { HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb651) }, { HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb654) }, { HID_USB_DEVICE(USB_VENDOR_ID_TOPSEED, USB_DEVICE_ID_TOPSEED_CYBERLINK) }, + { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
drivers/hid/hid-ids.h +1 -0
@@ -400,6 +400,7 @@#define USB_DEVICE_ID_VERNIER_LCSPEC 0x0006#define USB_VENDOR_ID_WACOM 0x056a +#define USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH 0x81#define USB_VENDOR_ID_WISEGROUP 0x0925#define USB_DEVICE_ID_1_PHIDGETSERVO_20 0x8101
drivers/hid/hid-wacom.c new file +260 -0
260 lines not on this page · raw message
Signature · 1 line
1.6.2
Re: [PATCH] Wacom Graphire Bluetooth driver (updated with a few fixes)
From Wed, 18 Mar 2009 00:11:52 +0000
Quoted 2 lines · Bastien Nocera
Based on the work by Andrew Zabolotny, an HID driver for the Bluetooth Wacom tablet.
Great to see my old work was finally useful :) I tried in the past to contact the bluetooth stack author to submit my patch, but got no answer and gave up.
Also I like the fact that you have dropped my wicked out-of-active-area pseudo-buttons support. Such kind of things should be implemented, if needed, in the x11 driver (but the driver would need a way to report out-of-active area stylus presses).
What's that "mode 2 patch" you're talking about? Should it be applied to hidd, and is it available somewhere?
Signature · 1 line
Andrew
Re: [PATCH] Wacom Graphire Bluetooth driver (updated with a few fixes)
Quoted 8 lines · Andrew Zabolotny
From Wed, 18 Mar 2009 00:11:52 +0000
Quoted 2 lines · Bastien Nocera
Based on the work by Andrew Zabolotny, an HID driver for the Bluetooth Wacom tablet.
Great to see my old work was finally useful :) I tried in the past to contact the bluetooth stack author to submit my patch, but got no answer and gave up.
I think that the main problem was because, at that time, there was no such thing as the HID sub-system to avoid having to reimplement things twice for Bluetooth and USB devices.
And adding support for a specific device in the hidp driver isn't the best way to do this. Nowadays the driver for joysticks and keyboards are the same whether Bluetooth or USB.
Quoted 4 lines
Also I like the fact that you have dropped my wicked out-of-active-area pseudo-buttons support. Such kind of things should be implemented, if needed, in the x11 driver (but the driver would need a way to report out-of-active area stylus presses).
I removed it because the other drivers didn't implement it. If it were to be implemented, the USB drivers would need to support it as well, so that the interface is agreed upon.
Better start with something small, and get it merged, then discuss extensions.
Quoted 2 lines
What's that "mode 2 patch" you're talking about? Should it be applied to hidd, and is it available somewhere?
It's at:
http://cvs.fedoraproject.org/viewvc/rpms/bluez/devel/bluez-activate-wacom-mode2.patch?view=markup
And it's a patch to input plugin for bluetoothd, not hidd. hidd is the BlueZ 3.x daemon, we've been at BlueZ 4.x for a while.
The bluetoothd patch is already in Fedora rawhide, and the kernel patch will get there once we've released Fedora 11 Beta.
Cheers
Re: [PATCH] Wacom Graphire Bluetooth driver (updated with a few fixes)
From Wed, 18 Mar 2009 22:47:28 +0000
Quoted 3 lines · Bastien Nocera
I think that the main problem was because, at that time, there was no such thing as the HID sub-system to avoid having to reimplement things twice for Bluetooth and USB devices.
Yes, that was the main problem and I hoped to discuss it with the bluetooth stack developers... The solution, as I was seeing it, is to make the bluetooth stack implement a "bluetooth bus": this would allow to emit udev events when devices are connected/disconnected, thus using the normal udev module autoloading stuff.
However, I see that the bluetooth stuff chose another path, by using a user-space daemon. I'm very far from bluetooth developement to understand why this choice was made, however I'm pretty sure there were serious arguments in favour of that.
Quoted 2 lines
And it's a patch to input plugin for bluetoothd, not hidd. hidd is the BlueZ 3.x daemon, we've been at BlueZ 4.x for a while.
Aha, it's the stuff for low-level tablet protocol initialization. Why separating it from the driver itself? It's kind of tricky having hardware initialization in a user-space daemon, and working with hardware in the driver itself. Isn't there an analogue of the hidp_send_ctrl_message() call for the new hid driver architecture?
Signature · 1 line
Andrew
Re: [PATCH] Wacom Graphire Bluetooth driver
In reply to Bastien NoceraQuoted 4 lines · Bastien Nocera
Quoted 1 line
From
3495e3be72d1df6132d5f5d978d2def3e4d57fc3Mon Sep 17 00:00:00 2001From: Bastien Nocera <[email protected]>
Date: Mon, 16 Mar 2009 23:36:54 +0000
Subject: [PATCH] Wacom Graphire Bluetooth driver
Any news on the patch? Matthew kindly added it to the Fedora 11 kernel:
http://cvs.fedoraproject.org/viewvc/rpms/kernel/F-11/linux-2.6-input-wacom-bluetooth.patch?view=log
Cheers
Re: [PATCH] Wacom Graphire Bluetooth driver (updated with a few fixes)
In reply to Bastien NoceraQuoted 1 line
From
99074a7cf9622837af84d330e07bdb46307c254fMon Sep 17 00:00:00 2001
From: Bastien Nocera <[email protected]>
Date: Mon, 16 Mar 2009 23:36:54 +0000
Subject: [PATCH] Wacom Graphire Bluetooth driver
Based on the work by Andrew Zabolotny, an HID driver for the Bluetooth Wacom tablet. This is required as it uses a slightly different protocols from what's currently support by the drivers/input/wacom* driver, and those only support USB.
A user-space patch is required to activate mode 2 of the Wacom tablet, as hidp does not support hid_output_raw_report.
--- drivers/hid/Kconfig | 7 ++ drivers/hid/Makefile | 1 + drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h | 1 + drivers/hid/hid-wacom.c | 260 +++++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 270 insertions(+), 0 deletions(-) create mode 100644 drivers/hid/hid-wacom.c
drivers/hid/Kconfig +7 -0
@@ -261,6 +261,13 @@ config THRUSTMASTER_FF Say Y here if you have a THRUSTMASTER FireStore Dual Power 2 or a THRUSTMASTER Ferrari GT Rumble Force or Force Feedback Wheel. +config HID_WACOM + tristate "Wacom Bluetooth devices support" if EMBEDDED + depends on BT_HIDP + default !EMBEDDED + ---help--- + Support for Wacom Graphire Bluetooth tablet. + config ZEROPLUS_FF tristate "Zeroplus based game controller support" depends on USB_HID
drivers/hid/Makefile +1 -0
@@ -41,6 +41,7 @@ obj-$(CONFIG_GREENASIA_FF) += hid-gaff.o obj-$(CONFIG_THRUSTMASTER_FF) += hid-tmff.o obj-$(CONFIG_HID_TOPSEED) += hid-topseed.o obj-$(CONFIG_ZEROPLUS_FF) += hid-zpff.o +obj-$(CONFIG_HID_WACOM) += hid-wacom.o obj-$(CONFIG_USB_HID) += usbhid/ obj-$(CONFIG_USB_MOUSE) += usbhid/
drivers/hid/hid-core.c +1 -0
@@ -1305,6 +1305,7 @@ static const struct hid_device_id hid_blacklist[] = { { HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb651) }, { HID_USB_DEVICE(USB_VENDOR_ID_THRUSTMASTER, 0xb654) }, { HID_USB_DEVICE(USB_VENDOR_ID_TOPSEED, USB_DEVICE_ID_TOPSEED_CYBERLINK) }, + { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_WACOM, USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) }, { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
drivers/hid/hid-ids.h +1 -0
@@ -400,6 +400,7 @@#define USB_DEVICE_ID_VERNIER_LCSPEC 0x0006#define USB_VENDOR_ID_WACOM 0x056a +#define USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH 0x81#define USB_VENDOR_ID_WISEGROUP 0x0925#define USB_DEVICE_ID_1_PHIDGETSERVO_20 0x8101
drivers/hid/hid-wacom.c new file +260 -0
260 lines not on this page · raw message
Signature · 1 line
1.6.2
Re: [PATCH] Wacom Graphire Bluetooth driver (updated with a few fixes)
Quoted 6 lines · Bastien Nocera
Signed-off-by Bastien Nocera <[email protected]>Based on the work by Andrew Zabolotny, an HID driver for the Bluetooth Wacom tablet. This is required as it uses a slightly different protocols from what's currently support by the
drivers/input/wacom*driver, and those only support USB.
Hi Bastien,
thanks for the driver.
Quoted 1 line
+HID_COMPAT_LOAD_DRIVER(wacom);
We don't need this one anymore, the HID_COMPAT stuff has gone away completely already.
Otherwise, it looks good. So if you agree, I will remove the COMPAT stuff and queue it in my tree.
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs
Re: [PATCH] Wacom Graphire Bluetooth driver (updated with a few fixes)
Quoted 13 lines · Jiri Kosina
Quoted 6 lines · Bastien Nocera
Signed-off-by Bastien Nocera <[email protected]>Based on the work by Andrew Zabolotny, an HID driver for the Bluetooth Wacom tablet. This is required as it uses a slightly different protocols from what's currently support by the
drivers/input/wacom*driver, and those only support USB.Hi Bastien,
thanks for the driver.
Quoted 7 lines
Quoted 1 line
+HID_COMPAT_LOAD_DRIVER(wacom);
We don't need this one anymore, the
HID_COMPATstuff has gone away completely already.Otherwise, it looks good. So if you agree, I will remove the COMPAT stuff and queue it in my tree.
Fine by me. Thanks!