Skip to contentSkip to conversation

ARM: DaVinci: ASoC: Adds Audio support for TI DM646X

PATCH In review Naresh Medisetty 2 participants 3 messages Mar 16, 2009 – Mar 18, 2009

lore
Share & tools
lore
#0 lore raw

cover ARM: DaVinci: ASoC: Adds Audio support for TI DM646X

Adds Audio support for TI DM646X EVM platform

---
This patch set adds audio support for DM646x

This series is dependant on the following 2 patches submitted to the DaVinci git:

[PATCH 1/2] ARM: DaVinci: EDMA: Move queue to tc mapping to dm<soc>.c [PATCH 2/2] ARM: DaVinci: EDMA: Enable EDMA support for dm646x

Patch 1: Adds ASoC driver support for TI DM646X EVM platform
Applies to the DaVinci git.

Patch 2: Adds ALSA SoC McASP Audio Layer for TI DM646X processor
Applies to the ASoC tree.

Patch 3: Adds header file for McASP Audio Layer for TI DM646X processor
Applies to the ASoC tree.

Patch 4: Adds ALSA PCM interface for the TI DM646X processor
Applies to the ASoC tree.

Patch 5: Adds Audio Serial Port support for TI DM646X processor
Applies to the DaVinci git.

Patch 6: Adds McASP clock support for TI DM646X processor
Applies to the DaVinci git.

Patch 7: Adds ALSA SoC DIT driver support for DM646X
Applies to the ASoC tree.

Patch 8: ASoC: Adds header file for DM646X DIT driver
Applies to the ASoC tree.

Patch 9: Adds build support for DM646X audio driver
Applies to the ASoC tree.

These patches are based on the work done by Steve Chen <[email protected]> on Monstavista 2.6.18 kernel.

Even without these patches the ASoC tree (http://opensource.wolfsonmicro.com/cgi-bin/gitweb.cgi?p=linux-2.6-asoc.git;a=commit;h=168776ef58d38503f8ac4f8a7eb1039137208032) build for DaVinci is broken.

#1 lore raw
Quoted 3 lines · Naresh Medisetty

Adds Audio support for TI DM646X EVM platform

I'm broadly OK with anything I haven't specifically commented on here. However, the ASoC bits of the series need to be updated to reflect the current ASoC APIs. Some additional documentation for your changes to the EVM would be very helpful.

It would also be very much better if you could restructure the series to reflect the changes you're making. You're actually doing three things:

- Add support for a dummy codec.
- Add support for the McASP port on the DaVinci.
- Update the DaVinci EVM driver to use these two things on relevant EVMs.

and the series should be structured to reflect this. The codec and EVM support should each go in a single patch by themselves. The McASP support is big enough to be broken down but it does need to come before the EVM support that uses it.

#2 lore raw

Mark,

Thanks for the review.

I will re-submit the series by taking care of your comments.

Quoted 7 lines

-----Original Message-----
From: naresh [mailto:[email protected]]
Sent: Wednesday, March 18, 2009 5:50 PM
To: '[email protected]'<mailto:'[email protected]'>
Subject:

On Mon, Mar 16, 2009 at 08:00:54AM -0400, Naresh Medisetty wrote:

Quoted 8 lines
Quoted 3 lines

Adds Audio support for TI DM646X EVM platform

I'm broadly OK with anything I haven't specifically commented on here. However, the ASoC bits of the series need to be updated to reflect the current ASoC APIs. Some additional documentation for your changes to the EVM would be very helpful.

I will take elaborate the documentation while re-submitting the patches

Quoted 10 lines

It would also be very much better if you could restructure the series to
reflect the changes you're making. You're actually doing three things:

- Add support for a dummy codec.
- Add support for the McASP port on the DaVinci.
- Update the DaVinci EVM driver to use these two things on relevant EVMs.

Quoted 4 lines

and the series should be structured to reflect this. The codec and EVM support should each go in a single patch by themselves. The McASP support is big enough to be broken down but it does need to come before the EVM support that uses it.

I will structure the series according to this.