Skip to contentSkip to conversation

ath5k: disable MIB interrupts

PATCH New Bob Copeland 1 participant 2 messages Mar 17, 2009 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ath5k: disable MIB interrupts

The MIB interrupt fires whenever counters overflow; however without support for automatic noise immunity, we can sometimes get an interrupt storm. The get_stats() callback reads the counters anyway so we can disable the interrupt for now until ANI is implemented. This fixes the issue reported in http://bugzilla.kernel.org/show_bug.cgi?id=12647.

Changes-licensed-under: 3-Clause-BSD

---
 drivers/net/wireless/ath5k/base.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/ath5k/base.c +1 -1
index cad3ccf..8eec155 100644
@@ -2305,7 +2305,7 @@ ath5k_init(struct ath5k_softc *sc)
 	sc->curband = &sc->sbands[sc->curchan->band];
 	sc->imask = AR5K_INT_RXOK | AR5K_INT_RXERR | AR5K_INT_RXEOL |
 		AR5K_INT_RXORN | AR5K_INT_TXDESC | AR5K_INT_TXEOL |
-		AR5K_INT_FATAL | AR5K_INT_GLOBAL | AR5K_INT_MIB;
+		AR5K_INT_FATAL | AR5K_INT_GLOBAL;
 	ret = ath5k_reset(sc, false, false);
 	if (ret)
 		goto done;
Signature · 1 line
1.6.0.6
#1 lore raw

PATCH 2/2 ath5k: remove dummy PCI "retry timeout" fix

Remove the PCI retry timeout code, for all the same reasons that Luis Rodriguez removed it for ath9k (wireless-testing commit 3149fde1bf083d32d5190cdc7f2bf8d0035966b1).

Changes-licensed-under: 3-Clause-BSD

Cc Luis Rodriguez <[email protected]>
---
 drivers/net/wireless/ath5k/base.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)
drivers/net/wireless/ath5k/base.c +0 -7
index 8eec155..ef9825f 100644
@@ -685,13 +685,6 @@ ath5k_pci_resume(struct pci_dev *pdev)
 	if (err)
 		return err;
 
-	/*
-	 * Suspend/Resume resets the PCI configuration space, so we have to
-	 * re-disable the RETRY_TIMEOUT register (0x41) to keep
-	 * PCI Tx retries from interfering with C3 CPU state
-	 */
-	pci_write_config_byte(pdev, 0x41, 0);
-
 	err = request_irq(pdev->irq, ath5k_intr, IRQF_SHARED, "ath", sc);
 	if (err) {
 		ATH5K_ERR(sc, "request_irq failed\n");
Signature · 1 line
1.6.0.6