radio-mr800.c: Missing mutex include
Subsystems (2)
PATCH 1/1 radio-mr800.c: Missing mutex include
radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be pulled in indirectly by one of the headers it already includes, the right thing is to include it directly.
--- drivers/media/radio/radio-mr800.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/media/radio/radio-mr800.c +1 -0
@@ -58,6 +58,7 @@#include <media/v4l2-ioctl.h> #include <linux/usb.h> #include <linux/version.h> /* for KERNEL_VERSION MACRO */ +#include <linux/mutex.h> /* driver and module definitions */ #define DRIVER_AUTHOR "Alexey Klimov <[email protected]>"
Signature · 1 line
1.6.0.4
Quoted 3 lines · Alessio Igor Bogani
radio-mr800.cuses struct mutex, so while <linux/mutex.h> seems to be pulled in indirectly by one of the headers it already includes, the right thing is to include it directly.
Hello, Alessio
Patch looks okay for my eyes.
If it useful it should be applied.
Thank you!
Mauro, if patch is okay please apply it.
If you need my ack - here it is:
Signature · 1 line
Best regards, Klimov Alexey
Quoted 8 lines · On Wed, 18 Mar 2009 00:42:08 +0300 Alexey Klimov <[email protected]> wrote:
Quoted 3 lines · Alessio Igor Bogani
radio-mr800.cuses struct mutex, so while <linux/mutex.h> seems to be pulled in indirectly by one of the headers it already includes, the right thing is to include it directly.Hello, Alessio
Quoted 8 lines
Patch looks okay for my eyes.
If it useful it should be applied.Thank you!
Mauro, if patch is okay please apply it.
If you need my ack - here it is:Acked-by Alexey Klimov <[email protected]>
If the mutex.h were already included by another kernel header, I don't see why to include it again. If a later patch remove the mutex.h from the header, then the patch author should take care of this change anyway.
Cheers,
Mauro