Skip to contentSkip to conversation

Staging: comedi: Fix an other build problem

PATCH In review Alessio Igor Bogani 2 participants 2 messages Mar 20, 2009 – Mar 21, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: comedi: Fix an other build problem

[...]
CC [M] drivers/staging/comedi/comedi_compat32.o
drivers/staging/comedi/comedi_compat32.c: In function ‘raw_ioctl’:
drivers/staging/comedi/comedi_compat32.c:451: error: ‘comedi32_chaninfo’ undeclared (first use in this function) drivers/staging/comedi/comedi_compat32.c:451: error: (Each undeclared identifier is reported only once drivers/staging/comedi/comedi_compat32.c:451: error: for each function it appears in.) drivers/staging/comedi/comedi_compat32.c:454: error: expected expression before ‘)’ token drivers/staging/comedi/comedi_compat32.c:454: error: expected expression before ‘)’ token drivers/staging/comedi/comedi_compat32.c:457: error: expected expression before ‘)’ token drivers/staging/comedi/comedi_compat32.c:457: error: expected expression before ‘)’ token drivers/staging/comedi/comedi_compat32.c:460: error: expected expression before ‘)’ token drivers/staging/comedi/comedi_compat32.c:460: error: expected expression before ‘)’ token drivers/staging/comedi/comedi_compat32.c:463: error: expected expression before ‘)’ token drivers/staging/comedi/comedi_compat32.c:463: error: expected expression before ‘)’ token drivers/staging/comedi/comedi_compat32.c:466: error: expected expression before ‘)’ token drivers/staging/comedi/comedi_compat32.c:466: error: expected expression before ‘)’ token [...]

---
 drivers/staging/comedi/comedi_compat32.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
drivers/staging/comedi/comedi_compat32.c +6 -6
index 2fa771e..5708f46 100644
@@ -37,16 +37,16 @@
 #include <linux/ioctl32.h>	/* for (un)register_ioctl32_conversion */
 #endif
 
-#define COMEDI32_CHANINFO _IOR(CIO, 3, comedi32_chaninfo)
-#define COMEDI32_RANGEINFO _IOR(CIO, 8, (struct comedi32_rangeinfo_struct))
+#define COMEDI32_CHANINFO _IOR(CIO, 3, struct comedi32_chaninfo_struct)
+#define COMEDI32_RANGEINFO _IOR(CIO, 8, struct comedi32_rangeinfo_struct)
 /* N.B. COMEDI32_CMD and COMEDI_CMD ought to use _IOWR, not _IOR.
  * It's too late to change it now, but it only affects the command number. */
-#define COMEDI32_CMD _IOR(CIO, 9, (struct comedi32_cmd_struct))
+#define COMEDI32_CMD _IOR(CIO, 9, struct comedi32_cmd_struct)
 /* N.B. COMEDI32_CMDTEST and COMEDI_CMDTEST ought to use _IOWR, not _IOR.
  * It's too late to change it now, but it only affects the command number. */
-#define COMEDI32_CMDTEST _IOR(CIO, 10, (struct comedi32_cmd_struct))
-#define COMEDI32_INSNLIST _IOR(CIO, 11, (struct comedi32_insnlist_struct))
-#define COMEDI32_INSN _IOR(CIO, 12, (struct comedi32_insn_struct))
+#define COMEDI32_CMDTEST _IOR(CIO, 10, struct comedi32_cmd_struct)
+#define COMEDI32_INSNLIST _IOR(CIO, 11, struct comedi32_insnlist_struct)
+#define COMEDI32_INSN _IOR(CIO, 12, struct comedi32_insn_struct)
 
 struct comedi32_chaninfo_struct {
 	unsigned int subdev;
Signature · 1 line
1.6.0.4
#1 lore raw
Quoted 9 lines · Alessio Igor Bogani

[...]
CC [M] drivers/staging/comedi/comedi_compat32.o
drivers/staging/comedi/comedi_compat32.c: In function ‘raw_ioctl’:
drivers/staging/comedi/comedi_compat32.c:451: error: ‘comedi32_chaninfo’ undeclared (first use in this function) drivers/staging/comedi/comedi_compat32.c:451: error: (Each undeclared identifier is reported only once drivers/staging/comedi/comedi_compat32.c:451: error: for each function it appears in.) drivers/staging/comedi/comedi_compat32.c:454: error: expected expression before ‘)’ token drivers/staging/comedi/comedi_compat32.c:454: error: expected expression before ‘)’ token drivers/staging/comedi/comedi_compat32.c:457: error: expected expression before ‘)’ token

Quoted 8 lines

drivers/staging/comedi/comedi_compat32.c:457: error: expected expression before ‘)’ token drivers/staging/comedi/comedi_compat32.c:460: error: expected expression before ‘)’ token drivers/staging/comedi/comedi_compat32.c:460: error: expected expression before ‘)’ token drivers/staging/comedi/comedi_compat32.c:463: error: expected expression before ‘)’ token drivers/staging/comedi/comedi_compat32.c:463: error: expected expression before ‘)’ token drivers/staging/comedi/comedi_compat32.c:466: error: expected expression before ‘)’ token drivers/staging/comedi/comedi_compat32.c:466: error: expected expression before ‘)’ token [...]

Ah, sorry, I just fixed this before I saw your patch (based on Randy's previous complaint.)

thanks,

greg k-h