Alsa-state: Wildcard removed and all *.state put back in the recipes
PATCH 1/1 Alsa-state: Wildcard removed and all *.state put back in the recipes
The wildcard doesn't work properly.
So either the wildcard support must be fixed or all the *.state files must be added in the SRC_URI.
--- recipes/alsa/alsa-state.bb | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-)
recipes/alsa/alsa-state.bb +9 -1
@@ -13,7 +13,15 @@ SRC_URI = "\ file://asound.conf \ file://asound.state \ file://alsa-state \ - file://*.state \ + file://asound.state \ + file://at91sam9263ek/asound.state \ + file://spitz/asound.state \ + file://tosa/asound.state \ + file://c7x0/asound.state \ + file://magician/asound.state \ + file://hx4700/asound.state \ + file://nokia800/asound.state \ + file://akita/asound.state \ " inherit update-rc.d
Signature · 1 line
1.5.6.3
Quoted 2 lines · Matthieu Poullet
The wildcard doesn't work properly.
So either the wildcard support must be fixed or all the *.state files must be added in theSRC_URI.
This makes the packages created from this recipe more deterministic.
Quoted 26 lines
--- recipes/alsa/alsa-state.bb | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-)recipes/alsa/alsa-state.bb +9
-1@@ -13,7 +13,15 @@ SRC_URI = "\ file://asound.conf \ file://asound.state \ file://alsa-state \ - file://*.state \ + file://asound.state \ + file://at91sam9263ek/asound.state \ + file://spitz/asound.state \ + file://tosa/asound.state \ + file://c7x0/asound.state \ + file://magician/asound.state \ + file://hx4700/asound.state \ + file://nokia800/asound.state \ + file://akita/asound.state \ " inherit update-rc.d
Andrea Adami
Acked-bytested here. thx.
Dnia niedziela, 22 marca 2009 o 15:12:22 Matthieu Poullet napisał(a):
Quoted 3 lines
The wildcard doesn't work properly.
So either the wildcard support must be fixed or all the *.state files must be added in theSRC_URI.
NACK
recipes/alsa/alsa-state.bb SRC_URI = "\ · line 16
Quoted 10 lines
recipes/alsa/alsa-state.bb +1
-1@@ -13,7 +13,15 @@ SRC_URI = "\ file://asound.conf \ file://asound.state \ file://alsa-state \ - file://*.state \ + file://asound.state \
This should be enough. BitBake will take proper asound.state from MACHINE/ directory if it is present.
recipes/alsa/alsa-state.bb SRC_URI = "\ · line 24
Quoted 8 lines
recipes/alsa/alsa-state.bb +8
-0+ file://at91sam9263ek/asound.state \ + file://spitz/asound.state \ + file://tosa/asound.state \ + file://c7x0/asound.state \ + file://magician/asound.state \ + file://hx4700/asound.state \ + file://nokia800/asound.state \ + file://akita/asound.state \
That part is wrong.
Regards,
Signature · 3 lines
JID: [email protected] Website: http://marcin.juszkiewicz.com.pl/ LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz
Quoted 2 lines
Review
Quoted 2 lines
(quoted diff) +0
-0
I looked more at that recipe and found few bugs in it:
1. It assumes that 'asound.conf' is same for all devices. This is not true for 'at91sam9263ek' which kernel oops with default file.
2. It plays with INITSCRIPT_PARAMS in postinst script. I do not know maybe it was required in past but why it is present now? No idea and no info in recipe why it is that way.
3. Postinst script restore default ALSA settings which is ugly too - what if user just muted all channels to have device quiet during night and postinst just makes his 1000W 7.1 audio system goes to full volume at 02:00 at night?
4. With current version is is broken for a780 device which has few states files available.
Regards,
Signature · 3 lines
JID: [email protected] Website: http://marcin.juszkiewicz.com.pl/ LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz
Dnia niedziela, 22 marca 2009 o 20:15:33 Marcin Juszkiewicz napisał(a):
Quoted 6 lines
Quoted 1 line
Review
Quoted 1 line
(quoted diff) +0
-0I looked more at that recipe and found few bugs in it:
1. It assumes that 'asound.conf' is same for all devices. This is not true for 'at91sam9263ek' which kernel oops with default file.
fixed in 139b0c1bad85fb628bc6a265a6da08dd190f684a
Quoted 11 lines
2. It plays with
INITSCRIPT_PARAMSin postinst script. I do not know maybe it was required in past but why it is present now? No idea and no info in recipe why it is that way.3. Postinst script restore default ALSA settings which is ugly too - what if user just muted all channels to have device quiet during night and postinst just makes his 1000W 7.1 audio system goes to full volume at 02:00 at night?
4. With current version is is broken for a780 device which has few states files available.
fixed in 30b5d30c274b2ae748ed65edea62cef40a23ce32
Regards,
Signature · 3 lines
JID: [email protected] Website: http://marcin.juszkiewicz.com.pl/ LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz
Dnia niedziela, 22 marca 2009 o 19:29:47 Marcin Juszkiewicz napisał(a):
Quoted 5 lines
Quoted 3 lines
The wildcard doesn't work properly.
So either the wildcard support must be fixed or all the *.state files must be added in theSRC_URI.NACK
fix pushed in dc6fc903acadd55c5fc5156f6997e0c055028a76
Regards,
Signature · 3 lines
JID: [email protected] Website: http://marcin.juszkiewicz.com.pl/ LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz