Skip to contentSkip to conversation

trace: ring_buffer.c fix various signedness issues

PATCH In review Jaswinder Singh Rajput 2 participants 3 messages Mar 22, 2009 – Mar 23, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 trace: ring_buffer.c fix various signedness issues

From: Jaswinder Singh Rajput <[email protected]>
Date: Mon, 23 Mar 2009 00:02:38 +0530
Subject: [PATCH] trace: ring_buffer.c fix various signedness issues

Impact:cleanup

---
 kernel/trace/ring_buffer.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
kernel/trace/ring_buffer.c +4 -4
index bd38c5c..114811b 100644
@@ -57,7 +57,7 @@ enum {
 	RB_BUFFERS_DISABLED	= 1 << RB_BUFFERS_DISABLED_BIT,
 };
 
-static long ring_buffer_flags __read_mostly = RB_BUFFERS_ON;
+static unsigned long ring_buffer_flags __read_mostly = RB_BUFFERS_ON;
 
 /**
  * tracing_on - enable all tracing buffers
@@ -2466,7 +2466,7 @@ static ssize_t
 rb_simple_read(struct file *filp, char __user *ubuf,
 	       size_t cnt, loff_t *ppos)
 {
-	long *p = filp->private_data;
+	unsigned long *p = filp->private_data;
 	char buf[64];
 	int r;
 
@@ -2482,9 +2482,9 @@ static ssize_t
 rb_simple_write(struct file *filp, const char __user *ubuf,
 		size_t cnt, loff_t *ppos)
 {
-	long *p = filp->private_data;
+	unsigned long *p = filp->private_data;
+	unsigned long val;
 	char buf[64];
-	long val;
 	int ret;
 
 	if (cnt >= sizeof(buf))
Signature · 1 line
1.6.0.6
#1 lore raw
Quoted 4 lines · Jaswinder Singh Rajput

From: Jaswinder Singh Rajput <[email protected]>
Date: Mon, 23 Mar 2009 00:02:38 +0530
Subject: [PATCH] trace: ring_buffer.c fix various signedness issues

BTW, these issues were solved by this patch:

CHECK kernel/trace/ring_buffer.c
kernel/trace/ring_buffer.c:70:30: warning: incorrect type in argument 2 (different signedness)
kernel/trace/ring_buffer.c:70:30: expected unsigned long volatile *addr
kernel/trace/ring_buffer.c:70:30: got long static [toplevel] *<noident>
kernel/trace/ring_buffer.c:84:32: warning: incorrect type in argument 2 (different signedness)
kernel/trace/ring_buffer.c:84:32: expected unsigned long volatile *addr
kernel/trace/ring_buffer.c:84:32: got long static [toplevel] *<noident>
kernel/trace/ring_buffer.c:96:36: warning: incorrect type in argument 2 (different signedness)
kernel/trace/ring_buffer.c:96:36: expected unsigned long volatile *addr
kernel/trace/ring_buffer.c:96:36: got long static [toplevel] *<noident>
kernel/trace/ring_buffer.c:2473:6: warning: incorrect type in argument 2 (different signedness)
kernel/trace/ring_buffer.c:2473:6: expected unsigned long const volatile *addr
kernel/trace/ring_buffer.c:2473:6: got long *p
kernel/trace/ring_buffer.c:2473:6: warning: incorrect type in argument 2 (different signedness)
kernel/trace/ring_buffer.c:2473:6: expected unsigned long const volatile *addr
kernel/trace/ring_buffer.c:2473:6: got long *p
kernel/trace/ring_buffer.c:2476:28: warning: incorrect type in argument 2 (different signedness)
kernel/trace/ring_buffer.c:2476:28: expected unsigned long const volatile *addr
kernel/trace/ring_buffer.c:2476:28: got long *p
kernel/trace/ring_buffer.c:2476:28: warning: incorrect type in argument 2 (different signedness)
kernel/trace/ring_buffer.c:2476:28: expected unsigned long const volatile *addr
kernel/trace/ring_buffer.c:2476:28: got long *p
kernel/trace/ring_buffer.c:2498:33: warning: incorrect type in argument 3 (different signedness)
kernel/trace/ring_buffer.c:2498:33: expected unsigned long *<noident>
kernel/trace/ring_buffer.c:2498:33: got long *<noident>
kernel/trace/ring_buffer.c:2503:30: warning: incorrect type in argument 2 (different signedness)
kernel/trace/ring_buffer.c:2503:30: expected unsigned long volatile *addr
kernel/trace/ring_buffer.c:2503:30: got long *p
kernel/trace/ring_buffer.c:2505:32: warning: incorrect type in argument 2 (different signedness)
kernel/trace/ring_buffer.c:2505:32: expected unsigned long volatile *addr
kernel/trace/ring_buffer.c:2505:32: got long *p

Quoted 41 lines

Impact:cleanup

---
 kernel/trace/ring_buffer.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
kernel/trace/ring_buffer.c +4 -4
index bd38c5c..114811b 100644
@@ -57,7 +57,7 @@ enum {
 	RB_BUFFERS_DISABLED	= 1 << RB_BUFFERS_DISABLED_BIT,
 };
 
-static long ring_buffer_flags __read_mostly = RB_BUFFERS_ON;
+static unsigned long ring_buffer_flags __read_mostly = RB_BUFFERS_ON;
 
 /**
  * tracing_on - enable all tracing buffers
@@ -2466,7 +2466,7 @@ static ssize_t
 rb_simple_read(struct file *filp, char __user *ubuf,
 	       size_t cnt, loff_t *ppos)
 {
-	long *p = filp->private_data;
+	unsigned long *p = filp->private_data;
 	char buf[64];
 	int r;
 
@@ -2482,9 +2482,9 @@ static ssize_t
 rb_simple_write(struct file *filp, const char __user *ubuf,
 		size_t cnt, loff_t *ppos)
 {
-	long *p = filp->private_data;
+	unsigned long *p = filp->private_data;
+	unsigned long val;
 	char buf[64];
-	long val;
 	int ret;
 
 	if (cnt >= sizeof(buf))
maintainer
#2 lore raw
In reply to Jaswinder Singh Rajput

You're a little late:

http://lkml.org/lkml/2009/2/10/262

-- Steve

Quoted 51 lines · Jaswinder Singh Rajput

From: Jaswinder Singh Rajput <[email protected]>
Date: Mon, 23 Mar 2009 00:02:38 +0530
Subject: [PATCH] trace: ring_buffer.c fix various signedness issues

Impact:cleanup

---
 kernel/trace/ring_buffer.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
kernel/trace/ring_buffer.c +4 -4
index bd38c5c..114811b 100644
@@ -57,7 +57,7 @@ enum {
 	RB_BUFFERS_DISABLED	= 1 << RB_BUFFERS_DISABLED_BIT,
 };
 
-static long ring_buffer_flags __read_mostly = RB_BUFFERS_ON;
+static unsigned long ring_buffer_flags __read_mostly = RB_BUFFERS_ON;
 
 /**
  * tracing_on - enable all tracing buffers
@@ -2466,7 +2466,7 @@ static ssize_t
 rb_simple_read(struct file *filp, char __user *ubuf,
 	       size_t cnt, loff_t *ppos)
 {
-	long *p = filp->private_data;
+	unsigned long *p = filp->private_data;
 	char buf[64];
 	int r;
 
@@ -2482,9 +2482,9 @@ static ssize_t
 rb_simple_write(struct file *filp, const char __user *ubuf,
 		size_t cnt, loff_t *ppos)
 {
-	long *p = filp->private_data;
+	unsigned long *p = filp->private_data;
+	unsigned long val;
 	char buf[64];
-	long val;
 	int ret;
 
 	if (cnt >= sizeof(buf))
Signature · 1 line
1.6.0.6