Skip to contentSkip to conversation

fix

PATCH In review Martin Peschke 2 participants 2 messages Mar 23, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix

Jens,

Tom fixed my "boken trace magic" issue. Please apply.

Thanks,
Martin

From: Tom Zanussi <[email protected]>

Blktrace failed to lock reader threads on the cpu used by the corresponding writer. This resulted in stale data being consumed when blktrace accidently read at a position that was being written to at the same time. This issue surfaced as "bad trace magic" warnings emitted by blktrace tools.

The problem occured on an SMP System z machine. The patch fixes the issue.

---
 blktrace.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
blktrace.c +1 -1
@@ -610,7 +610,7 @@ static int lock_on_cpu(int cpu)
 
 	CPU_ZERO(&cpu_mask);
 	CPU_SET(cpu, &cpu_mask);
-	if (sched_setaffinity(getpid(), sizeof(cpu_mask), &cpu_mask) < 0)
+	if (sched_setaffinity(0, sizeof(cpu_mask), &cpu_mask) < 0)
 		return errno;
 
 	return 0;
#1 lore raw
Quoted 3 lines · Martin Peschke

Jens,

Tom fixed my "boken trace magic" issue. Please apply.

Heh well, not sure I'd call that a real fix, but if it makes things, that is fine. I'll apply it.

Quoted 33 lines

Thanks,
Martin

From: Tom Zanussi <[email protected]>

Blktrace failed to lock reader threads on the cpu used by the corresponding writer. This resulted in stale data being consumed when blktrace accidently read at a position that was being written to at the same time. This issue surfaced as "bad trace magic" warnings emitted by blktrace tools.

The problem occured on an SMP System z machine. The patch fixes the issue.

---
 blktrace.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
blktrace.c +1 -1
@@ -610,7 +610,7 @@ static int lock_on_cpu(int cpu)
 
 	CPU_ZERO(&cpu_mask);
 	CPU_SET(cpu, &cpu_mask);
-	if (sched_setaffinity(getpid(), sizeof(cpu_mask), &cpu_mask) < 0)
+	if (sched_setaffinity(0, sizeof(cpu_mask), &cpu_mask) < 0)
 		return errno;
 
 	return 0;
Signature · 1 line
Jens Axboe