changed ioctls to unlocked
PATCH 9/13 changed ioctls to unlocked
From: Stoyan Gaydarov <[email protected]>
Signed-off-by Stoyan Gaydarov <[email protected]>
--- drivers/sbus/char/jsflash.c | 15 ++++++++++----- drivers/sbus/char/uctrl.c | 7 +++---- 2 files changed, 13 insertions(+), 9 deletions(-)
drivers/sbus/char/jsflash.c +10 -5
@@ -383,18 +383,22 @@ static int jsf_ioctl_program(void __user *arg)return 0 ; } -static int jsf_ioctl (struct inode *inode,struct file *f,unsigned int cmd, -unsigned long arg) +static long jsf_ioctl (struct file *f,unsigned int cmd,unsigned long arg) { +lock_kernel ();int error = -ENOTTY ;void __user *argp = (void __user *)arg; -if (!capable (CAP_SYS_ADMIN )) +if (!capable (CAP_SYS_ADMIN )) { +unlock_kernel ();return -EPERM ; + }switch (cmd) {case JSFLASH_IDENT : -if (copy_to_user (argp, &jsf0.id,JSFIDSZ )) +if (copy_to_user (argp, &jsf0.id,JSFIDSZ )) { +unlock_kernel ();return -EFAULT ; + }break ;case JSFLASH_ERASE : error =jsf_ioctl_erase (arg);
@@ -404,6 +408,7 @@ static int jsf_ioctl(struct inode *inode, struct file *f, unsigned int cmd,break ; } +unlock_kernel ();return error; }
@@ -439,7 +444,7 @@ static const struct file_operations jsf_fops = { .llseek = jsf_lseek, .read = jsf_read, .write = jsf_write, - .ioctl = jsf_ioctl, + .unlocked_ioctl = jsf_ioctl, .mmap = jsf_mmap, .open = jsf_open, .release = jsf_release,
drivers/sbus/char/uctrl.c +3 -4
@@ -197,9 +197,8 @@ static struct uctrl_driver {static void uctrl_get_event_status (struct uctrl_driver *);static void uctrl_get_external_status (struct uctrl_driver *); -static int -uctrl_ioctl (struct inode *inode,struct file *file, -unsigned int cmd,unsigned long arg) +static long +uctrl_ioctl (struct file *file,unsigned int cmd,unsigned long arg) {switch (cmd) {default :
@@ -226,7 +225,7 @@ static irqreturn_t uctrl_interrupt(int irq, void *dev_id)static const struct file_operations uctrl_fops = { .owner =THIS_MODULE , .llseek = no_llseek, - .ioctl = uctrl_ioctl, + .unlocked_ioctl = uctrl_ioctl, .open = uctrl_open, };
Signature · 1 line
1.6.2
From: [email protected]
Date: Tue, 24 Mar 2009 16:12:44 -0500
Quoted 1 line
Signed-off-by Stoyan Gaydarov <[email protected]>
Applied, thanks.