Skip to contentSkip to conversation

module: Kill warning: label 'free_init' defined but not used

PATCH In review Geert Uytterhoeven 3 participants 5 messages Mar 25, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 module: Kill warning: label 'free_init' defined but not used

On m68k (which doesn't do SMP), I get:

| kernel/module.c:2291: warning: label 'free_init' defined but not used

which was introduced by commit 6e2b75740bed35df98b8113300579e13ed2ce848 ("module: fix refptr allocation and release order").
Move the label inside the #ifdef, as the goto is protected by the same #ifdef.

---
 kernel/module.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/module.c +1 -1
index 1196f5d..df00a1b 100644
@@ -2288,8 +2288,8 @@ static noinline struct module *load_module(void __user *umod,
 	ftrace_release(mod->module_core, mod->core_size);
  free_unload:
 	module_unload_free(mod);
- free_init:
 #if defined(CONFIG_MODULE_UNLOAD) && defined(CONFIG_SMP)
+ free_init:
 	percpu_modfree(mod->refptr);
 #endif
 	module_free(mod, mod->module_init);
Signature · 13 lines
1.6.2


Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
#1 lore raw
Quoted 10 lines · Geert Uytterhoeven

On m68k (which doesn't do SMP), I get:

| kernel/module.c:2291: warning: label 'free_init' defined but not used

which was introduced by commit 6e2b75740bed35df98b8113300579e13ed2ce848 ("module: fix refptr allocation and release order").
Move the label inside the #ifdef, as the goto is protected by the same #ifdef.

---

AFAIK, it is already fixed in -tip:
http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-tip.git;a=commit;h=67f5ca081c6ace125e8ccc76b8a7d99b091abaa7

--
JSR

#2 lore raw
Quoted 9 lines · Jaswinder Singh Rajput
Quoted 8 lines · Geert Uytterhoeven

On m68k (which doesn't do SMP), I get:

| kernel/module.c:2291: warning: label 'free_init' defined but not used

which was introduced by commit 6e2b75740bed35df98b8113300579e13ed2ce848 ("module: fix refptr allocation and release order").
Move the label inside the #ifdef, as the goto is protected by the same #ifdef.

Quoted 5 lines
Quoted 2 lines

---

AFAIK, it is already fixed in -tip:
http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-tip.git;a=commit;h=67f5ca081c6ace125e8ccc76b8a7d99b091abaa7

Interesting, as I noticed the problem in today's linux-next.
http://kisskb.ellerman.id.au/kisskb/buildresult/271602/
Or am I caught again by fake warnings from the bisection process?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#3 lore raw
Quoted 14 lines · Geert Uytterhoeven
Quoted 12 lines · Jaswinder Singh Rajput
Quoted 10 lines · Geert Uytterhoeven

On m68k (which doesn't do SMP), I get:

| kernel/module.c:2291: warning: label 'free_init' defined but not used

which was introduced by commit 6e2b75740bed35df98b8113300579e13ed2ce848 ("module: fix refptr allocation and release order").
Move the label inside the #ifdef, as the goto is protected by the same #ifdef.

---

Quoted 7 lines
Quoted 2 lines

AFAIK, it is already fixed in -tip:
http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-tip.git;a=commit;h=67f5ca081c6ace125e8ccc76b8a7d99b091abaa7

Interesting, as I noticed the problem in today's linux-next.
http://kisskb.ellerman.id.au/kisskb/buildresult/271602/
Or am I caught again by fake warnings from the bisection process?

Yes, you are right linux-next is still having this problem.

You are the third guy who came with this fix.

Two of them are already applied in -tip and Rusty's tree:

----------->

Quoted 7 lines · Rusty Russell
Quoted 3 lines · On Wednesday 25 March 2009 02:37:19 Américo Wang wrote:

Label 'free_init' is only used when defined(CONFIG_MODULE_UNLOAD) && defined(CONFIG_SMP), so move it inside to shut up gcc.

Thanks, applied!
Rusty.

<-----------

May be you can also try linux-next tree ;-)

--
JSR

#4 lore raw
In reply to Geert Uytterhoeven
Quoted 7 lines · On Thursday 26 March 2009 06:13:06 Geert Uytterhoeven wrote:

On m68k (which doesn't do SMP), I get:

| kernel/module.c:2291: warning: label 'free_init' defined but not used

which was introduced by commit 6e2b75740bed35df98b8113300579e13ed2ce848 ("module: fix refptr allocation and release order").
Move the label inside the #ifdef, as the goto is protected by the same #ifdef.

Thanks, already in my tree. I'll get off my ass and push to Linus in next couple of days.

Thanks!
Rusty.