Update for inka4x0 plus some new features
Subsystems (2)
v3 cover Update for inka4x0 plus some new features
This patchset contains updates for the ink4x0 platform. Namely it adds hardware diagnostic funtions and an RTC driver.
For a nice integration by using private command tables, do_help is extended to support this scenario also.
To successfully convert all the pointer access to accessor macros, a bunch of new defines is also needed for the 5200 cpu.
Changes from v2:
Addresses comments from ML. Specifically:
- Fixing the odd empty line here and there
- Removed some cruft uncovered in the review process
- Rebased against master becaus some patches were already applied by Wolfgang.
Detlev Zundel (5):
drivers/twserial: Add protocol driver for "three wire serial"
interface.
rtc: add support for 4543 RTC (manufactured by e.g. EPSON)
inka4x0: Add hardware diagnosis functions for inka4x0
inka4x0: Add hardware diagnosis and RTC in configuration.
inka4x0: Use proper accessor macros for memory mapped registers.
Makefile | 3 +- board/inka4x0/Makefile | 4 +- board/inka4x0/inka4x0.c | 171 +++++++++----- board/inka4x0/inkadiag.c | 514 +++++++++++++++++++++++++++++++++++++++++++ drivers/rtc/Makefile | 1 + drivers/rtc/rtc4543.c | 118 ++++++++++ drivers/twserial/Makefile | 46 ++++ drivers/twserial/soft_tws.c | 111 ++++++++++ include/configs/inka4x0.h | 91 +++++++- include/ns16550.h | 11 + include/rtc.h | 4 + include/tws.h | 38 ++++ 12 files changed, 1042 insertions(+), 70 deletions(-) create mode 100644 board/inka4x0/inkadiag.c create mode 100644 drivers/rtc/rtc4543.c create mode 100644 drivers/twserial/Makefile create mode 100644 drivers/twserial/soft_tws.c create mode 100644 include/tws.h
PATCH v3 1/5 drivers/twserial: Add protocol driver for "three wire serial" interface.
This pretty unintelligent interface is used on some RTC chips.
--- Makefile | 3 +- drivers/twserial/Makefile | 46 ++++++++++++++++++ drivers/twserial/soft_tws.c | 111 +++++++++++++++++++++++++++++++++++++++++++ include/tws.h | 38 +++++++++++++++ 4 files changed, 197 insertions(+), 1 deletions(-) create mode 100644 drivers/twserial/Makefile create mode 100644 drivers/twserial/soft_tws.c create mode 100644 include/tws.h
Makefile +2 -1
@@ -1,5 +1,5 @@ # -# (C) Copyright 2000-2008 +# (C) Copyright 2000-2009 # Wolfgang Denk, DENX Software Engineering, wd at denx.de. # # See file CREDITS for list of people who contributed to this
@@ -262,6 +262,7 @@ TAG_SUBDIRS += cpu/mpc8xxx endif LIBS += drivers/rtc/librtc.a LIBS += drivers/serial/libserial.a +LIBS += drivers/twserial/libtws.a LIBS += drivers/usb/libusb.a LIBS += drivers/video/libvideo.a LIBS += common/libcommon.a
drivers/twserial/Makefile new file +46 -0
46 lines not on this page · raw message
drivers/twserial/soft_tws.c new file +111 -0
111 lines not on this page · raw message
include/tws.h new file +38 -0
@@ -0,0 +1,38 @@ +/* +* (C) Copyright 2009 +* Detlev Zundel, DENX Software Engineering, dzu at denx.de. +* +* See file CREDITS for list of people who contributed to this +* project. +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, +* MA 02111-1307 USA +* +*/ + +#ifndef _TWS_H_ +#define _TWS_H_ + +/* +* Read/Write interface: +* buffer: Where to read/write the data +* len: How many bits to read/write +* +* Returns: 0 on success, not 0 on failure +*/ +int tws_read (uchar *buffer,int len); +int tws_write (uchar *buffer,int len); + +#endif /* _TWS_H_ */
Signature · 1 line
1.6.0.6
PATCH v3 2/5 rtc: add support for 4543 RTC (manufactured by e.g. EPSON)
--- drivers/rtc/Makefile | 1 + drivers/rtc/rtc4543.c | 118 +++++++++++++++++++++++++++++++++++++++++++++++++ include/rtc.h | 4 ++ 3 files changed, 123 insertions(+), 0 deletions(-) create mode 100644 drivers/rtc/rtc4543.c
drivers/rtc/Makefile +1 -0
@@ -55,6 +55,7 @@ COBJS-$(CONFIG_RTC_MPC8xx) += mpc8xx.o COBJS-$(CONFIG_RTC_PCF8563) += pcf8563.o COBJS-$(CONFIG_RTC_PL031) += pl031.o COBJS-$(CONFIG_RTC_RS5C372A) += rs5c372.o +COBJS-$(CONFIG_RTC_RTC4543) += rtc4543.o COBJS-$(CONFIG_RTC_RX8025) += rx8025.o COBJS-$(CONFIG_RTC_S3C24X0) += s3c24x0_rtc.o COBJS-$(CONFIG_RTC_X1205) += x1205.o
drivers/rtc/rtc4543.c new file +118 -0
118 lines not on this page · raw message
include/rtc.h +4 -0
@@ -61,4 +61,8 @@ void to_tm (int, struct rtc_time *);unsigned long mktime (unsigned int ,unsigned int ,unsigned int ,unsigned int ,unsigned int ,unsigned int ); +uchar rtc_read (uchar reg) __attribute__((weak)); +void rtc_write (uchar reg,uchar val) __attribute__((weak)); + +#endif /* _RTC_H_ */
Signature · 1 line
1.6.0.6
PATCH v3 3/5 inka4x0: Add hardware diagnosis functions for inka4x0
This patch adds advanced diagnosis functions for the inka4x0 board.
--- board/inka4x0/Makefile | 4 +- board/inka4x0/inka4x0.c | 20 ++- board/inka4x0/inkadiag.c | 514 +++++++++++++++++++++++++++++++++++++++++++++ include/configs/inka4x0.h | 1 + include/ns16550.h | 11 + 5 files changed, 546 insertions(+), 4 deletions(-) create mode 100644 board/inka4x0/inkadiag.c
board/inka4x0/Makefile +2 -2
@@ -1,5 +1,5 @@ # -# (C) Copyright 2003-2006 +# (C) Copyright 2003-2009 # Wolfgang Denk, DENX Software Engineering, wd at denx.de. # # See file CREDITS for list of people who contributed to this
@@ -25,7 +25,7 @@ include $(TOPDIR)/config.mk LIB = $(obj)lib$(BOARD).a -COBJS := $(BOARD).o +COBJS := $(BOARD).o inkadiag.o SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) OBJS := $(addprefix $(obj),$(COBJS))
board/inka4x0/inka4x0.c +18 -2
@@ -1,6 +1,9 @@/* -* (C) Copyright 2003-2004 -* Wolfgang Denk, DENX Software Engineering, wd at denx.de. +* (C) Copyright 2008-2009 +* Andreas Pfefferle, DENX Software Engineering, ap at denx.de. +* +* (C) Copyright 2009 +* Detlev Zundel, DENX Software Engineering, dzu at denx.de. * * (C) Copyright 2004 * Mark Jonas, Freescale Semiconductor, mark.jonas at motorola.com.
@@ -8,6 +11,9 @@* (C) Copyright 2004 * Martin Krause, TQ-Systems GmbH, martin.krause at tqs.de * +* (C) Copyright 2003-2004 +* Wolfgang Denk, DENX Software Engineering, wd at denx.de. +* * See file CREDITS for list of people who contributed to this * project. *
@@ -171,6 +177,16 @@ void flash_preinit(void) *(vu_long *)MPC5XXX_BOOTCS_CFG &= ~0x1 ;/* clear RO */ } +int misc_init_r (void ) { +extern int inkadiag_init_r (void ); + +/* +* The command table used for the subcommands of inkadiag +* needs to be relocated manually. +*/ +return inkadiag_init_r (); +} +int misc_init_f (void ) {char tmp[10 ];
board/inka4x0/inkadiag.c new file +514 -0
514 lines not on this page · raw message
include/configs/inka4x0.h +1 -0
@@ -39,6 +39,7 @@#define BOOTFLAG_WARM 0x02/* Software reboot */ #define CONFIG_MISC_INIT_F 1/* Use misc_init_f() */ +#define CONFIG_MISC_INIT_R 1/* Use misc_init_r() */ #define CONFIG_HIGH_BATS 1/* High BATs supported */
include/ns16550.h +11 -0
@@ -123,6 +123,7 @@ typedef volatile struct NS16550 *NS16550_t;#define MCR_RTS 0x02#define MCR_DMA_EN 0x04#define MCR_TX_DFR 0x08 +#define MCR_LOOP 0x10/* Enable loopback test mode */ #define LCR_WLS_MSK 0x03/* character length select mask */ #define LCR_WLS_5 0x00/* 5 bit character length */
@@ -135,6 +136,7 @@ typedef volatile struct NS16550 *NS16550_t;#define LCR_STKP 0x20/* Stick Parity */ #define LCR_SBRK 0x40/* Set Break */ #define LCR_BKSE 0x80/* Bank select enable */ +#define LCR_DLAB 0x80/* Divisor latch access bit */ #define LSR_DR 0x01/* Data ready */ #define LSR_OE 0x02/* Overrun */
@@ -145,6 +147,15 @@ typedef volatile struct NS16550 *NS16550_t;#define LSR_TEMT 0x40/* Xmitter empty */ #define LSR_ERR 0x80/* Error */ +#define MSR_DCD 0x80/* Data Carrier Detect */ +#define MSR_RI 0x40/* Ring Indicator */ +#define MSR_DSR 0x20/* Data Set Ready */ +#define MSR_CTS 0x10/* Clear to Send */ +#define MSR_DDCD 0x08/* Delta DCD */ +#define MSR_TERI 0x04/* Trailing edge ring indicator */ +#define MSR_DDSR 0x02/* Delta DSR */ +#define MSR_DCTS 0x01/* Delta CTS */ +#ifdef CONFIG_OMAP1510 #define OSC_12M_SEL 0x01/* selects 6.5 * current clk div */ #endif
Signature · 1 line
1.6.0.6
PATCH v3 4/5 inka4x0: Add hardware diagnosis and RTC in configuration.
This patch adds the board specific communication routines needed by the external 4543 RTC.
--- board/inka4x0/inka4x0.c | 20 ++++++++++ include/configs/inka4x0.h | 90 ++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 105 insertions(+), 5 deletions(-)
board/inka4x0/inka4x0.c +20 -0
@@ -33,6 +33,7 @@* MA 02111-1307 USA */ +#include <asm/io.h> #include <common.h> #include <mpc5xxx.h> #include <pci.h>
@@ -189,6 +190,8 @@ int misc_init_r (void) {int misc_init_f (void ) { +struct mpc5xxx_gpio *gpio = (struct mpc5xxx_gpio *)MPC5XXX_GPIO ; +struct mpc5xxx_wu_gpio *wu_gpio = (struct mpc5xxx_wu_gpio *)MPC5XXX_WU_GPIO ;char tmp[10 ];int i, br;
@@ -236,6 +239,23 @@ int misc_init_f (void) *(vu_long *)MPC5XXX_WU_GPIO_ENABLE |=GPIO_PSC3_9 ; *(vu_long *)MPC5XXX_WU_GPIO_DIR |=GPIO_PSC3_9 ; *(vu_long *)MPC5XXX_WU_GPIO_DATA_O |=GPIO_PSC3_9 ; + +/* +* Configure three wire serial interface to RTC (PSC1_4, +* PSC2_4, PSC3_4, PSC3_5) +*/ +setbits_8 (&wu_gpio->enable,MPC5XXX_GPIO_WKUP_PSC1_4 | +MPC5XXX_GPIO_WKUP_PSC2_4 ); +setbits_8 (&wu_gpio->ddr,MPC5XXX_GPIO_WKUP_PSC1_4 | +MPC5XXX_GPIO_WKUP_PSC2_4 ); +clrbits_8 (&wu_gpio->dvo,MPC5XXX_GPIO_WKUP_PSC1_4 ); +clrbits_8 (&gpio->sint_inten,MPC5XXX_GPIO_SINT_PSC3_4 | +MPC5XXX_GPIO_SINT_PSC3_5 ); +setbits_8 (&gpio->sint_gpioe,MPC5XXX_GPIO_SINT_PSC3_4 | +MPC5XXX_GPIO_SINT_PSC3_5 ); +setbits_8 (&gpio->sint_ddr,MPC5XXX_GPIO_SINT_PSC3_5 ); +clrbits_8 (&gpio->sint_dvo,MPC5XXX_GPIO_SINT_PSC3_5 ); +return 0 ; }
include/configs/inka4x0.h +85 -5
120 lines not on this page · raw message
Signature · 1 line
1.6.0.6
PATCH v3 5/5 inka4x0: Use proper accessor macros for memory mapped registers.
--- board/inka4x0/inka4x0.c | 139 +++++++++++++++++++++++++---------------------- 1 files changed, 75 insertions(+), 64 deletions(-)
board/inka4x0/inka4x0.c +75 -64
@@ -55,41 +55,35 @@#ifndef CONFIG_SYS_RAMBOOT static void sdram_start (int hi_addr) { +volatile struct mpc5xxx_sdram *sdram = + (struct mpc5xxx_sdram *)MPC5XXX_SDRAM ;long hi_addr_bit = hi_addr ?0x01000000 :0 ;/* unlock mode register */ - *(vu_long *)MPC5XXX_SDRAM_CTRL =SDRAM_CONTROL |0x80000000 | hi_addr_bit; - __asm__volatile ("sync" ); +out_be32 (&sdram->ctrl,SDRAM_CONTROL |0x80000000 | hi_addr_bit);/* precharge all banks */ - *(vu_long *)MPC5XXX_SDRAM_CTRL =SDRAM_CONTROL |0x80000002 | hi_addr_bit; - __asm__volatile ("sync" ); +out_be32 (&sdram->ctrl,SDRAM_CONTROL |0x80000002 | hi_addr_bit);#if SDRAM_DDR /* set mode register: extended mode */ - *(vu_long *)MPC5XXX_SDRAM_MODE =SDRAM_EMODE ; - __asm__volatile ("sync" ); +out_be32 (&sdram->mode,SDRAM_EMODE );/* set mode register: reset DLL */ - *(vu_long *)MPC5XXX_SDRAM_MODE =SDRAM_MODE |0x04000000 ; - __asm__volatile ("sync" ); +out_be32 (&sdram->mode,SDRAM_MODE |0x04000000 );#endif /* precharge all banks */ - *(vu_long *)MPC5XXX_SDRAM_CTRL =SDRAM_CONTROL |0x80000002 | hi_addr_bit; - __asm__volatile ("sync" ); +out_be32 (&sdram->ctrl,SDRAM_CONTROL |0x80000002 | hi_addr_bit);/* auto refresh */ - *(vu_long *)MPC5XXX_SDRAM_CTRL =SDRAM_CONTROL |0x80000004 | hi_addr_bit; - __asm__volatile ("sync" ); +out_be32 (&sdram->ctrl,SDRAM_CONTROL |0x80000004 | hi_addr_bit);/* set mode register */ - *(vu_long *)MPC5XXX_SDRAM_MODE =SDRAM_MODE ; - __asm__volatile ("sync" ); +out_be32 (&sdram->mode,SDRAM_MODE );/* normal operation */ - *(vu_long *)MPC5XXX_SDRAM_CTRL =SDRAM_CONTROL | hi_addr_bit; - __asm__volatile ("sync" ); +out_be32 (&sdram->ctrl,SDRAM_CONTROL | hi_addr_bit); }#endif
@@ -101,24 +95,27 @@ static void sdram_start (int hi_addr)phys_size_t initdram (int board_type) { +volatile struct mpc5xxx_mmap_ctl *mm = + (struct mpc5xxx_mmap_ctl *)CONFIG_SYS_MBAR ; +volatile struct mpc5xxx_cdm *cdm = + (struct mpc5xxx_cdm *)MPC5XXX_CDM ; +volatile struct mpc5xxx_sdram *sdram = + (struct mpc5xxx_sdram *)MPC5XXX_SDRAM ;ulong dramsize =0 ;#ifndef CONFIG_SYS_RAMBOOT long test1, test2;/* setup SDRAM chip selects */ - *(vu_long *)MPC5XXX_SDRAM_CS0CFG =0x0000001c ;/* 512MB at 0x0 */ - *(vu_long *)MPC5XXX_SDRAM_CS1CFG =0x40000000 ;/* disabled */ - __asm__volatile ("sync" ); +out_be32 (&mm->sdram0,0x0000001c );/* 512MB at 0x0 */ +out_be32 (&mm->sdram1,0x40000000 );/* disabled */ /* setup config registers */ - *(vu_long *)MPC5XXX_SDRAM_CONFIG1 =SDRAM_CONFIG1 ; - *(vu_long *)MPC5XXX_SDRAM_CONFIG2 =SDRAM_CONFIG2 ; - __asm__volatile ("sync" ); +out_be32 (&sdram->config1,SDRAM_CONFIG1 ); +out_be32 (&sdram->config2,SDRAM_CONFIG2 );#if SDRAM_DDR /* set tap delay */ - *(vu_long *)MPC5XXX_CDM_PORCFG =SDRAM_TAPDELAY ; - __asm__volatile ("sync" ); +out_be32 (&cdm->porcfg,SDRAM_TAPDELAY );#endif /* find RAM size using SDRAM CS0 only */
@@ -140,17 +137,17 @@ phys_size_t initdram (int board_type)/* set SDRAM CS0 size according to the amount of RAM found */ if (dramsize >0 ) { - *(vu_long *)MPC5XXX_SDRAM_CS0CFG =0x13 + -__builtin_ffs (dramsize >>20 ) -1 ; +out_be32 (&mm->sdram0,0x13 + +__builtin_ffs (dramsize >>20 ) -1 ); }else { - *(vu_long *)MPC5XXX_SDRAM_CS0CFG =0 ;/* disabled */ +out_be32 (&mm->sdram0,0 );/* disabled */ } - *(vu_long *)MPC5XXX_SDRAM_CS1CFG = dramsize;/* disabled */ +out_be32 (&mm->sdram1, dramsize);/* disabled */ #else /* CONFIG_SYS_RAMBOOT */ /* retrieve size of memory connected to SDRAM CS0 */ - dramsize = *(vu_long *)MPC5XXX_SDRAM_CS0CFG &0xFF ; + dramsize =in_be32 (&mm->sdram0) &0xFF ;if (dramsize >=0x13 ) { dramsize = (1 << (dramsize -0x13 )) <<20 ; }else {
@@ -169,13 +166,15 @@ int checkboard (void)void flash_preinit (void ) { +volatile struct mpc5xxx_lpb *lpb = (struct mpc5xxx_lpb *)MPC5XXX_LPB ; +/* * Now, when we are in RAM, enable flash write * access for detection process. -* Note that CS_BOOT cannot be cleared when +* Note that CS_BOOT (CS0) cannot be cleared when * executing in flash. */ - *(vu_long *)MPC5XXX_BOOTCS_CFG &= ~0x1 ;/* clear RO */ +clrbits_be32 (&lpb->cs0_cfg,0x1 );/* clear RO */ }int misc_init_r (void ) {
@@ -190,8 +189,11 @@ int misc_init_r (void) {int misc_init_f (void ) { -struct mpc5xxx_gpio *gpio = (struct mpc5xxx_gpio *)MPC5XXX_GPIO ; -struct mpc5xxx_wu_gpio *wu_gpio = (struct mpc5xxx_wu_gpio *)MPC5XXX_WU_GPIO ; +volatile struct mpc5xxx_gpio *gpio = + (struct mpc5xxx_gpio *)MPC5XXX_GPIO ; +volatile struct mpc5xxx_wu_gpio *wu_gpio = + (struct mpc5xxx_wu_gpio *)MPC5XXX_WU_GPIO ; +volatile struct mpc5xxx_gpt *gpt;char tmp[10 ];int i, br;
@@ -205,40 +207,43 @@ int misc_init_f (void)/* Initialize GPIO output pins. */ /* Configure GPT as GPIO output (and set them as they control low-active LEDs */ - *(vu_long *)MPC5XXX_GPT0_ENABLE = - *(vu_long *)MPC5XXX_GPT1_ENABLE = - *(vu_long *)MPC5XXX_GPT2_ENABLE = - *(vu_long *)MPC5XXX_GPT3_ENABLE = - *(vu_long *)MPC5XXX_GPT4_ENABLE = - *(vu_long *)MPC5XXX_GPT5_ENABLE =0x34 ; +for (i =0 ; i <=5 ; i++) { + gpt = (struct mpc5xxx_gpt *)(MPC5XXX_GPT + (i *0x10 )); +out_be32 (&gpt->emsr,0x34 ); + }/* Configure GPT7 as PWM timer, 1kHz, no ints. */ - *(vu_long *)MPC5XXX_GPT7_ENABLE =0 ;/* Disable */ - *(vu_long *)MPC5XXX_GPT7_COUNTER =0x020000fe ; - *(vu_long *)MPC5XXX_GPT7_PWMCFG = (br <<16 ); - *(vu_long *)MPC5XXX_GPT7_ENABLE =0x3 ;/* Enable PWM mode and start */ + gpt = (struct mpc5xxx_gpt *)(MPC5XXX_GPT + (7 *0x10 )); +out_be32 (&gpt->emsr,0 );/* Disable */ +out_be32 (&gpt->cir,0x020000fe ); +out_be32 (&gpt->pwmcr, (br <<16 )); +out_be32 (&gpt->emsr,0x3 );/* Enable PWM mode and start */ /* Configure PSC3_6,7 as GPIO output */ - *(vu_long *)MPC5XXX_GPIO_ENABLE |=0x00003000 ; - *(vu_long *)MPC5XXX_GPIO_DIR |=0x00003000 ; - -/* Configure PSC3_8 as GPIO output, no interrupt */ - *(vu_long *)MPC5XXX_GPIO_SI_ENABLE |=0x04000000 ; - *(vu_long *)MPC5XXX_GPIO_SI_DIR |=0x04000000 ; - *(vu_long *)MPC5XXX_GPIO_SI_IEN &= ~0x04000000 ; +setbits_be32 (&gpio->simple_gpioe,MPC5XXX_GPIO_SIMPLE_PSC3_6 | +MPC5XXX_GPIO_SIMPLE_PSC3_7 ); +setbits_be32 (&gpio->simple_ddr,MPC5XXX_GPIO_SIMPLE_PSC3_6 | +MPC5XXX_GPIO_SIMPLE_PSC3_7 );/* Configure PSC3_9 and GPIO_WKUP6,7 as GPIO output */ - *(vu_long *)MPC5XXX_WU_GPIO_ENABLE |=0xc4000000 ; - *(vu_long *)MPC5XXX_WU_GPIO_DIR |=0xc4000000 ; +setbits_8 (&wu_gpio->enable,MPC5XXX_GPIO_WKUP_6 | +MPC5XXX_GPIO_WKUP_7 | +MPC5XXX_GPIO_WKUP_PSC3_9 ); +setbits_8 (&wu_gpio->ddr,MPC5XXX_GPIO_WKUP_6 | +MPC5XXX_GPIO_WKUP_7 | +MPC5XXX_GPIO_WKUP_PSC3_9 );/* Set LR mirror bit because it is low-active */ - *(vu_long *)MPC5XXX_WU_GPIO_DATA_O |=GPIO_WKUP_7 ; -/* -* Reset Coral-P graphics controller -*/ - *(vu_long *)MPC5XXX_WU_GPIO_ENABLE |=GPIO_PSC3_9 ; - *(vu_long *)MPC5XXX_WU_GPIO_DIR |=GPIO_PSC3_9 ; - *(vu_long *)MPC5XXX_WU_GPIO_DATA_O |=GPIO_PSC3_9 ; +setbits_8 (&wu_gpio->dvo,MPC5XXX_GPIO_WKUP_7 ); + +/* Reset Coral-P graphics controller */ +setbits_8 (&wu_gpio->dvo,MPC5XXX_GPIO_WKUP_PSC3_9 ); + +/* Enable display backlight */ +clrbits_8 (&gpio->sint_inten,MPC5XXX_GPIO_SINT_PSC3_8 ); +setbits_8 (&gpio->sint_gpioe,MPC5XXX_GPIO_SINT_PSC3_8 ); +setbits_8 (&gpio->sint_ddr,MPC5XXX_GPIO_SINT_PSC3_8 ); +setbits_8 (&gpio->sint_dvo,MPC5XXX_GPIO_SINT_PSC3_8 );/* * Configure three wire serial interface to RTC (PSC1_4,
@@ -274,25 +279,31 @@ void pci_init_board(void)void init_ide_reset (void ) { +volatile struct mpc5xxx_wu_gpio *wu_gpio = + (struct mpc5xxx_wu_gpio *)MPC5XXX_WU_GPIO ; +debug ("init_ide_reset\n" );/* Configure PSC1_4 as GPIO output for ATA reset */ - *(vu_long *)MPC5XXX_WU_GPIO_ENABLE |=GPIO_PSC1_4 ; - *(vu_long *)MPC5XXX_WU_GPIO_DIR |=GPIO_PSC1_4 ; +setbits_8 (&wu_gpio->enable,MPC5XXX_GPIO_WKUP_PSC1_4 ); +setbits_8 (&wu_gpio->ddr,MPC5XXX_GPIO_WKUP_PSC1_4 );/* Deassert reset */ - *(vu_long *)MPC5XXX_WU_GPIO_DATA_O |=GPIO_PSC1_4 ; +setbits_8 (&wu_gpio->dvo,MPC5XXX_GPIO_WKUP_PSC1_4 ); }void ide_set_reset (int idereset) { +volatile struct mpc5xxx_wu_gpio *wu_gpio = + (struct mpc5xxx_wu_gpio *)MPC5XXX_WU_GPIO ; +debug ("ide_reset(%d)\n" , idereset);if (idereset) { - *(vu_long *)MPC5XXX_WU_GPIO_DATA_O &= ~GPIO_PSC1_4 ; +clrbits_8 (&wu_gpio->dvo,MPC5XXX_GPIO_WKUP_PSC1_4 );/* Make a delay. MPC5200 spec says 25 usec min */ udelay (500000 ); }else { - *(vu_long *)MPC5XXX_WU_GPIO_DATA_O |=GPIO_PSC1_4 ; +setbits_8 (&wu_gpio->dvo,MPC5XXX_GPIO_WKUP_PSC1_4 ); } }#endif
Signature · 1 line
1.6.0.6
Wolfgang Denk
AppliedPATCH v3 5/5 inka4x0: Use proper accessor macros for memory mapped registers.
Dear Detlev Zundel,
Quoted 4 lines · In message <[email protected]> you wrote:
Signed-off-by Detlev Zundel <[email protected]>--- board/inka4x0/inka4x0.c | 139 +++++++++++++++++++++++++---------------------- 1 files changed, 75 insertions(+), 64 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Was hei?t Windows auf Indianisch? - "Wei?er Mann, der auf Sanduhr wartet!"
Wolfgang Denk
AppliedPATCH v3 4/5 inka4x0: Add hardware diagnosis and RTC in configuration.
In reply to Detlev ZundelDear Detlev Zundel,
Quoted 9 lines · In message <[email protected]> you wrote:
This patch adds the board specific communication routines needed by the external 4543 RTC.
Signed-off-by Detlev Zundel <[email protected]>Signed-off-by Andreas Pfefferle <[email protected]>--- board/inka4x0/inka4x0.c | 20 ++++++++++ include/configs/inka4x0.h | 90 ++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 105 insertions(+), 5 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 7 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Quote from the Boss after overriding the decision of a task force he created to find a solution: "I'm sorry if I ever gave you the impression your input would have any effect on my decision for the outcome of this project!"
Wolfgang Denk
AppliedPATCH v3 3/5 inka4x0: Add hardware diagnosis functions for inka4x0
In reply to Detlev ZundelDear Detlev Zundel,
Quoted 4 lines · In message <[email protected]> you wrote:
This patch adds advanced diagnosis functions for the inka4x0 board.
Signed-off-by Andreas Pfefferle <[email protected]>Signed-off-by Detlev Zundel <[email protected]>
Quoted 8 lines
--- board/inka4x0/Makefile | 4 +- board/inka4x0/inka4x0.c | 20 ++- board/inka4x0/inkadiag.c | 514 +++++++++++++++++++++++++++++++++++++++++++++ include/configs/inka4x0.h | 1 + include/ns16550.h | 11 + 5 files changed, 546 insertions(+), 4 deletions(-) create mode 100644 board/inka4x0/inkadiag.c
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Wagner's music is better than it sounds." - Mark Twain
Wolfgang Denk
AppliedPATCH v3 2/5 rtc: add support for 4543 RTC (manufactured by e.g. EPSON)
In reply to Detlev ZundelDear Detlev Zundel,
Quoted 8 lines · In message <[email protected]> you wrote:
Signed-off-by Detlev Zundel <[email protected]>Signed-off-by Andreas Pfefferle <[email protected]>--- drivers/rtc/Makefile | 1 + drivers/rtc/rtc4543.c | 118 +++++++++++++++++++++++++++++++++++++++++++++++++ include/rtc.h | 4 ++ 3 files changed, 123 insertions(+), 0 deletions(-) create mode 100644 drivers/rtc/rtc4543.c
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 8 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A secure program has to be robust: it must be able to deal with
conditions that "can't happen", whether user input, program error or
library/etc. This is basic damage control. Buffer overflow errors
have nothing to do with security, but everything with stupidity.
-- Wietse Venema in <[email protected]>Wolfgang Denk
AppliedPATCH v3 1/5 drivers/twserial: Add protocol driver for "three wire serial" interface.
In reply to Detlev ZundelDear Detlev Zundel,
Quoted 12 lines · In message <[email protected]> you wrote:
This pretty unintelligent interface is used on some RTC chips.
Signed-off-by Detlev Zundel <[email protected]>--- Makefile | 3 +- drivers/twserial/Makefile | 46 ++++++++++++++++++ drivers/twserial/soft_tws.c | 111 +++++++++++++++++++++++++++++++++++++++++++ include/tws.h | 38 +++++++++++++++ 4 files changed, 197 insertions(+), 1 deletions(-) create mode 100644 drivers/twserial/Makefile create mode 100644 drivers/twserial/soft_tws.c create mode 100644 include/tws.h
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What can it profit a man to gain the whole world and to come to his
property with a gastric ulcer, a blown prostate, and bifocals?
-- John Steinbeck, _Cannery Row_