Skip to contentSkip to conversation

add hotplug2 package

PATCH In review Angus Ainslie 3 participants 6 messages Mar 30, 2009 – Apr 1, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add hotplug2 package

---
 conf/checksums.ini                        |    4 +++
 packages/hotplug2/hotplug2_0.9+1.0beta.bb |   31
+++++++++++++++++++++++++++++
 2 files changed, 35 insertions(+), 0
deletions(-)                             
 create mode 100644 packages/hotplug2/hotplug2_0.9

+1.0beta.bb

conf/checksums.ini +0 -0
index 9548a02..c5e6910 100644                       
@@ -9318,6 +9318,10 @@

sha256=af40399fe434678454ae8ea100db6cba0482aa65b8972a05098c779cac57bc48

md5=faa08f321fefd2c61ce4c9355a62fe31

sha256=ca7ef124cde06883fbf28c7e78ce1e4c5526434bbe5672ef0a3e85a61a9d0b5f

+[http://isteve.bofh.cz/~isteve/hotplug2/downloads/hotplug2-1.0-beta.tar.gz] +md5=353656ea499d395260c0de143983da4d +sha256=54e2fa375506d92a8ac94b5ed332c4c0bf1b69c252692b332c92702670bba583 +

[http://www.porchdogsoft.com/download/howl-0.9.7.tar.gz]

md5=85fbe016e2ebad99108b1212ae4b1d6f

sha256=f8766c44291aac92b2b4abc762e1b11e3504dd9f2a855fdde371b5abd730fe9f

(quoted diff) +0 -0

b/packages/hotplug2/hotplug2_0.9+1.0beta.bb
new file mode 100644
index 0000000..8ae5149

packages/hotplug2/hotplug2_0.9+1.0beta.bb new file +1 -0
@@ -0,0 +1,31 @@
+DESCRIPTION = "hotplug2 is a daemon which dynamically creates and

removes device nodes from \
+/dev/, handles hotplug events and loads drivers at boot time. It replaces \
+the hotplug and udev packages and requires a kernel not older than 2.6.12."
+RPROVIDES_${PN} = "hotplug"
+RREPLACES_${PN} = "udev"
+PR = "r0"
+
+SRC_URI = "http://isteve.bofh.cz/~isteve/hotplug2/downloads/hotplug2-1.0-beta.tar.gz \
+ "
+
+S = "${WORKDIR}/hotplug2-1.0-beta"
+
+DEFAULT_PREFERENCE = "-1"
+
+inherit autotools
+
+INITSCRIPT_PARAMS = "start 03 S ."
+
+LDFLAGS += "-lglibc"
+DESTDIR=${D}
+
+do_configure () {
+}
+
+do_install_prepend () {
+ install -d ${D}/lib/hotplug2
+ install -d ${D}/sbin
+}
+
+FILES_${PN} += "${base_libdir}/hotplug2/*"
+FILES_${PN}-dbg += "${base_libdir}/hotplug2/.debug"
--
1.5.6.3

#1 lore raw

On 31-03-09 00:40, Angus Ainslie wrote:

Your commit message is invalid

Quoted 1 line

+PR = "r0"

r0 is the default so you can remove that

Quoted 1 line

+DEFAULT_PREFERENCE = "-1"

There's only one version of hotplug2, so why add a default_pref?

Quoted 1 line

+INITSCRIPT_PARAMS = "start 03 S ."

You forgot to inherit update-rc.d

Quoted 1 line

+LDFLAGS += "-lglibc"

I don't think that actually works, and if it did, uclibc would break

Quoted 1 line

+DESTDIR=${D}

missing quotes

Review

Quoted 2 lines
(quoted diff) +2 -0
+do_configure () {
+}

missing colon between the braces. But more importantly: why inherit autotools when you're not going to run configure?

regards,

Koen

#2 lore raw
Quoted 5 lines · Koen Kooi

On 31-03-09 00:40, Angus Ainslie wrote:

Your commit message is invalid

Thanks for pointing out the problem. I would find it helpful if you gave a hint about what might be invalid. Hopefully this is corrected.

Quoted 5 lines
Quoted 2 lines

+PR = "r0"

r0 is the default so you can remove that

fixed

Quoted 5 lines
Quoted 2 lines

+DEFAULT_PREFERENCE = "-1"

There's only one version of hotplug2, so why add a default_pref?

I had 2 on my system but only chose to submit this one. Fixed.

Quoted 5 lines
Quoted 2 lines

+INITSCRIPT_PARAMS = "start 03 S ."

You forgot to inherit update-rc.d

fixed

Quoted 4 lines
Quoted 1 line

+LDFLAGS += "-lglibc"

I don't think that actually works, and if it did, uclibc would break

Without that I get undefined refeences

loader.c:(.text+0x14): undefined reference to dlclose' workers/loader.o: In function worker_load':
loader.c:(.text+0x44): undefined reference to dlopen' loader.c:(.text+0x5c): undefined reference to dlsym' loader.c:(.text+0x84): undefined reference to `dlerror'

Quoted 5 lines
Quoted 2 lines

+DESTDIR=${D}

missing quotes

fixed

Quoted 6 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+do_configure () {
+}

missing colon between the braces. But more importantly: why inherit autotools when you're not going to run configure?

I was under the mistaken impression that autotools need to be included to get do_compile() and do_install(). It seems those are the defaults.

There is a deeper problem that without the inherit autotools then the LDFLAGS above fails to find glibc. Is there something missing in the default case ?

Quoted 4 lines

regards,

Koen

Thanks
Angus

From 24de7beb1d43caab4e3a59bb4de78e0449e47dfc Mon Sep 17 00:00:00 2001
From: Angus Ainslie <[email protected]>
Date: Tue, 31 Mar 2009 08:56:46 -0600
Subject: [PATCH] hotplug2: added new recipe and updated checksums.ini

---
 conf/checksums.ini                        |    4 +++
 packages/hotplug2/hotplug2_0.9+1.0beta.bb |   30 +++++++++++++++++++++++++++++
 2 files changed, 34 insertions(+), 0 deletions(-)
 create mode 100644 packages/hotplug2/hotplug2_0.9+1.0beta.bb
conf/checksums.ini +4 -0
index 9548a02..c5e6910 100644
@@ -9318,6 +9318,10 @@ sha256=af40399fe434678454ae8ea100db6cba0482aa65b8972a05098c779cac57bc48
 md5=faa08f321fefd2c61ce4c9355a62fe31
 sha256=ca7ef124cde06883fbf28c7e78ce1e4c5526434bbe5672ef0a3e85a61a9d0b5f
 
+[http://isteve.bofh.cz/~isteve/hotplug2/downloads/hotplug2-1.0-beta.tar.gz]
+md5=353656ea499d395260c0de143983da4d
+sha256=54e2fa375506d92a8ac94b5ed332c4c0bf1b69c252692b332c92702670bba583
+
 [http://www.porchdogsoft.com/download/howl-0.9.7.tar.gz]
 md5=85fbe016e2ebad99108b1212ae4b1d6f
 sha256=f8766c44291aac92b2b4abc762e1b11e3504dd9f2a855fdde371b5abd730fe9f
packages/hotplug2/hotplug2_0.9+1.0beta.bb new file +30 -0
new file mode 100644
index 0000000..1702c4f
@@ -0,0 +1,30 @@
+DESCRIPTION = "hotplug2 is a daemon which dynamically creates and removes device nodes from \
+/dev/, handles hotplug events and loads drivers at boot time. It replaces \
+the hotplug and udev packages and requires a kernel not older than 2.6.12."
+RPROVIDES_${PN} = "hotplug"
+RREPLACES_${PN} = "udev"
+
+SRC_URI = "http://isteve.bofh.cz/~isteve/hotplug2/downloads/hotplug2-1.0-beta.tar.gz \
+           "
+
+S = "${WORKDIR}/hotplug2-1.0-beta"
+
+inherit update-rc.d autotools
+
+INITSCRIPT_PARAMS = "start 03 S ."
+INITSCRIPT_NAME = "hotplug2"
+
+LDFLAGS += "-lglibc"
+DESTDIR="${D}"
+
+do_configure() {
+:
+}
+
+do_install_prepend () {
+        install -d ${D}/lib/hotplug2
+        install -d ${D}/sbin
+}
+
+FILES_${PN} += "${base_libdir}/hotplug2/*"
+FILES_${PN}-dbg += "${base_libdir}/hotplug2/.debug"
Signature · 1 line
1.5.6.3
#3 lore raw
Quoted 18 lines · Angus Ainslie
Quoted 3 lines
Quoted 1 line

+LDFLAGS += "-lglibc"

I don't think that actually works, and if it did, uclibc would break

Without that I get undefined refeences

loader.c:(.text+0x14): undefined reference to dlclose' workers/loader.o: In function worker_load':
loader.c:(.text+0x44): undefined reference to dlopen' loader.c:(.text+0x5c): undefined reference to dlsym' loader.c:(.text+0x84): undefined reference to `dlerror'

Quoted 5 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+do_configure () {
+}

missing colon between the braces. But more importantly: why inherit autotools when you're not going to run configure?

Quoted 6 lines

I was under the mistaken impression that autotools need to be included to get do_compile() and do_install(). It seems those are the defaults.

There is a deeper problem that without the inherit autotools then the LDFLAGS above fails to find glibc. Is there something missing in the default case ?

Wow, I'm surprised "-lglibc" above even worked for you:

$ find rootfs -name 'libglibc*'
$

Those undefined references above are provided by libdl.so, which needs:

LDFLAGS += " -ldl"

And no need for autotools.

Signature · 1 line
Denys
#4 lore raw
Quoted 12 lines · Denys Dmytriyenko

Wow, I'm surprised "-lglibc" above even worked for you:

$ find rootfs -name 'libglibc*'
$

Those undefined references above are provided by libdl.so, which needs:

LDFLAGS += " -ldl"

And no need for autotools.

Weird, I was sure I'd tried it that way the first time. Here's the updated recipe.

Angus

From 055519888c8d279e83ce11337746400343addb7c Mon Sep 17 00:00:00 2001
From: Angus Ainslie <[email protected]>
Date: Tue, 31 Mar 2009 08:56:46 -0600
Subject: [PATCH] hotplug2: added new recipe and updated checksums.ini

---
 conf/checksums.ini                        |    4 ++++
 packages/hotplug2/hotplug2_0.9+1.0beta.bb |   26 ++++++++++++++++++++++++++
 2 files changed, 30 insertions(+), 0 deletions(-)
 create mode 100644 packages/hotplug2/hotplug2_0.9+1.0beta.bb
conf/checksums.ini +4 -0
index 9548a02..c5e6910 100644
@@ -9318,6 +9318,10 @@ sha256=af40399fe434678454ae8ea100db6cba0482aa65b8972a05098c779cac57bc48
 md5=faa08f321fefd2c61ce4c9355a62fe31
 sha256=ca7ef124cde06883fbf28c7e78ce1e4c5526434bbe5672ef0a3e85a61a9d0b5f
 
+[http://isteve.bofh.cz/~isteve/hotplug2/downloads/hotplug2-1.0-beta.tar.gz]
+md5=353656ea499d395260c0de143983da4d
+sha256=54e2fa375506d92a8ac94b5ed332c4c0bf1b69c252692b332c92702670bba583
+
 [http://www.porchdogsoft.com/download/howl-0.9.7.tar.gz]
 md5=85fbe016e2ebad99108b1212ae4b1d6f
 sha256=f8766c44291aac92b2b4abc762e1b11e3504dd9f2a855fdde371b5abd730fe9f
packages/hotplug2/hotplug2_0.9+1.0beta.bb new file +26 -0
new file mode 100644
index 0000000..564785d
@@ -0,0 +1,26 @@
+DESCRIPTION = "hotplug2 is a daemon which dynamically creates and removes device nodes from \
+/dev/, handles hotplug events and loads drivers at boot time. It replaces \
+the hotplug and udev packages and requires a kernel not older than 2.6.12."
+RPROVIDES_${PN} = "hotplug"
+RREPLACES_${PN} = "udev"
+
+SRC_URI = "http://isteve.bofh.cz/~isteve/hotplug2/downloads/hotplug2-1.0-beta.tar.gz \
+           "
+
+S = "${WORKDIR}/hotplug2-1.0-beta"
+
+inherit update-rc.d
+
+INITSCRIPT_PARAMS = "start 03 S ."
+INITSCRIPT_NAME = "hotplug2"
+
+LDFLAGS += "-ldl"
+DESTDIR="${D}"
+
+do_install_prepend () {
+        install -d ${D}/lib/hotplug2
+        install -d ${D}/sbin
+}
+
+FILES_${PN} += "${base_libdir}/hotplug2/*"
+FILES_${PN}-dbg += "${base_libdir}/hotplug2/.debug"
Signature · 1 line
1.5.6.3
#5 lore raw
Quoted 2 lines · Angus Ainslie

Weird, I was sure I'd tried it that way the first time. Here's the updated recipe.

+RPROVIDES_${PN} = "hotplug"
+RREPLACES_${PN} = "udev"

What happens if both hotplug2 and udev and in deploy and I want to install udev? I suspect it will silently select hotplug2, which is not what we want.

So: NAK

regards,

Koen