snd: aica - fix annoying compiler warning
PATCH 1/1 snd: aica - fix annoying compiler warning
Cast pointer to data member of struct firmware as a void to end an annoying compiler warning.
fix annoying compiler warning
---
sound/sh/aica.c +1 -1
@@ -567,7 +567,7 @@ static int load_aica_firmware(void)return err;/* write firware into memory */ spu_disable (); -spu_memload (0 , fw_entry->data, fw_entry->size); +spu_memload (0 , (void *)fw_entry->data, fw_entry->size);spu_enable ();release_firmware (fw_entry);return err;
At Sun, 15 Mar 2009 22:05:40 +0000,
Quoted 14 lines · Adrian McMenamin
Cast pointer to data member of struct firmware as a void to end an annoying compiler warning.
fix annoying compiler warning
Signed-off-by Adrian McMenamin <[email protected]>---
sound/sh/aica.c +0
-0
sound/sh/aica.c static int load_aica_firmware(void) · line 570
Quoted 5 lines
sound/sh/aica.c +1
-1@@ -567,7 +567,7 @@ static int load_aica_firmware(void)return err;/* write firware into memory */ spu_disable (); -spu_memload (0 , fw_entry->data, fw_entry->size); +spu_memload (0 , (void *)fw_entry->data, fw_entry->size);
IMO, it's better to fix spu_memload() to take const pointer instead of cast.
thanks,
Takashi
Quoted 11 lines · Takashi Iwai
At Sun, 15 Mar 2009 22:05:40 +0000,
Quoted 9 lines · Adrian McMenamin
Cast pointer to data member of struct firmware as a void to end an annoying compiler warning.
fix annoying compiler warning
Signed-off-by Adrian McMenamin <[email protected]>---
Quoted 14 lines
sound/sh/aica.c static int load_aica_firmware(void) · line 570
Quoted 10 lines
sound/sh/aica.c +1
-1@@ -567,7 +567,7 @@ static int load_aica_firmware(void)return err;/* write firware into memory */ spu_disable (); -spu_memload (0 , fw_entry->data, fw_entry->size); +spu_memload (0 , (void *)fw_entry->data, fw_entry->size);IMO, it's better to fix
spu_memload()to take const pointer instead of cast.
If that's what you want I can do that but it adds to kernel bloat by having two functions essentially do the same thing.
At Mon, 16 Mar 2009 07:54:09 +0000,
Quoted 28 lines · Adrian McMenamin
Quoted 11 lines · Takashi Iwai
At Sun, 15 Mar 2009 22:05:40 +0000,
Quoted 9 lines · Adrian McMenamin
Cast pointer to data member of struct firmware as a void to end an annoying compiler warning.
fix annoying compiler warning
Signed-off-by Adrian McMenamin <[email protected]>---
Quoted 14 lines
sound/sh/aica.c static int load_aica_firmware(void) · line 570
Quoted 10 lines
sound/sh/aica.c +1
-1@@ -567,7 +567,7 @@ static int load_aica_firmware(void)return err;/* write firware into memory */ spu_disable (); -spu_memload (0 , fw_entry->data, fw_entry->size); +spu_memload (0 , (void *)fw_entry->data, fw_entry->size);IMO, it's better to fix
spu_memload()to take const pointer instead of cast.
Quoted 2 lines
If that's what you want I can do that but it adds to kernel bloat by having two functions essentially do the same thing.
I meant a fix like below...
Takashi
---
sound/sh/aica.c +2 -2
@@ -119,10 +119,10 @@ static void spu_memset(u32 toi, u32 what, int length) }/* spu_memload - write to SPU address space */ -static void spu_memload (u32 toi,void *from,int length) +static void spu_memload (u32 toi,const void *from,int length) {unsigned long flags; -u32 *froml = from; +const u32 *froml = from;u32 __iomem *to = (u32 __iomem *) (SPU_MEMORY_BASE + toi);int i;u32 val;
Quoted 30 lines · Takashi Iwai
At Mon, 16 Mar 2009 07:54:09 +0000,
Quoted 28 lines · Adrian McMenamin
Quoted 25 lines · Takashi Iwai
At Sun, 15 Mar 2009 22:05:40 +0000,
Quoted 14 lines · Adrian McMenamin
Cast pointer to data member of struct firmware as a void to end an annoying compiler warning.
fix annoying compiler warning
Signed-off-by Adrian McMenamin <[email protected]>---
sound/sh/aica.c +0
-0sound/sh/aica.c static int load_aica_firmware(void) · line 570
Quoted 5 lines
sound/sh/aica.c +1
-1@@ -567,7 +567,7 @@ static int load_aica_firmware(void)return err;/* write firware into memory */ spu_disable (); -spu_memload (0 , fw_entry->data, fw_entry->size); +spu_memload (0 , (void *)fw_entry->data, fw_entry->size);IMO, it's better to fix
spu_memload()to take const pointer instead of cast.
Quoted 5 lines
Quoted 2 lines
If that's what you want I can do that but it adds to kernel bloat by having two functions essentially do the same thing.
I meant a fix like below...
Is anything happening with this, or should I just ignore it?
Quoted 22 lines
---
sound/sh/aica.c +2
-3@@ -119,10 +119,10 @@ static void spu_memset(u32 toi, u32 what, int length) }/* spu_memload - write to SPU address space */ -static void spu_memload (u32 toi,void *from,int length) +static void spu_memload (u32 toi,const void *from,int length) {unsigned long flags; -u32 *froml = from; +const u32 *froml = from;u32 __iomem *to = (u32 __iomem *) (SPU_MEMORY_BASE + toi);int i;u32 val; --To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 31 lines · Paul Mundt
Quoted 30 lines · Takashi Iwai
At Mon, 16 Mar 2009 07:54:09 +0000,
Quoted 28 lines · Adrian McMenamin
Quoted 25 lines · Takashi Iwai
At Sun, 15 Mar 2009 22:05:40 +0000,
Quoted 14 lines · Adrian McMenamin
Cast pointer to data member of struct firmware as a void to end an annoying compiler warning.
fix annoying compiler warning
Signed-off-by Adrian McMenamin <[email protected]>---
sound/sh/aica.c +0
-0sound/sh/aica.c static int load_aica_firmware(void) · line 570
Quoted 5 lines
sound/sh/aica.c +1
-1@@ -567,7 +567,7 @@ static int load_aica_firmware(void)return err;/* write firware into memory */ spu_disable (); -spu_memload (0 , fw_entry->data, fw_entry->size); +spu_memload (0 , (void *)fw_entry->data, fw_entry->size);IMO, it's better to fix
spu_memload()to take const pointer instead of cast.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
If that's what you want I can do that but it adds to kernel bloat by having two functions essentially do the same thing.
I meant a fix like below...
Is anything happening with this, or should I just ignore it?
I though Takashi's fix was fine/obvious but it doesn't appear to have been pushed upstream (yet?)
At Thu, 02 Apr 2009 00:41:50 +0100,
Quoted 36 lines · Adrian McMenamin
Quoted 34 lines · Paul Mundt
Quoted 33 lines · Takashi Iwai
At Mon, 16 Mar 2009 07:54:09 +0000,
Quoted 30 lines · Adrian McMenamin
Quoted 11 lines · Takashi Iwai
At Sun, 15 Mar 2009 22:05:40 +0000,
Quoted 9 lines · Adrian McMenamin
Cast pointer to data member of struct firmware as a void to end an annoying compiler warning.
fix annoying compiler warning
Signed-off-by Adrian McMenamin <[email protected]>---
Quoted 14 lines
sound/sh/aica.c static int load_aica_firmware(void) · line 570
Quoted 10 lines
sound/sh/aica.c +1
-1@@ -567,7 +567,7 @@ static int load_aica_firmware(void)return err;/* write firware into memory */ spu_disable (); -spu_memload (0 , fw_entry->data, fw_entry->size); +spu_memload (0 , (void *)fw_entry->data, fw_entry->size);IMO, it's better to fix
spu_memload()to take const pointer instead of cast.If that's what you want I can do that but it adds to kernel bloat by having two functions essentially do the same thing.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
I meant a fix like below...
Is anything happening with this, or should I just ignore it?
I though Takashi's fix was fine/obvious but it doesn't appear to have been pushed upstream (yet?)
Well, then it'd be appreciated if you repost your patch with my fix.
thanks,
Takashi