Skip to contentSkip to conversation

Fix compile issue

PATCH Superseded Sanjeev Premi 5 participants 5 messages Apr 2, 2009

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix compile issue

Fixes this compile error:
board.c: In function 'do_switch_ecc':
board.c:339: error: 'cmd_tbl_t' has no member named 'help'
make[1]: *** [board.o] Error 1
make[1]: Leaving directory `/db/psp_git/users/a0756819/u-boot/cpu/arm_cortexa8/omap3'
make: *** [cpu/arm_cortexa8/omap3/libomap3.a] Error 2

---
 cpu/arm_cortexa8/omap3/board.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
cpu/arm_cortexa8/omap3/board.c +1 -1
index 7bb3e28..15ea936 100644
@@ -331,7 +331,7 @@ static int do_switch_ecc(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
 	return 0;
 
 usage:
-	printf ("Usage: nandecc %s\n", cmdtp->help);
+	printf ("Usage: nandecc %s\n", cmdtp->usage);
 	return 1;
 }
 
Signature · 1 line
1.6.2.1
#1 lore raw

PATCH 1/1 Fix compile issue

Quoted 1 line · On Thursday 02 April 2009 12:21:54 Sanjeev Premi wrote:
 cpu/arm_cortexa8/omap3/board.c |    2 +-

you're fixing a specific board or board family, so please put that into the subject line. "Fix compile issue" might be ok if it were an error in the top level build files, but this isnt ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090402/36ce8d76/attachment.pgp

#2 lore raw

PATCH 1/1 Fix compile issue

Quoted 6 lines · Mike Frysinger
Quoted 1 line · On Thursday 02 April 2009 12:21:54 Sanjeev Premi wrote:
 cpu/arm_cortexa8/omap3/board.c |    2 +-

you're fixing a specific board or board family, so please put that into the subject line. "Fix compile issue" might be ok if it were an error in the top level build files, but this isnt ...

please also add in your commit message that it's because the current command use the long help for usage print evenif when the CONFIG_SYS_LONGHELP is not active

Best Regards,
J.

#3 lore raw

PATCH 1/1 Fix compile issue

In reply to Sanjeev Premi
Quoted 6 lines · Sanjeev Premi

Fixes this compile error:
board.c: In function 'do_switch_ecc':
board.c:339: error: 'cmd_tbl_t' has no member named 'help'
make[1]: *** [board.o] Error 1
make[1]: Leaving directory `/db/psp_git/users/a0756819/u-boot/cpu/arm_cortexa8/omap3'
make: *** [cpu/arm_cortexa8/omap3/libomap3.a] Error 2

How do you get this error (which U-Boot branch/git head)? It seems I don't have this with recent U-Boot mainline:

-- cut --
HEAD is now at dfc91c3... Merge branch 'master' of
git://git.denx.de/u-boot-arm

Quoted 1 line

./MAKEALL ARM_CORTEX_A8

Configuring for omap3_beagle board...
text data bss dec hex filename
168317 8504 205616 382437 5d5e5 ./u-boot
Configuring for omap3_overo board...
text data bss dec hex filename
157161 8448 204936 370545 5a771 ./u-boot
Configuring for omap3_evm board...
text data bss dec hex filename
159957 6048 219032 385037 5e00d ./u-boot
Configuring for omap3_pandora board...
text data bss dec hex filename
157253 8368 204936 370557 5a77d ./u-boot
Configuring for omap3_zoom1 board...
text data bss dec hex filename
157905 8448 204936 371289 5aa59 ./u-boot
-- cut --

Regards

Dirk

Quoted 18 lines
---
 cpu/arm_cortexa8/omap3/board.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
cpu/arm_cortexa8/omap3/board.c +1 -1
index 7bb3e28..15ea936 100644
@@ -331,7 +331,7 @@ static int do_switch_ecc(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
 	return 0;
 
 usage:
-	printf ("Usage: nandecc %s\n", cmdtp->help);
+	printf ("Usage: nandecc %s\n", cmdtp->usage);
 	return 1;
 }
 
#4 lore raw

PATCH 1/1 Fix compile issue

Quoted 13 lines

-----Original Message-----
From: Dirk Behme [mailto:dirk.behme at googlemail.com]
Sent: Thursday, April 02, 2009 11:48 PM
To: Premi, Sanjeev
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] Fix compile issue

Quoted 5 lines · Sanjeev Premi

Fixes this compile error:
board.c: In function 'do_switch_ecc':
board.c:339: error: 'cmd_tbl_t' has no member named 'help' make[1]: *** [board.o] Error 1
make[1]: Leaving directory

Quoted 6 lines

`/db/psp_git/users/a0756819/u-boot/cpu/arm_cortexa8/omap3'

Quoted 1 line

make: *** [cpu/arm_cortexa8/omap3/libomap3.a] Error 2

How do you get this error (which U-Boot branch/git head)? It seems I don't have this with recent U-Boot mainline:

It doesn't come with my default configuration (omap3_evm_config). But when I tried to turn on/off few options for minimal uboot build, I came across this.

I am away from the actual code, but I believe it was after enabling #define CONFIG_NAND_OMAP_GPMC

Of course, it leads to another error - a missing function. But still haven't figured that one.

~sanjeev

Quoted 49 lines

-- cut --
HEAD is now at dfc91c3... Merge branch 'master' of
git://git.denx.de/u-boot-arm

Quoted 1 line

./MAKEALL ARM_CORTEX_A8

Configuring for omap3_beagle board...
text data bss dec hex filename
168317 8504 205616 382437 5d5e5 ./u-boot
Configuring for omap3_overo board...
text data bss dec hex filename
157161 8448 204936 370545 5a771 ./u-boot
Configuring for omap3_evm board...
text data bss dec hex filename
159957 6048 219032 385037 5e00d ./u-boot
Configuring for omap3_pandora board...
text data bss dec hex filename
157253 8368 204936 370557 5a77d ./u-boot
Configuring for omap3_zoom1 board...
text data bss dec hex filename
157905 8448 204936 371289 5aa59 ./u-boot
-- cut --

Regards

Dirk

Review

Quoted 6 lines
---
 cpu/arm_cortexa8/omap3/board.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
(quoted diff) +0 -0

b/cpu/arm_cortexa8/omap3/board.c

cpu/arm_cortexa8/omap3/board.c static int do_switch_ecc(cmd_tbl_t *

Quoted 4 lines

index 7bb3e28..15ea936 100644

cpu/arm_cortexa8/omap3/board.c +0 -0
@@ -331,7 +331,7 @@ static int do_switch_ecc(cmd_tbl_t * 

cmdtp, int flag, int argc, char *argv[])

Quoted 8 lines
cpu/arm_cortexa8/omap3/board.c +1 -1
 	return 0;
 
 usage:
-	printf ("Usage: nandecc %s\n", cmdtp->help);
+	printf ("Usage: nandecc %s\n", cmdtp->usage);
 	return 1;
 }