Skip to contentSkip to conversation

kvm: Fix wrong counting of MSI-X table size

PATCH Applied Sheng Yang 2 participants 2 messages Apr 8, 2009 – Apr 9, 2009 KVM

lore
Share & tools
lore

Sheng Yang

author
#0 lore raw

PATCH 1/1 kvm: Fix wrong counting of MSI-X table size

The PCI spec said...

System software reads this field to determine the MSI-X Table Size *N*, which is encoded as *N-1*. For example, a returned value of “00000000011” indicates a table size of 4.

---
 qemu/hw/device-assignment.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
qemu/hw/device-assignment.c +1 -0
index 09e54ae..f33ce3c 100644
@@ -818,6 +818,7 @@ static int assigned_dev_update_msix_mmio(PCIDevice *pci_dev)
 
     entries_max_nr = pci_dev->config[pos + 2];
     entries_max_nr &= PCI_MSIX_TABSIZE;
+    entries_max_nr += 1;
 
     /* Get the usable entry number for allocating */
     for (i = 0; i < entries_max_nr; i++) {
Signature · 1 line
1.5.4.5
Applied
#1 lore raw
Quoted 7 lines · Sheng Yang

The PCI spec said...

System software reads this field to determine the MSI-X Table Size *N*, which is encoded as *N-1*. For example, a returned value of “00000000011” indicates a table size of 4.

Applied, thanks.

Signature · 1 line
Do not meddle in the internals of kernels, for they are subtle and quick to panic.