Skip to contentSkip to conversation

Kernel freeze caused by a7bb3909b3293d503211d7f6af8ed62c1644b686

DISCUSSION Daniel Ribeiro 2 participants 4 messages Apr 8, 2009 – Apr 9, 2009 1 message not in the archive SPI

lore
Share & tools
lore

Daniel Ribeiro

author
#0 lore raw

Hi Eric!

Today i was updating my code from linus git, and all my devices freeze with a white screen of death at early boot.

I bisected it, and found that commit a7bb3909b3293d503211d7f6af8ed62c1644b686 is the culprit.

My code still uses cs_control to toggle the CS gpio. Is your commit supposed to deprecate cs_control?

Signature · 8 lines
Daniel Ribeiro


------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com
#1 lore raw
Quoted 11 lines · Daniel Ribeiro

Hi Eric!

Today i was updating my code from linus git, and all my devices freeze with a white screen of death at early boot.

I bisected it, and found that commit a7bb3909b3293d503211d7f6af8ed62c1644b686 is the culprit.

My code still uses cs_control to toggle the CS gpio. Is your commit supposed to deprecate cs_control?

No, should be backward compatible and I verified it before submitting the patch. Could you please help identify why it fails and I'm going to reproduce it here as well.

------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com

A message that is not in the archive (sent off-list or not yet received): f17812d70904081741n440fc5b4w35e55424e9c35a25-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

author
#3 lore raw

Em Qui, 2009-04-09 às 08:41 +0800, Eric Miao escreveu:

Quoted 10 lines
Quoted 6 lines

I bisected it, and found that commit a7bb3909b3293d503211d7f6af8ed62c1644b686 is the culprit.

My code still uses cs_control to toggle the CS gpio. Is your commit supposed to deprecate cs_control?

No, should be backward compatible and I verified it before submitting the patch. Could you please help identify why it fails and I'm going to reproduce it here as well.

Fix is trivial, sorry for not seeing this earlier. I have no idea why my device freezes at startup, but this is enough to get everything working again.

Correct typo on pxa2xx-spi.c cs_deassert.

Signed-off-by Daniel Ribeiro <[email protected]>
drivers/spi/pxa2xx_spi.c +1 -1
index 79d7341..1a00b41 100644
@@ -195,7 +195,7 @@ static void cs_deassert(struct driver_data *drv_data)
 	struct chip_data *chip = drv_data->cur_chip;
 
 	if (chip->cs_control) {
-		chip->cs_control(PXA2XX_CS_ASSERT);
+		chip->cs_control(PXA2XX_CS_DEASSERT);
 		return;
 	}
Signature · 12 lines
Daniel Ribeiro


------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com
_______________________________________________
spi-devel-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Acked-by
#4 lore raw
Quoted 12 lines · Daniel Ribeiro

Em Qui, 2009-04-09 às 08:41 +0800, Eric Miao escreveu:

Quoted 10 lines
Quoted 6 lines

I bisected it, and found that commit a7bb3909b3293d503211d7f6af8ed62c1644b686 is the culprit.

My code still uses cs_control to toggle the CS gpio. Is your commit supposed to deprecate cs_control?

No, should be backward compatible and I verified it before submitting the patch. Could you please help identify why it fails and I'm going to reproduce it here as well.

Quoted 7 lines

Fix is trivial, sorry for not seeing this earlier. I have no idea why my device freezes at startup, but this is enough to get everything working again.

Correct typo on pxa2xx-spi.c cs_deassert.

Grrr.... this is really embarassing, shame me ///

Quoted 2 lines
Signed-off-by Daniel Ribeiro <[email protected]>
Acked-by Eric Miao <[email protected]>

David,

Please help merge this patch, thanks.

------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com
_______________________________________________
spi-devel-general mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general