Skip to contentSkip to conversation

x86: apic/io_apic.c declare smp_irq_move_cleanup_interrupt before they get used

PATCH New Jaswinder Singh Rajput 1 participant 1 message Apr 9, 2009 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: apic/io_apic.c declare smp_irq_move_cleanup_interrupt before they get used

Impact: fix sparse warning:
arch/x86/kernel/apic/io_apic.c:2431:17: warning: symbol 'smp_irq_move_cleanup_interrupt' was not declared. Should it be static?

smp_irq_move_cleanup_interrupt needs asmlinkage only for 64 bit.

---
 arch/x86/include/asm/hw_irq.h  |    9 +++++++++
 arch/x86/kernel/apic/io_apic.c |    6 +++++-
 2 files changed, 14 insertions(+), 1 deletions(-)
arch/x86/include/asm/hw_irq.h +9 -0
index 7309c0a..03316a8 100644
@@ -93,6 +93,15 @@ extern asmlinkage void smp_invalidate_interrupt(struct pt_regs *);
 #endif
 #endif
 
+#ifdef CONFIG_X86_IO_APIC
+#ifdef CONFIG_X86_32
+extern void smp_irq_move_cleanup_interrupt(void);
+#else
+extern asmlinkage void smp_irq_move_cleanup_interrupt(void);
+#endif
+#endif
+
+
 extern void (*__initconst interrupt[NR_VECTORS-FIRST_EXTERNAL_VECTOR])(void);
 
 typedef int vector_irq_t[NR_VECTORS];
arch/x86/kernel/apic/io_apic.c +5 -1
index 7c9d045..7d7d429 100644
@@ -59,6 +59,7 @@
 #include <asm/setup.h>
 #include <asm/irq_remapping.h>
 #include <asm/hpet.h>
+#include <asm/hw_irq.h>		/* smp_irq_move_cleanup_interrupt */
 #include <asm/uv/uv_hub.h>
 #include <asm/uv/uv_irq.h>
 
@@ -2428,7 +2429,10 @@ static inline void set_ir_ioapic_affinity_irq_desc(struct irq_desc *desc,
 }
 #endif
 
-asmlinkage void smp_irq_move_cleanup_interrupt(void)
+#ifdef CONFIG_X86_64
+asmlinkage
+#endif
+void smp_irq_move_cleanup_interrupt(void)
 {
 	unsigned vector, me;
 
Signature · 1 line
1.6.0.6