Skip to contentSkip to conversation

Alpha: remove helper_load_implver

PATCH Applied Tristan Gingold 2 participants 2 messages Apr 10, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Alpha: remove helper_load_implver

There is no need to use an helper. Directly load the value with tcg code.

---
 target-alpha/helper.h    |    1 -
 target-alpha/op_helper.c |    5 -----
 target-alpha/translate.c |    4 +++-
 3 files changed, 3 insertions(+), 7 deletions(-)
target-alpha/helper.h +0 -1
index 4c4855d..f62b1c2 100644
@@ -5,7 +5,6 @@ DEF_HELPER_0(tb_flush, void)
 DEF_HELPER_2(excp, void, int, int)
 DEF_HELPER_1(amask, i64, i64)
 DEF_HELPER_0(load_pcc, i64)
-DEF_HELPER_0(load_implver, i64)
 DEF_HELPER_0(rc, i64)
 DEF_HELPER_0(rs, i64)
 
target-alpha/op_helper.c +0 -5
index 3c95e98..59010fc 100644
@@ -58,11 +58,6 @@ uint64_t helper_load_pcc (void)
     return 0;
 }
 
-uint64_t helper_load_implver (void)
-{
-    return env->implver;
-}
-
 uint64_t helper_load_fpcr (void)
 {
     uint64_t ret = 0;
target-alpha/translate.c +3 -1
index 9702214..11b8139 100644
@@ -51,6 +51,7 @@ struct DisasContext {
 #if !defined (CONFIG_USER_ONLY)
     int pal_mode;
 #endif
+    CPUAlphaState *env;
     uint32_t amask;
 };
 
@@ -1175,7 +1176,7 @@ static always_inline int translate_one (DisasContext *ctx, uint32_t insn)
         case 0x6C:
             /* IMPLVER */
             if (rc != 31)
-                gen_helper_load_implver(cpu_ir[rc]);
+                tcg_gen_movi_i64(cpu_ir[rc], ctx->env->implver);
             break;
         default:
             goto invalid_opc;
@@ -2346,6 +2347,7 @@ static always_inline void gen_intermediate_code_internal (CPUState *env,
     gen_opc_end = gen_opc_buf + OPC_MAX_SIZE;
     ctx.pc = pc_start;
     ctx.amask = env->amask;
+    ctx.env = env;
 #if defined (CONFIG_USER_ONLY)
     ctx.mem_idx = 0;
 #else
Signature · 1 line
1.6.2
#1 lore raw
Quoted 8 lines · Tristan Gingold

There is no need to use an helper. Directly load the value with tcg code.

---
 target-alpha/helper.h    |    1 -
 target-alpha/op_helper.c |    5 -----
 target-alpha/translate.c |    4 +++-
 3 files changed, 3 insertions(+), 7 deletions(-)

Thanks, applied.

Quoted 63 lines
target-alpha/helper.h +0 -1
index 4c4855d..f62b1c2 100644
@@ -5,7 +5,6 @@ DEF_HELPER_0(tb_flush, void)
 DEF_HELPER_2(excp, void, int, int)
 DEF_HELPER_1(amask, i64, i64)
 DEF_HELPER_0(load_pcc, i64)
-DEF_HELPER_0(load_implver, i64)
 DEF_HELPER_0(rc, i64)
 DEF_HELPER_0(rs, i64)
 
target-alpha/op_helper.c +0 -5
index 3c95e98..59010fc 100644
@@ -58,11 +58,6 @@ uint64_t helper_load_pcc (void)
     return 0;
 }
 
-uint64_t helper_load_implver (void)
-{
-    return env->implver;
-}
-
 uint64_t helper_load_fpcr (void)
 {
     uint64_t ret = 0;
target-alpha/translate.c +3 -1
index 9702214..11b8139 100644
@@ -51,6 +51,7 @@ struct DisasContext {
 #if !defined (CONFIG_USER_ONLY)
     int pal_mode;
 #endif
+    CPUAlphaState *env;
     uint32_t amask;
 };
 
@@ -1175,7 +1176,7 @@ static always_inline int translate_one (DisasContext *ctx, uint32_t insn)
         case 0x6C:
             /* IMPLVER */
             if (rc != 31)
-                gen_helper_load_implver(cpu_ir[rc]);
+                tcg_gen_movi_i64(cpu_ir[rc], ctx->env->implver);
             break;
         default:
             goto invalid_opc;
@@ -2346,6 +2347,7 @@ static always_inline void gen_intermediate_code_internal (CPUState *env,
     gen_opc_end = gen_opc_buf + OPC_MAX_SIZE;
     ctx.pc = pc_start;
     ctx.amask = env->amask;
+    ctx.env = env;
 #if defined (CONFIG_USER_ONLY)
     ctx.mem_idx = 0;
 #else
Signature · 1 line
1.6.2
Signature · 2 lines
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
[email protected]                 http://www.aurel32.net