b43 rfkill LED broken in 2.6.30-rc1 from wireless-testing
Johannes,
Boy is the rfkill subsystem fragile.
After all our debugging of the control of the b43 LED with the rfkill switch, it is broken again with 2.6.30-rc1.
I put a test print at the start of b43_led_brightness_set(). It gets called lots of times for the TX/RX LED (which I do not have), but only gets called for the radio LED when the driver is loaded or unloaded. Changing the rfkill switch causes the "radio hardware status" messages to be output, but nothing happens with the LED.
Now, led_trigger_event() once again is only called indirectly through rfkill_led_trigger() from rfkill_led_trigger_activate(), but rfkill_led_trigger() is never called. I have no idea who is calling b43_led_brightness at start-up/shut-down. It must be some part of the LED system.
Some things are working. The contents of /sys/class/rfkill/rfkill3/state change from 0 to 1 when the switch is turned on; however, I have not been able to locate what code is doing the change. Routine rfkill_uevent() is never entered.
Larry
Quoted 6 lines · Larry Finger
Johannes,
Boy is the rfkill subsystem fragile.
After all our debugging of the control of the b43 LED with the rfkill switch, it is broken again with 2.6.30-rc1.
I found the problem and will be submitting a patch ASAP.
Larry
Larry,
Quoted 4 lines
Boy is the rfkill subsystem fragile.
After all our debugging of the control of the b43 LED with the rfkill switch, it is broken again with 2.6.30-rc1.
Is that really _again_? My patch, which contained the fix, didn't go into the tree yet, as I still need to fix up a few things and get toshiba/sony/thinkpad converted :)
johannes
Quoted 2 lines · Johannes Berg
into the tree yet, as I still need to fix up a few things and get toshiba/sony/thinkpad converted :)
As I said, I will do the thinkpad conversion for you, but I am still waiting for your reply (and maybe a new version of the rfkill rework patchset)...
Signature · 4 lines
"One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh
Quoted 6 lines · Henrique de Moraes Holschuh
Quoted 2 lines · Johannes Berg
into the tree yet, as I still need to fix up a few things and get toshiba/sony/thinkpad converted :)
As I said, I will do the thinkpad conversion for you, but I am still waiting for your reply (and maybe a new version of the rfkill rework patchset)...
Yes, your mail's still marked unread -- I need to take some time to work on it.
johannes