Skip to contentSkip to conversation

batman-adv: Enable LockLess TX for softif

PATCH Applied Sven Eckelmann 1 participant 3 messages Sep 11, 2018 – Sep 14, 2018 Batman advanced

lore
Share & tools
lore

Sven Eckelmann

author maintainer
#0 lore raw

PATCH 1/1 batman-adv: Enable LockLess TX for softif

The batadv interfaces are virtual interfaces which just tunnel the traffic over other ethernet compatible interfaces. It doesn't need serialization during the tx phase and is using RCU for most of its internal datastructures. Since it doesn't have actual queues which could be locked independently, the throughput gets significantly reduced by the extra lock in the core net code.

8 parallel TCP connections forwarded by an IPQ4019 based hardware over 5GHz could reach:

* without LLX: 349 Mibit/s
* with LLX: 563 Mibit/s

---
 net/batman-adv/soft-interface.c | 1 +
 1 file changed, 1 insertion(+)
net/batman-adv/soft-interface.c +1 -0
index 626ddca3..b1596c23 100644
@@ -1062,6 +1062,7 @@ static void batadv_softif_init_early(struct net_device *dev)
 	dev->needs_free_netdev = true;
 	dev->priv_destructor = batadv_softif_free;
 	dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER | NETIF_F_NETNS_LOCAL;
+	dev->features |= NETIF_F_LLTX;
 	dev->priv_flags |= IFF_NO_QUEUE;
 
 	/* can't call min_mtu, because the needed variables
Signature · 1 line
2.11.0
author maintainer
#1 lore raw

On Dienstag, 11. September 2018 17:59:42 CEST Sven Eckelmann wrote:
[...]

Quoted 2 lines

* without LLX: 349 Mibit/s
* with LLX: 563 Mibit/s

I know, it is called LLTX :(

Kind regards,
Sven

author maintainer Applied
#2 lore raw
In reply to Sven Eckelmann
Quoted 10 lines · On Dienstag, 11. September 2018 17:59:42 CEST Sven Eckelmann wrote:

The batadv interfaces are virtual interfaces which just tunnel the traffic over other ethernet compatible interfaces. It doesn't need serialization during the tx phase and is using RCU for most of its internal datastructures. Since it doesn't have actual queues which could be locked independently, the throughput gets significantly reduced by the extra lock in the core net code.

8 parallel TCP connections forwarded by an IPQ4019 based hardware over 5GHz could reach:

Quoted 7 lines

* without LLX: 349 Mibit/s
* with LLX: 563 Mibit/s

---
 net/batman-adv/soft-interface.c | 1 +
 1 file changed, 1 insertion(+)

Applied as e3ed8ad1a7b3 [1]

Kind regards,
Sven

[1] https://git.open-mesh.org/batman-adv.git/commit/e3ed8ad1a7b36bc63b31df6fc9771dc63f8cac3e