Skip to contentSkip to conversation

x86: apic/x2apic_cluster.c x86_cpu_to_logical_apicid should be static

PATCH Applied Jaswinder Singh Rajput 2 participants 5 messages Apr 11, 2009 – Apr 12, 2009 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: apic/x2apic_cluster.c x86_cpu_to_logical_apicid should be static

Impact: reduce kernel size a bit, avoid sparse warning

Fixes sparse warning:
arch/x86/kernel/apic/x2apic_cluster.c:13:1: warning: symbol 'per_cpu__x86_cpu_to_logical_apicid' was not declared. Should it be static?

---
 arch/x86/kernel/apic/x2apic_cluster.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/apic/x2apic_cluster.c +1 -1
index 4a903e2..8e4cbb2 100644
@@ -10,7 +10,7 @@
 #include <asm/apic.h>
 #include <asm/ipi.h>
 
-DEFINE_PER_CPU(u32, x86_cpu_to_logical_apicid);
+static DEFINE_PER_CPU(u32, x86_cpu_to_logical_apicid);
 
 static int x2apic_acpi_madt_oem_check(char *oem_id, char *oem_table_id)
 {
Signature · 1 line
1.6.0.6
#1 lore raw
Commit-ID:  0be88dbc90fceb2261a8358b796d203475235da9
Gitweb:     http://git.kernel.org/tip/0be88dbc90fceb2261a8358b796d203475235da9
Author:     Jaswinder Singh Rajput <[email protected]>
AuthorDate: Sat, 11 Apr 2009 12:55:26 +0530
Committer:  Ingo Molnar <[email protected]>
CommitDate: Sun, 12 Apr 2009 12:38:01 +0200

x86: apic/x2apic_cluster.c x86_cpu_to_logical_apicid should be static

Impact: reduce kernel size a bit, address sparse warning

Fixes sparse warning:
arch/x86/kernel/apic/x2apic_cluster.c:13:1: warning: symbol 'per_cpu__x86_cpu_to_logical_apicid' was not declared. Should it be static?

LKML-Reference: <[email protected]>

---
 arch/x86/kernel/apic/x2apic_cluster.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/apic/x2apic_cluster.c +1 -1
index 4a903e2..8e4cbb2 100644
@@ -10,7 +10,7 @@
 #include <asm/apic.h>
 #include <asm/ipi.h>
 
-DEFINE_PER_CPU(u32, x86_cpu_to_logical_apicid);
+static DEFINE_PER_CPU(u32, x86_cpu_to_logical_apicid);
 
 static int x2apic_acpi_madt_oem_check(char *oem_id, char *oem_table_id)
 {
Applied
#2 lore raw
In reply to Jaswinder Singh Rajput
Quoted 9 lines · Jaswinder Singh Rajput

Impact: reduce kernel size a bit, avoid sparse warning

Fixes sparse warning:
arch/x86/kernel/apic/x2apic_cluster.c:13:1: warning: symbol 'per_cpu__x86_cpu_to_logical_apicid' was not declared. Should it be static?

---
 arch/x86/kernel/apic/x2apic_cluster.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

There is a not so small nit:

Quoted 3 lines

Impact: reduce kernel size a bit, avoid sparse warning

Fixes sparse warning:

the thing is, we dont 'fix', nor do we 'avoid' Sparse warnings!

We _read_ them, _understand_ them, and then we act upon them, fixing the problem they expose.

Or, if there is no problem exposed, we annotate the code to fix the Sparse false positive warning.

Your changelog does not tell us anything whether you went through that thought process. I had to double-check it and had to create this information from scratch.

Please take this as a last warning: you send lots of patches that address various things mechanically, often without thinking through the effects. They are expensive to maintain, because they cause churn and because people often have to do more work accepting them than you did creating them!

You sent a hundred patches in two weeks and they are not applied yet
- and this is why: it is expensive to filter through them and if you dont do it we can only do it by simply not taking them all that easily. Taking them simply does not scale.

And if you write a hundred patches in two weeks you _really_ have to ask yourself whether your quality controls are strong enough before emitting them. There are highly productive members of the Linux community who only send a dozen patches per _year_.

You really want to avoid the 'also sends clueless patches' contributor label, because the only way to deal with such patches as a maintainer is to rate-throttle them.

Thanks,

Ingo

#3 lore raw

Hello Ingo,

Quoted 43 lines · Ingo Molnar
Quoted 9 lines · Jaswinder Singh Rajput

Impact: reduce kernel size a bit, avoid sparse warning

Fixes sparse warning:
arch/x86/kernel/apic/x2apic_cluster.c:13:1: warning: symbol 'per_cpu__x86_cpu_to_logical_apicid' was not declared. Should it be static?

---
 arch/x86/kernel/apic/x2apic_cluster.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

There is a not so small nit:

Quoted 3 lines

Impact: reduce kernel size a bit, avoid sparse warning

Fixes sparse warning:

the thing is, we dont 'fix', nor do we 'avoid' Sparse warnings!

We _read_ them, _understand_ them, and then we act upon them, fixing the problem they expose.

Or, if there is no problem exposed, we annotate the code to fix the Sparse false positive warning.

Your changelog does not tell us anything whether you went through that thought process. I had to double-check it and had to create this information from scratch.

Please take this as a last warning: you send lots of patches that address various things mechanically, often without thinking through the effects. They are expensive to maintain, because they cause churn and because people often have to do more work accepting them than you did creating them!

You sent a hundred patches in two weeks and they are not applied yet
- and this is why: it is expensive to filter through them and if you dont do it we can only do it by simply not taking them all that easily. Taking them simply does not scale.

Quoted 5 lines

And if you write a hundred patches in two weeks you _really_ have to ask yourself whether your quality controls are strong enough before emitting them. There are highly productive members of the Linux community who only send a dozen patches per _year_.

OK, I will be more careful and spend more time on each patch by this way count will be reduce and quality will also improve.

Please check [git-pull -tip] x86: declaration patches Sam and Thomas reviewed them and I also fixed the pointed issues.

My problem is I am work-addict I can not sit ideal ;-)

Thanks for your advice,

--
JSR

#4 lore raw
In reply to Jaswinder Singh Rajput
Commit-ID:  2de1f33e99cec5fd79542a1d0e26efb9c36a98bb
Gitweb:     http://git.kernel.org/tip/2de1f33e99cec5fd79542a1d0e26efb9c36a98bb
Author:     Jaswinder Singh Rajput <[email protected]>
AuthorDate: Sat, 11 Apr 2009 12:55:26 +0530
Committer:  Ingo Molnar <[email protected]>
CommitDate: Sun, 12 Apr 2009 12:39:24 +0200

x86: apic/x2apic_cluster.c x86_cpu_to_logical_apicid should be static

Impact: reduce kernel size a bit, address sparse warning

Addresses the problem pointed out by this sparse warning:
arch/x86/kernel/apic/x2apic_cluster.c:13:1: warning: symbol 'per_cpu__x86_cpu_to_logical_apicid' was not declared. Should it be static?

LKML-Reference: <[email protected]>

---
 arch/x86/kernel/apic/x2apic_cluster.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/apic/x2apic_cluster.c +1 -1
index 4a903e2..8e4cbb2 100644
@@ -10,7 +10,7 @@
 #include <asm/apic.h>
 #include <asm/ipi.h>
 
-DEFINE_PER_CPU(u32, x86_cpu_to_logical_apicid);
+static DEFINE_PER_CPU(u32, x86_cpu_to_logical_apicid);
 
 static int x2apic_acpi_madt_oem_check(char *oem_id, char *oem_table_id)
 {